Debian Bug report logs - #953646
node-nodedbi: please make the build reproducible

version graph

Package: src:node-nodedbi; Maintainer for src:node-nodedbi is Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Wed, 11 Mar 2020 18:06:01 UTC

Severity: wishlist

Tags: patch

Found in version node-nodedbi/1.0.13+dfsg-1

Done: Xavier <yadd@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#953646; Package src:node-nodedbi. (Wed, 11 Mar 2020 18:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Wed, 11 Mar 2020 18:06:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: node-nodedbi: please make the build reproducible
Date: Wed, 11 Mar 2020 18:03:40 +0000
[Message part 1 (text/plain, inline)]
Source: node-nodedbi
Version: 1.0.13+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
node-nodedbi could not be built reproducibly.

This is because it embedded the build path within files under a /.dep/
directory. For example:

   /usr/lib/x86_64-linux-gnu/nodejs/nodedbi/build/Release/.deps/Release/obj.target/nodedbi/src/query.o.d

This is all a little confusing as you exclude .deps (via -X/.deps/) in
debian/rules, but this is not making any difference as the files are
installed via dh_auto_install (not dh_install)... but surely the
Debhelper buildsystem should be excluding these anyway..? You also
attempt to fix some permissions for a directory that can only
exist under .deps due to the wildcard, so when I prevent the .deps
being installed via some ugly means, this line then fails.

Patch attached that, at least, makes it build reproducibly but
moreoever a concrete demonstration of what I mean in the above
rambling paragraphs; you likely do not want to apply it as-is. :)

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[node-nodedbi.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#953646; Package src:node-nodedbi. (Wed, 11 Mar 2020 18:30:02 GMT) (full text, mbox, link).


Acknowledgement sent to Xavier <yadd@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Wed, 11 Mar 2020 18:30:02 GMT) (full text, mbox, link).


Message #10 received at 953646@bugs.debian.org (full text, mbox, reply):

From: Xavier <yadd@debian.org>
To: Chris Lamb <lamby@debian.org>, 953646@bugs.debian.org
Subject: Re: [Pkg-javascript-devel] Bug#953646: node-nodedbi: please make the build reproducible
Date: Wed, 11 Mar 2020 19:08:49 +0100
Le 11/03/2020 à 19:03, Chris Lamb a écrit :
> Source: node-nodedbi
> Version: 1.0.13+dfsg-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: timestamps
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0] we noticed that
> node-nodedbi could not be built reproducibly.
> 
> This is because it embedded the build path within files under a /.dep/
> directory. For example:
> 
>    /usr/lib/x86_64-linux-gnu/nodejs/nodedbi/build/Release/.deps/Release/obj.target/nodedbi/src/query.o.d
> 
> This is all a little confusing as you exclude .deps (via -X/.deps/) in
> debian/rules, but this is not making any difference as the files are
> installed via dh_auto_install (not dh_install)... but surely the
> Debhelper buildsystem should be excluding these anyway..? You also
> attempt to fix some permissions for a directory that can only
> exist under .deps due to the wildcard, so when I prevent the .deps
> being installed via some ugly means, this line then fails.
> 
> Patch attached that, at least, makes it build reproducibly but
> moreoever a concrete demonstration of what I mean in the above
> rambling paragraphs; you likely do not want to apply it as-is. :)
> 
>  [0] https://reproducible-builds.org/
> 
> 
> Regards,

Hi,

this is automatically fixed by a rebuild with recent pkg-js-tools.
However this package has a RC bug (incompatible with Nodejs ≥ 12)

Cheers,
Xavier



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#953646; Package src:node-nodedbi. (Thu, 10 Sep 2020 23:03:06 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Thu, 10 Sep 2020 23:03:06 GMT) (full text, mbox, link).


Message #15 received at 953646@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: 953646@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org
Subject: Re: Bug#953646: node-nodedbi: please make the build reproducible
Date: Thu, 10 Sep 2020 22:58:06 -0000
Chris Lamb wrote:

> Would you consider applying this patch and uploading?

Friendly ping on this? Seems like there hasn't been any update on this bug in
182 days now (!).


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Reply sent to Xavier <yadd@debian.org>:
You have taken responsibility. (Fri, 11 Sep 2020 05:03:05 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Fri, 11 Sep 2020 05:03:05 GMT) (full text, mbox, link).


Message #20 received at 953646-done@bugs.debian.org (full text, mbox, reply):

From: Xavier <yadd@debian.org>
To: 953646-done@bugs.debian.org
Subject: Fixed by pkg-js-tools
Date: Fri, 11 Sep 2020 06:48:00 +0200


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 09 Oct 2020 07:26:00 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 14:11:32 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.