Debian Bug report logs - #948269
file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

Date: Mon, 6 Jan 2020 11:28:40 +0100

[Message part 1 (text/plain, inline)]

Package: file
Version: 1:5.38-2
Severity: grave

With file version 1:5.37-6:

$ file /usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0
/usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=4b36146a48b30a0658cbd4c0f32cdf262be38a5f, stripped

With file version 1:5.38-2:

$ file /usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0
/usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), statically linked, BuildID[sha1]=4b36146a48b30a0658cbd4c0f32cdf262be38a5f, stripped

Note the difference in dynamically linked vs statically linked. This
change breaks dh_shlibdeps causing ${shlibs:Depends} to not be properly
populated.

Cheers

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (650, 'unstable-debug'), (650, 'unstable'), (601, 'testing'), (600, 'experimental-debug'), (600, 'buildd-unstable'), (600, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0-3-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages file depends on:
ii  libc6      2.29-8
ii  libmagic1  1:5.38-2

file recommends no packages.

file suggests no packages.

-- no debconf information

-- 
Sebastian Ramacher

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 948269@bugs.debian.org (full text, mbox, reply):

From: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>

To: Sebastian Ramacher <sramacher@debian.org>, 948269@bugs.debian.org

Subject: Re: Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

Date: Mon, 6 Jan 2020 12:19:21 +0100

[Message part 1 (text/plain, inline)]

Control: tags 948269 tags pending upstream

Sebastian Ramacher wrote...

(...)
> Note the difference in dynamically linked vs statically linked. This
> change breaks dh_shlibdeps causing ${shlibs:Depends} to not be properly
> populated.

That was a change done upstream:

|    PR/93: iaeiaeiaeiae: Do as the comment says, and count as dynamically linked
|    only the binaries that have an interpreter, not the ones that contain a
|    dynamic section. Fixes issue with -static-pie from gcc-9.x
<https://github.com/file/file/commit/FILE5_37-59-g24c9c086>

... which obviously requires a re-visit.

Assuming the current version of src:file breaks more or less the entire
buildd infrastructure, I'll upload a new version, reverting that commit.
As you can see from the commit message, this might introduce issues in
other places - so please keep me informed about any future problems.

For example, I've spotted a regression as follows:

-./debian-bugs/882310/dummy.so: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), no program header, not stripped
+./debian-bugs/882310/dummy.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), no program header, not stripped

Additionally, I always upload new upstream versions of src:file to
experimental first to avoid situations like this. If anybody wishes to
receive a notification to start tests, drop me a line with your e-mail
address, preferably group/team/package address. That list is public.

    Christoph

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 948269-close@bugs.debian.org (full text, mbox, reply):

From: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>

To: 948269-close@bugs.debian.org

Subject: Bug#948269: fixed in file 1:5.38-3

Date: Mon, 06 Jan 2020 12:10:47 +0000

Source: file
Source-Version: 1:5.38-3

We believe that the bug you reported is fixed in the latest version of
file, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 948269@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Biedl <debian.axhn@manchmal.in-ulm.de> (supplier of updated file package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 06 Jan 2020 12:22:22 +0100
Source: file
Architecture: source
Version: 1:5.38-3
Distribution: unstable
Urgency: medium
Maintainer: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
Changed-By: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
Closes: 948269
Changes:
 file (1:5.38-3) unstable; urgency=medium
 .
   * Revert upstream commit "... count as dynamically linked only the
     binaries that have an interpreter". Closes: #948269
Checksums-Sha1:
 3f696f2dcc9412e0e968c20bdda1d40ef6ecbb21 2214 file_5.38-3.dsc
 c1ec2d332adae663fc92678b64c6a6a07ed61e59 33940 file_5.38-3.debian.tar.xz
 a13fa7f131d5cfa57f2b2739bd7565b05258a937 6581 file_5.38-3_powerpc.buildinfo
Checksums-Sha256:
 211e4ff9e05380657f317a54e606f969f4af87516bbd4dd8a9d3687706ce3bc9 2214 file_5.38-3.dsc
 fe2600d301f49b2ef8fd38353169c5673afafcdd793d299e2549a24e9eb302b2 33940 file_5.38-3.debian.tar.xz
 f04070adc4d7f13be1ba876c79db4dd8b61c2e770fe9c20d09cb130d329e46e3 6581 file_5.38-3_powerpc.buildinfo
Files:
 5a50a601f3bfcab532b910c997829987 2214 utils standard file_5.38-3.dsc
 4be6e90f0b2113dad2fe576ad7a8b193 33940 utils standard file_5.38-3.debian.tar.xz
 71052ad9b4458d5de107cda768a5293a 6581 utils standard file_5.38-3_powerpc.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEWXMI+726A12MfJXdxCxY61kUkv0FAl4TGgwACgkQxCxY61kU
kv0ZtBAAky4d011oYcmxbDS51wAmfhxTREeD8Q2RWIYamlSz+/flK8mG3DrkuIbH
MEBfYUCvdSYmFseZtjoITFY/sGLM0unekCQ6DEllRXHGgDZviMPzP5Nn5entqlh5
IaDOafcnbc1QtFvj6sxGMqAWGFE3/bt8EmN84kXSnKVaE9NT1JTTcDkJBM1AWSfY
kqHsroUNkaIHq1O0rZZ6RycTksUWIBwELAdzekuEyNZA5RqV5JKSDorGOeFYfvoA
sdQMyZs7Tkn2U3NIDJbvCILuT8xfwPFMu8TC+BoIZdGo/Tmd5yVTaE6Avx/4bsoh
2SClX81mjggxdO6ZJFrjFJzeUwBjD9mQtBCp/AB3R/62UnBh10d1PGpfHl1WLbmT
v2MG3MSvKbxMAT/2d9lfkIVaSl1BGfYH1Eysz8xrewyWQjSwwtoSYD3NLLlYKupo
G2VB62fWQ8/yzger0ogvX8iBco6A7/CKkk4SOjn0knbJS8NQBACyyF5Av4CQvfkZ
6fSo8tHOD7VcrZPm39gSIU6Ivoo5DzoppKOtFCfmn/PDp2LkQMuZOX7knKkvAJAF
OnJ0/5JvOBWzGHGllyeH8SN9oJTYgTqPV8YZ2lCsxskyxj1e2h5eiNUDNLS8vUSm
73GpjwEldv5ivwdu+SrFMdn3n+joVXYioCQOMFP83emcASdI0jc=
=O0Uy
-----END PGP SIGNATURE-----

Message #22 received at 948269@bugs.debian.org (full text, mbox, reply):

From: James McCoy <jamessan@debian.org>

To: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>, 948269@bugs.debian.org

Subject: Re: Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

Date: Mon, 6 Jan 2020 07:11:32 -0500

On Mon, Jan 06, 2020 at 12:19:21PM +0100, Christoph Biedl wrote:
> Additionally, I always upload new upstream versions of src:file to
> experimental first to avoid situations like this. If anybody wishes to
> receive a notification to start tests, drop me a line with your e-mail
> address, preferably group/team/package address. That list is public.

Autopkgtests already run against packages in experimental, albeit at a
slower pace than those in unstable.  It seems those did catch the issue
-- https://release.debian.org/britney/pseudo-excuses-experimental.html#file

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

Message #27 received at 948269@bugs.debian.org (full text, mbox, reply):

From: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>

To: James McCoy <jamessan@debian.org>, 948269@bugs.debian.org

Subject: Re: Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

Date: Mon, 6 Jan 2020 16:17:28 +0100

[Message part 1 (text/plain, inline)]

James McCoy wrote...

> Autopkgtests already run against packages in experimental, albeit at a
> slower pace than those in unstable.  It seems those did catch the issue
> -- https://release.debian.org/britney/pseudo-excuses-experimental.html#file

TIL - now added to the list of things to check before the first upload
to unstable.

    Christoph

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.