Debian Bug report logs - #945993
diffoscope: FAILED tests/test_source.py::test_code_is_black_clean - assert 228381 == 0

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: FAILED tests/test_source.py::test_code_is_black_clean - assert 228381 == 0

Date: Mon, 2 Dec 2019 14:34:22 +0100

Package: diffoscope
Severity: serious
Tags: bullseye sid
X-Debbugs-Cc: black@packages.debian.org

diffoscope autopkgtests fail with the current version of "black" in sid:
https://ci.debian.net/data/autopkgtest/unstable/amd64/d/diffoscope/3557636/log.gz

It seems to me the test is inherently extremely sensitive to the exact
version of black used, so it probably shouldn't be part of autopkgtests?

Cheers,
Julien

Message #10 received at 945993@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Julien Cristau" <jcristau@debian.org>, "Debian Bug Tracking System" <945993@bugs.debian.org>

Subject: Re: Bug#945993: diffoscope: FAILED tests/test_source.py::test_code_is_black_clean - assert 228381 == 0

Date: Mon, 02 Dec 2019 19:37:02 +0000

Hi Julien,

> It seems to me the test is inherently extremely sensitive to the exact
> version of black used, so it probably shouldn't be part of autopkgtests?

Mmm, except I anticipated this at the time with the following
commit:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/aefa5a39bb5f86f21cb67f94a013aa2c9bc4b69d

At a quick guess, I think this is problem caused by the autopkgtests
being run without the pyproject.toml. As in:

--- a/debian/tests/pytest
+++ b/debian/tests/pytest
@@ -14,7 +14,7 @@ fi

 for py in $(py3versions -s); do
     echo "@@@@@@@@ Running against $py"
-    cp -r tests "$AUTOPKGTEST_TMP"
+    cp -r tests pyproject.toml "$AUTOPKGTEST_TMP"
     (cd "$AUTOPKGTEST_TMP"; "$py" -m pytest -vv -l -r a)
     rm -rf "${AUTOPKGTEST_TMP:?}"/*
 done

… will likely fix this.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #13 received at 945993-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 945993-submitter@bugs.debian.org

Subject: Bug#945993 marked as pending in diffoscope

Date: Mon, 02 Dec 2019 20:04:08 +0000

Control: tag -1 pending

Hello,

Bug #945993 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/commit/f4f26dbc9a392220b2b9f5f287bee48badaf4b3b

------------------------------------------------------------------------
Ensure that autopkgtests are run with our pyproject.toml present for the correct black source code formatter settings. (Closes: #945993)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/945993

Message #20 received at 945993@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: Debian Bug Tracking System <945993@bugs.debian.org>

Subject: Re: Bug#945993: diffoscope: FAILED tests/test_source.py::test_code_is_black_clean - assert 228381 == 0

Date: Mon, 2 Dec 2019 21:12:38 +0100

On Mon, Dec 02, 2019 at 07:37:02PM +0000, Chris Lamb wrote:
> Hi Julien,
> 
> > It seems to me the test is inherently extremely sensitive to the exact
> > version of black used, so it probably shouldn't be part of autopkgtests?
> 
> Mmm, except I anticipated this at the time with the following
> commit:
> 
>   https://salsa.debian.org/reproducible-builds/diffoscope/commit/aefa5a39bb5f86f21cb67f94a013aa2c9bc4b69d
> 
> At a quick guess, I think this is problem caused by the autopkgtests
> being run without the pyproject.toml. As in:
> 
> --- a/debian/tests/pytest
> +++ b/debian/tests/pytest
> @@ -14,7 +14,7 @@ fi
> 
>  for py in $(py3versions -s); do
>      echo "@@@@@@@@ Running against $py"
> -    cp -r tests "$AUTOPKGTEST_TMP"
> +    cp -r tests pyproject.toml "$AUTOPKGTEST_TMP"
>      (cd "$AUTOPKGTEST_TMP"; "$py" -m pytest -vv -l -r a)
>      rm -rf "${AUTOPKGTEST_TMP:?}"/*
>  done
> 
> … will likely fix this.
> 
> 
Aha.  Thanks for the quick reply and fix!

Cheers,
Julien

Message #25 received at 945993-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 945993-close@bugs.debian.org

Subject: Bug#945993: fixed in diffoscope 134

Date: Fri, 27 Dec 2019 22:34:28 +0000

Source: diffoscope
Source-Version: 134

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 945993@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 27 Dec 2019 19:17:16 +0000
Source: diffoscope
Architecture: source
Version: 134
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 945993
Changes:
 diffoscope (134) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Ensure that autopkgtests are run with our pyproject.toml present for the
     correct "black" source code formatter settings. (Closes: #945993)
   * Tidy some unnecessary boolean logic in the ISO9660 tests.
   * Rename the "text_option_with_stdiout" to "text_option_with_stdout".
   * Include the libarchive file listing for ISO images to ensure that
     timestamps (not just dates) are visible in any difference.
     (Closes: reproducible-builds/diffoscope#81)
 .
   [ Eli Schwartz ]
   * Fix an exception in the progressbar handler.
 .
   [ Vagrant Cascadian ]
   * Add an external tool reference for zstd on GNU Guix.
Checksums-Sha1:
 dfd63811a853517bc775583b9e8310ec112b92a4 4717 diffoscope_134.dsc
 11df858a29b55e43555fdb99cb172c09a539e16d 974476 diffoscope_134.tar.xz
 3ac3b73ae7e0fe0559d3c86e292a1fe985a4257c 26300 diffoscope_134_amd64.buildinfo
Checksums-Sha256:
 89fef3182bab0119bcf2493158319f280b95ecbfb3600c143fc238c15b368ae8 4717 diffoscope_134.dsc
 a025f1133a88d84b2139684d4d64ab65e4ae7214d6e154cc0b77369832469d79 974476 diffoscope_134.tar.xz
 899f2bdb6c0c9a18e62b3df8e92ae11837b00d2b2d54a350e3e8222b785780cd 26300 diffoscope_134_amd64.buildinfo
Files:
 7b85657920ef986dcb047d8837aa0b26 4717 devel optional diffoscope_134.dsc
 5a5002aea8c555d0e0fb50dced284684 974476 devel optional diffoscope_134.tar.xz
 8a6ad4d66d14283546bcf3995e031ad3 26300 devel optional diffoscope_134_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl4GhEIACgkQHpU+J9Qx
HliX9g/9HEZsl5vfI6PtgdEjHEhIvGGgXeXlqBcW8S1GIv51kYO2vF1blEZ9jbKC
O/bsMErKcm60QjaFLmiQlF9P1U9npE0TmMncr3vuWHu8LqMQ0ouSv8k21Ao/drQp
LLHsh+9mHtMeZZWESkHJDInmqave8FGLkV0WcZQIJj3oaVsfwI2fXdew06QYnxyC
p6dec5ZzQxg60xBXd0OMR9zDefpuJ9I2Qsmvc2COh1cEutoj4d0wzviunh8tL46m
xJPVkUViRTQm6VqTgKOHSFB+cK8GJB4/XDXTo115Fv9kQIyOClHfhQLEOWdJ0bbO
0cOpS6odHKUCJCg1v/oGiV5p2p2ma8Z36u7omf4rJR49H/CBdP0shqtddXPCwqz0
B0I1uzvOnUITJ9TYiatdBGMc37EOx+PjjdexY1c33g0f70MePIJultpuV+Py4DF7
V9BbRjMDQ0BAs8nDRkxVsc/3V9tjP2+grU8J+amjecBXtXzvesCvyM953rUGmrDg
oVL0RQ7xNcSn0hLlsb60ay6blEwN7RyVx9AWBkEHx/GgJs94POS67HPXz6YxOPPa
8Gl1KC2FCixap2ELHKG4HMmX/XTQzP9A0XiAwWghpCwP1bYXDS2b6nO4Ko8OOWf/
eHqpxfRQZWECme0cTLpvkmsqqdJ0cH9QSAi8FToMLVcTp6IQE/w=
=CNF+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.