Debian Bug report logs - #943471
khard: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: khard: please make the build reproducible

Date: Fri, 25 Oct 2019 09:51:39 +0100

[Message part 1 (text/plain, inline)]

Source: khard
Version: 0.15.0-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that khard could not be built reproducibly.

This is because it includes the absolute build directory in the
documentation via the SPEC_FILE attribute. Patch attached that
calculates this dynamically instead.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[/tmp/khard.diff.txt (text/plain, attachment)]

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Félix Sipma <felix+debian@gueux.org>

To: Chris Lamb <lamby@debian.org>, 943471@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: Bug#943471: khard: please make the build reproducible

Date: Mon, 28 Oct 2019 14:38:42 +0100

[Message part 1 (text/plain, inline)]

Hi Chris,

Thanks for the report and the attached patch. Would you want to file a
pull request to upstream directly? https://github.com/scheibler/khard

If not, of course I can do that by myself.

Regards,

-- 
Félix

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 943471@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 943471@bugs.debian.org, felix+debian@gueux.org

Subject: Re: khard: please make the build reproducible

Date: Mon, 28 Oct 2019 14:19:17 +0000

forwarded 943471 https://github.com/scheibler/khard/pull/233
thanks

Félix Sipma wrote:

> Thanks for the report and the attached patch. Would you want to file a
> pull request to upstream directly?

No problem. I've forwarded this upstream here:

  https://github.com/scheibler/khard/pull/233

As part of this I noticed that the patch I previously attached was a
little bit garbled so it won't apply completely cleanly... but I think
after the above PR is merged and released you will just need to do:

    --- a/debian/rules	2019-10-25 09:18:54.208690284 +0100
    --- b/debian/rules	2019-10-25 09:33:48.499676643 +0100
    @@ -8,5 +8,9 @@
	    make man
	    dh_auto_build
     
    +override_dh_auto_clean:
    +	dh_auto_clean
    +	rm -f khard/version.py
    +	

… but you may need to add `tar-ignore = "*/version.py"` to debian/
source/options too, I am not quite sure right now.

Hope that helps.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #27 received at 943471@bugs.debian.org (full text, mbox, reply):

From: Félix Sipma <felix+debian@gueux.org>

To: Chris Lamb <lamby@debian.org>

Cc: 943471@bugs.debian.org

Subject: Re: khard: please make the build reproducible

Date: Mon, 28 Oct 2019 15:28:34 +0100

[Message part 1 (text/plain, inline)]

On 2019-10-28 14:19+0000, Chris Lamb wrote:
> No problem. I've forwarded this upstream here:
> 
>  https://github.com/scheibler/khard/pull/233
> 
> As part of this I noticed that the patch I previously attached was a
> little bit garbled so it won't apply completely cleanly... but I think
> after the above PR is merged and released you will just need to do:
> 
>    --- a/debian/rules	2019-10-25 09:18:54.208690284 +0100
>    --- b/debian/rules	2019-10-25 09:33:48.499676643 +0100
>    @@ -8,5 +8,9 @@
> 	    make man
> 	    dh_auto_build
>     
>    +override_dh_auto_clean:
>    +	dh_auto_clean
>    +	rm -f khard/version.py
>    +	
> 
> … but you may need to add `tar-ignore = "*/version.py"` to debian/
> source/options too, I am not quite sure right now.
> 
> Hope that helps.
> 
> Best wishes,

OK, I'll keep this in mind.

Thanks again,

-- 
Félix

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 943471-close@bugs.debian.org (full text, mbox, reply):

From: Félix Sipma <felix+debian@gueux.org>

To: 943471-close@bugs.debian.org

Subject: Bug#943471: fixed in khard 0.15.0-3

Date: Thu, 31 Oct 2019 18:19:48 +0000

Source: khard
Source-Version: 0.15.0-3

We believe that the bug you reported is fixed in the latest version of
khard, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 943471@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Félix Sipma <felix+debian@gueux.org> (supplier of updated khard package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 31 Oct 2019 18:53:17 +0100
Source: khard
Architecture: source
Version: 0.15.0-3
Distribution: unstable
Urgency: medium
Maintainer: Félix Sipma <felix+debian@gueux.org>
Changed-By: Félix Sipma <felix+debian@gueux.org>
Closes: 943471
Changes:
 khard (0.15.0-3) unstable; urgency=medium
 .
   * add patch to make build reproducible (Closes: #943471).
     Thanks, Chris Lamb.
   * fix bug in use-debian-paths-in-doc.patch (khard.conf file not included in
     doc)
   * add python3-pygments to build dependencies (required to build doc)
Checksums-Sha1:
 59c9717b50d5a077fe40d892cac08daf98e868e1 1519 khard_0.15.0-3.dsc
 75fc77a4ff268b5fffcd1e7eaa18626cc5d7f76b 6292 khard_0.15.0-3.debian.tar.xz
Checksums-Sha256:
 c578ad5144d1872c47eef0d0aa6662492287d7630834cba44a9c074ccdc13143 1519 khard_0.15.0-3.dsc
 938536f8247ded5bba134ee15017015cadc1179f985ad43f568e5fad4cd1bc05 6292 khard_0.15.0-3.debian.tar.xz
Files:
 e906e54d8316057df6b820fba24d3606 1519 utils optional khard_0.15.0-3.dsc
 8fa2181ed228ad1269a3fcf7804f5aa5 6292 utils optional khard_0.15.0-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQR6zeIsS8L0XLQfqiQBpfxHUdFE8AUCXbsjIgAKCRABpfxHUdFE
8MS+AP46wXIi6qw/60zQJaPqHT3ez++0x62xBNbxexYiVmZ6vwEAvglgarSGROFL
AJEnphVSBbjLE+YND0m2tfLwC10f1gQ=
=A8CH
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.