Debian Bug report logs - #942867
r-base: does not respect nocheck build profile in DEB_BUILD_OPTIONS

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: r-base: does not respect nocheck build profile in DEB_BUILD_OPTIONS

Date: Tue, 22 Oct 2019 15:46:51 +0100

[Message part 1 (text/plain, inline)]

Source: r-base
Version: 3.6.1-6
Severity: normal
Tags: patch

Hi,

src:r-base does not appear to respect the "nocheck" profile in
DEB_BUILD_OPTIONS. Whilst there appears to be code that intends to do
exactly this, ie.:

    build-arch: make-arch
    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
    build-arch: check
    endif

… AFAICT this does not work as we specify "check" directly in the
binary target:

    binary: make-stamp check binary-arch binary-indep

However, a patch is attached that drops the puts all of the "shall I
actually run the tests" predicates together which not only works (!)
it also is a bit clearer.

Discovered as part of faffing around with Reproducible Builds [0].

  [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[/tmp/r-base.diff.txt (text/plain, attachment)]

Message #10 received at 942867@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: "Chris Lamb" <lamby@debian.org>, 942867@bugs.debian.org

Cc: Dirk Eddelbuettel <edd@debian.org>

Subject: Re: Bug#942867: r-base: does not respect nocheck build profile in DEB_BUILD_OPTIONS

Date: Tue, 22 Oct 2019 10:17:17 -0500

Hi Chris,

On 22 October 2019 at 15:46, Chris Lamb wrote:
| Source: r-base
| Version: 3.6.1-6
| Severity: normal
| Tags: patch
| 
| Hi,
| 
| src:r-base does not appear to respect the "nocheck" profile in
| DEB_BUILD_OPTIONS. Whilst there appears to be code that intends to do
| exactly this, ie.:
| 
|     build-arch: make-arch
|     ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
|     build-arch: check
|     endif
| 
| … AFAICT this does not work as we specify "check" directly in the
| binary target:
| 
|     binary: make-stamp check binary-arch binary-indep
| 
| However, a patch is attached that drops the puts all of the "shall I
| actually run the tests" predicates together which not only works (!)
| it also is a bit clearer.
| 
| Discovered as part of faffing around with Reproducible Builds [0].
| 
|   [0] https://reproducible-builds.org/

Big big BIG thank you.  I noticed the 'no repro for you' checkmark the other
day when scanning my QA page. It may be a side effect of the recent switch to
source-only uploads which affected the doc packages (and I had to cheat and
make binary-arch build binary-all builds -- it depends on configure and
friends doing their thing).

Will fold this in this evening.

Happy to assist with the other missing 'no repro for you' on my page at
https://qa.debian.org/developer.php?login=edd@debian.org but may need
help. If you can spare a few more moments I would appreciate it. If you're
tied up no mas.

Cheers, Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Message #15 received at 942867-close@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: 942867-close@bugs.debian.org

Subject: Bug#942867: fixed in r-base 3.6.1-7

Date: Wed, 23 Oct 2019 01:57:04 +0000

Source: r-base
Source-Version: 3.6.1-7

We believe that the bug you reported is fixed in the latest version of
r-base, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 942867@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dirk Eddelbuettel <edd@debian.org> (supplier of updated r-base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 22 Oct 2019 20:03:02 -0500
Source: r-base
Architecture: source
Version: 3.6.1-7
Distribution: unstable
Urgency: medium
Maintainer: Dirk Eddelbuettel <edd@debian.org>
Changed-By: Dirk Eddelbuettel <edd@debian.org>
Closes: 942867 942870
Changes:
 r-base (3.6.1-7) unstable; urgency=medium
 .
   * debian/rules: Respect DEB_BUILD_OPTIONS setting 'nocheck' thanks to
     patch by Chris Lamb 				(Closes: #942867)
 .
   * debian/rules: Respect DEB_BUILD_OPTIONS setting 'nodoc' thanks to
     patch by Chris Lamb 				(Closes: #942870)
Checksums-Sha1:
 29797e7f9cd8c715aacc5022d0e584b7b524007a 3016 r-base_3.6.1-7.dsc
 9063672e73d2504875154f0398851a879b617a8a 96168 r-base_3.6.1-7.debian.tar.xz
 c14b9ee588490a83101138f0cfdf91edb712cceb 16021 r-base_3.6.1-7_amd64.buildinfo
Checksums-Sha256:
 55cf95d72cc289642a29cddcaa5f29500903f78e57f3367a2254f53bdb807c94 3016 r-base_3.6.1-7.dsc
 2734b06cf43605b31e6f79d5b858f8a47fe330621222661c4a956a29db122cfc 96168 r-base_3.6.1-7.debian.tar.xz
 3cfdbe11aed4875ae4412bf415d0922ad9df02b6787ca3baab17b8922d143ff9 16021 r-base_3.6.1-7_amd64.buildinfo
Files:
 620e9679f4e708e93ef91fcdbd2f39b4 3016 gnu-r optional r-base_3.6.1-7.dsc
 f51d53e5d5d18b770f8c699573de42a3 96168 gnu-r optional r-base_3.6.1-7.debian.tar.xz
 ad66f8f140c96ef0d991a8cbc5b0bb17 16021 gnu-r optional r-base_3.6.1-7_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIVAwUBXa+raKFIn+KrmaIaAQgUQRAAjfBoNJKq2EfXVumyx6WRfY2NqsTrdf8P
auvAGWn354BQuAt//0AytSPjHNt7MAHdv+T1fwwNQ3qNimylj1L8M1GoHZ8YgQp8
L6qvtSGi63vQj9M41vUOdt9y/0ykf5IC9OjgR0fYtXENohV+MvA0njiOSpSUeIPg
o4iRv6Rs8Jzj7CwQZ8cNlbBhTVT4nI8yyL43+TttDkL2YbVWtQg2j7rSwWpmloNg
6Jtgo0f1JN2BwLxrEPkJHZFlS2ldsp5DXcTikulULQCWTxX1oJOKxwqMBtmzyAij
llH+IqAc9aCs7fqM25RTuLgyGJoh6iZf6NVV8A/HnMSZ/C8WafcyB+TP8F0eUe9L
A2/A0wg9NJNqWCexaypGk8YnK8tdEnM8P91b4kQkPUGXVRtOQk58WBXja+IlpOdE
aIYE+jVLrf49VHPy2L0lfZCUBft6/y3y4VAqaFfSlqQPzRYIpLupK/qW+oVMVTmr
WSymnSBKWuh5+iLySUF+CW2xUjVYZrYzpGdgIcjT7mHbQpC+BgcElAIgCFFW3VYd
m5ayZ0MA3hapFHUBS3PMKs89QJP+wqxHLj0ZQyiKHipkDVfQIdluBoNtNSwRg9fB
59fl2MvqakCK09v12Eu3lakgHbelkc6BTDB/1Dpu4uB5L1M12gNWftAJpUUf9hG6
Ki1fv8cy2Tk=
=rQVw
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.