Debian Bug report logs - #942342
traitlets: please make the output reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: traitlets: please make the output reproducible

Date: Mon, 14 Oct 2019 14:38:55 -0700

[Message part 1 (text/plain, inline)]

Source: traitlets
Version: 4.3.3-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness toolchian
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that traitlets generates non-reproducible output which is affecting
the reproducibility of other packages. For example, in nbconvert:

  -<dd><p class="first">Default: […] {'image/jpeg',</span> <span class="pre">'image/svg+xml',</span> <span class="pre">'ap
plication/pdf',</span>
  +<dd><p class="first">Default: <code class="docutils literal notranslate"><span class="pre">{'image/svg+xml',</span> <span class="pre">'application/pdf',</span>

(From https://tests.reproducible-builds.org/debian/rb-pkg/unstable/
amd64/nbconvert.html on 20191014)

This is due to it not iterating over a Set traitlet type in a
deterministic ordering when generating the "Default:" human-readable
string.

Patch attached.

  [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[/tmp/traitlets.diff.txt (text/plain, attachment)]

Message #10 received at 942342@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 942342@bugs.debian.org

Cc: "Chris Lamb" <lamby@debian.org>

Subject: Re: traitlets: please make the output reproducible

Date: Mon, 14 Oct 2019 14:53:14 -0700

forwarded 942342 https://github.com/ipython/traitlets/pull/535
thanks

I've forwarded this upstream here:

  https://github.com/ipython/traitlets/pull/535


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 942342@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 942342@bugs.debian.org

Subject: Re: traitlets: please make the output reproducible

Date: Mon, 14 Oct 2019 14:48:10 -0700

Chris Lamb wrote:

> Patch attached.

Let's try that again:

    --- a/traitlets/traitlets.py
    +++ b/traitlets/traitlets.py
    @@ -2366,6 +2366,10 @@ class Set(List):
	     """
	     super(Set, self).__init__(trait, default_value, minlen, maxlen, **kwargs)
     
    +    def make_dynamic_default(self):
    +        # Ensure default value is sorted for a reproducible build
    +        return sorted(super(Set, self).make_dynamic_default())
    +
     
     class Tuple(Container):
	 """An instance of a Python tuple."""


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 942342-submitter@bugs.debian.org (full text, mbox, reply):

From: Julien Puydt <noreply@salsa.debian.org>

To: 942342-submitter@bugs.debian.org

Subject: Bug#942342 marked as pending in traitlets

Date: Tue, 17 Dec 2019 07:00:50 +0000

Control: tag -1 pending

Hello,

Bug #942342 in traitlets reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/python-team/modules/traitlets/commit/b1c5dd73762930abeae828d33e309f8f87a51ff5

------------------------------------------------------------------------
Add patch from Chris Lamb to allow reproducible builds (Closes: #942342)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/942342

Message #27 received at 942342-close@bugs.debian.org (full text, mbox, reply):

From: Julien Puydt <jpuydt@debian.org>

To: 942342-close@bugs.debian.org

Subject: Bug#942342: fixed in traitlets 4.3.3-2

Date: Tue, 17 Dec 2019 07:19:33 +0000

Source: traitlets
Source-Version: 4.3.3-2

We believe that the bug you reported is fixed in the latest version of
traitlets, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 942342@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Puydt <jpuydt@debian.org> (supplier of updated traitlets package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 17 Dec 2019 07:54:41 +0100
Source: traitlets
Architecture: source
Version: 4.3.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Julien Puydt <jpuydt@debian.org>
Closes: 942342 945541
Changes:
 traitlets (4.3.3-2) unstable; urgency=medium
 .
   * Use my debian.org mail address.
   * Add patch from Chris Lamb to allow reproducible builds (Closes: #942342).
   * Add patch to remove a warning with Python 3.8 (Closes: #945541).
Checksums-Sha1:
 1080d6612417c1c7b549efc4a30ea444b0cdc361 2423 traitlets_4.3.3-2.dsc
 b961ce76be4a78fffa9401ec03c341b03b444a54 4428 traitlets_4.3.3-2.debian.tar.xz
 56521ed1dce414ed1d090392381f1f6e8454d143 8554 traitlets_4.3.3-2_source.buildinfo
Checksums-Sha256:
 0b719992813be8f1aa1ebfe4660aea0c046afdb034a2415468bda68c6a893781 2423 traitlets_4.3.3-2.dsc
 17ca12fbf7d32fc27e688b7072d977bdfe1f0361c59c9205ccaafda16eaba7c2 4428 traitlets_4.3.3-2.debian.tar.xz
 b74e2ab338774c835e2e5ffe90ffbaf895151cef65f3049d17203456cb7e1d87 8554 traitlets_4.3.3-2_source.buildinfo
Files:
 d3d6195bc3cd9ff822575a85103867f9 2423 python optional traitlets_4.3.3-2.dsc
 7ae700413a51201f49c56d6ed696dde2 4428 python optional traitlets_4.3.3-2.debian.tar.xz
 882e73167dfa2df3ba082d6994111825 8554 python optional traitlets_4.3.3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEgS7v2KP7pKzk3xFLBMU71/4DBVEFAl34fPUSHGpwdXlkdEBk
ZWJpYW4ub3JnAAoJEATFO9f+AwVRdh4P+wbg7vrrFkH826J20XibTUY3wepB2L9C
sxUjy8RDoJz8v583/UJUsCFZGXiza/dmbqQ51NiJsh9wtRjdkRJ/2ySyDy3jxIiL
YAPDRHh2xUyh+fxbxBTxsTgd2K2EhBpr5GnRtgFMC4My4b6oq1w/D7K9awKRwEHK
+pHIPSNlOqjYGFOnaO0KYItyxFmeDW3fW3DZH1YDlXkxUvppf9HHwtZKyQ8s4YD0
3j+A9vDSyNPWiwMVM8Tqwnkh0po1Xm7QE2DY5Y59Y5y8PiISywAgoZAkJ58vpXAk
m/qOYqUIMQ3WGYOAdZHhwUGGey1laOTgQRj5WmZNT9T562PNdmfK0Vt30rlRLj15
DtlVum5mpPPEz5xHj+6J4thVtvYC+nx4L4d4O2agCKivcYk/KY7vfLg+Z6Mmeijd
hvIQGkeMCIgWAdeBoXNjlqaspN648zNV9TtZpKLz+tT9lRL6P6Fm7WxPIKkwy+HA
GMNpAdm0jJUYCSvzqkYhUUmJS02lpu5iirpavO9ct9dbRJcxln4dno9mTHWnJ+Q/
7pyLpgBpHgy5As/xJ7rnVAmJHfl/2hgUaaQ09UgQRjeP8sWUnZfoCaPi75beY5Pz
LAif7Vdr4XfMEgCOA49o8njhXHCN78ZDal7QAw2wr8WAh2kYQPKCpQvh+6vPx1WZ
fTd5C4dUHl0p
=KZ02
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.