Debian Bug report logs - #942009
stgit: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: stgit: please make the build reproducible

Date: Tue, 08 Oct 2019 16:35:39 -0700

[Message part 1 (text/plain, inline)]

Source: stgit
Version: 0.19-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that stgit could not be built reproducibly.

This is because the contents of the dynamically-compiled Bash
completion script was not being generated in a deterministic manner,
as well as the cmdlist.py module.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[/tmp/stgit.diff.txt (text/plain, attachment)]

Message #12 received at 942009@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 942009@bugs.debian.org

Subject: Re: stgit: please make the build reproducible

Date: Tue, 08 Oct 2019 17:09:25 -0700

forwarded 942009 https://github.com/ctmarinas/stgit/pull/43
thanks

I've forwarded this upstream here:

  https://github.com/ctmarinas/stgit/pull/43


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 942009@bugs.debian.org (full text, mbox, reply):

From: Maximiliano Curia <maxy@gnuservers.com.ar>

To: Chris Lamb <lamby@debian.org>, 942009@bugs.debian.org

Subject: Re: Bug#942009: stgit: please make the build reproducible

Date: Wed, 09 Oct 2019 12:58:56 +0000

[Message part 1 (text/plain, inline)]

On 2019-10-08 23:35, Chris Lamb wrote:
> Source: stgit
> Version: 0.19-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: randomness
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

> Whilst working on the Reproducible Builds effort [0] we noticed
> that stgit could not be built reproducibly.
> 
> This is because the contents of the dynamically-compiled Bash
> completion script was not being generated in a deterministic manner,
> as well as the cmdlist.py module.

> Patch attached.

Thanks. I thought that (python3 > 3.6)'s sets also preserved their 
insertion order (as dictionaries do), apparently not. We could probably 
request that to cpython, that should fix some other set related 
reproducibility issues.

Happy hacking,
-- 
Saludos /\/\ /\ >< `/

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 942009@bugs.debian.org (full text, mbox, reply):

From: "Stepanka Fillipova" <shirley@webstersie.com>

To: <942009@bugs.debian.org>

Subject: RE:RE: Doplatek na ucet c.1 (01270-51343)

Date: Fri, 27 Dec 2019 11:47:19 +0200

[Message part 1 (text/plain, inline)]

Vazeni klienti

Dle domluvy Vam posilam info ohledne doplatku.
vysi 5686.477 ,- Kc, kterou  prosim uhradte na nize uvedeny bankovni ucet
do 29.12.2019.

Fakturacni udaje.

S pratelskym pozdravem,
Stepanka Fillipova
advokat/attorney at law
Opatovicka 1652/4, Praha 1

[faktura-23.12.2019_c.1 (01270-51337).doc (application/msword, attachment)]

Message #29 received at 942009@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 942009@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#942009: stgit: please make the build reproducible

Date: Wed, 09 Sep 2020 22:56:03 -0000

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #32 received at 942009-submitter@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <noreply@salsa.debian.org>

To: 942009-submitter@bugs.debian.org

Subject: Bug#942009 marked as pending in stgit

Date: Thu, 01 Dec 2022 20:08:34 +0000

Control: tag -1 pending

Hello,

Bug #942009 in stgit reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/stgit/-/commit/52e3c23c66df52e9cf3c405bf45a624ac77e9349

------------------------------------------------------------------------
Make the build reproducible. (Closes: #942009)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/942009

Message #39 received at 942009@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Chris Lamb <lamby@debian.org>, 942009@bugs.debian.org

Subject: Re: Bug#942009: stgit: please make the build reproducible

Date: Thu, 01 Dec 2022 12:11:29 -0800

[Message part 1 (text/plain, inline)]

On 2019-10-08, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed
> that stgit could not be built reproducibly.
>
> This is because the contents of the dynamically-compiled Bash
> completion script was not being generated in a deterministic manner,
> as well as the cmdlist.py module.
>
> Patch attached.

Uploaded an NMU fixing this:

diff -Nru stgit-0.19/debian/changelog stgit-0.19/debian/changelog
--- stgit-0.19/debian/changelog	2019-10-03 05:38:18.000000000 -0700
+++ stgit-0.19/debian/changelog	2022-12-01 11:53:31.000000000 -0800
@@ -1,3 +1,12 @@
+stgit (0.19-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Make the build reproducible. (Closes: #942009)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 01 Dec 2022 11:53:31 -0800
+
 stgit (0.19-1) unstable; urgency=medium
 
   [ Maximiliano Curia ]
diff -Nru stgit-0.19/debian/patches/reproducible_build stgit-0.19/debian/patches/reproducible_build
--- stgit-0.19/debian/patches/reproducible_build	1969-12-31 16:00:00.000000000 -0800
+++ stgit-0.19/debian/patches/reproducible_build	2022-12-01 11:53:00.000000000 -0800
@@ -0,0 +1,33 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2019-10-08
+
+--- stgit-0.19.orig/stgit/argparse.py
++++ stgit-0.19/stgit/argparse.py
+@@ -260,7 +260,7 @@ class CompgenBase(object):
+             cmd += ['-A', act]
+         words = self.words(var)
+         if words:
+-            cmd += ['-W', '"%s"' % ' '.join(words)]
++            cmd += ['-W', '"%s"' % ' '.join(sorted(words))]
+         cmd += ['--', '"%s"' % var]
+         return ' '.join(cmd)
+ 
+@@ -310,4 +310,4 @@ class patch_range(CompgenBase):
+         for e in self.__endpoints:
+             assert not e.actions(var)
+             words |= e.words(var)
+-        return set(['$(_patch_range "%s" "%s")' % (' '.join(words), var)])
++        return set(['$(_patch_range "%s" "%s")' % (' '.join(sorted(words)), var)])
+
+--- stgit-0.19.orig/stgit/commands/__init__.py
++++ stgit-0.19/stgit/commands/__init__.py
+@@ -63,7 +63,7 @@
+ def py_commands(commands, f):
+     f.write('from __future__ import unicode_literals\n\n')
+     f.write('command_list = {\n')
+-    for name, (mod, kind, help) in commands.items():
++    for name, (mod, kind, help) in sorted(commands.items()):
+         f.write('    %r: (\n' % name)
+         f.write('        %r,\n' % mod)
+         f.write('        %r,\n' % kind)
diff -Nru stgit-0.19/debian/patches/series stgit-0.19/debian/patches/series
--- stgit-0.19/debian/patches/series	2019-10-03 05:38:18.000000000 -0700
+++ stgit-0.19/debian/patches/series	2022-12-01 11:53:00.000000000 -0800
@@ -2,3 +2,4 @@
 stg-gitk_bashism
 disable_interactive_test
 Avoid-the-git-error-messages-when-running-stg-outside-of-.patch
+reproducible_build

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 942009-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 942009-close@bugs.debian.org

Subject: Bug#942009: fixed in stgit 0.19-1.1

Date: Thu, 01 Dec 2022 20:53:45 +0000

Source: stgit
Source-Version: 0.19-1.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
stgit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 942009@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated stgit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 01 Dec 2022 11:53:31 -0800
Source: stgit
Architecture: source
Version: 0.19-1.1
Distribution: unstable
Urgency: medium
Maintainer: Maximiliano Curia <maxy@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 942009
Changes:
 stgit (0.19-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * Make the build reproducible. (Closes: #942009)
Checksums-Sha1:
 622d4b49896d132fd31789250505049acd2c53bf 1330 stgit_0.19-1.1.dsc
 b9186f6d5047f4cbddc08a9b6ff92dcc31a01524 16740 stgit_0.19-1.1.debian.tar.xz
 4b415934f2c092cc54ef556ffafe197e0f5cf52e 6953 stgit_0.19-1.1_arm64.buildinfo
Checksums-Sha256:
 1b88cbf3c3507954a9b0d57efdcedd00e5347af5a718e8f683810b69c00d850a 1330 stgit_0.19-1.1.dsc
 caeb7513bfdd3d09a61de8543339f5941081cb0bb62ccbc17df7b948064d507e 16740 stgit_0.19-1.1.debian.tar.xz
 a33c1c6630aa3a01b788feabf6057cca779bc0c42531a925cd16ab0c68204003 6953 stgit_0.19-1.1_arm64.buildinfo
Files:
 16946baf9164a2d020b1564e3c43d581 1330 vcs optional stgit_0.19-1.1.dsc
 5c2950def36aff24572781a728740a8a 16740 vcs optional stgit_0.19-1.1.debian.tar.xz
 1586d310ff67742f4541cf899e87ca8b 6953 vcs optional stgit_0.19-1.1_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY4kJcCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqpTfAP0Vh9/80TrXOLDm
uzER29eVVoD8sZENjjy7lx8t79c/tQD/U9IsDBVUYxE4FJrINY3DMMA6ZLjjcLQQ
NM8+TPFngA8=
=7W1V
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.