Debian Bug report logs - #942006
squeak-plugins-scratch: please make the build reproducible

version graph

Package: src:squeak-plugins-scratch; Maintainer for src:squeak-plugins-scratch is Miriam Ruiz <miriam@debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Tue, 8 Oct 2019 22:48:02 UTC

Severity: wishlist

Tags: patch

Found in version squeak-plugins-scratch/1.4.0.2~svn.r83-3

Fixed in version squeak-plugins-scratch/1.4.0.2~svn.r83-3.1

Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Miriam Ruiz <miriam@debian.org>:
Bug#942006; Package src:squeak-plugins-scratch. (Tue, 08 Oct 2019 22:48:05 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Miriam Ruiz <miriam@debian.org>. (Tue, 08 Oct 2019 22:48:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: squeak-plugins-scratch: please make the build reproducible
Date: Tue, 08 Oct 2019 15:45:23 -0700
[Message part 1 (text/plain, inline)]
Source: squeak-plugins-scratch
Version: 1.4.0.2~svn.r83-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that squeak-plugins-scratch could not be built reproducibly.

This was because the upstream Makefile was not respecting CFLAGS
and/or dpkg-buildflags and thus was missing the -fdebug-prefix-map
GCC argument.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[/tmp/squeak-plugins-scratch.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Miriam Ruiz <miriam@debian.org>:
Bug#942006; Package src:squeak-plugins-scratch. (Sat, 29 Aug 2020 10:42:10 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Miriam Ruiz <miriam@debian.org>. (Sat, 29 Aug 2020 10:42:10 GMT) (full text, mbox, link).


Message #10 received at 942006@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: 942006@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org
Subject: Re: Bug#942006: squeak-plugins-scratch: please make the build reproducible
Date: Sat, 29 Aug 2020 06:39:16 -0400 (EDT)
Dear Maintainer,

> Source: squeak-plugins-scratch
> Version: 1.4.0.2~svn.r83-3
> Tags: patch

There hasn't seem to be any update on this bug in 325 days, in which
time the Reproducible Builds effort has come on a long way.

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Miriam Ruiz <miriam@debian.org>:
Bug#942006; Package src:squeak-plugins-scratch. (Sat, 28 Nov 2020 13:09:08 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Miriam Ruiz <miriam@debian.org>. (Sat, 28 Nov 2020 13:09:08 GMT) (full text, mbox, link).


Message #15 received at 942006@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: 942006@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org
Subject: Re: Bug#942006: squeak-plugins-scratch: please make the build reproducible
Date: Sat, 28 Nov 2020 13:07:04 -0000
Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Miriam Ruiz <miriam@debian.org>:
Bug#942006; Package src:squeak-plugins-scratch. (Thu, 01 Dec 2022 20:27:05 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Miriam Ruiz <miriam@debian.org>. (Thu, 01 Dec 2022 20:27:05 GMT) (full text, mbox, link).


Message #20 received at 942006@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: 876771@bugs.debian.org, 942006@bugs.debian.org
Subject: NMU fixing reproducible and cross-build issues
Date: Thu, 01 Dec 2022 12:25:52 -0800
[Message part 1 (text/plain, inline)]
I am uploading an NMU fixing reproducible builds and cross-building
issues:

diff -Nru squeak-plugins-scratch-1.4.0.2~svn.r83/debian/changelog squeak-plugins-scratch-1.4.0.2~svn.r83/debian/changelog
--- squeak-plugins-scratch-1.4.0.2~svn.r83/debian/changelog	2018-11-09 03:16:26.000000000 -0800
+++ squeak-plugins-scratch-1.4.0.2~svn.r83/debian/changelog	2022-12-01 12:18:32.000000000 -0800
@@ -1,3 +1,15 @@
+squeak-plugins-scratch (1.4.0.2~svn.r83-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Make the build reproducible. (Closes: #942006)
+
+  [ Helmut Grohne ]
+  * Fix cross-building (Closes: #876771)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 01 Dec 2022 12:18:32 -0800
+
 squeak-plugins-scratch (1.4.0.2~svn.r83-3) unstable; urgency=medium
 
   * Cleaned up many lintian warnings
diff -Nru squeak-plugins-scratch-1.4.0.2~svn.r83/debian/rules squeak-plugins-scratch-1.4.0.2~svn.r83/debian/rules
--- squeak-plugins-scratch-1.4.0.2~svn.r83/debian/rules	2018-11-09 03:16:26.000000000 -0800
+++ squeak-plugins-scratch-1.4.0.2~svn.r83/debian/rules	2022-12-01 12:18:32.000000000 -0800
@@ -1,9 +1,15 @@
 #!/usr/bin/make -f
 
+include /usr/share/dpkg/architecture.mk
+
 export DH_ALWAYS_EXCLUDE=.svn
 
+ifeq ($(origin CC),default)
+CC = $(DEB_HOST_GNU_TYPE)-gcc
+endif
+PKG_CONFIG ?= $(DEB_HOST_GNU_TYPE)-pkg-config
 LDFLAGS=-Wl,-z,defs -Wl,--as-needed -Wl,--no-undefined
-CFLAGS=-std=gnu89
+CFLAGS=-std=gnu89 $(shell dpkg-buildflags --get CFLAGS)
 
 config: config-stamp
 config-stamp: 
@@ -17,21 +23,21 @@
 build-stamp: config
 	dh_testdir
 	cd camera/ && \
-		gcc $(CFLAGS) -g -fPIC -c *.c
+		$(CC) $(CFLAGS) -g -fPIC -c *.c
 	cd camera/ && \
-		gcc $(LDFLAGS) -g -shared *.o -lv4l2 -ldl -o so.CameraPlugin
+		$(CC) $(LDFLAGS) -g -shared *.o -lv4l2 -ldl -o so.CameraPlugin
 	cd scratch/ && \
-		gcc $(CFLAGS) -g -fPIC -c *.c
+		$(CC) $(CFLAGS) -g -fPIC -c *.c
 	cd scratch/ && \
-		gcc $(LDFLAGS) -g -shared *.o -lm -o so.ScratchPlugin
+		$(CC) $(LDFLAGS) -g -shared *.o -lm -o so.ScratchPlugin
 	cd unicode/ && \
-		gcc $(CFLAGS) -g -fPIC -c `pkg-config --cflags pangocairo` *.c
+		$(CC) $(CFLAGS) -g -fPIC -c `$(PKG_CONFIG) --cflags pangocairo` *.c
 	cd unicode/ && \
-		gcc $(LDFLAGS) -g -shared *.o `pkg-config --libs pangocairo` -lc -o so.UnicodePlugin
+		$(CC) $(LDFLAGS) -g -shared *.o `$(PKG_CONFIG) --libs pangocairo` -lc -o so.UnicodePlugin
 	cd wedo/ && \
-		gcc $(CFLAGS) -g -fPIC -c *.c
+		$(CC) $(CFLAGS) -g -fPIC -c *.c
 	cd wedo/ && \
-		gcc $(LDFLAGS) -g -shared *.o -o so.WeDoPlugin
+		$(CC) $(LDFLAGS) -g -shared *.o -o so.WeDoPlugin
 	touch $@
 
 clean: 
[signature.asc (application/pgp-signature, inline)]

Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Thu, 01 Dec 2022 20:57:07 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Thu, 01 Dec 2022 20:57:07 GMT) (full text, mbox, link).


Message #25 received at 942006-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 942006-close@bugs.debian.org
Subject: Bug#942006: fixed in squeak-plugins-scratch 1.4.0.2~svn.r83-3.1
Date: Thu, 01 Dec 2022 20:53:36 +0000
Source: squeak-plugins-scratch
Source-Version: 1.4.0.2~svn.r83-3.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
squeak-plugins-scratch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 942006@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated squeak-plugins-scratch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 01 Dec 2022 12:18:32 -0800
Source: squeak-plugins-scratch
Architecture: source
Version: 1.4.0.2~svn.r83-3.1
Distribution: unstable
Urgency: medium
Maintainer: Miriam Ruiz <miriam@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 876771 942006
Changes:
 squeak-plugins-scratch (1.4.0.2~svn.r83-3.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * Make the build reproducible. (Closes: #942006)
 .
   [ Helmut Grohne ]
   * Fix cross-building (Closes: #876771)
Checksums-Sha1:
 2a3cdf1ee8af47a20bd21c328d21cfc8ebdaa371 1698 squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.dsc
 32137d3f7875279257caedbdad0eb20e63833b25 4264 squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.debian.tar.xz
Checksums-Sha256:
 fc9b8913934523a0f734545f1274a89e421aadb0a5faf32e3011fc14782f61b0 1698 squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.dsc
 a55a8f33515eb3433b57b80996335037263d95efbc05a06a1fe31aad143da493 4264 squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.debian.tar.xz
Files:
 7c7ed49c7931412ae58c80b0104de337 1698 devel optional squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.dsc
 9632da847e8b4e902bc130727c7d8fe7 4264 devel optional squeak-plugins-scratch_1.4.0.2~svn.r83-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY4kOaCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqmtNAQDhgL66B5x6dT6w
ruPOvFUOikmT/igbMm97DLd/dpt9WQEAh+BCh6AZGDOHKP12dz5/ldchEGmC+BEF
mgCwJ/GptAc=
=RjNR
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 30 Dec 2022 07:24:57 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:14:15 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.