Debian Bug report logs - #940973
strip-nondeterminism: broken zip file t/fixtures/zip/bug_803503.zip.in in test suite

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Paul Gevers <elbrus@debian.org>

To: submit@bugs.debian.org

Subject: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Sun, 22 Sep 2019 21:47:47 +0200

[Message part 1 (text/plain, inline)]

Source: libarchive-zip-perl, strip-nondeterminism
Control: found -1 libarchive-zip-perl/1.66-1
Control: found -1 strip-nondeterminism/1.6.0-1
Severity: serious
Tags: sid bullseye
X-Debbugs-CC: debian-ci@lists.debian.org
User: debian-ci@lists.debian.org
Usertags: breaks needs-update

Dear maintainers,

With a recent upload of libarchive-zip-perl the autopkgtest of
strip-nondeterminism fails in testing when that autopkgtest is run with
the binary packages of libarchive-zip-perl from unstable. It passes when
run with only packages from testing. In tabular form:
                       pass            fail
libarchive-zip-perl    from testing    1.66-1
strip-nondeterminism   from testing    1.6.0-1
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of
libarchive-zip-perl to testing [1]. Due to the nature of this issue, I
filed this bug report against both packages. Can you please investigate
the situation and reassign the bug to the right package? If needed,
please change the bug's severity.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=libarchive-zip-perl

https://ci.debian.net/data/autopkgtest/testing/amd64/s/strip-nondeterminism/3013957/log.gz

ok 20 - t/fixtures/zip/bug_803503.zip.in
Reading ZIP archive failed: IO error: reading local extra field :

error: becoming Archive::Zip::DirectoryMember
# Looks like your test exited with 29 just after 20.
Tests failed

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 940973@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Paul Gevers" <elbrus@debian.org>, 940973@bugs.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Sun, 22 Sep 2019 20:57:02 +0100

Hi Paul,

> ok 20 - t/fixtures/zip/bug_803503.zip.in
> Reading ZIP archive failed: IO error: reading local extra field :
> 
> error: becoming Archive::Zip::DirectoryMember
> # Looks like your test exited with 29 just after 20.
> Tests failed

These is likely related:

  https://bugs.debian.org/858431
  https://salsa.debian.org/reproducible-builds/strip-nondeterminism/issues/4
  https://bugs.debian.org/931730

Will investigate soon.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #27 received at 940973@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Chris Lamb" <lamby@debian.org>, "Paul Gevers" <elbrus@debian.org>, 940973@bugs.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Mon, 23 Sep 2019 13:02:04 +0100

notfound 940973 strip-nondeterminism/1.6.0-1
affects 940973 + strip-nondeterminism
tags 940973 + fixed-upstream
forwarded 940973 https://github.com/redhotpenguin/perl-Archive-Zip/issues/51
thanks

Chris Lamb wrote:

> Will investigate soon.

This appears to be happening as libarchive-zip-perl 1.66 incorrectly
hardcodes the minimum zip version required to extract. Here is the
diffoscope output between the expected test output file and the actual
one generated with this version:

    --- t/fixtures/jar/jdependency.jar.out
    +++ jdependency.jar
    ├── zipinfo -v {}
    │ @@ -21,15 +21,15 @@
    │    META-INF/
    │  
    │    offset of local header from start of archive:   0
    │                                                    (0000000000000000h) bytes
    │    file system or operating system of origin:      Unix
    │    version of encoding software:                   2.0
    │    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
    │ -  minimum software version required to extract:   1.0
    │ +  minimum software version required to extract:   2.0
    │    compression method:                             none (stored)
    │    file security status:                           not encrypted
    │    extended local header:                          no
    │    file last modified on (DOS date/time):          2015 Feb 5 18:09:30
    │    32-bit CRC value (hex):                         00000000
    │    compressed size:                                0 bytes
    │    uncompressed size:                              0 bytes
    │ @@ -49,15 +49,15 @@
    │    META-INF/MANIFEST.MF
    │  
    │    offset of local header from start of archive:   39
    │                                                    (0000000000000027h) bytes
    │    file system or operating system of origin:      Unix
    │    version of encoding software:                   2.0
    │    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
    │ -  minimum software version required to extract:   1.0
    │ +  minimum software version required to extract:   2.0
    │    compression method:                             deflated
    │    compression sub-type (deflation):               normal
    │    file security status:                           not encrypted
    │    extended local header:                          no
    │    file last modified on (DOS date/time):          2015 Feb 5 18:09:30
    │    32-bit CRC value (hex):                         ea7cd5ff
    │    compressed size:                                98 bytes

This has been fixed upstream here:

  https://github.com/farblos/perl-Archive-Zip/commit/b0179cbbfeb276ceac0f424d32acf56811b01568

Reassigning to libarchive-zip-perl; there is unfortunately nothing
strip-nondeterminism can or should really do here, but setting
'affects' for visibility.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #32 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>, 940973@bugs.debian.org

Cc: Paul Gevers <elbrus@debian.org>

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Mon, 23 Sep 2019 18:47:44 +0200

[Message part 1 (text/plain, inline)]

On Mon, 23 Sep 2019 13:02:04 +0100, Chris Lamb wrote:

> This has been fixed upstream here:
>   https://github.com/farblos/perl-Archive-Zip/commit/b0179cbbfeb276ceac0f424d32acf56811b01568

Thanks for the analysis!
I've now uploaded -2 with this patch (minus 2 not applying but
irrelevant hunks) plus the previous commit which also touches on the
same topic. Will monitor the behaviour a bit :)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Jerry Lee Lewis: It'll Be Me

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 940973-submitter@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <noreply@salsa.debian.org>

To: 940973-submitter@bugs.debian.org

Subject: Bug#940973 marked as pending in libarchive-zip-perl

Date: Mon, 23 Sep 2019 16:47:40 +0000

Control: tag -1 pending

Hello,

Bug #940973 in libarchive-zip-perl reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/perl-team/modules/packages/libarchive-zip-perl/commit/f72b6498b8e5b14daea7d10dac894d97265fe9a9

------------------------------------------------------------------------
Add patch from upstream pull request to fix versionMadeBy and versionNeededToExtract issue in zip64.

Thanks: Paul Gevers for the bug report and Chris Lamb for the analysis.
Closes: #940973
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/940973

Message #42 received at 940973-close@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: 940973-close@bugs.debian.org

Subject: Bug#940973: fixed in libarchive-zip-perl 1.66-2

Date: Mon, 23 Sep 2019 17:05:03 +0000

Source: libarchive-zip-perl
Source-Version: 1.66-2

We believe that the bug you reported is fixed in the latest version of
libarchive-zip-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 940973@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gregoa@debian.org> (supplier of updated libarchive-zip-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 23 Sep 2019 18:44:09 +0200
Source: libarchive-zip-perl
Architecture: source
Version: 1.66-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: gregor herrmann <gregoa@debian.org>
Closes: 940973
Changes:
 libarchive-zip-perl (1.66-2) unstable; urgency=medium
 .
   * Team upload.
   * Add patch from upstream pull request to fix versionMadeBy and
     versionNeededToExtract issue in zip64.
     Thanks to Paul Gevers for the bug report and Chris Lamb for the analysis.
     (Closes: #940973)
   * Annotate test-only build dependencies with <!nocheck>.
   * Update debian/upstream/metadata.
   * Update years of packaging copyright.
Checksums-Sha1:
 a033862ccae6008309bfc7399dc56c79a862af07 2496 libarchive-zip-perl_1.66-2.dsc
 f5d93a4f4768d921123ad44526a4e179dcbd7e80 10336 libarchive-zip-perl_1.66-2.debian.tar.xz
Checksums-Sha256:
 e86fbe9efb5239b868565fda3360a66b27543594572608e9f1f4c597f8af3f87 2496 libarchive-zip-perl_1.66-2.dsc
 61a137d4ede7cd41a9759753b924f232e164b30828ec1154fe27a217d4ca9206 10336 libarchive-zip-perl_1.66-2.debian.tar.xz
Files:
 9d307fb3102949c6652e4f1018e01e24 2496 perl optional libarchive-zip-perl_1.66-2.dsc
 5625abb434d07a399416547e609d76ea 10336 perl optional libarchive-zip-perl_1.66-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl2I9xxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgaz7A//bOTDTERtyXhktJ6JzjVjZkaG0CyxstxVrR4kfR9/JS1Kq8y4aeO7ctEq
m+9mZXByhNUdJUDKn0PdSWS7n99JCQAjGlekLFU6eRt/bQQn9rhmPQbH2xZBzP2F
AEv20YTUBdjlcg6n3U7yGavOcuue/rR9JlnrDCz9xjVUaaHhBH1jrPH5sdgZBkwe
bSxoVduiBQEGRWWZd23x5BceHQkp/k2p5t+Z5gHq0WO8hp4nOxMrWpIaYDeIOYsd
4+uyeUzKWUl17o4jGs3hCtGoeJzk5z8UjfGKe+qLXXbBbeUI1IEApkb+C36r7Abf
0heMqIpZvQWJOOeE9a3EwyE9xg3Hf1cndRTwnQb7FYGVii0TQoG6Dvi4Vqxn6A2e
lxd+jfiQCSOW7VSbc+cRKh5VtSEwju+2xsIZ/Od7fxJaPYin7Mnc2mb/KEfGoyUz
I7lioTi+bdkOC3btOZpe56i9NCn1C8iXIqxgJ6FXOyF/+QFRpqUDv20kwbCDkDym
8kQrxPZmrNokPvZxCn1RiEX2GgPu8o0k7Jv9OzV5qKpdLpqywz7gYDiX15fQ0JXr
iDHD1kjLfdYqirEkyMaHnVQxfMhemMGCw2yQoL8Gf5UpFFzVBRY8I1dpOtuXHP/t
8AOke4LR3jCtz+iLIKVnpUubkR2fVJuqv3e0o5gmv89KlLezKtQ=
=Ulsq
-----END PGP SIGNATURE-----

Message #57 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>, 940973@bugs.debian.org

Cc: Paul Gevers <elbrus@debian.org>

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Tue, 24 Sep 2019 16:35:11 +0200

[Message part 1 (text/plain, inline)]

Control: reopen -1
Control: found -1 1.66-2
Control: affects -1 + strip-nondeterminism
Control: tags -1 - fixed-upstream

On Mon, 23 Sep 2019 18:47:44 +0200, gregor herrmann wrote:

> On Mon, 23 Sep 2019 13:02:04 +0100, Chris Lamb wrote:
> 
> > This has been fixed upstream here:
> >   https://github.com/farblos/perl-Archive-Zip/commit/b0179cbbfeb276ceac0f424d32acf56811b01568
> Thanks for the analysis!
> I've now uploaded -2 with this patch (minus 2 not applying but
> irrelevant hunks) plus the previous commit which also touches on the
> same topic. Will monitor the behaviour a bit :)

And the result of the monitoring is: 1.66-2 breaks strip-nondeterminism
as well:
https://ci.debian.net/data/autopkgtest/testing/amd64/s/strip-nondeterminism/3020870/log.gz

#v+
Reading ZIP archive failed: IO error: reading local extra field :  

error: becoming Archive::Zip::DirectoryMember 
# Looks like your test exited with 29 just after 20.
#v-

Looks like this needs more investigation …


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Dido: Slide

[signature.asc (application/pgp-signature, inline)]

Message #70 received at 940973@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 940973@bugs.debian.org

Cc: "gregor herrmann" <gregoa@debian.org>

Subject: Re: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Tue, 08 Oct 2019 14:10:19 -0700

tags 940973 + fixed-upstream
thanks

This has apparently been fixed (again) upstream in version 1.67:

  https://github.com/redhotpenguin/perl-Archive-Zip/issues/51#issuecomment-539679696


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #77 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 940973@bugs.debian.org, carnil@debian.org

Subject: Re: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Tue, 8 Oct 2019 23:15:38 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 - fixed-upstream
COntrol: notforwarded -1

On Tue, 08 Oct 2019 14:10:19 -0700, Chris Lamb wrote:

> This has apparently been fixed (again) upstream in version 1.67:
> 
>   https://github.com/redhotpenguin/perl-Archive-Zip/issues/51#issuecomment-539679696

Thanks for the notice but I'm afraid this is a different issue, and
"our" problem is not yet fixed.
(I tried with some of the merge requests earlier, and Salvatore tried
today with the 1.67 release.)

I guess now that 1.67 is out we should open a separate issue upstream
…


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   

[signature.asc (application/pgp-signature, inline)]

Message #86 received at 940973@bugs.debian.org (full text, mbox, reply):

From: tony mancill <tmancill@debian.org>

To: gregor herrmann <gregoa@debian.org>, 940973@bugs.debian.org

Cc: Chris Lamb <lamby@debian.org>, carnil@debian.org, debian-java@lists.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Thu, 10 Oct 2019 06:30:52 -0700

[Message part 1 (text/plain, inline)]

On Tue, Oct 08, 2019 at 11:15:38PM +0200, gregor herrmann wrote:
> Control: tag -1 - fixed-upstream
> COntrol: notforwarded -1
> 
> On Tue, 08 Oct 2019 14:10:19 -0700, Chris Lamb wrote:
> 
> > This has apparently been fixed (again) upstream in version 1.67:
> > 
> >   https://github.com/redhotpenguin/perl-Archive-Zip/issues/51#issuecomment-539679696
> 
> Thanks for the notice but I'm afraid this is a different issue, and
> "our" problem is not yet fixed.
> (I tried with some of the merge requests earlier, and Salvatore tried
> today with the 1.67 release.)
> 
> I guess now that 1.67 is out we should open a separate issue upstream
> …

Hi Gregor,

I have recently started observing build failures for packages that use
jh_manifest (which is part of Debian's javahelper).  All of the failures
I have seen so far have the same symptom, namely that the manifest
cannot be extracted from the JAR, which is actually a Zip archive.  An
example build error:

>    jh_classpath
> error: No member named $memberName 
>  at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
> 	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x55bbbdadedd0), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
> 	main::update_jar("/<<PKGBUILDDIR>>/debian/li"..., undef) called at /usr/bin/jh_manifest line 147
> Could not read manifest from /<<PKGBUILDDIR>>/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.
> jh_classpath: jh_manifest -plibquartz2-java --classpath=/usr/share/java/slf4j-api.jar debian/libquartz2-java/usr/share/java/quartz2.jar returned exit code 255
> make: *** [debian/rules:4: binary] Error 255

I don't know if this is the same issue but wanted to mention it here,
since it seems potentially related.  I'd be glad to provide more
debugging information or testing if that would help.  libquartz2-java is
an example of a source package that exhibits this issue.

Cheers,
tony

[signature.asc (application/pgp-signature, inline)]

Message #91 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: tony mancill <tmancill@debian.org>

Cc: 940973@bugs.debian.org, Chris Lamb <lamby@debian.org>, carnil@debian.org, debian-java@lists.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Thu, 10 Oct 2019 17:53:57 +0200

[Message part 1 (text/plain, inline)]

On Thu, 10 Oct 2019 06:30:52 -0700, tony mancill wrote:

> I have recently started observing build failures for packages that use
> jh_manifest (which is part of Debian's javahelper).  All of the failures
> I have seen so far have the same symptom, namely that the manifest
> cannot be extracted from the JAR, which is actually a Zip archive.  

Ouch.
Thanks for mentioning this issue.

> >    jh_classpath
> > error: No member named $memberName 
> >  at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
> > 	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x55bbbdadedd0), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
> > 	main::update_jar("/<<PKGBUILDDIR>>/debian/li"..., undef) called at /usr/bin/jh_manifest line 147
> > Could not read manifest from /<<PKGBUILDDIR>>/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.
> > jh_classpath: jh_manifest -plibquartz2-java --classpath=/usr/share/java/slf4j-api.jar debian/libquartz2-java/usr/share/java/quartz2.jar returned exit code 255
> > make: *** [debian/rules:4: binary] Error 255
> 
> I don't know if this is the same issue but wanted to mention it here,
> since it seems potentially related.  I'd be glad to provide more
> debugging information or testing if that would help.  libquartz2-java is
> an example of a source package that exhibits this issue.

Salvatore has uploaded libarchive-zip-perl 1.67-1 right now. Could
you try and check with this version? If there's still a problem I'm
happy to debug this together and forward it upstream.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   

[signature.asc (application/pgp-signature, inline)]

Message #96 received at 940973@bugs.debian.org (full text, mbox, reply):

From: tony mancill <tmancill@debian.org>

To: gregor herrmann <gregoa@debian.org>, 940973@bugs.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Thu, 10 Oct 2019 20:59:01 -0700

[Message part 1 (text/plain, inline)]

On Thu, Oct 10, 2019 at 05:53:57PM +0200, gregor herrmann wrote:
> On Thu, 10 Oct 2019 06:30:52 -0700, tony mancill wrote:
> > >    jh_classpath
> > > error: No member named $memberName 
> > >  at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
> > > 	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x55bbbdadedd0), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
> > > 	main::update_jar("/<<PKGBUILDDIR>>/debian/li"..., undef) called at /usr/bin/jh_manifest line 147
> > > Could not read manifest from /<<PKGBUILDDIR>>/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.
> > > jh_classpath: jh_manifest -plibquartz2-java --classpath=/usr/share/java/slf4j-api.jar debian/libquartz2-java/usr/share/java/quartz2.jar returned exit code 255
> > > make: *** [debian/rules:4: binary] Error 255
> > 
> > I don't know if this is the same issue but wanted to mention it here,
> > since it seems potentially related.  I'd be glad to provide more
> > debugging information or testing if that would help.  libquartz2-java is
> > an example of a source package that exhibits this issue.
> 
> Salvatore has uploaded libarchive-zip-perl 1.67-1 right now. Could
> you try and check with this version? If there's still a problem I'm
> happy to debug this together and forward it upstream.

Hi Gregor,

The behavior is the same with 1.67-1.  I'll have some time to look into
it in more detail this weekend.

Thanks,
tony

[signature.asc (application/pgp-signature, inline)]

Message #101 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: tony mancill <tmancill@debian.org>, 940973@bugs.debian.org

Cc: Chris Lamb <lamby@debian.org>, carnil@debian.org, debian-java@lists.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Sat, 12 Oct 2019 18:29:08 +0200

[Message part 1 (text/plain, inline)]

On Thu, 10 Oct 2019 06:30:52 -0700, tony mancill wrote:

> > error: No member named $memberName 
> >  at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
> > 	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x55bbbdadedd0), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
> > 	main::update_jar("/<<PKGBUILDDIR>>/debian/li"..., undef) called at /usr/bin/jh_manifest line 147
> > Could not read manifest from /<<PKGBUILDDIR>>/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.
> > jh_classpath: jh_manifest -plibquartz2-java --classpath=/usr/share/java/slf4j-api.jar debian/libquartz2-java/usr/share/java/quartz2.jar returned exit code 255
> > make: *** [debian/rules:4: binary] Error 255
> 
> I don't know if this is the same issue but wanted to mention it here,
> since it seems potentially related.  I'd be glad to provide more
> debugging information or testing if that would help.  libquartz2-java is
> an example of a source package that exhibits this issue.

I tried with libquartz2-java now and found the following:

# jh_manifest -plibquartz2-java --classpath=/usr/share/java/slf4j-api.jar debian/libquartz2-java/usr/share/java/quartz2.jar
error: No member named $memberName 
 at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x5622c68d6100), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
	main::update_jar("/build/libquartz2-java-2.3.0/debian/libquartz2-java/usr/share"..., undef) called at /usr/bin/jh_manifest line 147
Could not read manifest from /build/libquartz2-java-2.3.0/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.


So the same error as above. What jh_manifest is doing is:

sub update_jar{
    my $jar = shift;
    my $merge = shift;
    my $zip = Archive::Zip->new();
    my $con;
    my $manifest;
    my $stat;
    my $dirty = 0;
    my $main;
    my $new_manifest = 0;
    # stringify or $zip will make a call back that fails.
    $zip->read( "$jar" ) == AZ_OK or error("Could not read $jar: $!");
    ($con, $stat) = $zip->contents( 'META-INF/MANIFEST.MF' );
    die("Could not read manifest from $jar ($stat): $!")
        unless(!defined($stat) || $stat == AZ_OK);

i.e. it tries to return META-INF/MANIFEST.MF from the jar file.

But:

# unzip -l debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar | grep -c MANIFEST
0
# unzip -l debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar | grep META-INF
        0  2019-10-12 16:19   META-INF/
        0  2019-10-12 16:19   META-INF/terracotta/
      142  2019-10-12 16:19   META-INF/terracotta/public-api-types
        0  2019-10-12 16:19   META-INF/maven/
        0  2019-10-12 16:19   META-INF/maven/org.quartz-scheduler/
        0  2019-10-12 16:19   META-INF/maven/org.quartz-scheduler/quartz/
     6144  2019-10-12 16:19   META-INF/maven/org.quartz-scheduler/quartz/pom.xml
      101  2019-10-12 16:19   META-INF/maven/org.quartz-scheduler/quartz/pom.properties

So there doesn't seem to be a META-INF/MANIFEST.MF file in this jar,
and Archive::Zip seems to do the right thing.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Kurt Ostbahn & Kombo: Da Talking Plachutta Blues

[signature.asc (application/pgp-signature, inline)]

Message #106 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>, 940973@bugs.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Sat, 12 Oct 2019 19:10:35 +0200

[Message part 1 (text/plain, inline)]

Control: forwarded -1 https://github.com/redhotpenguin/perl-Archive-Zip/issues/68

On Tue, 24 Sep 2019 16:35:11 +0200, gregor herrmann wrote:

> #v+
> Reading ZIP archive failed: IO error: reading local extra field :  
> 
> error: becoming Archive::Zip::DirectoryMember 
> # Looks like your test exited with 29 just after 20.
> #v-

Forwarded upstream as a new issue with a minimal reproducer.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Kurt Ostbahn & Kombo: Da Talking Plachutta Blues

[signature.asc (application/pgp-signature, inline)]

Message #113 received at 940973@bugs.debian.org (full text, mbox, reply):

From: tony mancill <tmancill@debian.org>

To: 940973@bugs.debian.org, Chris Lamb <lamby@debian.org>, carnil@debian.org, debian-java@lists.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Sat, 12 Oct 2019 10:30:01 -0700

[Message part 1 (text/plain, inline)]

On Sat, Oct 12, 2019 at 06:29:08PM +0200, gregor herrmann wrote:
> On Thu, 10 Oct 2019 06:30:52 -0700, tony mancill wrote:
> 
> error: No member named $memberName 
>  at /usr/share/perl5/Archive/Zip/Archive.pm line 411.
> 	Archive::Zip::Archive::contents(Archive::Zip::Archive=HASH(0x5622c68d6100), "META-INF/MANIFEST.MF") called at /usr/bin/jh_manifest line 297
> 	main::update_jar("/build/libquartz2-java-2.3.0/debian/libquartz2-java/usr/share"..., undef) called at /usr/bin/jh_manifest line 147
> Could not read manifest from /build/libquartz2-java-2.3.0/debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar (2):  at /usr/bin/jh_manifest line 298.
> 
> 
> So the same error as above. What jh_manifest is doing is:
> 
> sub update_jar{
>     my $jar = shift;
>     my $merge = shift;
>     my $zip = Archive::Zip->new();
>     my $con;
>     my $manifest;
>     my $stat;
>     my $dirty = 0;
>     my $main;
>     my $new_manifest = 0;
>     # stringify or $zip will make a call back that fails.
>     $zip->read( "$jar" ) == AZ_OK or error("Could not read $jar: $!");
>     ($con, $stat) = $zip->contents( 'META-INF/MANIFEST.MF' );
>     die("Could not read manifest from $jar ($stat): $!")
>         unless(!defined($stat) || $stat == AZ_OK);
> 
> i.e. it tries to return META-INF/MANIFEST.MF from the jar file.
> 
> But:
> 
> # unzip -l debian/libquartz2-java/usr/share/java/quartz2-2.3.0.jar | grep -c MANIFEST
> 0

Thank you Gregor!  I'll start rooting around in the Java toolchain.

Cheers,
tony

[signature.asc (application/pgp-signature, inline)]

Message #128 received at 940973@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: 940973@bugs.debian.org

Subject: Re: Bug#940973: libarchive-zip-perl breaks strip-nondeterminism autopkgtest: error: becoming Archive::Zip::DirectoryMember

Date: Tue, 15 Oct 2019 21:57:25 +0200

[Message part 1 (text/plain, inline)]

On Sat, 12 Oct 2019 19:10:35 +0200, gregor herrmann wrote:

> > #v+
> > Reading ZIP archive failed: IO error: reading local extra field :  
> > 
> > error: becoming Archive::Zip::DirectoryMember 
> > # Looks like your test exited with 29 just after 20.
> > #v-
> 
> Forwarded upstream as a new issue with a minimal reproducer.

Bug reassigned back to strip-nondeterminism after analysis in 
https://github.com/redhotpenguin/perl-Archive-Zip/issues/68

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Steppenwolf: Wild Thing

[signature.asc (application/pgp-signature, inline)]

Message #131 received at 940973-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 940973-submitter@bugs.debian.org

Subject: Bug#940973 marked as pending in strip-nondeterminism

Date: Tue, 15 Oct 2019 19:57:28 +0000

Control: tag -1 pending

Hello,

Bug #940973 in strip-nondeterminism reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/strip-nondeterminism/commit/4862c51ba2bf73687b1e17bb96f323175545f8fd

------------------------------------------------------------------------
Drop the t/fixtures/zip/bug_803503.zip test fixtures as they are no longer compatible with Archive::Zip >= 1.66. Thanks to gregor herrmann for liasing on this issue with upstream. (Closes: #940973)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/940973

Message #138 received at 940973-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 940973-close@bugs.debian.org

Subject: Bug#940973: fixed in strip-nondeterminism 1.6.1-1

Date: Tue, 15 Oct 2019 20:48:59 +0000

Source: strip-nondeterminism
Source-Version: 1.6.1-1

We believe that the bug you reported is fixed in the latest version of
strip-nondeterminism, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 940973@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated strip-nondeterminism package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 15 Oct 2019 12:56:45 -0700
Source: strip-nondeterminism
Architecture: source
Version: 1.6.1-1
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 940973
Changes:
 strip-nondeterminism (1.6.1-1) unstable; urgency=medium
 .
   * Drop the t/fixtures/zip/bug_803503.zip test fixtures as they are no longer
     compatible with Archive::Zip >= 1.66. Thanks to gregor herrmann for liasing
     on this issue with upstream. (Closes: #940973)
   * Bump debhelper compat level to 12.
   * Bump Standards-Version to 4.4.1.
Checksums-Sha1:
 a6c9aa81f9cf30d59af66f9acfc2c397e2e0874f 2555 strip-nondeterminism_1.6.1-1.dsc
 1e292a0030280779cae5a61dbefce7c187df98fc 276727 strip-nondeterminism_1.6.1.orig.tar.bz2
 cd245d3f97f56e010037d3184d9c42f1a9822397 32428 strip-nondeterminism_1.6.1-1.debian.tar.xz
 48a766e43ebd0dee506ab9640ce4ed0f5fec46a2 6404 strip-nondeterminism_1.6.1-1_amd64.buildinfo
Checksums-Sha256:
 2f87d8fdfb07284e349e7c220c843feb0af4cd497eb4563cf4f6128a779245de 2555 strip-nondeterminism_1.6.1-1.dsc
 e3efa1a41494303c88749e538fb7f9e751a6303654300f8e16a58e52978f6c67 276727 strip-nondeterminism_1.6.1.orig.tar.bz2
 85b0140e5607f0b84543e996b1f1115e4a56e063fdf4f1ec92aa3c65cc8cfca3 32428 strip-nondeterminism_1.6.1-1.debian.tar.xz
 58bf46e1dda0ebe4b7eaba4f729ca5c04a98149ed5bb700fd0baf067e535b0ad 6404 strip-nondeterminism_1.6.1-1_amd64.buildinfo
Files:
 ddf5a00a51685bb614406555e73a9660 2555 devel optional strip-nondeterminism_1.6.1-1.dsc
 b56aa435ca37cd96fb75cdd18e304857 276727 devel optional strip-nondeterminism_1.6.1.orig.tar.bz2
 e328abce376a7520e7265a5c6cd2f721 32428 devel optional strip-nondeterminism_1.6.1-1.debian.tar.xz
 d169e5d09968cabc2c233ac375d9636c 6404 devel optional strip-nondeterminism_1.6.1-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl2mJK4ACgkQHpU+J9Qx
HljwGg/+No7v+I8XD8t2Je5alZmIlqw6Lf9Z1KJrERTguzchHaR/lGljNV+17LUr
SMCErH9hTUO/cZ7RKc6l9UhbWJJBVMUo3nGg1ON4JrF+sjehLyUnTkCWKNTKJ6H7
sFgrTgL71S1Ableh4Um4uAlnh2oOO5FzQtTbb+DDfjSfcvjcfnJTWmLe4/ml72II
XR3OEZzJlZ+1FwiUEzKbtyNxuY7dHKAMJYvuiN/VMxAWQZyMtz5Ow7DGgMdEMxkP
/0pJNFL3CFZHrODRaaMHMPIt9OCrBMlQhEIisvFFxYM9WHOaSp1fnRXgSbTNF5S+
0vP7hVbGBh0FPV+U7jtCdRij3P8R3kdWbm+tS+oLNgWQbGPqDpn3eh50ytFMqu43
lzqvQ7O1WlwKtweGkpvofpM7vWCDs7atI1O4bNk4aa2Jrp63CtJwmPnvIreEoEDZ
835S1VjVECMShGTocDuU2NhVixVQLL2pHtoGxxXlYjgykDDqPrDdit24MCY8a90Y
DSfJRVTIjnSE7XE9/fH6Ju6EhWMPIsGgZqH/RnGz++ohCtEGj07BLhCEwhJxPD5g
zu6yOe7d6ubHU3WY7Rd7JxyC5lcLmsV22uLRZabwsVUssFWrJdLS61bJjIUvjvf4
A3B5ZFTQoG2YRbq9d3ejpOIePpzs2xGXrHI3pNiZ106ZIIvFULs=
=Ky0h
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.