Debian Bug report logs - #939549
sdaps: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: sdaps: please make the build reproducible

Date: Fri, 06 Sep 2019 08:53:41 +0100

[Message part 1 (text/plain, inline)]

Source: sdaps
Version: 1.9.7-0.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that sdaps could not be built reproducibly.

This is because its "setup.py" iterated over the keys of a dictionary
(to generate translations), an operation which, in Python, is
nondeterministic.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[sdaps.diff.txt (text/plain, attachment)]

Message #12 received at 939549@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 939549@bugs.debian.org

Subject: Re: sdaps: please make the build reproducible

Date: Fri, 06 Sep 2019 09:31:58 +0100

forwarded 939549 https://github.com/sdaps/sdaps/pull/182
thanks

I've forwarded this upstream here:

  https://github.com/sdaps/sdaps/pull/182


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #19 received at 939549@bugs.debian.org (full text, mbox, reply):

From: Boyuan Yang <byang@debian.org>

To: 940119@bugs.debian.org, 939549@bugs.debian.org

Subject: sdaps: diff for NMU version 1.9.7-0.2

Date: Sun, 15 Sep 2019 14:35:56 -0400

[Message part 1 (text/plain, inline)]

Package: sdaps
Version: 1.9.7-0.1
Severity: normal
Tags: patch  pending

Dear maintainer,

I've prepared an NMU for sdaps (versioned as 1.9.7-0.2) and
uploaded it to DELAYED/7. Please feel free to tell me if I
should delay it longer.

Regards.

diff -Nru sdaps-1.9.7/debian/changelog sdaps-1.9.7/debian/changelog
--- sdaps-1.9.7/debian/changelog	2019-09-03 11:00:23.000000000 -0400
+++ sdaps-1.9.7/debian/changelog	2019-09-15 14:04:29.000000000 -0400
@@ -1,3 +1,14 @@
+sdaps (1.9.7-0.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/control: Replace old build-dependency
+    texlive-generic-recommended with texlive-plain-generic.
+    (Closes: #940119)
+  * debian/patches: Add patch 0001 to make the build
+    reproducible. (Patch already merged upstream) (Closes: #939549)
+
+ -- Boyuan Yang <byang@debian.org>  Sun, 15 Sep 2019 14:04:29 -0400
+
 sdaps (1.9.7-0.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru sdaps-1.9.7/debian/control sdaps-1.9.7/debian/control
--- sdaps-1.9.7/debian/control	2019-08-20 14:31:23.000000000 -0400
+++ sdaps-1.9.7/debian/control	2019-09-15 14:00:36.000000000 -0400
@@ -25,7 +25,7 @@
  python3-setuptools,
  python3-zbar,
  texlive,
- texlive-generic-recommended,
+ texlive-plain-generic,
  texlive-latex-extra,
  texlive-latex-recommended,
  texlive-science,
@@ -54,7 +54,7 @@
  python3-pil,
  python3-reportlab,
  texlive,
- texlive-generic-recommended,
+ texlive-plain-generic,
  texlive-latex-extra,
  texlive-latex-recommended,
  texlive-science,
diff -Nru sdaps-1.9.7/debian/patches/0001-Make-the-build-reproducible.patch
sdaps-1.9.7/debian/patches/0001-Make-the-build-reproducible.patch
--- sdaps-1.9.7/debian/patches/0001-Make-the-build-reproducible.patch	1969-
12-31 19:00:00.000000000 -0500
+++ sdaps-1.9.7/debian/patches/0001-Make-the-build-reproducible.patch	2019-
09-15 14:04:22.000000000 -0400
@@ -0,0 +1,35 @@
+From: Chris Lamb <lamby@debian.org>
+Date: Fri, 6 Sep 2019 09:28:51 +0100
+Subject: Make the build reproducible
+
+Whilst working on the Reproducible Builds effort [0] we noticed
+that sdaps could not be built reproducibly.
+
+This is because its "setup.py" iterated over the keys of a dictionary
+(to generate translations), an operation which, in Python, is
+nondeterministic.
+
+This was originally filed in Debian as #939549 [1].
+
+ [0] https://reproducible-builds.org/
+ [1] https://bugs.debian.org/939549
+
+Applied-Upstream: https://github.com/sdaps/sdaps/pull/182
+Signed-off-by: Chris Lamb <lamby@debian.org>
+---
+ setup.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/setup.py b/setup.py
+index 018f632..9562ef4 100755
+--- a/setup.py
++++ b/setup.py
+@@ -132,7 +132,7 @@ class sdaps_build_i18n(build_i18n.build_i18n):
+             f.write('%\n\n')
+             f.write('\\ProvidesDictionary{translator-sdaps-
dictionary}{%s}\n\n' % name)
+ 
+-            for key in keys:
++            for key in sorted(keys):
+                 if lang is not None:
+                     k = "%s[%s]" % (key, lang)
+                 else:
diff -Nru sdaps-1.9.7/debian/patches/series sdaps-1.9.7/debian/patches/series
--- sdaps-1.9.7/debian/patches/series	1969-12-31 19:00:00.000000000 -0500
+++ sdaps-1.9.7/debian/patches/series	2019-09-15 14:03:33.000000000 -0400
@@ -0,0 +1 @@
+0001-Make-the-build-reproducible.patch

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 939549-close@bugs.debian.org (full text, mbox, reply):

From: Boyuan Yang <byang@debian.org>

To: 939549-close@bugs.debian.org

Subject: Bug#939549: fixed in sdaps 1.9.7-0.2

Date: Sun, 22 Sep 2019 19:19:00 +0000

Source: sdaps
Source-Version: 1.9.7-0.2

We believe that the bug you reported is fixed in the latest version of
sdaps, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 939549@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated sdaps package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 15 Sep 2019 14:04:29 -0400
Source: sdaps
Architecture: source
Version: 1.9.7-0.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Edu Packaging Team <debian-edu-pkg-team@lists.alioth.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 939549 940119
Changes:
 sdaps (1.9.7-0.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * debian/control: Replace old build-dependency
     texlive-generic-recommended with texlive-plain-generic.
     (Closes: #940119)
   * debian/patches: Add patch 0001 to make the build
     reproducible. (Patch already merged upstream) (Closes: #939549)
Checksums-Sha1:
 b6d2ccb3fea2d1c5de4003af2467b0616c45933c 2574 sdaps_1.9.7-0.2.dsc
 8896c1fb1000ca1ed4b7d2114ab1f4d80eee9b9a 21076 sdaps_1.9.7-0.2.debian.tar.xz
 53b71f6ce919d53c39e6d2a00403f9339209e128 20282 sdaps_1.9.7-0.2_amd64.buildinfo
Checksums-Sha256:
 546fd8366f394703e90a8ea234194f4cc0101640eae83556f57074640ab89dec 2574 sdaps_1.9.7-0.2.dsc
 8ffe3b529573b6d3be6dad94841d32cfcd3fc7506c330150ab5d763d97aff43e 21076 sdaps_1.9.7-0.2.debian.tar.xz
 33256f8f3efe54e0aec7440bed38d6da6dda355849240a0d25bd9c78cf88642f 20282 sdaps_1.9.7-0.2_amd64.buildinfo
Files:
 e28c7ff73a7087a50bba6f7d7fcddce2 2574 science optional sdaps_1.9.7-0.2.dsc
 8532b04d9fd1ffefe0fdbcb22f9e6b49 21076 science optional sdaps_1.9.7-0.2.debian.tar.xz
 59679df7a51e50bad750afa88b549cef 20282 science optional sdaps_1.9.7-0.2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAl1+gvAACgkQwpPntGGC
Ws7PbA//e+fXJFHn2JVWU6XTYLKYR4t/K3Z7UipSmtTSgzhIazvUk070cX0qyjQZ
Jfrn+hMTrG99C48bULhc9Vk/U9bBQZyIjshyx/0RyEa0BPY1SzaTvOVUIaoiWw8t
kK5Up5ZdvEIUu9hDkkQNO6nYFKVum+zjtOFbWQWqmIPTDtvK3aUoqPM5qGeZ7zm3
BOtXBn/TgGxdzTt1VfoUWkWMO+l1SX/+HOdEyyQfvtFcLmnBXmb/RRHfam8xT49A
U81+OGpgMrAgsxbma6pwmsdCIJEXsvEdBFVXJd9qUpRYycoGWFFXaK3Fhb3+zVo1
P8fmbUPnRG60sLXbIuEtmZWvXidple6x578brdWwFarcNQdE9H1pAqX0nNbnkqUB
9qo+UnasLsYFkafTkYKF0Vk4Div5lt7BclUNa+HUHG3XTdikDjgp7qkhK+3L5X5y
ozUhPXGA+xYnvYSdub6R35H2vkCELRi7hvNjgPcGesDAVhrcVQ/8LVesl9k19m0I
Vk6X34LLDVu4kjYZuzeDMHSo+Gqoezz5SP0nGPTfdgSMODLHeTlNjkgw333ezLl6
qzuk8ftP65EE3PQ9PwQYiUzntxl7xxDC+UEL0bbi0h1kgWx4maReolie0KkioCWv
7RLRLs9aFtRZ65ZIu6p7b1V/sR2BBRTGpYYSx9no+panXRZYfYg=
=/qgH
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.