Debian Bug report logs - #935684
diffoscope: squashfs-tools output change

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: László Böszörményi (GCS) <gcs@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: squashfs-tools output change

Date: Sun, 25 Aug 2019 09:27:33 +0200

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 121
Severity: important
Tags: patch

Hi!

Recently squashfs-tools changed its output lines. This making
diffoscope self-test fail without real reason. Please apply the
attached patch to fix this and let squashfs-tools migrate to testing.

Thanks,
Laszlo/GCS

[diffoscope_update.patch (text/x-patch, attachment)]

Message #8 received at 935684@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: László Böszörményi <gcs@debian.org>, 935684@bugs.debian.org

Subject: Re: Bug#935684: diffoscope: squashfs-tools output change

Date: Sun, 25 Aug 2019 10:19:14 +0200

[Message part 1 (text/plain, inline)]

On Sun, Aug 25, 2019 at 09:27:33AM +0200, László Böszörményi wrote:
> Recently squashfs-tools changed its output lines. This making
> diffoscope self-test fail without real reason. Please apply the
> attached patch to fix this and let squashfs-tools migrate to testing.

We can't apply that patch, because then the test would fail with an
older squashfs tools.

We usually use the program version or other indicators to decide if our
data is usable with the programs versions, but here I notice that the
change comes from an updated git tarball that doesn't seem to change the
porgram version.

How can we distinguish the previous squashfs-tools with the new one?

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 935684@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 935684@bugs.debian.org

Subject: Re: diffoscope: squashfs-tools output change

Date: Sun, 25 Aug 2019 10:36:40 +0100

forwarded 935684 https://salsa.debian.org/reproducible-builds/diffoscope/issues/62
thanks

I've forwarded this upstream here:

  https://salsa.debian.org/reproducible-builds/diffoscope/issues/62


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #22 received at 935684@bugs.debian.org (full text, mbox, reply):

From: László Böszörményi (GCS) <gcs@debian.org>

To: Mattia Rizzolo <mattia@debian.org>, Chris Lamb <lamby@debian.org>

Cc: 935684@bugs.debian.org

Subject: Re: Bug#935684: diffoscope: squashfs-tools output change

Date: Thu, 29 Aug 2019 18:59:01 +0200

On Sun, Aug 25, 2019 at 10:19 AM Mattia Rizzolo <mattia@debian.org> wrote:
> We can't apply that patch, because then the test would fail with an
> older squashfs tools.
 As I saw, it's now solved. The version number of squashfs-tools is
checked along with its expected output.

> We usually use the program version or other indicators to decide if our
> data is usable with the programs versions, but here I notice that the
> change comes from an updated git tarball that doesn't seem to change the
> porgram version.
>
> How can we distinguish the previous squashfs-tools with the new one?
 It is now clear '4.4' (no 'pre-git' ending) [1]. Please upload the
updated diffoscope soon to let squashfs-tools migrate to testing. It
solves a lot of things that would be a benefit for our users.

Thanks,
Laszlo/GCS
[1] https://github.com/plougher/squashfs-tools/commit/52eb4c279cd283ed9802dd1ceb686560b22ffb67#diff-64f9b9f920063cbf890d0a44d3c9ef17

Message #29 received at 935684@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: László Böszörményi <gcs@debian.org>, "Mattia Rizzolo" <mattia@debian.org>

Cc: 935684@bugs.debian.org

Subject: Re: Bug#935684: diffoscope: squashfs-tools output change

Date: Fri, 30 Aug 2019 08:54:25 +0100

tags 935684 + pending
thanks

Hi László,

>  It is now clear '4.4' (no 'pre-git' ending) [1]. Please upload the
> updated diffoscope soon to let squashfs-tools migrate to testing. It
> solves a lot of things that would be a benefit for our users.

Sure thing; working on that now...


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #34 received at 935684-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 935684-close@bugs.debian.org

Subject: Bug#935684: fixed in diffoscope 122

Date: Fri, 30 Aug 2019 08:34:09 +0000

Source: diffoscope
Source-Version: 122

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 935684@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 30 Aug 2019 08:52:25 +0100
Source: diffoscope
Architecture: source
Version: 122
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 935684
Changes:
 diffoscope (122) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Apply patch from László Böszörményi to update the squashfs test output and
     bump the required version for the test itself. (Closes: #935684)
   * Skip calls to unsquashfs when we are not root or fakeroot.
     (Re: reproducible-builds/diffoscope#63)
   * Include either standard error or standard output (and not just the latter)
     if/when an external command fails.
   * Fix a few unicode/bytes issues:
     - Avoid a possible traceback caused by a str/bytes confusion when handling
       the output of failing external commands.
     - Ensure that all of our artificially-created subprocess.CalledProcessError
       instances have `output` instances that are bytes objects, not str.
   * Improve debugging output:
     * Add the containing module name to the (eg.) "Using StaticLibFile for ..."
     * Improve and condense output when creating our Comparator object types.
   * Correct a reference to `parser.diff` as `diff` in this context is a Python
     function in the module, not the actual output returned from diff(1).
   * Add the "wabt" Debian package to the test dependencies so that we run the
     wasm tests.
 .
   [ Mattia Rizzolo ]
   * Now that we test-require wabt, expect that its tools to be available during
     autopkgtests.
Checksums-Sha1:
 75115658a8cd8c994236256ff3fe1126fb5e6fc1 4683 diffoscope_122.dsc
 3cf483416684d2ff22a8d67463decf73db339b3c 1138236 diffoscope_122.tar.xz
 90a89a6f5738a20486e645edd490c46eea6b4950 26467 diffoscope_122_amd64.buildinfo
Checksums-Sha256:
 11d10b3223f1d452ae2dfccfe9d8d0f135364a2b0b1ac2cfd086d5931043780f 4683 diffoscope_122.dsc
 f324c0f6b82760e8dadf2bfd499cf10910208d40ac639c3784a3ef19d69de045 1138236 diffoscope_122.tar.xz
 39e8d8ad928721baae6bd2417e561208509326f119aa5519baa9709098b88b7a 26467 diffoscope_122_amd64.buildinfo
Files:
 ff778b4455969bae32cddbe85ea11106 4683 devel optional diffoscope_122.dsc
 8c0f7e29351579652793c871fcf97741 1138236 devel optional diffoscope_122.tar.xz
 c4654581f2fa6b0650e5b2d3d59bdf65 26467 devel optional diffoscope_122_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl1o2a8ACgkQHpU+J9Qx
HliEaRAAu6j/LFEJTDq4qH6ZkSs/v6YqeanUPJPYvDv0T1J0lif6ukIOAHc8MZI9
pNf7NZw6g5U//Nnh90ikW89T4DydlsD2RTXgfTU7MSU/tMj7KvENSbCGYFU3c7Qe
6M1GIBTqaImfK26B7KvXMkvaUGu+/E2v9vPTsGeqmkhvfRD5F7KUZPkJRuPpuh0L
M70hqlMuqutyH3XUsWC6yMYF53QfjgeXfK66h+uwIP60NoEXAcW64EDz/DQDAU4u
EzkuU43c9Oe7ryPCSnfmWCbR+KE9l0XOsH74JuDJXFx3B89Q/GIPUNJ3nCpLZ3So
s7qTyiE5SrDPterDj22Vkjts1LZ18krAeoIX41JbGmZ67jgj3CASV3bpWY55zaXz
L4xps5c3G9vDW/VB/jVnWJqpD2JVzL3dEzSZLsv1AEG6UdHuV7qzJWYJom5MP9jP
iHRjQfadwLuUvAK/w9HeOlRqFd1cBIPd+imbgHfBcw8WqeiM/WR8b7VwR/WsbcWM
8tOU8QgR0xQqLGtumRc54xfWHiyP+PUzt4yRF3bPauCc75nyTvKnihsWQuUFOAyo
S+OC5HK75/jcvg7WgfuqA6ExHYD5na/h18w6PYs6o8OJgQgtPqjgCP2a+kLbUiRu
ZgTowbkY366CTqq+sTCWRzoRIbuOxikYn9w3QGf0biVBBNxMAbs=
=YTL3
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.