Debian Bug report logs -
#935035
u-boot: Olimex Teres-I support for builtin keyboard
Reported by: Jonas Smedegaard <dr@jones.dk>
Date: Sun, 18 Aug 2019 12:12:02 UTC
Severity: normal
Tags: moreinfo, patch
Found in version u-boot/2019.01+dfsg-7
Fixed in version u-boot/2020.10+dfsg-2
Done: Vagrant Cascadian <vagrant@debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Sun, 18 Aug 2019 12:12:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
New Bug report received and forwarded. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Sun, 18 Aug 2019 12:12:04 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Source: u-boot
Version: 2019.01+dfsg-7
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
U-Boot supports the DIY laptop Olimex Teres-I, except the builtin
keyboard is not detected.
The keyboard firmware pauses for 2 seconds to allow reflashing its
firmware, and U-Boot needs to wait equally long to detect it as a HID
device. Issuing a "usb reset" works occationally, possibly because that
pulls the power triggering a reboot of the keyboard controller.
U-Boot offers KConfig setting CONFIG_INITIAL_USB_SCAN_DELAY which
apparently fails to work, seemingly because that adds a delay _before_
the USB hub is powered on which (pure guesswork) fails to work if the
keyboard draws its power from the USB hub.
A working solution is to set environment variable usb_pgood_delay before
initially calling "usb start": Seemingly that variable adds a delay
_after_ powering up the USB hub but before devices are probed.
U-Boot environment variables is set in include/configs/<yourboard>.h or
with KConfig settings CONFIG_USE_PREBOOT and CONFIG_PREBOOT. Sunxi
devices share a common file include/configs/sunxi_common.h which
complicates setting env directly and also messes with preboot setting in
ways not overridable with KConfig.
The patch setting usb_pgood_delay therefore requires another patch to
allow overriding preboot.
A working patchset is pushed to git branch wip-teres-i-keyboard:
https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
I have tested the patchset only on the Teres-I device, where keyboard is
succesfully detected 5 times in a row power-cycling in-between.
I have also tested that the preboot patch applied alone causes no change
to preboot config value.
This patchset is not in mainline U-Boot, but I intent to propose it.
- Jonas
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl1ZP+AACgkQLHwxRsGg
ASHTYhAAiygm195o4LU4o8hH5gaoQpbeYmYQdudxU5LCbSrkE/ZoHO7DImOwfWX/
e1OPLTIcMVTQA5KcGX/I378uvh5mQzhdmaEHRRne2sggRqTLncQ8uVh6YKHyw974
Hdej57lZsQkjVR214Y/Qjgfidn6Vi8KHHNSBtxej7xaks0ASta2Y/o2+ufZDY7Om
YPEgjp3Ve0lwbUobK+wXUw4Sb/EWQADQtof+3ie2ESiKwEKUtHIwvHGByvdEMWH/
8ST3Wu0roi161OPN46IaGlRuL0xI3LdlRWbq3bZuUH8XEb4rPDJz0TdPs79swct2
z141SgvdRsW+5SlAKBzK4GZbOn3gj1UXKlCXrOHcMLipN1oyPnoTZ5c99sggzUdn
L3rXFbBvnUn3zP50WJQzvlKi3Xs3OxOfFtIq9E/I5fmp6PC3/y1YZkBDoW2PJ4Hq
1DCJQIKe5txzGGrloI7oMVeryVfo9Yecv79jLYAcAk9ZqwrXXOdpdUWvrG6vAHgY
uELkgiZbeNfz3jDXSrr0Jqa3M4aA7g1fRCc0CpD5+vhNuQZQkAt5Etj2pkos9DMA
JqDlEpR5WW9a+knrCwG5Zq/dTGNbZiM7k3LkrsSBqV5tMxZGN16ICG4I5m+2fxVy
tZDwWFbMcijuWxXUyDqKBJNBcRLHue2Ns2DtP0r8jq4IDS5bHo8=
=pDyY
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Sun, 18 Aug 2019 13:27:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Sun, 18 Aug 2019 13:27:03 GMT) (full text, mbox, link).
Message #10 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Jonas Smedegaard (2019-08-18 14:09:06)
> A working patchset is pushed to git branch wip-teres-i-keyboard:
> https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
...and now updated (i.e. replaced) to include upstream cherry-picked
commit 607d06d needed for the 2019.01 branch (applied since 2019.04).
> I have tested the patchset only on the Teres-I device, where keyboard
> is succesfully detected 5 times in a row power-cycling in-between.
...and now tested succesfully 5 times with Buster-based 2019.01 patchset
(additionally to the not 5 but accidentally 10 tests against
experimental-based 2019.07 patchset).
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org:
Bug#935035; Package src:u-boot.
(Mon, 20 Apr 2020 17:27:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Vagrant Cascadian <vagrant@debian.org>:
Extra info received and forwarded to list.
(Mon, 20 Apr 2020 17:27:02 GMT) (full text, mbox, link).
Message #15 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Control: tags 935035 moreinfo
On 2019-08-18, Jonas Smedegaard wrote:
> U-Boot supports the DIY laptop Olimex Teres-I, except the builtin
> keyboard is not detected.
...
> A working patchset is pushed to git branch wip-teres-i-keyboard:
> https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
...
> This patchset is not in mainline U-Boot, but I intent to propose it.
Any status update on mainline support? Is it still an issue with newer
u-boot packages in Debian?
live well,
vagrant
[signature.asc (application/pgp-signature, inline)]
Added tag(s) moreinfo.
Request was from Vagrant Cascadian <vagrant@debian.org>
to 935035-submit@bugs.debian.org.
(Mon, 20 Apr 2020 17:27:02 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Mon, 27 Apr 2020 07:03:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Mon, 27 Apr 2020 07:03:03 GMT) (full text, mbox, link).
Message #22 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Vagrant Cascadian (2020-04-20 19:25:15)
> Control: tags 935035 moreinfo
>
> On 2019-08-18, Jonas Smedegaard wrote:
> > U-Boot supports the DIY laptop Olimex Teres-I, except the builtin
> > keyboard is not detected.
> ...
> > A working patchset is pushed to git branch wip-teres-i-keyboard:
> > https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
> ...
> > This patchset is not in mainline U-Boot, but I intent to propose it.
>
> Any status update on mainline support? Is it still an issue with newer
> u-boot packages in Debian?
Last I checked it was still needed.
I noticed a recent change to the USB driver (commit 31232de) that
*might* render all or half of my patch unnecessary, but that's just a
guess based on the commit message - needs to be actually tested.
If still needed, then status of the patch is that U-boot developers
wants a more general cleanup of the related options, won't accept my
minimal patch as-is. Again, I have not yet taken the time to do that.
Thanks for pinging/nudging,
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Sun, 19 Jul 2020 17:15:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Sun, 19 Jul 2020 17:15:03 GMT) (full text, mbox, link).
Message #27 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Jonas Smedegaard (2020-04-27 09:00:49)
> Quoting Vagrant Cascadian (2020-04-20 19:25:15)
> > Control: tags 935035 moreinfo
> >
> > On 2019-08-18, Jonas Smedegaard wrote:
> > > U-Boot supports the DIY laptop Olimex Teres-I, except the builtin
> > > keyboard is not detected.
> > ...
> > > A working patchset is pushed to git branch wip-teres-i-keyboard:
> > > https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
> > ...
> > > This patchset is not in mainline U-Boot, but I intent to propose it.
> >
> > Any status update on mainline support? Is it still an issue with newer
> > u-boot packages in Debian?
>
> Last I checked it was still needed.
>
> I noticed a recent change to the USB driver (commit 31232de) that
> *might* render all or half of my patch unnecessary, but that's just a
> guess based on the commit message - needs to be actually tested.
>
> If still needed, then status of the patch is that U-boot developers
> wants a more general cleanup of the related options, won't accept my
> minimal patch as-is. Again, I have not yet taken the time to do that.
Patch is still needed, and I have now updated it upstream:
https://patchwork.ozlabs.org/project/uboot/patch/20200719135632.681954-2-dr@jones.dk/
The newest upstream patch is larger, because developers requested I do a
more general change, where earlier proposed patches generalized only
across sunxi devices.
There should be no functional difference between the older more minimal
patches and the newer one, and I therefore propose to apply the older
one for Buster.
Please tell me if you disagree, then I will prepare a backport of the
newest more general patchset.
Or, obviously, please tell me if you consider it unlikely that this
change can be accepted in Buster, so we stop spend more time on that.
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org:
Bug#935035; Package src:u-boot.
(Mon, 20 Jul 2020 20:09:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Vagrant Cascadian <vagrant@debian.org>:
Extra info received and forwarded to list.
(Mon, 20 Jul 2020 20:09:02 GMT) (full text, mbox, link).
Message #32 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On 2020-07-19, Jonas Smedegaard wrote:
> Quoting Jonas Smedegaard (2020-04-27 09:00:49)
>> Quoting Vagrant Cascadian (2020-04-20 19:25:15)
>> > Control: tags 935035 moreinfo
>> >
>> > On 2019-08-18, Jonas Smedegaard wrote:
>> > > U-Boot supports the DIY laptop Olimex Teres-I, except the builtin
>> > > keyboard is not detected.
>> > ...
>> > > A working patchset is pushed to git branch wip-teres-i-keyboard:
>> > > https://salsa.debian.org/debian/u-boot/tree/wip/teres-i-keyboard
>> > ...
>> > > This patchset is not in mainline U-Boot, but I intent to propose it.
>> >
>> > Any status update on mainline support? Is it still an issue with newer
>> > u-boot packages in Debian?
>>
>> Last I checked it was still needed.
>>
>> I noticed a recent change to the USB driver (commit 31232de) that
>> *might* render all or half of my patch unnecessary, but that's just a
>> guess based on the commit message - needs to be actually tested.
>>
>> If still needed, then status of the patch is that U-boot developers
>> wants a more general cleanup of the related options, won't accept my
>> minimal patch as-is. Again, I have not yet taken the time to do that.
>
> Patch is still needed, and I have now updated it upstream:
> https://patchwork.ozlabs.org/project/uboot/patch/20200719135632.681954-2-dr@jones.dk/
This link gets both patches:
https://patchwork.ozlabs.org/project/uboot/list/?series=190758&state=*
It looks like they've gotten a few reviews already, and presuming no
objections surface, I could apply them in the next u-boot 2020.07
upload, and hopefully will be applied upstream for 2020.10.
> The newest upstream patch is larger, because developers requested I do a
> more general change, where earlier proposed patches generalized only
> across sunxi devices.
>
> There should be no functional difference between the older more minimal
> patches and the newer one, and I therefore propose to apply the older
> one for Buster.
The wip-teres-i-keyboard branch on salsa?
That includes a bunch of changes for platforms (unifier) that we don't
support.
I think could probably be trimmed down to a more minimal patch. e.g. It
doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think* you
could just use CONFIG_PREBOOT without adding Kconfig support (needs
testing) and then use ifdef/ifndef directly where the preboot command is
added.
I'd normally be hesitant to add non-upstreamed patches, and will want to
wait to see how that plays out, but once the functionality lands in
experimental or unstable, I'd be willing to consider a more minimal
patch for buster.
> Please tell me if you disagree, then I will prepare a backport of the
> newest more general patchset.
I think the full patchsets are too invasive for buster, so would prefer
to avoid it.
> Or, obviously, please tell me if you consider it unlikely that this
> change can be accepted in Buster, so we stop spend more time on that.
I think it can be done, but we'll have to be careful not to break other
platforms. I have several other platforms (pine64+, pinebook, others)
that might be impacted by these changes, so can check for breakage at
least.
live well,
vagrant
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Tue, 21 Jul 2020 00:30:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Tue, 21 Jul 2020 00:30:02 GMT) (full text, mbox, link).
Message #37 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Vagrant Cascadian (2020-07-20 22:05:43)
> On 2020-07-19, Jonas Smedegaard wrote:
> > Patch is still needed, and I have now updated it upstream:
> > https://patchwork.ozlabs.org/project/uboot/patch/20200719135632.681954-2-dr@jones.dk/
>
> This link gets both patches:
>
> https://patchwork.ozlabs.org/project/uboot/list/?series=190758&state=*
Ah, that's helpful!
> It looks like they've gotten a few reviews already, and presuming no
> objections surface, I could apply them in the next u-boot 2020.07
> upload, and hopefully will be applied upstream for 2020.10.
Thanks.
> > The newest upstream patch is larger, because developers requested I
> > do a more general change, where earlier proposed patches generalized
> > only across sunxi devices.
> >
> > There should be no functional difference between the older more
> > minimal patches and the newer one, and I therefore propose to apply
> > the older one for Buster.
>
> The wip-teres-i-keyboard branch on salsa?
Yes.
> That includes a bunch of changes for platforms (unifier) that we don't
> support.
If you prefer a shorter patch with those plastforms being broken, then
indeed I can reduce it.
> I think could probably be trimmed down to a more minimal patch. e.g.
> It doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think*
> you could just use CONFIG_PREBOOT without adding Kconfig support
> (needs testing) and then use ifdef/ifndef directly where the preboot
> command is added.
Sorry, I don't follow how you think it could be done without per-board
definitions.
> I'd normally be hesitant to add non-upstreamed patches, and will want
> to wait to see how that plays out, but once the functionality lands in
> experimental or unstable, I'd be willing to consider a more minimal
> patch for buster.
Thanks.
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Tue, 21 Jul 2020 08:21:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Tue, 21 Jul 2020 08:21:02 GMT) (full text, mbox, link).
Message #42 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Jonas Smedegaard (2020-07-21 02:28:11)
> Quoting Vagrant Cascadian (2020-07-20 22:05:43)
> > I think could probably be trimmed down to a more minimal patch. e.g.
> > It doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think*
> > you could just use CONFIG_PREBOOT without adding Kconfig support
> > (needs testing) and then use ifdef/ifndef directly where the preboot
> > command is added.
>
> Sorry, I don't follow how you think it could be done without per-board
> definitions.
Sleeping on it helped: I figured it out - here's a much shorter patch:
https://salsa.debian.org/debian/u-boot/-/commit/17bcf50
Tested to work with TERES-I laptop.
I also issued a minor update to the upstream patch:
https://patchwork.ozlabs.org/project/uboot/list/?series=191157
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org:
Bug#935035; Package src:u-boot.
(Tue, 21 Jul 2020 17:45:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Vagrant Cascadian <vagrant@debian.org>:
Extra info received and forwarded to list.
(Tue, 21 Jul 2020 17:45:03 GMT) (full text, mbox, link).
Message #47 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On 2020-07-21, Jonas Smedegaard wrote:
> Quoting Jonas Smedegaard (2020-07-21 02:28:11)
>> Quoting Vagrant Cascadian (2020-07-20 22:05:43)
>> > I think could probably be trimmed down to a more minimal patch. e.g.
>> > It doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think*
>> > you could just use CONFIG_PREBOOT without adding Kconfig support
>> > (needs testing) and then use ifdef/ifndef directly where the preboot
>> > command is added.
>>
>> Sorry, I don't follow how you think it could be done without per-board
>> definitions.
>
> Sleeping on it helped: I figured it out - here's a much shorter patch:
> https://salsa.debian.org/debian/u-boot/-/commit/17bcf50
Yeah, that's more like what I was thinking! Clever figuring out
configuration options only present on the teres-i. :)
> Tested to work with TERES-I laptop.
>
> I also issued a minor update to the upstream patch:
> https://patchwork.ozlabs.org/project/uboot/list/?series=191157
Yeah, wondered about usb "reset" vs usb "start".
Nice work!
live well,
vagrant
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Wed, 05 Aug 2020 23:21:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Wed, 05 Aug 2020 23:21:02 GMT) (full text, mbox, link).
Message #52 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Vagrant Cascadian (2020-07-21 19:43:21)
> On 2020-07-21, Jonas Smedegaard wrote:
> > Quoting Jonas Smedegaard (2020-07-21 02:28:11)
> >> Quoting Vagrant Cascadian (2020-07-20 22:05:43)
> >> > I think could probably be trimmed down to a more minimal patch. e.g.
> >> > It doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think*
> >> > you could just use CONFIG_PREBOOT without adding Kconfig support
> >> > (needs testing) and then use ifdef/ifndef directly where the preboot
> >> > command is added.
> >>
> >> Sorry, I don't follow how you think it could be done without per-board
> >> definitions.
> >
> > Sleeping on it helped: I figured it out - here's a much shorter patch:
> > https://salsa.debian.org/debian/u-boot/-/commit/17bcf50
>
> Yeah, that's more like what I was thinking! Clever figuring out
> configuration options only present on the teres-i. :)
>
>
> > Tested to work with TERES-I laptop.
> >
> > I also issued a minor update to the upstream patch:
> > https://patchwork.ozlabs.org/project/uboot/list/?series=191157
>
> Yeah, wondered about usb "reset" vs usb "start".
Part 1/2 entered mainline u-boot few hours ago.
The remaining part, touching only Teres-I, bumped and still pending:
https://patchwork.ozlabs.org/project/uboot/list/?series=194355
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Vagrant Cascadian <vagrant@debian.org>:
Bug#935035; Package src:u-boot.
(Sat, 24 Oct 2020 01:36:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Jonas Smedegaard <dr@jones.dk>:
Extra info received and forwarded to list. Copy sent to Vagrant Cascadian <vagrant@debian.org>.
(Sat, 24 Oct 2020 01:36:03 GMT) (full text, mbox, link).
Message #57 received at 935035@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Quoting Jonas Smedegaard (2020-08-06 01:19:15)
> Quoting Vagrant Cascadian (2020-07-21 19:43:21)
> > On 2020-07-21, Jonas Smedegaard wrote:
> > > Quoting Jonas Smedegaard (2020-07-21 02:28:11)
> > >> Quoting Vagrant Cascadian (2020-07-20 22:05:43)
> > >> > I think could probably be trimmed down to a more minimal patch. e.g.
> > >> > It doesn't look like CONFIG_USE_PREBOOT is needed at all; I *think*
> > >> > you could just use CONFIG_PREBOOT without adding Kconfig support
> > >> > (needs testing) and then use ifdef/ifndef directly where the preboot
> > >> > command is added.
> > >>
> > >> Sorry, I don't follow how you think it could be done without per-board
> > >> definitions.
> > >
> > > Sleeping on it helped: I figured it out - here's a much shorter patch:
> > > https://salsa.debian.org/debian/u-boot/-/commit/17bcf50
> >
> > Yeah, that's more like what I was thinking! Clever figuring out
> > configuration options only present on the teres-i. :)
> >
> >
> > > Tested to work with TERES-I laptop.
> > >
> > > I also issued a minor update to the upstream patch:
> > > https://patchwork.ozlabs.org/project/uboot/list/?series=191157
> >
> > Yeah, wondered about usb "reset" vs usb "start".
>
> Part 1/2 entered mainline u-boot few hours ago.
>
> The remaining part, touching only Teres-I, bumped and still pending:
> https://patchwork.ozlabs.org/project/uboot/list/?series=194355
Final patch has now entered mainline u.boot:
https://gitlab.denx.de/u-boot/u-boot/-/commit/1949232
Please consider cherry-picking the patches for current Debian package
targeted unstable, and for stable Debian as well.
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
[signature.asc (application/pgp-signature, inline)]
Message sent on
to Jonas Smedegaard <dr@jones.dk>:
Bug#935035.
(Sat, 24 Oct 2020 15:45:06 GMT) (full text, mbox, link).
Message #60 received at 935035-submitter@bugs.debian.org (full text, mbox, reply):
Control: tag -1 pending
Hello,
Bug #935035 in u-boot reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:
https://salsa.debian.org/debian/u-boot/-/commit/88022988e3a7ac212997b56fecc0c1c86da53cb9
------------------------------------------------------------------------
debian/patches: Fix keyboard on Teres-I (Closes: #935035). Thanks to
Jonas Smedegaard.
------------------------------------------------------------------------
(this message was generated automatically)
--
Greetings
https://bugs.debian.org/935035
Added tag(s) pending.
Request was from Vagrant Cascadian <noreply@salsa.debian.org>
to 935035-submitter@bugs.debian.org.
(Sat, 24 Oct 2020 15:45:06 GMT) (full text, mbox, link).
Reply sent
to Vagrant Cascadian <vagrant@debian.org>:
You have taken responsibility.
(Tue, 05 Jan 2021 04:21:05 GMT) (full text, mbox, link).
Notification sent
to Jonas Smedegaard <dr@jones.dk>:
Bug acknowledged by developer.
(Tue, 05 Jan 2021 04:21:05 GMT) (full text, mbox, link).
Message #67 received at 935035-close@bugs.debian.org (full text, mbox, reply):
Source: u-boot
Source-Version: 2020.10+dfsg-2
Done: Vagrant Cascadian <vagrant@debian.org>
We believe that the bug you reported is fixed in the latest version of
u-boot, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 935035@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated u-boot package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 04 Jan 2021 19:59:11 -0800
Source: u-boot
Architecture: source
Version: 2020.10+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Vagrant Cascadian <vagrant@debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 916822 935035 972513 976315 976316 976317 976318 979107
Changes:
u-boot (2020.10+dfsg-2) unstable; urgency=medium
.
[ Vagrant Cascadian ]
* debian/patches: Enable ethernet on A20-OLinuXino-Lime2-eMMC.
(Closes: #916822). Thanks to Jonas Smedegaard.
* debian/patches: Fix keyboard on Teres-I (Closes: #935035). Thanks to
Jonas Smedegaard.
.
[ Nicolas Boulenguez ]
* Update Homepage and uscan configuration (Closes: #976317).
* Drop obsolete version restriction in Build-Depends (Closes: #976316).
* Change behaviour of debian/bin/u-boot-install-* for an unknown device
tree (Closes: #976315)
* Use specific dh_installman instead of dh_install (Closes: #976318).
* Simplify debian/u-boot-tools.install (Closes: #976318).
* In debian/rules, add prerequisite configs/*_defconfig
(Closes: #976318)
.
[ Vagrant Cascadian ]
* u-boot-qemu: Ship u-boot.rom for the qemu-x86_64 and qemu-x86
targets. Thanks to Faidon Liambotis. (Closes: #979107)
* debian/control: Update Standards-Version to 4.5.1.
* debian/control: Update Build-Depends on lzop.
.
[ Luca Boccassi ]
* Build u-boot-tools with signature support with OpenSSL.
(Closes: #972513)
Checksums-Sha1:
c3e36f82e91b5f8d19f31b18153a0e47091c596d 2860 u-boot_2020.10+dfsg-2.dsc
30c210be1f26aa5c957401a56abad157df86a0f7 43628 u-boot_2020.10+dfsg-2.debian.tar.xz
4b5bd62dba2648ed4682769df615477a58c3b863 9506 u-boot_2020.10+dfsg-2_amd64.buildinfo
Checksums-Sha256:
ccfbc8d37456d364ee4229e227750544be863a1e9655739e77fd87f8c478d03a 2860 u-boot_2020.10+dfsg-2.dsc
c764b9c876e8ece75f738a06a07675b6fd0bf954f78af00658b81705cb4a1ca4 43628 u-boot_2020.10+dfsg-2.debian.tar.xz
6e73a81509748da01969c3a0eb46e2b53fa7fab42780acc8776f5ca82d6cf86b 9506 u-boot_2020.10+dfsg-2_amd64.buildinfo
Files:
26a3366d7ff00599f5954d23325a0180 2860 admin optional u-boot_2020.10+dfsg-2.dsc
490c2b231ffac5d61c013d66709ab5f9 43628 admin optional u-boot_2020.10+dfsg-2.debian.tar.xz
4e5d323607997d52abe70131012b7b83 9506 admin optional u-boot_2020.10+dfsg-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX/PmtxMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqpKIA/AvsF6EZ9lsGZ9zaOf6MgBymp14uz76y
hHJ6q6985Sv0APoD7E2734ytn9cUhlg2r/e9kN563nvb3ZxM2xmPp7UhAg==
=A4VB
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Thu, 04 Feb 2021 07:27:28 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Mon Sep 25 12:33:36 2023;
Machine Name:
bembo
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.