Debian Bug report logs - #934331
linux: backport "dm: disable DISCARD if the underlying storage no longer supports it"?

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Hofstaedtler <zeha@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: linux: backport "dm: disable DISCARD if the underlying storage no longer supports it"?

Date: Fri, 09 Aug 2019 23:12:36 +0200

Package: linux
Version: 4.9.168-1+deb9u4
Severity: normal

Hi!

Today I ran into an issue that matches the description of upstream
commit bcb44433bba5eaff293888ef22ffa07f1f0347d6:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bcb44433bba5eaff293888ef22ffa07f1f0347d6

> dm: disable DISCARD if the underlying storage no longer supports it
>
> Storage devices which report supporting discard commands like
> WRITE_SAME_16 with unmap, but reject discard commands sent to the
> storage device.  This is a clear storage firmware bug but it doesn't
> change the fact that should a program cause discards to be sent to a
> multipath device layered on this buggy storage, all paths can end up
> failed at the same time from the discards, causing possible I/O loss.
>
> The first discard to a path will fail with Illegal Request, Invalid
> field in cdb, e.g.:
>  kernel: sd 8:0:8:19: [sdfn] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
>  kernel: sd 8:0:8:19: [sdfn] tag#0 Sense Key : Illegal Request [current]
>  kernel: sd 8:0:8:19: [sdfn] tag#0 Add. Sense: Invalid field in cdb
>  kernel: sd 8:0:8:19: [sdfn] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 a0 08 00 00 00 80 00 00 00
>  kernel: blk_update_request: critical target error, dev sdfn, sector 10487808

The patch was CC'ed to stable but doesn't seem to appear in 4.19.y.

Unfortunately this appears to be a transient bug in the storage
firmware, so I don't know how to reproduce it -- deleting and rescanning
the sdX device has cleared the repeated error condition for now.

However I'd really like to avoid corrupting the involved file systems,
so if bcb44433bba5eaff293888ef22ffa07f1f0347d6 could make it into either
the 4.9 branch or the 4.19 branch, that'd be lovely.

I've also asked the storage vendor what they think about this, but I'm
not going to hold my breath.

Many thanks in advance,
Chris

Message #20 received at 934331@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: Chris Hofstaedtler <zeha@debian.org>, 934331@bugs.debian.org

Subject: Re: Bug#934331: linux: backport "dm: disable DISCARD if the underlying storage no longer supports it"?

Date: Sun, 18 Aug 2019 21:01:03 +0200

Control: forwarded 934331 https://lore.kernel.org/stable/20190818155941.GA26766@eldamar.local/

Hi Chris,

On Fri, Aug 09, 2019 at 11:12:36PM +0200, Chris Hofstaedtler wrote:
> Package: linux
> Version: 4.9.168-1+deb9u4
> Severity: normal
> 
> Hi!
> 
> Today I ran into an issue that matches the description of upstream
> commit bcb44433bba5eaff293888ef22ffa07f1f0347d6:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bcb44433bba5eaff293888ef22ffa07f1f0347d6
> 
> > dm: disable DISCARD if the underlying storage no longer supports it
> >
> > Storage devices which report supporting discard commands like
> > WRITE_SAME_16 with unmap, but reject discard commands sent to the
> > storage device.  This is a clear storage firmware bug but it doesn't
> > change the fact that should a program cause discards to be sent to a
> > multipath device layered on this buggy storage, all paths can end up
> > failed at the same time from the discards, causing possible I/O loss.
> >
> > The first discard to a path will fail with Illegal Request, Invalid
> > field in cdb, e.g.:
> >  kernel: sd 8:0:8:19: [sdfn] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
> >  kernel: sd 8:0:8:19: [sdfn] tag#0 Sense Key : Illegal Request [current]
> >  kernel: sd 8:0:8:19: [sdfn] tag#0 Add. Sense: Invalid field in cdb
> >  kernel: sd 8:0:8:19: [sdfn] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 a0 08 00 00 00 80 00 00 00
> >  kernel: blk_update_request: critical target error, dev sdfn, sector 10487808
> 
> The patch was CC'ed to stable but doesn't seem to appear in 4.19.y.
> 
> Unfortunately this appears to be a transient bug in the storage
> firmware, so I don't know how to reproduce it -- deleting and rescanning
> the sdX device has cleared the repeated error condition for now.
> 
> However I'd really like to avoid corrupting the involved file systems,
> so if bcb44433bba5eaff293888ef22ffa07f1f0347d6 could make it into either
> the 4.9 branch or the 4.19 branch, that'd be lovely.
> 
> I've also asked the storage vendor what they think about this, but I'm
> not going to hold my breath.

I have sent
https://lore.kernel.org/stable/20190818155941.GA26766@eldamar.local/
let's see what happends. 4.19 should be easier than 4.9, but given Ben
has backported the change to 3.16.72 this should be possible for both
4.9 and 4.19.

Regards,
Salvatore

Message #29 received at 934331-close@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: 934331-close@bugs.debian.org

Subject: Bug#934331: fixed in linux 4.19.67-2

Date: Wed, 28 Aug 2019 13:17:08 +0000

Source: linux
Source-Version: 4.19.67-2

We believe that the bug you reported is fixed in the latest version of
linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 934331@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 28 Aug 2019 06:20:22 +0200
Source: linux
Architecture: source
Version: 4.19.67-2
Distribution: buster
Urgency: medium
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Closes: 866122 934331
Changes:
 linux (4.19.67-2) buster; urgency=medium
 .
   [ Salvatore Bonaccorso ]
   * dm: disable DISCARD if the underlying storage no longer supports it
     (Closes: #934331)
   * xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT
     (CVE-2019-15538)
 .
   [ Ben Hutchings ]
   * KVM: Ignore ABI changes
   * [ppc64el] Disable PPC_TRANSACTIONAL_MEM (Closes: #866122)
   * [ppc64el] Avoid ABI change for disabling TM
   * netfilter: conntrack: Use consistent ct id hash calculation
     (fixes regression in 4.19.44)
 .
   [ Cyril Brulebois ]
   * [arm] Backport DTB support for Rasperry Pi Compute Module 3.
   * [arm64] Backport DTB support for Rasperry Pi Compute Module 3.
Checksums-Sha1:
 d9ca78154e088ce5d19d1ff28bbcb8fb4db64f63 189279 linux_4.19.67-2.dsc
 4f6e45335c9118084dd850557d8d35c82a8ba94e 3139596 linux_4.19.67-2.debian.tar.xz
 57754d990f1684f5ebd49f19f21c8f47f92edcf3 47724 linux_4.19.67-2_source.buildinfo
Checksums-Sha256:
 109e0478e90f34e646aa37eed1b9c5b50fe3ceb8cf3a688d23aaa50e5c7bb190 189279 linux_4.19.67-2.dsc
 9ae7b0ecbab63bdaa89eb9eb2b695899522b2ec5ed4039022ec030a14fc0b63f 3139596 linux_4.19.67-2.debian.tar.xz
 6865a8c68e43ce4748416f6cd6c37b6e036775cb5c1f2e1a012509feee5ea4a9 47724 linux_4.19.67-2_source.buildinfo
Files:
 4514afbdfb89ed763458d5692d8d1d3d 189279 kernel optional linux_4.19.67-2.dsc
 dd8819438530bb2e69c28c967e9c9dfb 3139596 kernel optional linux_4.19.67-2.debian.tar.xz
 224695455a51544a64a7df1e0bd7a52c 47724 kernel optional linux_4.19.67-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAl1mBJZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2
NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk
ZWJpYW4ub3JnAAoJEAVMuPMTQ89Eay0P/iB2RjN4uhk/iLEtH+ARDtAiJ6hs9mBP
bb9eHs7kB5P4HzJze8EXlYsgy+5iP5pY3VM2X37YBMUhQpNUoeCl7Wzb/NFgSTrK
g1CULNwuj8S62WGea72StgOwtnPW2N2S31PT6GtHuICopChn/4a8cEeJ2Otmzu4R
hD9ZeY0DBmwMh/m5sxNYSGc6zqOjdjbjGgpmQTDd5YxoSimV9mllxVyptO7fvPwk
PfBqWZuxQvkE+kXSbUjaw3YeYK/+/YR/c7PmWCFWMIk/MQisJMlVuJ7plUg7agTc
XVIgOkdXKk4hcJ64NwPUsBMaaGWxb6mRpdBJpJoEIcJpkD3lQUhToBrZonePsdzx
lRo5mDnGOXjGti1gPNj/fIF4wImmQJIuk4Sp2ieGiUKzjvImXVSeBkpT1CLrfis3
7SJsFG/jWHmUk/TBEd5Z5pmc+GNx0Qxn0LeQcImVMwHjN4OnF8ab+or3eK8LugkS
Dvbiu1qVwqbSlESOcGA2I/SBPg8HpPr9O7h5Qfb9plbOfba6C8GdyUqkJfwyz4As
8n6wj47jY4HPAKXyqEASLYPlAtgZh3npHRNYuuedl5C1taJEGzX/cl8tKexS2kuU
Uvk2tgS6ZTj84IiReq6+Hm9EIejKzG8DOxQLaD5eE+JvEUcmzGn9Fl9PJmVQQjZ0
46/ae8bETIQS
=m0kW
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.