Debian Bug report logs - #933834
haskell-devscripts: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: haskell-devscripts: please make the build reproducible

Date: Sun, 04 Aug 2019 09:39:01 +0100

[Message part 1 (text/plain, inline)]

Source: haskell-devscripts
Version: 0.15.0
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed
that haskell-devscripts is now generating unreproducible packages.

This is due to:

    commit 359f53d3a559944b372e1648d9a84757f6aafc24
    Author: Clint Adams <clint@debian.org>
    Date:   Sat Jul 27 11:55:45 2019 -0400

        work around old timestamps

    diff --git a/Dh_Haskell.sh b/Dh_Haskell.sh
    index 46d4e3e..378ab5c 100644
    --- a/Dh_Haskell.sh
    +++ b/Dh_Haskell.sh
    @@ -443,6 +443,16 @@ make_setup_recipe(){

     configure_recipe(){
         # local PS5=$PS4; PS4=" + configure_recipe> "; set -x
    +
    +    # dak gets all neurotic about file timestamps older than 1975
    +    # new tarballs from Hackage have files with mtimes at the
    +    # beginning of the epoch, so work around this pair of silliness
    +    # by setting old mtimes to 1998
    +    reftime=$(mktemp)
    +    touch -d 1975-01-01 "${reftime}"
    +    find . \! -newer "${reftime}" -exec touch -d 1998-01-01 {} \;
    +    rm "${reftime}"
    +
         hc=`packages_hc`

However, this breaks reproducible build as it does not specify a
timezone in the second call to touch. You can see this behaviour by
doing something like:

    $ for X in Etc/GMT-12 Etc/GMT+12; do
        TZ=${X} touch -d 1998-01-01 testcase
        stat -c %Y testcase
      done
      883569600
      883656000
         ^^^^

I suggest that we *also* fix the timezone when setting up the reftime,
otherwise we will inevitably — one day — hit a file in that magic
range in/around the 1997/1998 crossover that will not trigger the
test.

Patch attached that does both.

  [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[haskell-devscripts.diff.txt (text/plain, attachment)]

Message #10 received at 933834-close@bugs.debian.org (full text, mbox, reply):

From: Clint Adams <clint@debian.org>

To: 933834-close@bugs.debian.org

Subject: Bug#933834: fixed in haskell-devscripts 0.15.1

Date: Sun, 04 Aug 2019 13:50:13 +0000

Source: haskell-devscripts
Source-Version: 0.15.1

We believe that the bug you reported is fixed in the latest version of
haskell-devscripts, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 933834@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Clint Adams <clint@debian.org> (supplier of updated haskell-devscripts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 04 Aug 2019 09:15:16 -0400
Source: haskell-devscripts
Binary: haskell-devscripts haskell-devscripts-minimal
Architecture: source
Version: 0.15.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Haskell Group <pkg-haskell-maintainers@lists.alioth.debian.org>
Changed-By: Clint Adams <clint@debian.org>
Description:
 haskell-devscripts - Tools to help Debian developers build Haskell packages
 haskell-devscripts-minimal - Tools to help Debian developers build Haskell packages
Closes: 933834
Changes:
 haskell-devscripts (0.15.1) unstable; urgency=medium
 .
   * Patch from Chris Lamb to explicitly set UTC for 1975 hack.
     closes: #933834.
Checksums-Sha1:
 50f74926bf0ef46853c607d38200d5ff52ed45fe 1871 haskell-devscripts_0.15.1.dsc
 4c44a9ddb8819e2643f8fec962f4383357940505 31584 haskell-devscripts_0.15.1.tar.xz
Checksums-Sha256:
 6f1fd1f1d9acb148f127509691e1a80c03e502c478385dc15e33044b5e3e2016 1871 haskell-devscripts_0.15.1.dsc
 e3703c9f8b6d503b9f50fa65512ae21f2030128db32040a44ef0847bdb8fcee7 31584 haskell-devscripts_0.15.1.tar.xz
Files:
 79da4adfe6049991d2c6c54bb9921a57 1871 haskell optional haskell-devscripts_0.15.1.dsc
 1febc55b4d2bdb81c24290022f3760a9 31584 haskell optional haskell-devscripts_0.15.1.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdYHsh0BT5sgHeRubVZIzHhmdOKgFAl1G2yUACgkQVZIzHhmd
OKiIuA//QLItWI/nYREyJlw6bS9kSYiGiCe8965YQQyQ462qTf0NslOmDWp1HUDz
YSHlNdP44bjLKK7HFYkr3mzXLX8POlsO6aMFljzptg8U5MzhIKvwbtuXafr+ngOd
/+fdBKFeZA6sJcP0rDtsq+q5IOU+SN1z69C7FVeCZAwNTC9GAZ3FzoTW15Yh2HMb
A3UClpMweVHGwjw0PYN6MFYBxont0XY3iAP7aNvi/G13ZZJHzWlR3+DI71TH1bCk
csMr2WrSio5dYdR8abKgrJ+lFF5EYDffUT92gaTnKg9nu+K0IJQjvrFf6pv7SrM5
7Zgymy+Yrv8MrXfn0ZDasics7tgmDgx6Lvrik1k15A7p7ktQtakhcaQE4OdV2uWs
EJi3NJtpMsHegGJTKmEKsrJv0XVpjhB7SpKjVFNzDjMDvpVTEoDoMNtENrIcVxKN
Rx6D2dgU8sIAqTjy5vFddL56B2mOik5dzfG0J2djMZxlDsqW8I+93qfhJvMrUx8u
XWt6xbUIiIpiOCgJqm3Rfznj6c64JlJgXQ6SbVX7030vJyUWBjr1xTqqkkP1LGWW
1bTKyra88f/tyOLwdtr1X/ocBlwRj6DW8WexyIXh46+K+bV+QmdTtTMD/cSi+SQ+
o8eHVsre5oYzOzLGFk0gfNDzsJbc51StRExGgUdE4G0P0UOMScA=
=7eez
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.