Debian Bug report logs - #932849
ftp.debian.org: `dak process-policy new` loses .buildinfo files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ftp.debian.org: NEW process looses .buildinfo files

Date: Tue, 23 Jul 2019 18:44:28 -0300

[Message part 1 (text/plain, inline)]

Package: ftp.debian.org
Severity: normal

hi,

<h01ger> https://tracker.debian.org/news/1027072/accepted-liblogger-simple-perl-20-1-source-all-into-unstable-unstable/ says this upload was made with a .buildinfo file, yet this .buildinfo file isnt available
<h01ger> this was on 2019-02-04
<h01ger> any idea why this could have happened?
<jrtc27> process_new loses them
<h01ger> really?
<jrtc27> the buildinfo copying happens here https://salsa.debian.org/ftp-team/dak/blob/master/dak/process_upload.py#L270
<jrtc27> which isn't on the NEW->policy->ACCEPT path
<h01ger> thanks. i would have accepted a 'yes' but this is "better" :/
<h01ger> i guess i will file a bug now
<jrtc27> tar tf /srv/ftp-master.debian.org/queue/done/2019/02.tar.xz  | grep liblogger-simple-perl
<jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.changes
<jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.buildinfo
<jrtc27> they're still retrievable, just not as friendly
<h01ger> lol/thank you!
       * h01ger lols at bremner mubling next to him
<h01ger> jrtc27: may i quote you in that bug to be filed?
<jrtc27> yeah please do
<jrtc27> meant to report one last time I ran into this...
<h01ger> thank you, again! :)
       * h01ger hopes that would be an easy patch
<jrtc27> probably, for someone who knows the detailed code structure for NEW
<jrtc27> that's one part of dak that I haven't really fully understood
<h01ger> isnt it just adding a 'cp $buildinfofile $path/$date/' somewhere?
<jrtc27> sure
<h01ger> (in python, of course)
<jrtc27> a call to the existing function
<jrtc27> the question is where exactly though
<jrtc27> :)


thanks for maintaining ftp.d.o!


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 932849@bugs.debian.org (full text, mbox, reply):

From: Ansgar Burchardt <ansgar@debian.org>

To: Holger Levsen <holger@debian.org>

Cc: 932849@bugs.debian.org

Subject: Re: Bug#932849: ftp.debian.org: NEW process looses .buildinfo files

Date: Wed, 24 Jul 2019 08:20:20 +0200

Control: tag -1 moreinfo
Control: retitle -1 ftp.debian.org: `dak process-policy new` loses .buildinfo files

The title says "loses .buildinfo files", but the IRC log says:

> <jrtc27> tar tf /srv/ftp-master.debian.org/queue/done/2019/02.tar.xz  | grep liblogger-simple-perl
> <jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.changes
> <jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.buildinfo
> <jrtc27> they're still retrievable, just not as friendly

So I'm not sure what the problem is?

Ansgar

Message #15 received at 932849@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: Ansgar Burchardt <ansgar@debian.org>, 932849@bugs.debian.org

Cc: Holger Levsen <holger@debian.org>

Subject: Re: Bug#932849: ftp.debian.org: NEW process looses .buildinfo files

Date: Wed, 24 Jul 2019 13:38:48 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 -moreinfo

On Wed, Jul 24, 2019 at 08:20:20AM +0200, Ansgar Burchardt wrote:
> The title says "loses .buildinfo files", but the IRC log says:
> 
> > <jrtc27> tar tf /srv/ftp-master.debian.org/queue/done/2019/02.tar.xz  | grep liblogger-simple-perl
> > <jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.changes
> > <jrtc27> 02/04/liblogger-simple-perl_2.0-1_amd64.buildinfo
> > <jrtc27> they're still retrievable, just not as friendly
> 
> So I'm not sure what the problem is?

The issue is that they are not exported to Dir::BuildinfoArchive like
regular uploads not going through a queue.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 932849@bugs.debian.org (full text, mbox, reply):

From: Benjamin Hof <vexel@vexel.net>

To: 932849@bugs.debian.org

Subject: Re: Bug#932849: ftp.debian.org: NEW process looses .buildinfo files

Date: Sat, 27 Jul 2019 00:02:48 +0200

Hi,

I've proposed a potential fix in

    https://salsa.debian.org/ftp-team/dak/merge_requests/150


Kind regards,
Benjamin

Message #29 received at 932849-done@bugs.debian.org (full text, mbox, reply):

From: Ansgar <ansgar@debian.org>

To: 932849-done@bugs.debian.org

Subject: Bug#932849 fixed in ftp.debian.org

Date: Fri, 13 Sep 2019 16:34:36 +0000

Hello,

Bug #932849 in ftp.debian.org reported by you has been fixed in the Git repository.
You can see the commit message below and you can check the diff of the fix at:

https://salsa.debian.org/ftp-team/dak/commit/e29d4c4dca77aea5555aac7a5ea7f665efec688f

------------------------------------------------------------------------
Copy buildinfo files from NEW to BuildinfoArchive

Closes: #932849
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/932849

Send a report that this bug log contains spam.