Debian Bug report logs - #932684
buster-pu: package gnupg2/2.2.12-1+deb10u1

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Sun, 21 Jul 2019 15:55:28 -0400

[Message part 1 (text/plain, inline)]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian.org@packages.debian.org
Usertags: pu
Control: affects -1 src:gnupg2

The version of GnuPG in debian buster (2.2.12-1) has a number of
outstanding bugs related to OpenPGP certificate management and network
access.  Many of these concerns are addressed in some of the patches
in upstream's STABLE-BRANCH-2-2 series.

The debdiff (attached) is basically a slew of bugfix, documentation,
stability, and efficiency patches cherry-picked from upstream, plus
some additional changes to reduce the exposure of debian users to
malicious attack on the SKS keyserver network, and some improvements
in the continuous integration test suite.

These additional changes address concerns due to the fact that the SKS
keyserver network is failing due to abuse, and GnuPG had used it as a
default keyserver.  These changes offer ways to work around the
problems our users face when fetching data off the network today.  In
particular:

 * We adopt GnuPG's upstream approach of making keyserver access
   default to self-sigs-only.  This means that the keyserver cannot
   flood the user's keyring by default. (we do *not* adopt upstream's
   choice of import-clean for keyserver default, see
   https://dev.gnupg.org/T4628 for more explanation)
   
 * We constrain the SKS CA to only validate
   hkps.pool.sks-keyservers.net (and we avoid using the system CAs for
   the SKS pool), thereby tightening the confidentiality constraints
   on TLS-wrapped keyserver access.

 * Since the SKS pool's distribution of third-party certifications
   will be ignored by default, we change the default keyserver to
   hkps://keys.openpgp.org, which won't waste the user's bandwidth for
   data that they won't even consider by default.  keys.openpgp.org is
   significantly more performant for read-only clients (most keyserver
   access) than any member of the SKS pool.

 * We also allow GnuPG to merge certificate updates (revocations,
   subkey rotations) which might be published on keys.openpgp.org
   without any user ID (see https://dev.gnupg.org/T4393 for more
   discussion).  This represents a security improvement for users who
   might otherwise use a locally-cached certificate that should have
   been revoked, or who cannot encrypt to a locally-cached certificate
   because they don't know about its new encryption-capable subkey.

 * migrate-pubring-from-classic-gpg fails when the user's keyring
   contains a flooded certificate -- we address this (#931385), and
   adds a test for it.

-------

A note about "web of trust" and the third-party certifications it
depends on:

Third-party certifications are still importable by default over WKD
and DANE/OPENPGPKEY access.  It is generally recommended to use those
mechanisms where providers offer them, using --locate-key by e-mail
address instead of --search.

A user who wants to import arbitrary third-party certifications via
HKP or HKPS can still do so by identifying their trusted keyserver
source and indicating that third-party certifications are OK.  for
example:

    --keyserver hkps://hkps.pool.sks-keyservers.net --keyserver-options no-self-sigs-only

-------

Finally, we add an additional simple test for ci.debian.org, and we
adjust the gpgv-win32 ci test so that it will only run on i386 testers
(#905563).  continuous integration for the win! :)

The changelog entry provides this summary:

gnupg2 (2.2.12-1+deb10u1) buster; urgency=medium

  * drop unneeded patch for printing revocation certificates
  * backport bugfix and stability patches from upstream 2.2.13
  * backport bugfix and stability patches from upstream 2.2.14
  * backport documentation, stability, ssh, and WKD patches from upstream 2.2.15
  * backport documentation and bugfix patches from upstream 2.2.16
  * import bugfixes and cleanup around secret key handling from 2.2.14
  * backport bugfixes, documentation, WKD, and keyserver fixes from 2.2.17
  * import efficiency and security fixes from upstream STABLE-BRANCH-2-2
  * avoid using SKS pool CA unless the keyserver is hkps.pool.sks-keyservers.net
  * drop import-clean from default keyserver options, to avoid data loss
  * use keys.openpgp.org as the default keyserver
  * enable merging certificate updates even if update has no user ID
  * update Vcs-Git: to point to debian/buster branch
  * Adopt migrate-pubring-from-classic-gpg robustness fixes (Closes: #931385)
  * add new CI test: debian/tests/simple-tests
  * debian/tests/gpgv-win32: make arch-specific (Closes: #905563)

 -- Daniel Kahn Gillmor <dkg@fifthhorseman.net>  Sun, 21 Jul 2019 15:39:05 -0400


I recognize that this is a lot of changes, but upstream's 2.2 branch
is intended to be stable.  (most of the GnuPG development work is
happening on the 2.3 branch, and most of the work on 2.2 is just
backports of bugfixes) These changes are also visible on the
debian/buster branch on https://salsa.debian.org/debian/gnupg2.

So another option, if the release-team prefers, would be to move GnuPG
on buster to 2.2.17, with some of the additional changes mentioned
above -- that would involve more upstream changes that are not
currently included in this series, but it would also mean that our
versions are less divergent from what upstream believes the shipped
version of gnupg is.  Please let me know if you'd prefer that i take
that approach instead of these patch queues.

Fwiw, i don't think that GnuPG upstream is as stable as i would
personally like it to be, but the set of changes i've included here
attempt to minimize the amount of negative disruption that a user
might experience from the upgrade, while still ensuring that the user
can deal with the current reality of how OpenPGP certificates are
distributed on the public Internet.

Regards,

        --dkg

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'oldstable'), (200, 'unstable-debug'), (200, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[gnupg2_2.2.12-1_2.2.12-1+deb10u1.debdiff.gz (application/gzip, attachment)]

Message #12 received at 932684@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: 932684@bugs.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Sun, 28 Jul 2019 10:56:25 -0400

[Message part 1 (text/plain, inline)]

On Sun 2019-07-21 15:55:28 -0400, Daniel Kahn Gillmor wrote:
> Package: release.debian.org
> Severity: normal
> Tags: buster
> User: release.debian.org@packages.debian.org
> Usertags: pu
> Control: affects -1 src:gnupg2
>
> The version of GnuPG in debian buster (2.2.12-1) has a number of
> outstanding bugs related to OpenPGP certificate management and network
> access.  Many of these concerns are addressed in some of the patches
> in upstream's STABLE-BRANCH-2-2 series.
>
> The debdiff (attached) is basically a slew of bugfix, documentation,
> stability, and efficiency patches cherry-picked from upstream, plus
> some additional changes to reduce the exposure of debian users to
> malicious attack on the SKS keyserver network, and some improvements
> in the continuous integration test suite.

ping on this?  i'd appreciate any feedback about its prospects for
fixing problems for users of debian buster.

       --dkg

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 932684@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, 932684@bugs.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Wed, 21 Aug 2019 18:19:06 +0100

Control: tags -1 + moreinfo

On Sun, 2019-07-21 at 15:55 -0400, Daniel Kahn Gillmor wrote:
> The version of GnuPG in debian buster (2.2.12-1) has a number of
> outstanding bugs related to OpenPGP certificate management and
> network access.  Many of these concerns are addressed in some of the
> patches in upstream's STABLE-BRANCH-2-2 series.
> 
> The debdiff (attached) is basically a slew of bugfix, documentation,
> stability, and efficiency patches cherry-picked from upstream, plus
> some additional changes to reduce the exposure of debian users to
> malicious attack on the SKS keyserver network, and some improvements
> in the continuous integration test suite.

Apologies for the delay in getting back to you regarding this.

On the whole, I'm happy to trust your judgement on the necessity of the
included changes, however this change in particular is one of the
reasons for the delay, while I considered it and sought wider input:

>  * We adopt GnuPG's upstream approach of making keyserver access
>    default to self-sigs-only.  This means that the keyserver cannot
>    flood the user's keyring by default. (we do *not* adopt upstream's
>    choice of import-clean for keyserver default, see
>    https://dev.gnupg.org/T4628 for more explanation)

The introduction of this change in unstable (and since in testing)
apparently led to some confusion amongst, and queries from, members of
the project, so is likely to have a similar (but quite possibly larger)
effect on the wider stable user base.

If we are to include it, I think it would therefore be wise to ensure
that it is accompanied by a NEWS entry which briefly explains the
change and its implications. (Relatedly, the further through the stable
cycle we get, the more awkward this would be to introduce.)

Regards,

Adam

Message #24 received at 932684@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: "Adam D. Barratt" <adam@adam-barratt.org.uk>, 932684@bugs.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Wed, 21 Aug 2019 15:05:05 -0400

[Message part 1 (text/plain, inline)]

On Wed 2019-08-21 18:19:06 +0100, Adam D. Barratt wrote:
>>  * We adopt GnuPG's upstream approach of making keyserver access
>>    default to self-sigs-only.  This means that the keyserver cannot
>>    flood the user's keyring by default. (we do *not* adopt upstream's
>>    choice of import-clean for keyserver default, see
>>    https://dev.gnupg.org/T4628 for more explanation)
>
> The introduction of this change in unstable (and since in testing)
> apparently led to some confusion amongst, and queries from, members of
> the project, so is likely to have a similar (but quite possibly larger)
> effect on the wider stable user base.
>
> If we are to include it, I think it would therefore be wise to ensure
> that it is accompanied by a NEWS entry which briefly explains the
> change and its implications. (Relatedly, the further through the stable
> cycle we get, the more awkward this would be to introduce.)

Thanks, that's entirely reasonable.  I've put this NEWS item into the
debian/buster branch on salsa.  Otherwise, the debdiff is the same.  


diff --git a/debian/NEWS b/debian/NEWS
index 0a6a7440d..3005e935c 100644
--- a/debian/NEWS
+++ b/debian/NEWS
@@ -1,3 +1,25 @@
+gnupg2 (2.2.12-1+deb10u1) buster; urgency=medium
+
+  In this version we adopt GnuPG's upstream approach of making keyserver
+  access default to self-sigs-only.  This defends against receiving
+  flooded OpenPGP certificates.  To revert to the previous behavior (not
+  recommended!), add the following directive to ~/.gnupg/gpg.conf:
+
+    keyserver-options no-self-sigs-only
+
+  We also adopt keys.openpgp.org as the default keyserver, since it avoids
+  the associated bandwidth waste of fetching third-party certifications
+  that will not be used.  To revert to the older SKS keyserver network (not
+  recommended!), add the following directive to ~/.gnupg/dirmngr.conf:
+
+    keyserver hkps://hkps.pool.sks-keyservers.net
+
+  Note: we do *not* adopt upstream's choice of import-clean for the
+  keyserver default, since it can lead to data loss, see
+  https://dev.gnupg.org/T4628 for more details.
+
+ -- Daniel Kahn Gillmor <dkg@fifthhorseman.net>  Wed, 21 Aug 2019 14:53:47 -0400
+


Let me know if you want me to re-generate a full debdiff, or if you're
ok with this plus the previous debdiff (with an updated date on
debian/changelog to match debian/NEWS), let me know whether i should go
ahead and upload.

Thanks for your thoughtfulness and review.

Regards,

        --dkg

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 932684@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, 932684@bugs.debian.org

Cc: kibi@debian.org, debian-boot@lists.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Thu, 22 Aug 2019 11:32:49 +0100

Control: tags -1 + confirmed d-i

[full quote for KiBi's benefit]

On 2019-08-21 20:05, Daniel Kahn Gillmor wrote:
> On Wed 2019-08-21 18:19:06 +0100, Adam D. Barratt wrote:
>>>  * We adopt GnuPG's upstream approach of making keyserver access
>>>    default to self-sigs-only.  This means that the keyserver cannot
>>>    flood the user's keyring by default. (we do *not* adopt upstream's
>>>    choice of import-clean for keyserver default, see
>>>    https://dev.gnupg.org/T4628 for more explanation)
>> 
>> The introduction of this change in unstable (and since in testing)
>> apparently led to some confusion amongst, and queries from, members of
>> the project, so is likely to have a similar (but quite possibly 
>> larger)
>> effect on the wider stable user base.
>> 
>> If we are to include it, I think it would therefore be wise to ensure
>> that it is accompanied by a NEWS entry which briefly explains the
>> change and its implications. (Relatedly, the further through the 
>> stable
>> cycle we get, the more awkward this would be to introduce.)
> 
> Thanks, that's entirely reasonable.  I've put this NEWS item into the
> debian/buster branch on salsa.  Otherwise, the debdiff is the same.
> 
> 
> diff --git a/debian/NEWS b/debian/NEWS
> index 0a6a7440d..3005e935c 100644
> --- a/debian/NEWS
> +++ b/debian/NEWS
> @@ -1,3 +1,25 @@
> +gnupg2 (2.2.12-1+deb10u1) buster; urgency=medium
> +
> +  In this version we adopt GnuPG's upstream approach of making 
> keyserver
> +  access default to self-sigs-only.  This defends against receiving
> +  flooded OpenPGP certificates.  To revert to the previous behavior 
> (not
> +  recommended!), add the following directive to ~/.gnupg/gpg.conf:
> +
> +    keyserver-options no-self-sigs-only
> +
> +  We also adopt keys.openpgp.org as the default keyserver, since it 
> avoids
> +  the associated bandwidth waste of fetching third-party 
> certifications
> +  that will not be used.  To revert to the older SKS keyserver network 
> (not
> +  recommended!), add the following directive to ~/.gnupg/dirmngr.conf:
> +
> +    keyserver hkps://hkps.pool.sks-keyservers.net
> +
> +  Note: we do *not* adopt upstream's choice of import-clean for the
> +  keyserver default, since it can lead to data loss, see
> +  https://dev.gnupg.org/T4628 for more details.
> +
> + -- Daniel Kahn Gillmor <dkg@fifthhorseman.net>  Wed, 21 Aug 2019
> 14:53:47 -0400
> +
> 
> 
> Let me know if you want me to re-generate a full debdiff, or if you're
> ok with this plus the previous debdiff (with an updated date on
> debian/changelog to match debian/NEWS),

That's fine, thanks.

> let me know whether i should go
> ahead and upload.

This will need a d-i ack, so tagging + CCing.

Regards,

Adam

Message #38 received at 932684@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: 932684@bugs.debian.org, Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Sat, 31 Aug 2019 12:33:51 +0100

On Thu, 2019-08-22 at 11:32 +0100, Adam D. Barratt wrote:
> Control: tags -1 + confirmed d-i
> 
> [full quote for KiBi's benefit]
> 
> On 2019-08-21 20:05, Daniel Kahn Gillmor wrote:
[...]
> > let me know whether i should go
> > ahead and upload.
> 
> This will need a d-i ack, so tagging + CCing.

I don't know if that will be in time, but while we wait feel free to
upload so that the package is available if the timings turn out to be
on our side.

Regards,

Adam

Message #43 received at 932684@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

To: "Adam D. Barratt" <adam@adam-barratt.org.uk>, 932684@bugs.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Sat, 31 Aug 2019 09:27:41 -0400

[Message part 1 (text/plain, inline)]

On Sat 2019-08-31 12:33:51 +0100, Adam D. Barratt wrote:
> I don't know if that will be in time, but while we wait feel free to
> upload so that the package is available if the timings turn out to be
> on our side.

uploaded now, thanks.

         --dkg

[signature.asc (application/pgp-signature, inline)]

Message #48 received at 932684@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: "Adam D. Barratt" <adam@adam-barratt.org.uk>

Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, 932684@bugs.debian.org, debian-boot@lists.debian.org

Subject: Re: Bug#932684: buster-pu: package gnupg2/2.2.12-1+deb10u1

Date: Sat, 31 Aug 2019 17:16:56 +0200

[Message part 1 (text/plain, inline)]

Adam D. Barratt <adam@adam-barratt.org.uk> (2019-08-22):
> > Thanks, that's entirely reasonable.  I've put this NEWS item into the
> > debian/buster branch on salsa.  Otherwise, the debdiff is the same.

No obvious regressions, so no objections.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #55 received at 932684@bugs.debian.org (full text, mbox, reply):

From: Adam D Barratt <adam@adam-barratt.org.uk>

To: 932684@bugs.debian.org

Cc: 932684-submitter@bugs.debian.org

Subject: gnupg2 2.2.12-1+deb10u1 flagged for acceptance

Date: Sat, 31 Aug 2019 23:02:45 +0000

package release.debian.org
tags 932684 = buster pending
thanks

Hi,

The upload referenced by this bug report has been flagged for acceptance into the proposed-updates queue for Debian buster.

Thanks for your contribution!

Upload details
==============

Package: gnupg2
Version: 2.2.12-1+deb10u1

Explanation: 

Message #65 received at 932684-done@bugs.debian.org (full text, mbox, reply):

From: "Adam D. Barratt" <adam@adam-barratt.org.uk>

To: 930795-done@bugs.debian.org, 931126-done@bugs.debian.org, 931198-done@bugs.debian.org, 931199-done@bugs.debian.org, 931358-done@bugs.debian.org, 931596-done@bugs.debian.org, 931608-done@bugs.debian.org, 931615-done@bugs.debian.org, 931616-done@bugs.debian.org, 931724-done@bugs.debian.org, 931817-done@bugs.debian.org, 931967-done@bugs.debian.org, 932009-done@bugs.debian.org, 932030-done@bugs.debian.org, 932069-done@bugs.debian.org, 932111-done@bugs.debian.org, 932193-done@bugs.debian.org, 932318-done@bugs.debian.org, 932335-done@bugs.debian.org, 932441-done@bugs.debian.org, 932448-done@bugs.debian.org, 932518-done@bugs.debian.org, 932522-done@bugs.debian.org, 932588-done@bugs.debian.org, 932606-done@bugs.debian.org, 932684-done@bugs.debian.org, 932790-done@bugs.debian.org, 932945-done@bugs.debian.org, 933036-done@bugs.debian.org, 933125-done@bugs.debian.org, 933147-done@bugs.debian.org, 933175-done@bugs.debian.org, 933369-done@bugs.debian.org, 933379-done@bugs.debian.org, 933392-done@bugs.debian.org, 933535-done@bugs.debian.org, 933754-done@bugs.debian.org, 933764-done@bugs.debian.org, 933769-done@bugs.debian.org, 933787-done@bugs.debian.org, 933899-done@bugs.debian.org, 933911-done@bugs.debian.org, 933976-done@bugs.debian.org, 934094-done@bugs.debian.org, 934163-done@bugs.debian.org, 934183-done@bugs.debian.org, 934308-done@bugs.debian.org, 934311-done@bugs.debian.org, 934329-done@bugs.debian.org, 934343-done@bugs.debian.org, 934345-done@bugs.debian.org, 934507-done@bugs.debian.org, 934537-done@bugs.debian.org, 934650-done@bugs.debian.org, 934689-done@bugs.debian.org, 934704-done@bugs.debian.org, 934826-done@bugs.debian.org, 934827-done@bugs.debian.org, 934928-done@bugs.debian.org, 934934-done@bugs.debian.org, 934956-done@bugs.debian.org, 935137-done@bugs.debian.org, 935165-done@bugs.debian.org, 935200-done@bugs.debian.org, 935253-done@bugs.debian.org, 935261-done@bugs.debian.org, 935265-done@bugs.debian.org, 935308-done@bugs.debian.org, 935370-done@bugs.debian.org, 935386-done@bugs.debian.org, 935411-done@bugs.debian.org, 935465-done@bugs.debian.org, 935474-done@bugs.debian.org, 935479-done@bugs.debian.org, 935480-done@bugs.debian.org, 935576-done@bugs.debian.org, 935583-done@bugs.debian.org, 935704-done@bugs.debian.org, 935707-done@bugs.debian.org, 935719-done@bugs.debian.org, 935746-done@bugs.debian.org, 935770-done@bugs.debian.org, 935776-done@bugs.debian.org, 935809-done@bugs.debian.org, 935815-done@bugs.debian.org, 935827-done@bugs.debian.org, 935888-done@bugs.debian.org, 935957-done@bugs.debian.org, 935988-done@bugs.debian.org, 936022-done@bugs.debian.org, 936056-done@bugs.debian.org, 938954-done@bugs.debian.org, 938975-done@bugs.debian.org, 939019-done@bugs.debian.org

Cc: 935588@bugs.debian.org

Subject: Closing bugs for fixes including in 10.1 point release

Date: Sat, 07 Sep 2019 14:34:49 +0100

Version: 10.1

Hi,

The fixes referenced by each of these bugs were included in today's
buster point release.

Regards,

Adam

Send a report that this bug log contains spam.