Debian Bug report logs - #931881
diffoscope: undeclared versioned dependency on file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <steve.langasek@canonical.com>

To: submit@bugs.debian.org

Subject: diffoscope: undeclared versioned dependency on file

Date: Thu, 11 Jul 2019 13:05:56 -0700

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 117
Severity: serious
Justification: autopkgtest failures and runtime failures
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu eoan

Dear maintainers,

diffoscope 117 is not migratable to testing because its autopkgtests are
failing, due to runtime errors complaining about a wrong version of the
'file' command:

[...]
=================================== FAILURES ===================================
_________________________ test_text_proper_indentation _________________________

args2 = (), kwargs2 = {}

    def inner(*args2, **kwargs2):
        if args[0]:  # i.e. the condition of the skipif() is True
>           return pytest.fail(msg)
E           Failed: requires file >= 5.37 (5.35 detected) (DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1)

args       = (True,)
args2      = ()
kwargs2    = {}
msg        = ('requires file >= 5.37 (5.35 detected) '
 '(DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1)')

tests/utils/tools.py:77: Failed
[...]

    (https://ci.debian.net/packages/d/diffoscope/testing/amd64/)

file 5.37 is only present in Debian experimental, and the diffoscope package
declares no dependency on file >= 5.37.

At the very least, it seems this should be a versioned test dep on file (>=
5.37), but perhaps it should also be a versioned runtime dependency.  I
haven't looked to see what the impact is of the wrong version of 'file' when
DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS is not set.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 931881@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Steve Langasek" <steve.langasek@canonical.com>, 931881@bugs.debian.org

Subject: Re: Bug#931881: diffoscope: undeclared versioned dependency on file

Date: Thu, 11 Jul 2019 18:39:29 -0300

Steve Langasek wrote:

> At the very least, it seems this should be a versioned test dep on file (>=
> 5.37), but perhaps it should also be a versioned runtime dependency. I
> haven't looked to see what the impact is of the wrong version of 'file' when
> DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS is not set.

I think we need to add "file" to the DIFFOSCOPE_TESTS_MISSING_TOOLS
list in debian/tests/pytest. Mattia, can you confirm?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #15 received at 931881@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@mapreri.org>

To: Chris Lamb <lamby@debian.org>, 931881@bugs.debian.org

Cc: Steve Langasek <steve.langasek@canonical.com>

Subject: Re: Bug#931881: diffoscope: undeclared versioned dependency on file

Date: Fri, 12 Jul 2019 01:21:10 +0200

[Message part 1 (text/plain, inline)]

mh, no.  I think some logic needs tweaking, as file is definitely present
(it's an hard dependency of diffoscope), and that test should just be
skipped.

On Thu, Jul 11, 2019 at 11:42 PM Chris Lamb <lamby@debian.org> wrote:

> Steve Langasek wrote:
>
> > At the very least, it seems this should be a versioned test dep on file
> (>=
> > 5.37), but perhaps it should also be a versioned runtime dependency. I
> > haven't looked to see what the impact is of the wrong version of 'file'
> when
> > DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS is not set.
>
> I think we need to add "file" to the DIFFOSCOPE_TESTS_MISSING_TOOLS
> list in debian/tests/pytest. Mattia, can you confirm?
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
>        `-
>
>

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[Message part 2 (text/html, inline)]

Message #20 received at 931881@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Mattia Rizzolo" <mattia@mapreri.org>, 931881@bugs.debian.org

Cc: "Steve Langasek" <steve.langasek@canonical.com>

Subject: Re: Bug#931881: diffoscope: undeclared versioned dependency on file

Date: Fri, 12 Jul 2019 13:09:21 -0300

Hi Mattia,

> >  I think we need to add "file" to the DIFFOSCOPE_TESTS_MISSING_TOOLS
> >  list in debian/tests/pytest. Mattia, can you confirm?
[…]
> mh, no. I think some logic needs tweaking, as file is definitely 
> present (it's an hard dependency of diffoscope), and that test should 
> just be skipped.

I just went to hack on this but, hmm, isn't this providing exactly
what we need? :) ie. skipping these tests when run with a insufficiently
new version of file?

My testcase is to run:

  $ py.test-3 -rsx tests/test_presenters.py::test_text_proper_indentation

… within current sid (ie. src:file 5.35-4) and then by variously exporting:

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS=[unset]
    → Skipped correctly.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS=''
    → Fails; the required version is missing and unlisted.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS="foo bar" 
    → Fails; the required version is missing and unlisted.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS="foo bar file"
    → Skipped correctly.

What am I missing here? :) (Note that I renamed this variable in
d5b9daf04).


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #25 received at 931881@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@mapreri.org>

To: Chris Lamb <lamby@debian.org>

Cc: 931881@bugs.debian.org, Steve Langasek <steve.langasek@canonical.com>

Subject: Re: Bug#931881: diffoscope: undeclared versioned dependency on file

Date: Fri, 12 Jul 2019 18:35:55 +0200

[Message part 1 (text/plain, inline)]

On Fri, 12 Jul 2019, 6:09 pm Chris Lamb, <lamby@debian.org> wrote:

>   * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS=''
>     → Fails; the required version is missing and unlisted.
>
>   * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS="foo bar"
>     → Fails; the required version is missing and unlisted.
>

These shouldn't fail.  As in, the program is present, but the required
version is missing.  That variable isn't holding versions after all.

At least, having that fail in this case wasn't my intention when I wrote
that thing.  If you went down that route it would make that
variable/setting unusable in any circumstance where simply the required
version is missing.

Having said all of this, I think we should make the failing test able to
run with either of the file versions.  `file` keeps changing and breaking
our tests, but it would be awful to only support running the testsuite with
the latest version available.

>
>

[Message part 2 (text/html, inline)]

Message #28 received at 931881-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 931881-submitter@bugs.debian.org

Subject: Bug#931881 marked as pending in diffoscope

Date: Fri, 12 Jul 2019 19:25:44 +0000

Control: tag -1 pending

Hello,

Bug #931881 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/commit/372346e4990114f6305e66a6a13b0f267b83f9d7

------------------------------------------------------------------------
Don't fail in autopkgtests when, for example, we do not have sufficiently newer or older version of file. (Closes: #931881)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/931881

Message #35 received at 931881-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 931881-close@bugs.debian.org

Subject: Bug#931881: fixed in diffoscope 118

Date: Sat, 13 Jul 2019 13:50:10 +0000

Source: diffoscope
Source-Version: 118

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 931881@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 13 Jul 2019 10:23:29 -0300
Source: diffoscope
Binary: diffoscope
Architecture: source all
Version: 118
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 931881
Changes:
 diffoscope (118) unstable; urgency=medium
 .
   * Don't fail in autopkgtests when, for example, we do not have sufficiently
     newer or older version of file. (Closes: #931881)
   * Also include python3-tlsh in test dependencies.
   * Tidy handling of DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS:
     - Merge two previously-overlapping environment variables.
     - Use repr(..)-style output when printing test status.
     - Add some explicit return values to appease pylint.
Checksums-Sha1:
 884fda29574f5c3b6f9b5ebe62c7500d608acc08 4660 diffoscope_118.dsc
 f8d75b50d51b8b63117a2baef2b5ad7e2c7a8ab2 1118532 diffoscope_118.tar.xz
 1ce2ea7292cde0574773966ce71b227a68a419b6 131316 diffoscope_118_all.deb
 fa889c2d3790016b2b6e13d3d5ea8cfc33745b12 26267 diffoscope_118_amd64.buildinfo
Checksums-Sha256:
 c2bd53c5427e7b62fea26b2ce5f30cca846c372f9a7710f818e8388c1a37113d 4660 diffoscope_118.dsc
 59f1a3155be52b0a7b4f055618e89674621e4c9d4de6dc1d19302da35fd0058a 1118532 diffoscope_118.tar.xz
 e3798b149b27b77a24920338f943c31e9f29d8fd3f5526d832820517e7f394b9 131316 diffoscope_118_all.deb
 56dae6a5acd1f64d75653af0578d77c1c5b7f18705785f7a40cd5f821200e665 26267 diffoscope_118_amd64.buildinfo
Files:
 15c8dd13d6915f8b93c6d103c28f548a 4660 devel optional diffoscope_118.dsc
 a1cf0d4e5bd176f55dd693561d6bae65 1118532 devel optional diffoscope_118.tar.xz
 e697211f86338cecd457450a6f03b129 131316 devel optional diffoscope_118_all.deb
 2ceba45652342064a360c5bc3cafd101 26267 devel optional diffoscope_118_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl0p35kACgkQHpU+J9Qx
HlhZvw//RaXXqnE3OPA22EPz/sLMJ2uEUD1HrxV+l/2t8esiM4enqomQD9Hfv2EX
YAJbvKwh8yG5oJy/cz6bZ1x7YGJuZkBJxJNCf5zGjI4+XD8jWPVCPWTPgQjLqXAg
V32ekZtRSUgPjHjgMqL0ToK8fJqFmY2qh1TTwKJSks4NiRxJ13Vce2gB+vSZN6hE
4B7n/np/j4dGjKtjgPTvsdNSOULaVSprHsl8ROK8L64YUKvYDF+JS1qT7ImMnGdL
MGxZUgISHX3xU9F9SAY8BD+gNU+ey1pZZCiFSYnCAq74OV3mLdSPZfNODsWPz20L
hsKh4Z0GEgOrppZ7KfOAYIIf7tmAjTERnoDln6mVQ73py4NrINAO58HHubf2R7z9
CmzZ7MzP6rn3u/oqmxnoKPmK80uRkTOMXwPa8o4G3kZNspVAsMjORndKC7yI3hYm
s4PXzydTCGVxRwFy7a4NLFmo6hbXoLVeyWqRJ/Og5uD9E7cp5yphDLW7UdefKgyZ
05UzOxr6ZILCjG71SMwU94bGBPFfoYTyLtF7jIxIVMtWHmMiPD/mlKZ2uC/t/V1v
VPhIjgVgDlu9mREVHGwGKLoJSpjRSp8rWWp1MhFW4IlhOM388UmGysIkRdtC4Vlo
WEdisGtiQP+r+yutkZMdTEJzS6DILob8odbuqStRsE4HkuSXb4U=
=4k30
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.