Debian Bug report logs - #931852
[armel/marvell] cmdline mtd partition map without effect

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Laif <chris.laif@googlemail.com>

To: submit@bugs.debian.org

Subject: [armel/marvell] cmdline mtd partition map without effect

Date: Thu, 11 Jul 2019 15:11:33 +0200

Package: debian-installer
Version: 20190702

Hi,

I'm using the current Buster kernel/initrd on my Seagate Blackarmor NAS.

The mtd partition map ('mtdparts' cmdline variable) has no effect
(even with 'cmdline' module loaded):

[...]
[    2.312626] This architecture does not have kernel memory protection.
[    2.319057] Run /init as init process
[    2.659299] nand: device found, Manufacturer ID: 0xec, Chip ID: 0x75
[    2.665704] nand: Samsung NAND 32MiB 3,3V 8-bit
[    2.670237] nand: 32 MiB, SLC, erase size: 16 KiB, page size: 512,
OOB size: 16
[    2.738418] mv643xx_eth: MV-643xx 10/100/1000 ethernet driver version 1.4
[    2.778297] libphy: orion_mdio_bus: probed
[    2.798779] mv643xx_eth_port mv643xx_eth_port.0: DMA mask not set
[    2.824205] Scanning device for bad blocks
[...]
~ # uname -a
Linux (none) 4.19.0-5-marvell #1 Debian 4.19.37-5 (2019-06-19)
armv5tel GNU/Linux
~ # cat /proc/cmdline
console=ttyS0,115200
mtdparts=orion_nand:0xa0000@0x0(uboot),0x010000@0xa0000(env),0x500000@0xc0000(uimage),0x1a40000@0x5c0000(rootfs)
~ # cat /proc/mtd
dev:    size   erasesize  name
mtd0: 02000000 00004000 "orion_nand"
~ # lsmod
Module                  Size  Used by
ofpart                  3447  0
cmdlinepart             2775  0
ehci_orion              3765  0
ehci_hcd               53205  1 ehci_orion
usbcore               159269  2 ehci_orion,ehci_hcd
mvmdio                  4528  0
mv643xx_eth            27872  0
usb_common              3755  1 usbcore
nls_base                5869  1 usbcore
orion_nand              1914  0
nand                   74301  1 orion_nand
nand_ecc                3294  1 nand
nand_bch                2470  1 nand
bch                     9396  1 nand_bch
mtd                    44525  6 nand_bch,ofpart,nand,cmdlinepart,orion_nand
sha256_generic          9524  0
~ #

Manually removing/adding cmdline, mtd and nand modules does not help.

The same device started with Debian Stretch has 4 MTD partitions enabled:

[    0.851760] nand: Samsung NAND 32MiB 3,3V 8-bit
[    0.856313] nand: 32 MiB, SLC, erase size: 16 KiB, page size: 512,
OOB size: 16
[    0.863602] Scanning device for bad blocks
[    1.095922] 4 cmdlinepart partitions found on MTD device orion_nand
[    1.102165] Creating 4 MTD partitions on "orion_nand":
[    1.107309] 0x000000000000-0x0000000a0000 : "uboot"
[    1.112995] 0x0000000a0000-0x0000000b0000 : "env"
[    1.118397] 0x0000000c0000-0x0000005c0000 : "uimage"
[    1.124306] 0x0000005c0000-0x000002000000 : "rootfs"
[    1.131105] mtd: device 3 (rootfs) set to be root filesystem

Kind regards,
Chris

Message #10 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Ben Hutchings <ben@decadent.org.uk>

To: Chris Laif <chris.laif@googlemail.com>, 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Sat, 13 Jul 2019 22:36:52 +0100

[Message part 1 (text/plain, inline)]

Control: tag -1 moreinfo

On Thu, 2019-07-11 at 15:11 +0200, Chris Laif wrote:
> Package: debian-installer
> Version: 20190702
> 
> Hi,
> 
> I'm using the current Buster kernel/initrd on my Seagate Blackarmor NAS.
> 
> The mtd partition map ('mtdparts' cmdline variable) has no effect
> (even with 'cmdline' module loaded):
[...]

What if you replace "mtdparts=" with "cmdlineparts.mtdparts="?

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that
there are so many of them.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Chris Laif <chris.laif@googlemail.com>

To: 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Mon, 15 Jul 2019 09:31:43 +0200

On Sat, Jul 13, 2019 at 11:37 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> On Thu, 2019-07-11 at 15:11 +0200, Chris Laif wrote:
> > Package: debian-installer
> > Version: 20190702
> >
> > I'm using the current Buster kernel/initrd on my Seagate Blackarmor NAS.
> >
> > The mtd partition map ('mtdparts' cmdline variable) has no effect
> > (even with 'cmdline' module loaded):
> [...]
>
> What if you replace "mtdparts=" with "cmdlineparts.mtdparts="?
>

With "cmdlineparts.mtdparts" it does not work:

~ # cat /proc/cmdline
console=ttyS0,115200
cmdlineparts.mtdparts=orion_nand:0xa0000@0x0(uboot),0x010000@0xa0000(env),0x500000@0xc0000(uimage),0x1a40000@0x5c0000(rootfs)
~ # cat /proc/mtd
dev:    size   erasesize  name
mtd0: 02000000 00004000 "orion_nand"
~ #

With "cmdlinepart.mtdparts" (without trailing "s", equal to the name
of the kernel-module) it works!:

~ # cat /proc/cmdline
console=ttyS0,115200
cmdlinepart.mtdparts=orion_nand:0xa0000@0x0(uboot),0x010000@0xa0000(env),0x500000@0xc0000(uimage),0x1a40000@0x5c0000(rootfs)
~ # cat /proc/mtd
dev:    size   erasesize  name
mtd0: 000a0000 00004000 "uboot"
mtd1: 00010000 00004000 "env"
mtd2: 00500000 00004000 "uimage"
mtd3: 01a40000 00004000 "rootfs"
~ #

This seems to break backwards compatibility for a lot of devices
(Google shows lots of hits for "mtdparts=" and only a handful for
"cmdlinepart.mtdparts", so I think nobody is using the latter).

I wonder what's the best way to have a both Stretch and Buster
compatible cmdline. A quick test shows that "cmdlinepart.mtdparts"
works with Stretch, too (even Stretch does not have a seperate
"cmdlinepart" module). Do you have any recommendations?

Thanks,
Chris

Message #22 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Ben Hutchings <ben@decadent.org.uk>

To: Chris Laif <chris.laif@googlemail.com>, 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Tue, 16 Jul 2019 00:22:48 +0100

[Message part 1 (text/plain, inline)]

On Mon, 2019-07-15 at 09:31 +0200, Chris Laif wrote:
> On Sat, Jul 13, 2019 at 11:37 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Thu, 2019-07-11 at 15:11 +0200, Chris Laif wrote:
> > > Package: debian-installer
> > > Version: 20190702
> > > 
> > > I'm using the current Buster kernel/initrd on my Seagate Blackarmor NAS.
> > > 
> > > The mtd partition map ('mtdparts' cmdline variable) has no effect
> > > (even with 'cmdline' module loaded):
> > [...]
> > 
> > What if you replace "mtdparts=" with "cmdlineparts.mtdparts="?
> > 
> 
> With "cmdlineparts.mtdparts" it does not work:
[...]
> With "cmdlinepart.mtdparts" (without trailing "s", equal to the name
> of the kernel-module) it works!:

Sorry for the typo.

> ~ # cat /proc/cmdline
> console=ttyS0,115200
> cmdlinepart.mtdparts=orion_nand:0xa0000@0x0(uboot),0x010000@0xa0000(env),0x500000@0xc0000(uimage),0x1a40000@0x5c0000(rootfs)
> ~ # cat /proc/mtd
> dev:    size   erasesize  name
> mtd0: 000a0000 00004000 "uboot"
> mtd1: 00010000 00004000 "env"
> mtd2: 00500000 00004000 "uimage"
> mtd3: 01a40000 00004000 "rootfs"
> ~ #
> 
> This seems to break backwards compatibility for a lot of devices
> (Google shows lots of hits for "mtdparts=" and only a handful for
> "cmdlinepart.mtdparts", so I think nobody is using the latter).
>
> I wonder what's the best way to have a both Stretch and Buster
> compatible cmdline. A quick test shows that "cmdlinepart.mtdparts"
> works with Stretch, too (even Stretch does not have a seperate
> "cmdlinepart" module). Do you have any recommendations?

I think that "cmdlinepart.mtdparts" will work whether or not the driver
is actually a module.  But I accept it would be better if "mtdparts"
also continued to work when the driver is a module.

Ben.

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Chris Laif <chris.laif@googlemail.com>

To: Ben Hutchings <ben@decadent.org.uk>, 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Tue, 16 Jul 2019 09:02:30 +0200

On Tue, Jul 16, 2019 at 1:22 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> On Mon, 2019-07-15 at 09:31 +0200, Chris Laif wrote:
> > On Sat, Jul 13, 2019 at 11:37 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > On Thu, 2019-07-11 at 15:11 +0200, Chris Laif wrote:
> > This seems to break backwards compatibility for a lot of devices
> > (Google shows lots of hits for "mtdparts=" and only a handful for
> > "cmdlinepart.mtdparts", so I think nobody is using the latter).
> >
> > I wonder what's the best way to have a both Stretch and Buster
> > compatible cmdline. A quick test shows that "cmdlinepart.mtdparts"
> > works with Stretch, too (even Stretch does not have a seperate
> > "cmdlinepart" module). Do you have any recommendations?
>
> I think that "cmdlinepart.mtdparts" will work whether or not the driver
> is actually a module.  But I accept it would be better if "mtdparts"
> also continued to work when the driver is a module.
>

Thanks. Do you know if the acceptance of 'mtdparts' with/without
prefix is specific to the Debian kernel or if it is a decision by the
upstream kernel devs? I remember that some months ago one of the beta
Buster kernels accepted the 'mtdparts' variable, I /think/ the
incompatible change has been introduced during finalisation of Buster.

Kernel docs (https://www.kernel.org/doc/html/v4.19/admin-guide/kernel-parameters.html)
refer to the 'mtdparts' variable (without prefix).

Chris

Message #32 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Ben Hutchings <ben@decadent.org.uk>

To: Chris Laif <chris.laif@googlemail.com>, 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Tue, 16 Jul 2019 11:25:13 +0100

[Message part 1 (text/plain, inline)]

On Tue, 2019-07-16 at 09:02 +0200, Chris Laif wrote:
> On Tue, Jul 16, 2019 at 1:22 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Mon, 2019-07-15 at 09:31 +0200, Chris Laif wrote:
> > > On Sat, Jul 13, 2019 at 11:37 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > > On Thu, 2019-07-11 at 15:11 +0200, Chris Laif wrote:
> > > This seems to break backwards compatibility for a lot of devices
> > > (Google shows lots of hits for "mtdparts=" and only a handful for
> > > "cmdlinepart.mtdparts", so I think nobody is using the latter).
> > > 
> > > I wonder what's the best way to have a both Stretch and Buster
> > > compatible cmdline. A quick test shows that "cmdlinepart.mtdparts"
> > > works with Stretch, too (even Stretch does not have a seperate
> > > "cmdlinepart" module). Do you have any recommendations?
> > 
> > I think that "cmdlinepart.mtdparts" will work whether or not the driver
> > is actually a module.  But I accept it would be better if "mtdparts"
> > also continued to work when the driver is a module.
> > 
> 
> Thanks. Do you know if the acceptance of 'mtdparts' with/without
> prefix is specific to the Debian kernel or if it is a decision by the
> upstream kernel devs? I remember that some months ago one of the beta
> Buster kernels accepted the 'mtdparts' variable, I /think/ the
> incompatible change has been introduced during finalisation of Buster.
> 
> Kernel docs (https://www.kernel.org/doc/html/v4.19/admin-guide/kernel-parameters.html)
> refer to the 'mtdparts' variable (without prefix).

The difference in behaviour between the built-in and modular builds of
the driver, is not specific to Debian.

The change to building this driver as a module was our decision,
however.  That change was made in version 4.16-1~exp1, over a year ago.

Ben.

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 931852@bugs.debian.org (full text, mbox, reply):

From: Chris Laif <chris.laif@googlemail.com>

To: Ben Hutchings <ben@decadent.org.uk>, 931852@bugs.debian.org

Subject: Re: Bug#931852: [armel/marvell] cmdline mtd partition map without effect

Date: Thu, 18 Jul 2019 09:11:05 +0200

On Tue, Jul 16, 2019 at 12:25 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> On Tue, 2019-07-16 at 09:02 +0200, Chris Laif wrote:
> > On Tue, Jul 16, 2019 at 1:22 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > Thanks. Do you know if the acceptance of 'mtdparts' with/without
> > prefix is specific to the Debian kernel or if it is a decision by the
> > upstream kernel devs? I remember that some months ago one of the beta
> > Buster kernels accepted the 'mtdparts' variable, I /think/ the
> > incompatible change has been introduced during finalisation of Buster.
> >
> > Kernel docs (https://www.kernel.org/doc/html/v4.19/admin-guide/kernel-parameters.html)
> > refer to the 'mtdparts' variable (without prefix).
>
> The difference in behaviour between the built-in and modular builds of
> the driver, is not specific to Debian.
>
> The change to building this driver as a module was our decision,
> however.  That change was made in version 4.16-1~exp1, over a year ago.
>

Thanks. I'm using 'cmdlinepart.mtdparts' now and for me this bug can
be closed. I expect other people will run into this problem but I'm
not in a position to judge of whether including cmdlinepart as a
module or not.

Chris

Send a report that this bug log contains spam.