Debian Bug report logs - #927022
/usr/bin/sensible-editor: Prints stderr from which

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: /usr/bin/sensible-editor: Prints stderr from which

Date: Sat, 13 Apr 2019 13:37:21 -0400

Package: sensible-utils
Version: 0.0.12
Severity: minor
File: /usr/bin/sensible-editor
Tags: patch


sensible-editor is not discarding the stderr from which, thus its error
messages are printed when EDITOR VISUAL and SELECTED_EDITOR are empty:

% sensible-editor testfile
usage: which [-as] program ...
usage: which [-as] program ...
usage: which [-as] program ...


Please swallow the stderr:

-[ "$(which $EDITOR || true)" = "$p" ] && EDITOR=
-[ "$(which $VISUAL || true)" = "$p" ] && VISUAL=
-[ "$(which $SELECTED_EDITOR || true)" = "$p" ] && SELECTED_EDITOR=
+[ "$(which $EDITOR 2>/dev/null|| true)" = "$p" ] && EDITOR=
+[ "$(which $VISUAL 2>/dev/null|| true)" = "$p" ] && VISUAL=
+[ "$(which $SELECTED_EDITOR 2>/dev/null|| true)" = "$p" ] && SELECTED_EDITOR=

Or skip the check if they are empty:

[ -n "$EDITOR" ] && [ "$(which $EDITOR || true)" = "$p" ] && EDITOR=
[ -n "$EDITOR" ] && [ "$(which $VISUAL || true)" = "$p" ] && VISUAL=
[ -n "$EDITOR" ] && [ "$(which $SELECTED_EDITOR || true)" = "$p" ] && SELECTED_EDITOR=



-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- no debconf information

Message #10 received at 927022@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Debian Bug Tracking System <927022@bugs.debian.org>

Subject: Re: /usr/bin/sensible-editor: Prints stderr from which

Date: Sat, 27 Jul 2019 08:46:04 -0400

Package: sensible-utils
Version: 0.0.12
Followup-For: Bug #927022
Control: tags -1 patch

> sensible-editor is not discarding the stderr from which, thus its error
> messages are printed when EDITOR VISUAL and SELECTED_EDITOR are empty:

I have posted a MR on salsa eliding the check if the variable is empty
on all three sensible- utils.

https://salsa.debian.org/debian/sensible-utils/merge_requests/2

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- no debconf information

Message #15 received at 927022@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: 927022@bugs.debian.org

Subject: sensible-utils: diff for NMU version 0.0.12+nmu1

Date: Sun, 17 Nov 2019 09:30:06 -0300

[Message part 1 (text/plain, inline)]

Control: tags 927022 + pending

Dear maintainer,

I've prepared an NMU for sensible-utils (versioned as 0.0.12+nmu1) and
uploaded it to DELAYED/10. Please feel free to tell me if I
should delay it longer.

-- 
Saludos,
Felipe Sateler

[sensible-utils-0.0.12+nmu1-nmu.diff (text/x-diff, attachment)]

Message #22 received at 927022-close@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: 927022-close@bugs.debian.org

Subject: Bug#927022: fixed in sensible-utils 0.0.12+nmu1

Date: Wed, 27 Nov 2019 13:20:32 +0000

Source: sensible-utils
Source-Version: 0.0.12+nmu1

We believe that the bug you reported is fixed in the latest version of
sensible-utils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 927022@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Felipe Sateler <fsateler@debian.org> (supplier of updated sensible-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 17 Nov 2019 09:21:22 -0300
Source: sensible-utils
Architecture: source
Version: 0.0.12+nmu1
Distribution: unstable
Urgency: medium
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Changed-By: Felipe Sateler <fsateler@debian.org>
Closes: 927022
Changes:
 sensible-utils (0.0.12+nmu1) unstable; urgency=medium
 .
   [ Felipe Sateler ]
   * Non-maintainer upload.
   * Do not attempt to discover the executable path of empty variables.
     Otherwise, which outputs a message like `usage: which [-as] program ... `.
     Instead of invoking which without arguments, lets skip the check
     (Closes: #927022)
 .
   [ Boyuan Yang ]
   * debian/control: Update Vcs-* fields and use git packaging repo under Salsa Debian group.
Checksums-Sha1:
 f74fb97bc066a42b2959f80a637e6a19d8f86843 1753 sensible-utils_0.0.12+nmu1.dsc
 1f1d4dfd3fbf949c3cac0b57c5a4dbdf1455321c 61988 sensible-utils_0.0.12+nmu1.tar.xz
 16e1fdd02d74175bb0171c630cce9d4952ef390b 5770 sensible-utils_0.0.12+nmu1_amd64.buildinfo
Checksums-Sha256:
 68bcb3e542e29a8a0bf281d9145d0e4cd9def529af2ba0cfe0afee3c5af958bc 1753 sensible-utils_0.0.12+nmu1.dsc
 53c6606facf083adbbf0da04e6d774b31ff3f46c7ba36a82d3f182779f4c3f5b 61988 sensible-utils_0.0.12+nmu1.tar.xz
 b66d0a6149b09645638d54326f3f823f5c8dae9699fc8737eaaaf4599c5c39a2 5770 sensible-utils_0.0.12+nmu1_amd64.buildinfo
Files:
 79a56f77859d5effc7e033168fcf156d 1753 utils required sensible-utils_0.0.12+nmu1.dsc
 056d3212f2dec8d4a9b5655a639b13a7 61988 utils required sensible-utils_0.0.12+nmu1.tar.xz
 fbdb0044147b1698c34e47f526c8584b 5770 utils required sensible-utils_0.0.12+nmu1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCAAyFiEEIY7gNiAzyHtsE1+ko7q64kCN1s8FAl3RPWgUHGZzYXRlbGVy
QGRlYmlhbi5vcmcACgkQo7q64kCN1s9s0Q//dNbmfs3PaEehBn+q0ObUwO5QFOeo
8+WxNXpCjdUqkFv3bQUFXy2Eh2PXmX9bXAi8O8y4z3/LKRLsuVD3oCPMHBPncco0
SlLPDmgZfUA9qmE4uObrgQ0cwOhM4vKfADqvhJG4JWekyn+JGnCZoRDGux3Zti2J
si5GH1tTRQgr26l1UeeY7LHG8flrOxgpJX+GuHowROlM8S7SWP/KbmZ9lPTSyvFm
298NTBFgcVZ5JhmrQ4RgX1ZkA3Q0mMh0x+xcWbQ3OKSvlWmTfyAtc7Yu7C36sLwd
iUivsVK3g6GE7OEaMvs5/CGt7zCrThosgrqoiYcxld8h+6a0Dm1It/7ZMnpGEjx+
qroo3HsvatCw+Aqz/6pgKUzEhULdiQ45WwWEqoQBLC6VZH43eBXhME7GnyqrKqqP
He5ivRCg+NZLElt1dIQaSWwZpzY9n4PU/bLLFUOjXJLLOHgrxUbhCTYomxK1xguS
gEBIhDzPu7vBskO83qEiLt28XUj8Lik8fZqJ8g5kOuZ+0Pic75eiIQqQu3PMXwj/
gIxEq7MYUYLKf0Y+Y9Wfg+Tgn2fBVM3YB97+sHFG/+4Y7YJ/DtNtQ64oNAC6JAJR
o6FIYE74O+ytHcJSuqWyOL3y5ROzMC8kAoNiXEIWXtjXmYwvzqLhApF2DFOiBSQj
CqlLnZan1amIFEU=
=h0qA
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.