Debian Bug report logs - #924458
node-js-beautify: please make the build reproducible

version graph

Package: src:node-js-beautify; Maintainer for src:node-js-beautify is Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Wed, 13 Mar 2019 08:51:02 UTC

Severity: wishlist

Tags: patch

Found in version node-js-beautify/1.7.5+dfsg-2

Fixed in version node-js-beautify/1.7.5+dfsg-3

Done: Xavier Guimard <yadd@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#924458; Package src:node-js-beautify. (Wed, 13 Mar 2019 08:51:04 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Wed, 13 Mar 2019 08:51:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: node-js-beautify: please make the build reproducible
Date: Wed, 13 Mar 2019 04:49:47 -0400
[Message part 1 (text/plain, inline)]
Source: node-js-beautify
Version: 1.7.5+dfsg-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that node-js-beautify could not be built reproducibly.

This is because it will vary the output depending on which shell
is configured as /bin/sh due to the use of {foo,bar} expansion
in the debian/rules file.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[node-js-beautify.diff.txt (text/plain, attachment)]

Message sent on to "Chris Lamb" <lamby@debian.org>:
Bug#924458. (Wed, 13 Mar 2019 09:21:08 GMT) (full text, mbox, link).


Message #8 received at 924458-submitter@bugs.debian.org (full text, mbox, reply):

From: Xavier Guimard <noreply@salsa.debian.org>
To: 924458-submitter@bugs.debian.org
Subject: Bug #924458 in node-js-beautify marked as pending
Date: Wed, 13 Mar 2019 09:20:01 +0000
Control: tag -1 pending

Hello,

Bug #924458 in node-js-beautify reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/js-team/node-js-beautify/commit/5268d0435c59d1bdafa30cf7e619be837e34189c

------------------------------------------------------------------------
Add SHELL=/bin/bash in debian/rules to make build reproducible. Thanks to Chris Lamb

Closes: #924458
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/924458



Added tag(s) pending. Request was from Xavier Guimard <noreply@salsa.debian.org> to 924458-submitter@bugs.debian.org. (Wed, 13 Mar 2019 09:21:08 GMT) (full text, mbox, link).


Reply sent to Xavier Guimard <yadd@debian.org>:
You have taken responsibility. (Wed, 24 Apr 2019 12:06:03 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Wed, 24 Apr 2019 12:06:03 GMT) (full text, mbox, link).


Message #15 received at 924458-close@bugs.debian.org (full text, mbox, reply):

From: Xavier Guimard <yadd@debian.org>
To: 924458-close@bugs.debian.org
Subject: Bug#924458: fixed in node-js-beautify 1.7.5+dfsg-3
Date: Wed, 24 Apr 2019 12:03:38 +0000
Source: node-js-beautify
Source-Version: 1.7.5+dfsg-3

We believe that the bug you reported is fixed in the latest version of
node-js-beautify, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 924458@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Xavier Guimard <yadd@debian.org> (supplier of updated node-js-beautify package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 24 Apr 2019 13:39:16 +0200
Source: node-js-beautify
Architecture: source
Version: 1.7.5+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Xavier Guimard <yadd@debian.org>
Changed-By: Xavier Guimard <yadd@debian.org>
Closes: 924458 927868
Changes:
 node-js-beautify (1.7.5+dfsg-3) unstable; urgency=medium
 .
   * Team upload
   * Add SHELL=/bin/bash in debian/rules to make build reproducible. Thanks to
     Chris Lamb (Closes: #924458)
   * Fix install (Closes: #927868)
   * Add test on css-beautify and html-beautify
Checksums-Sha1: 
 6c58ad43220bf91c64e72b0f20514d2b35a5fc99 2205 node-js-beautify_1.7.5+dfsg-3.dsc
 e04445a223fde39cde3b332b8a5a3958182024cc 19764 node-js-beautify_1.7.5+dfsg-3.debian.tar.xz
Checksums-Sha256: 
 ed976f311709a6ad11a1aca9927d94f6bcff80360a674343022c8f0a1c93fd98 2205 node-js-beautify_1.7.5+dfsg-3.dsc
 ef83dbb14579eaf1bbdf2e2058a27e2f489cb9afe0e0097a7f97f6ea820f4cf0 19764 node-js-beautify_1.7.5+dfsg-3.debian.tar.xz
Files: 
 7dcd16968c6e000eb83ae1f8961ae300 2205 javascript optional node-js-beautify_1.7.5+dfsg-3.dsc
 ab7de48a5041cadd1224afc494381db1 19764 javascript optional node-js-beautify_1.7.5+dfsg-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlzAS9oACgkQ9tdMp8mZ
7uk0LQ/+PrH+riOkWxXMSvCM5sYeasFCLifNtqeuseSdZRpPmF3iX7EPxIjAQ9mE
40J1IsfawjdxlKXRpEzcM+X+YMW2xn7JRbtEvy1NJ65iwgBiQVBPg2xuWB7iwReI
DaVpRJQz5XtDeF6p+E6NGBbkF5dWfze/PbiJFSXcoVvLn835fRqzbb8PCagEfJR9
IlIrh1fFDS8aWHBAO3JbGq3/uol2nDD0S3ox2EWVREcEcg0P+PLgM0GdUDy7+lSN
x8nN/a1A5QXn6KhwogaKaYJIGg8VQRYM1Q76QcHY+VSPJjjiuB5w1F8vVkXj/MhY
4i+pUIVlRtwcT1IYsWbSif1G1PKoa36tsG8akhungkcBOVbKJr7klhsWWHPSWpcF
Jx/+l+heB1p9z4DQNsH01nWCHuFfPF/bPUDFlDb3IWqDFBzQiFejLQsndY/pOxEF
/JyjOLqJrrSaqtKct/4diMHoNl9zqn/DTYV8zBfPF2zET4u+VFGET1psE/Ai4z22
ATYyF7ZHBu9eNfCsyfL49qh4uyAdNqrUzQOGpvTWvyNxjxeM43WPUmOJ/bmN4RKK
QWo4DZn4Jk/dbven+0Uxw4OW4edf+uPWwW25KZO5FFiE8yyS82EQfqyFw6hNsusQ
T1K1g2RoJBqUyVi1mhazglLwMJP9wEqovx4r4/Fmm6jmHXEIz2Q=
=6YAa
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 24 May 2019 07:26:29 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:06:42 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.