Debian Bug report logs - #915293
systraq: reproducible build (usrmerge): embeds path of run-parts found via PATH

version graph

Package: systraq; Maintainer for systraq is Joost van Baal-Ilić <joostvb@debian.org>; Source for systraq is src:systraq (PTS, buildd, popcon).

Reported by: Andreas Henriksson <andreas@fatal.se>

Date: Sun, 2 Dec 2018 15:03:04 UTC

Severity: normal

Tags: patch

Found in version systraq/20160803-3

Fixed in version systraq/20201231-1

Done: Joost van Baal-Ilić <joostvb@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Joost van Baal-Ilić <joostvb@debian.org>:
Bug#915293; Package systraq. (Sun, 02 Dec 2018 15:03:06 GMT) (full text, mbox, link).


Acknowledgement sent to Andreas Henriksson <andreas@fatal.se>:
New Bug report received and forwarded. Copy sent to Joost van Baal-Ilić <joostvb@debian.org>. (Sun, 02 Dec 2018 15:03:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: systraq: reproducible build (usrmerge): embeds path of run-parts found via PATH
Date: Sun, 2 Dec 2018 15:59:58 +0100
[Message part 1 (text/plain, inline)]
Package: systraq
Version: 20160803-3
Severity: normal
Tags: patch
User: md@linux.it
Usertags: usrmerge

Dear Maintainer,

The package currently fails to reproducibly build on merged-usr vs
non-merged systems.

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/systraq.html

The problem is caused by embedding the full path of run-parts looked
up via PATH. On merged-usr systems /bin is a symlink to /usr/bin
and normally PATH has /usr/bin before /bin, thus you end up
with /usr/bin/run-parts on merged-usr systems while it's
/bin/run-parts on non-merged systems.

In my opinion the best solution would be to avoid embedding a path at
all and just rely on PATH at *runtime* (instead of build-time).
Unfortunately the generated configure script for some reason only
accepts RUN_PATHS variables that contains slashes for unknown reasons.
(This doesn't happen in all packages I've looked at, only some.)

Thus the solution for now is to pass RUN_PARTS=/bin/run-parts to
configure. Please see attached debdiff.

Regards,
Andreas Henriksson
[systraq-usrmerge.debdiff (text/plain, attachment)]

Reply sent to Joost van Baal-Ilić <joostvb@debian.org>:
You have taken responsibility. (Sun, 03 Jan 2021 13:24:03 GMT) (full text, mbox, link).


Notification sent to Andreas Henriksson <andreas@fatal.se>:
Bug acknowledged by developer. (Sun, 03 Jan 2021 13:24:03 GMT) (full text, mbox, link).


Message #10 received at 915293-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 915293-close@bugs.debian.org
Subject: Bug#915293: fixed in systraq 20201231-1
Date: Sun, 03 Jan 2021 13:21:11 +0000
Source: systraq
Source-Version: 20201231-1
Done: Joost van Baal-Ilić <joostvb@debian.org>

We believe that the bug you reported is fixed in the latest version of
systraq, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 915293@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joost van Baal-Ilić <joostvb@debian.org> (supplier of updated systraq package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 03 Jan 2021 13:57:04 +0100
Source: systraq
Architecture: source
Version: 20201231-1
Distribution: unstable
Urgency: medium
Maintainer: Joost van Baal-Ilić <joostvb@debian.org>
Changed-By: Joost van Baal-Ilić <joostvb@debian.org>
Closes: 915293
Changes:
 systraq (20201231-1) unstable; urgency=medium
 .
   * New upstream release: The Geefhuishof Release.
 .
   [ Andreas Henriksson <andreas@fatal.se>  Sun, 02 Dec 2018 15:25:39 +0100 ]
   * Pass RUN_PARTS=/bin/run-parts to configure
     - fixes reproducible build on merged-usr vs non-merged systems.
       Closes: #915293
 .
   [ Joost van Baal-Ilić ]
   * debian/control: update vcs-headers: moved from alioth to salsa.
   * debian/control: change Depends "exim4 | mail-transport-agent" in
     "default-mta | mail-transport-agent", thanks lintian.
   * update debhelper compatibility version just a tiny bit:
     - debian/control: change Build-Depends: remove (>=9) from debhelper
     - debian/compat: s/9/10/
     (it seems ye olde cdbs is not happy with dh version 12)
Checksums-Sha1:
 81706ba30df138c2f000e43cbac54e1192ff3fa6 2080 systraq_20201231-1.dsc
 8172c725d808789067d831c5fc240b999bf0109b 478964 systraq_20201231.orig.tar.xz
 6c084b1f766440d6083feafc0e116b6ecbeca960 833 systraq_20201231.orig.tar.xz.asc
 b77293e255478d050106f8c8d3a07eff58970f82 232916 systraq_20201231-1.debian.tar.xz
 39c9c79370de68d6b2f4596161c910602a713519 5626 systraq_20201231-1_source.buildinfo
Checksums-Sha256:
 ff1bb32b6cb18c1b06b3c6a52fe0afa2370a39cdcdd86ac83ec96910576165fe 2080 systraq_20201231-1.dsc
 ea645be9f9ea42381b917873429d19ea6002390cc54911744e47cc4912ef517a 478964 systraq_20201231.orig.tar.xz
 8766d562cc22d445297304857fda58bfce2dc72cdc748daf31cbc237f13065f8 833 systraq_20201231.orig.tar.xz.asc
 9add0338e0f4834aa7596b17b8e8a42417c13f38fcb05a79b29b4a58e37be692 232916 systraq_20201231-1.debian.tar.xz
 104e37a7f681838f96defd4702c3a3c194f77474ae22854ba2b9f7a2766f252d 5626 systraq_20201231-1_source.buildinfo
Files:
 99cce067a16fc8cc371c94559e0aa174 2080 admin optional systraq_20201231-1.dsc
 2e1d2ed381ce6134894b396b47d78159 478964 admin optional systraq_20201231.orig.tar.xz
 064b202def00da4eebf99f87c8249944 833 admin optional systraq_20201231.orig.tar.xz.asc
 685c52b0720a30d81047b0c47f33bc9c 232916 admin optional systraq_20201231-1.debian.tar.xz
 250011059ab8416756545a39c6c2e145 5626 admin optional systraq_20201231-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkqrZAbIbS8eaR6AwVPGmYxdIZxMFAl/xwI0ACgkQVPGmYxdI
ZxPNmBAAmHX872eBRI9LRSciuLaI+WKi9Yk/nmtAxd5VrGi+DaTVRRHzyv+885rr
ZLc3e5bGRiyS65MOEh0hClQg7xdpNLg0fXv5UN/lSMjjEK3gIoX8EuTp9x6ZdZhy
nUrpaF0sWLj4ZcxzkAOK8WpqLeLIK3uzP+ALCKdG+OIEBBVB4Eekg392FzODa/8M
kzzDf0PQaZa1w1MNn2zbSJw3RqbJeT6aA/hAp/XI3h5j7DaKvUOISyGs9jkSwo+x
FeaHWLfjroX9y3l3CKjjHalQ6WfPuQWB/HpnkIgViMjrDJAka39oUXJgcySn0y+P
UtixrG/q7h3i8hzjseJ+Lyi7GalAT8RsvzPPG0lSSv6/dIGCslqaQfi2ZejyXO7O
shhm/xjsnHIBVl/3Rc2eKuRtZvor7zXbWAgX8A9xIZHZXN+94y8mnh3F0XCz9OcV
EMD1mLqdoAGIx7InXomXyg9sIey9gnaWsvSdCmvE1TV/4GvysFW+CTqa9a9D45eR
LUHmcD36H+BZnGW/PS2fu15rq+Iym9JdBwaS0n35PVVo7uT3MvxzqvifszI52RQ+
ifgNpQWaUOv1cKiqN1AOwGOC9ceOss4KVgCmA11S6cxL07FpVOKuxzyPpikFhF+u
oJdez28jJkwTYHw9XqMeVOAYRIU5ptezTVXCFuVDe9Fx4NEZs3Y=
=uQG+
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#915293; Package systraq. (Sun, 03 Jan 2021 21:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Joost van Baal-Ilić <joostvb@debian.org>:
Extra info received and forwarded to list. (Sun, 03 Jan 2021 21:09:03 GMT) (full text, mbox, link).


Message #15 received at 915293@bugs.debian.org (full text, mbox, reply):

From: Joost van Baal-Ilić <joostvb@debian.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: 915293@bugs.debian.org
Subject: Re: Bug#915293: fixed in systraq 20201231-1
Date: Sun, 3 Jan 2021 21:56:49 +0100
Hi Andreas,

And thanks for your very nice bugreport + patch!

Bye,

Joost

PS: and indeed, I agree with your analysis, doing the lookup at runtime would
be even better.


On Sun, Jan 03, 2021 at 01:21:11PM +0000, Debian FTP Masters wrote:
> Source: systraq
<snip>
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Format: 1.8
> Date: Sun, 03 Jan 2021 13:57:04 +0100
> Source: systraq
> Architecture: source
> Version: 20201231-1
> Distribution: unstable
> Urgency: medium
> Maintainer: Joost van Baal-Ilić <joostvb@debian.org>
> Changed-By: Joost van Baal-Ilić <joostvb@debian.org>
> Closes: 915293
> Changes:
>  systraq (20201231-1) unstable; urgency=medium
>  .
>    * New upstream release: The Geefhuishof Release.
>  .
>    [ Andreas Henriksson <andreas@fatal.se>  Sun, 02 Dec 2018 15:25:39 +0100 ]
>    * Pass RUN_PARTS=/bin/run-parts to configure
>      - fixes reproducible build on merged-usr vs non-merged systems.
>        Closes: #915293
>  .
>    [ Joost van Baal-Ilić ]
>    * debian/control: update vcs-headers: moved from alioth to salsa.
>    * debian/control: change Depends "exim4 | mail-transport-agent" in
>      "default-mta | mail-transport-agent", thanks lintian.
>    * update debhelper compatibility version just a tiny bit:
>      - debian/control: change Build-Depends: remove (>=9) from debhelper
>      - debian/compat: s/9/10/
>      (it seems ye olde cdbs is not happy with dh version 12)
> Checksums-Sha1:
>  81706ba30df138c2f000e43cbac54e1192ff3fa6 2080 systraq_20201231-1.dsc
<snip>




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 05 Feb 2021 07:32:51 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:25:30 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.