Debian Bug report logs - #913734
snake4 FTCBFS: make install strips with the wrong strip

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helmut Grohne <helmut@subdivi.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: snake4 FTCBFS: make install strips with the wrong strip

Date: Wed, 14 Nov 2018 14:00:58 +0100

[Message part 1 (text/plain, inline)]

Source: snake4
Version: 1.0.14-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

snake4 fails to cross build from source, because make install strips
with the wrong strip. Stripping at make install time not only breaks
cross compilation, but also the generation of -dbgsym packages and
DEB_BUILD_OPTIONS=nocheck. As such I porpose removing it. Please
consider applying the attached patch.

Helmut

[snake4_1.0.14-1.1.debdiff (text/plain, attachment)]

Message #12 received at 913734@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 913734@bugs.debian.org, 829715@bugs.debian.org

Subject: NMU for reproducible builds and cross building issues

Date: Thu, 06 Oct 2022 13:39:48 -0700

[Message part 1 (text/plain, inline)]

Control: tags 913734 pending
Control: tags 829715 pending

Uploaded an NMU to DELAYED/10 fixing the cross building and reproducible
builds patches submitted in 2018 and 2016:

diff -Nru snake4-1.0.14/debian/changelog snake4-1.0.14/debian/changelog
--- snake4-1.0.14/debian/changelog	2014-08-18 06:07:37.000000000 -0700
+++ snake4-1.0.14/debian/changelog	2022-10-06 13:24:22.000000000 -0700
@@ -1,3 +1,16 @@
+snake4 (1.0.14-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Reiner Herrmann ]
+  * Strip build date/user to enable reproducible building.
+    (Closes: #829715)
+
+  [ Helmut Grohne ]
+  * Fix FTCBFS: Don't strip during make install. (Closes: #913734)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 06 Oct 2022 13:24:22 -0700
+
 snake4 (1.0.14-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru snake4-1.0.14/debian/patches/makefile-use-install-variable-rather-tha.patch snake4-1.0.14/debian/patches/makefile-use-install-variable-rather-tha.patch
--- snake4-1.0.14/debian/patches/makefile-use-install-variable-rather-tha.patch	1969-12-31 16:00:00.000000000 -0800
+++ snake4-1.0.14/debian/patches/makefile-use-install-variable-rather-tha.patch	2022-10-06 13:24:22.000000000 -0700
@@ -0,0 +1,40 @@
+From: Helmut Grohne <helmut@subdivi.de>
+Date: Wed, 14 Nov 2018 14:00:58 +0100
+X-Dgit-Generated: 1.0.14-1.1 cc12e06821c48f4a94bfa55ea275a6de3b2979b9
+Subject: Makefile: Use INSTALL variable rather than hard-coded install.
+
+Patch from https://bugs.debian.org/913734
+
+Patch description by Vagrant Cascadian <vagrant@reproducible-builds.org>
+
+---
+
+diff --git a/Makefile b/Makefile
+index bf234f9..6ac7b99 100644
+--- a/Makefile
++++ b/Makefile
+@@ -63,6 +63,7 @@ DEFINES		= -DVERSION=\"$(VERSION)\" \
+ ###########################################################################
+ 
+ CC		= gcc
++INSTALL		?= install
+ 
+ OPTIM		= -s -O2
+ CCOPT		= -Wall $(OPTIM) $(INCDIR) $(DEFINES) $(CFLAGS)
+@@ -90,12 +91,12 @@ clean:
+ 	rm -f *.o core depend *~ $(PROG)
+ 
+ install: $(PROG)
+-	install -d -m 755 $(INSTBINDIR) $(INSTLIBDIR) $(INSTMANDIR)
+-	install -s -m 4755 -o $(OWNER) -g $(GROUP) $(PROG) $(INSTBINDIR)
++	$(INSTALL) -d -m 755 $(INSTBINDIR) $(INSTLIBDIR) $(INSTMANDIR)
++	$(INSTALL) -s -m 4755 -o $(OWNER) -g $(GROUP) $(PROG) $(INSTBINDIR)
+ 	ln -sf $(PROG) $(INSTBINDIR)/snake4scores
+-	install -m 644 $(DIST).6 $(INSTMANDIR)
++	$(INSTALL) -m 644 $(DIST).6 $(INSTMANDIR)
+ 	if test ! -f $(SCOREFILE); then \
+-	  install -m 644 -o $(OWNER) -g $(GROUP) \
++	  $(INSTALL) -m 644 -o $(OWNER) -g $(GROUP) \
+ 	          $(SCOREBASEFILE) $(INSTLIBDIR); fi
+ 
+ depend dep:
diff -Nru snake4-1.0.14/debian/patches/series snake4-1.0.14/debian/patches/series
--- snake4-1.0.14/debian/patches/series	2014-08-18 04:43:09.000000000 -0700
+++ snake4-1.0.14/debian/patches/series	2022-10-06 13:24:22.000000000 -0700
@@ -1,3 +1,5 @@
 useless-linkage.patch
 hardening.patch
 standard-install-directories.patch
+strip-build-dateuser-to-enable-reproduci.patch
+makefile-use-install-variable-rather-tha.patch
diff -Nru snake4-1.0.14/debian/patches/strip-build-dateuser-to-enable-reproduci.patch snake4-1.0.14/debian/patches/strip-build-dateuser-to-enable-reproduci.patch
--- snake4-1.0.14/debian/patches/strip-build-dateuser-to-enable-reproduci.patch	1969-12-31 16:00:00.000000000 -0800
+++ snake4-1.0.14/debian/patches/strip-build-dateuser-to-enable-reproduci.patch	2022-10-06 13:24:22.000000000 -0700
@@ -0,0 +1,35 @@
+From: Reiner Herrmann <reiner@reiner-h.de>
+Date: Tue, 5 Jul 2016 16:43:38 +0200
+X-Dgit-Generated: 1.0.14-1.1 a00bd8404731fe2738413108aee6fcb249a5727e
+Subject: Strip build date/user to enable reproducible building (Closes: #829715).
+
+
+---
+
+diff --git a/Makefile b/Makefile
+index bfe5a78..bf234f9 100644
+--- a/Makefile
++++ b/Makefile
+@@ -57,8 +57,6 @@ GROUP		= games
+ SCOREBASEFILE	= $(PROG).score
+ SCOREFILE	= $(INSTLIBDIR)/$(SCOREBASEFILE)
+ DEFINES		= -DVERSION=\"$(VERSION)\" \
+-		  "-DCOMPILED_DATE=\"$(COMPILED_DATE)\"" \
+-		  "-DCOMPILED_BY=\"$(COMPILED_BY)\"" \
+ 		  -DSCOREFILE=\"$(SCOREFILE)\" \
+ 		  -DXK_MISCELLANY -DXK_LATIN1 
+ 
+diff --git a/snake4.c b/snake4.c
+index 13c5b25..1180adc 100644
+--- a/snake4.c
++++ b/snake4.c
+@@ -31,8 +31,7 @@ static void
+ version(void)
+ {
+     printf(
+-      "snake4 " VERSION ", by Sverre H. Huseby "
+-      "(compiled " COMPILED_DATE " by " COMPILED_BY ")\n"
++      "snake4 " VERSION ", by Sverre H. Huseby\n"
+     );
+     exit(0);
+ }
diff -Nru snake4-1.0.14/debian/rules snake4-1.0.14/debian/rules
--- snake4-1.0.14/debian/rules	2014-08-14 16:45:50.000000000 -0700
+++ snake4-1.0.14/debian/rules	2022-10-06 13:24:22.000000000 -0700
@@ -5,6 +5,9 @@
 %:
 	dh $@ --parallel
 
+override_dh_auto_install: # drop with debhelper compat 10
+	dh_auto_install -- 'INSTALL=install --strip-program=true'
+
 override_dh_fixperms:
 	chown 'root:games' debian/snake4/usr/games/snake4
 	chmod 2755 debian/snake4/usr/games/snake4

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 913734-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 913734-close@bugs.debian.org

Subject: Bug#913734: fixed in snake4 1.0.14-1.1

Date: Sun, 16 Oct 2022 21:21:01 +0000

Source: snake4
Source-Version: 1.0.14-1.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
snake4, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 913734@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated snake4 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 06 Oct 2022 13:24:22 -0700
Source: snake4
Architecture: source
Version: 1.0.14-1.1
Distribution: unstable
Urgency: medium
Maintainer: Alexandre Dantas <eu@alexdantas.net>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 829715 913734
Changes:
 snake4 (1.0.14-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Reiner Herrmann ]
   * Strip build date/user to enable reproducible building.
     (Closes: #829715)
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Don't strip during make install. (Closes: #913734)
Checksums-Sha1:
 149f54aef36470802dcde231d9672fa0d579480c 1479 snake4_1.0.14-1.1.dsc
 ecef7be85b29d4f1eacde319ff28eeca73da62ea 6740 snake4_1.0.14-1.1.debian.tar.xz
Checksums-Sha256:
 f10f5e5b676757f87a94b16c39a181d8b6218ce075793057ff3ea1c7012c6698 1479 snake4_1.0.14-1.1.dsc
 6dd4b597e2a5af2c7169aafa478963dc67fee2e1823ccfa214d9b0b947c8b991 6740 snake4_1.0.14-1.1.debian.tar.xz
Files:
 349a9399980160308e6e865977e1b20f 1479 games optional snake4_1.0.14-1.1.dsc
 bf8bec0d1f64a3acf4cf79039f8f82f5 6740 games optional snake4_1.0.14-1.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYz87VSAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqnZBAP4m3YAQsBPBSgpy
Dek20NknA+k1MWPCXAKjMIG8j8hvzwD/Q+v3TCb/NnUqetG2a5qz+RtU5dk3Z7Eb
wjpT4Th7oQ4=
=GEX9
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.