Debian Bug report logs - #913315
diffoscope: crash with PyPDF2.utils.PdfReadError with some packages

Toggle useless messages

Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: submit@bugs.debian.org

Subject: diffoscope: crash with PyPDF2.utils.PdfReadError with some packages

Date: Fri, 9 Nov 2018 15:07:01 +0100

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 104
Severity: important


Seen with several packages, for example gle-graphics/unstable/amd64
right now.

Thu Nov  8 21:45:12 UTC 2018  I: diffoscope 104 will be used to compare the two builds:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 470, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 442, in run_diffoscope
    difference = compare_root_paths(path1, path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 68, in compare_root_paths
    difference = compare_files(file1, file2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/debian.py", line 184, in compare
    differences = super().compare(other, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 321, in _compare_using_details
    other.as_container, no_recurse=no_recurse))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 177, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 321, in _compare_using_details
    other.as_container, no_recurse=no_recurse))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 177, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 321, in _compare_using_details
    other.as_container, no_recurse=no_recurse))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 177, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 321, in _compare_using_details
    other.as_container, no_recurse=no_recurse))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 177, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 321, in _compare_using_details
    other.as_container, no_recurse=no_recurse))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", line 177, in compare_pair
    file1, file2, source=None, diff_content_only=no_recurse)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
    return file1.compare(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
    difference = self._compare_using_details(other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 304, in _compare_using_details
    details.extend(self.compare_details(other, source))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/pdf.py", line 49, in compare_details
    self.dump_pypdf2_metadata(self),
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/pdf.py", line 70, in dump_pypdf2_metadata
    for k, v in sorted(pdf.getDocumentInfo().items()):
  File "/usr/lib/python3/dist-packages/PyPDF2/pdf.py", line 1101, in getDocumentInfo
    obj = self.trailer['/Info']
  File "/usr/lib/python3/dist-packages/PyPDF2/generic.py", line 520, in __getitem__
    return dict.__getitem__(self, key).getObject()
  File "/usr/lib/python3/dist-packages/PyPDF2/generic.py", line 182, in getObject
    return self.pdf.getObject(self).getObject()
  File "/usr/lib/python3/dist-packages/PyPDF2/pdf.py", line 1611, in getObject
    retval = readObject(self.stream, self)
  File "/usr/lib/python3/dist-packages/PyPDF2/generic.py", line 66, in readObject
    return DictionaryObject.readFromStream(stream, pdf)
  File "/usr/lib/python3/dist-packages/PyPDF2/generic.py", line 589, in readFromStream
    % (utils.hexStr(stream.tell()), key))
PyPDF2.utils.PdfReadError: Multiple definitions in dictionary at byte 0x2c1900 for key /Author


-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 913315@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 913315@bugs.debian.org

Subject: Re: diffoscope: crash with PyPDF2.utils.PdfReadError with some packages

Date: Fri, 09 Nov 2018 12:45:55 -0500

tags 913315 + pending
thanks

Fixed in Git, pending upload:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/9624319001171a59e8de0f220cedd71fcebf7ee9

  diffoscope/comparators/pdf.py | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 913315-close@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 913315-close@bugs.debian.org

Subject: Bug#913315: fixed in diffoscope 106

Date: Fri, 23 Nov 2018 11:19:49 +0000

Source: diffoscope
Source-Version: 106

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 913315@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 23 Nov 2018 11:09:28 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 106
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 903446 913315
Changes:
 diffoscope (106) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * comparators:
     + elf: Don't assume all files called ".a" are ELF binaries.  Closes: #903446
     + pdf:
       - Display the reason when cannot extract metadata from PDF files.
       - Prevent tracebacks when obtaining PDF metadata from files with multiple
         PDF dictionary definition entries.  Closes: #913315
 .
   [ Marius Gedminas ]
   * Add a python_requires to setup.py.
 .
   [ Mattia Rizzolo ]
   * debian:
     + Disable depends on gnumeric and procyon as they are RC buggy.
     + Override the new lintian's public-upstream-key-in-native-package.
Checksums-Sha1:
 4d1041a25ebaa4f4c9042926858187d51e8490af 4414 diffoscope_106.dsc
 27de1757c263157b8cf5505bfa0b64d7f89e7fd9 9277820 diffoscope_106.tar.xz
 d18d7505876284370d649ef9c5ea7290e42b8c21 20677 diffoscope_106_amd64.buildinfo
Checksums-Sha256:
 a1c920dbcfe5fbb10f291c9e0d8b47542c82b17f500405e97b7b875e30ce8128 4414 diffoscope_106.dsc
 3d0628088acc38d5edce1bab9b83ee409798ae4eb6a1c843655af740db32df94 9277820 diffoscope_106.tar.xz
 4d5216eb570da86858bb23d95d0cbc33c306043cfbea76c45169e649b755f553 20677 diffoscope_106_amd64.buildinfo
Files:
 cb915c4f0dde771df7dbb135ed1e1786 4414 devel optional diffoscope_106.dsc
 5fc534a9b4a8c89286e75a9fd0ef36c5 9277820 devel optional diffoscope_106.tar.xz
 7011db4ddb2b6c507f93980e171bd6fc 20677 devel optional diffoscope_106_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlv33H0ACgkQCBa54Yx2
K61HgxAAolWXdN3nSFXd0h0pkoOrGFmBq4oTOYYR8PoOLYnpnX88GnaQXy+ytCrl
yI7/16MzvOvXdtj5CjaJjB9lAH0pYF2l4R5Kg/7oMmI3s6b7Ky1snY/9X4jwfNcw
z6uCGicZ+eWlZQgFD7I5++MlNDvQZKCF5jMwzGf/ZouQJxwakXmEwvmhHGjS4E3U
+PTsHlaxpUIn3RRTK5kSynhSXW89ef6atqszmVOJu2pQaX6jXlft6iF4d9YskU2b
o/7syQDISyOEtCsdK/iG+LhZwaYjfinrKE/9rRAU1eZ8bZ/aF8IFFklkLgJTh1KO
RYIL/YXq5jov30tQcmJ8uJBVYrAYJqV+P9pjNKZXl1bUGk7aV7q8r/Gq35TJ8anE
y4zki88QMXwFV69skOHtCrnQ0DQA1S2I8wTG/n9OUuq6wKGvFER8XaqdS+7KicLG
OLdQph8wMNV+1F2Lwq1DMK/X5XzgB+hPH9j7XA3kDS4u5e5/E6I99xcP7XVYWw38
v5f8YlUY7sEe33xaX69074RhEJvr1koAm/Rc/zV975t1lp5wevJKAKGqSpYW7zqp
DXffugkfUdsQB8Ni4HG7FvqWLEd/+h3x93KEyuXDec1MHu333/Lh+X1wasxydmXU
KuPf72SCSeccCvPGrY1OQNikVoTJ2cqmzl9SBzMghHGem2RGtjc=
=IVWp
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.