Debian Bug report logs - #912340
src:samba: Fails To Build Reproducibly

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mathieu Parent <math.parent@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: [src:samba]: Unreproducible on sid

Date: Tue, 30 Oct 2018 16:43:57 +0100

Source: samba
Version: 2:4.6.5+dfsg-6
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Since https://salsa.debian.org/samba-team/samba/commit/c7628ec63c8372c9d3a73d51a0d4a8401f9a1f8e,
samba FTBR.

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/samba.html
has:

    Expands build prefix variables in smb.conf.5 but curiously only
three of the variables are expanded, not all of them...

I will try the following patch:

diff --git a/dynconfig/wscript b/dynconfig/wscript
index 54977e42bd4..008a1942a46 100644
--- a/dynconfig/wscript
+++ b/dynconfig/wscript
@@ -365,7 +365,6 @@ def get_override(bld):
                  'BINDIR'        : 'bin',
                  'SBINDIR'       : 'bin',
                  'CODEPAGEDIR'   : 'codepages',
-                 'SCRIPTSBINDIR' : 'source4/scripting/bin',
                  'SETUPDIR'      : 'source4/setup'
                  }
     return override



Regards
-- 
Mathieu Parent

Message #10 received at 912340@bugs.debian.org (full text, mbox, reply):

From: Andrew Bartlett <abartlet@samba.org>

To: Mathieu Parent <math.parent@gmail.com>, 912340@bugs.debian.org, Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: [Pkg-samba-maint] Bug#912340: [src:samba]: Unreproducible on sid

Date: Wed, 31 Oct 2018 06:08:38 +1300

On Tue, 2018-10-30 at 16:43 +0100, Mathieu Parent wrote:
> Source: samba
> Version: 2:4.6.5+dfsg-6
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Since https://salsa.debian.org/samba-team/samba/commit/c7628ec63c8372c9d3a73d51a0d4a8401f9a1f8e,
> samba FTBR.
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/samba.html
> has:
> 
>     Expands build prefix variables in smb.conf.5 but curiously only
> three of the variables are expanded, not all of them...
> 
> I will try the following patch:
> 
> diff --git a/dynconfig/wscript b/dynconfig/wscript
> index 54977e42bd4..008a1942a46 100644
> --- a/dynconfig/wscript
> +++ b/dynconfig/wscript
> @@ -365,7 +365,6 @@ def get_override(bld):
>                   'BINDIR'        : 'bin',
>                   'SBINDIR'       : 'bin',
>                   'CODEPAGEDIR'   : 'codepages',
> -                 'SCRIPTSBINDIR' : 'source4/scripting/bin',
>                   'SETUPDIR'      : 'source4/setup'
>                   }
>      return override

As long as you are happy for make test to fail, that will be OK.

For reasons I couldn't track down, waf doesn't realise the dependency
has changed for the xml manpage generation so doesn't rebuild the
manpages.

I filed this bug https://bugzilla.samba.org/show_bug.cgi?id=13198

waf has changed a lot for 4.10 so the first step would be to double-
check master. 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

Message #15 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andrew Bartlett <abartlet@samba.org>

To: 912340@bugs.debian.org, Mathieu Parent <math.parent@gmail.com>, Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#912340: [Pkg-samba-maint] Bug#912340: [src:samba]: Unreproducible on sid

Date: Wed, 31 Oct 2018 06:50:18 +1300

On Wed, 2018-10-31 at 06:08 +1300, Andrew Bartlett wrote:
> On Tue, 2018-10-30 at 16:43 +0100, Mathieu Parent wrote:
> > 
> > Source: samba
> > Version: 2:4.6.5+dfsg-6
> > Tags: patch
> > User: reproducible-builds@lists.alioth.debian.org
> > Usertags: buildpath
> > X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> > 
> > Hi,
> > 
> > Since https://salsa.debian.org/samba-team/samba/commit/c7628ec63c83
> > 72c9d3a73d51a0d4a8401f9a1f8e,
> > samba FTBR.
> > 
> > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/
> > samba.html
> > has:
> > 
> >     Expands build prefix variables in smb.conf.5 but curiously only
> > three of the variables are expanded, not all of them...
> > 
> > I will try the following patch:
> > 
> > diff --git a/dynconfig/wscript b/dynconfig/wscript
> > index 54977e42bd4..008a1942a46 100644
> > --- a/dynconfig/wscript
> > +++ b/dynconfig/wscript
> > @@ -365,7 +365,6 @@ def get_override(bld):
> >                   'BINDIR'        : 'bin',
> >                   'SBINDIR'       : 'bin',
> >                   'CODEPAGEDIR'   : 'codepages',
> > -                 'SCRIPTSBINDIR' : 'source4/scripting/bin',
> >                   'SETUPDIR'      : 'source4/setup'
> >                   }
> >      return override
> As long as you are happy for make test to fail, that will be OK.
> 
> For reasons I couldn't track down, waf doesn't realise the dependency
> has changed for the xml manpage generation so doesn't rebuild the
> manpages.
> 
> I filed this bug https://bugzilla.samba.org/show_bug.cgi?id=13198
> 
> waf has changed a lot for 4.10 so the first step would be to double-
> check master. 

Sadly master is no better :-(

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

Message #39 received at 912340-done@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: 912340-done@bugs.debian.org

Subject: Re: Bug#912340: [src:samba]: Unreproducible on sid

Date: Tue, 6 Dec 2022 10:27:24 +0300

Version: 2:4.16.0+dfsg-1

On Wed, 31 Oct 2018 06:50:18 +1300 Andrew Bartlett <abartlet@samba.org> wrote:
..
> > For reasons I couldn't track down, waf doesn't realise the dependency
> > has changed for the xml manpage generation so doesn't rebuild the
> > manpages.

It looks like this has been fixed quite long time ago. At least with 4.16,
manpages are rebuilt correctly when xml files are changed.

We had reprotest failing on salsa for quite some time due to entirely
different reason which I can't even understand.  For example,
https://salsa.debian.org/samba-team/samba/-/jobs/3551551 reprotest job
says that libldb2.deb is different in different builds, and the difference
is within the debian control area, namely:

diff -u -p -r c/shlibs e/shlibs
--- c/shlibs	2022-11-21 20:41:46.000000000 +0300
+++ e/shlibs	2022-11-21 20:41:46.000000000 +0300
@@ -1,5 +1,5 @@
 libldb 2 libldb2 (>> 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419~)
-libldb-tdb-err-map-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)
-libldb-tdb-int-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)
 libldb-mdb-int-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)
+libldb-tdb-err-map-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)
 libldb-key-value-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)
+libldb-tdb-int-samba4 0 libldb2 (= 2:2.6.1+samba4.17.3+dfsg-2+salsaci+20221121+419)

(similar difference exists in other binary packages too).  It looks like collation
difference between different locales.

But since a few days ago, apparently salsa reprotest has changed somehow, and
these differences does not occur anymore.

So I guess this bug can be closed now.

Another question is why I marked it as found in 4.17 version... :)

/mjt

Send a report that this bug log contains spam.