Debian Bug report logs - #912180
find: "-type " wrong on bind-mounted char device

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Mathieu Parent (Debian)" <sathieu@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: find: "-type " wrong on bind-mounted char device

Date: Sun, 28 Oct 2018 21:15:58 +0100

[Message part 1 (text/plain, inline)]

Package: findutils
Version: 4.6.0+git+20181018-1
Tags: upstream patch
Affects: piuparts
X-Debbugs-CC: Andreas Beckmann <anbe@debian.org>

Hi,

The following testcase [1]:

mkdir foo
mknod foo/null c 1 3
touch foo/bindmntoverfile
mount --bind foo/null foo/bindmntoverfile
find foo -type f -ls
3857271640      0 crw-r--r--   1 root     root       1,   3 Oct 24
07:50 foo/bindmntoverfile

i.e "-type f" wrongly matches a char device.

The attached patch fixes this.

Regards

-- 
Mathieu Parent

[1]: Thanks Andreas: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911334#25

[0001-Ensure-type-is-checked-with-FTS_NSOK-and-FTS_NS.patch (text/x-patch, attachment)]

Message #10 received at 912180@bugs.debian.org (full text, mbox, reply):

From: Andreas Metzler <ametzler@bebt.de>

To: "Mathieu Parent (Debian)" <sathieu@debian.org>, 912180@bugs.debian.org

Subject: Re: Bug#912180: find: "-type " wrong on bind-mounted char device

Date: Mon, 29 Oct 2018 19:01:43 +0100

Control: forwarded -1 https://savannah.gnu.org/bugs/index.php?54913

On 2018-10-28 "Mathieu Parent (Debian)" <sathieu@debian.org> wrote:
> Package: findutils
> Version: 4.6.0+git+20181018-1
[...]
> The following testcase [1]:

> mkdir foo
> mknod foo/null c 1 3
> touch foo/bindmntoverfile
> mount --bind foo/null foo/bindmntoverfile
> find foo -type f -ls
> 3857271640      0 crw-r--r--   1 root     root       1,   3 Oct 24
> 07:50 foo/bindmntoverfile

> i.e "-type f" wrongly matches a char device.

> The attached patch fixes this.

Thanks, I have forwarded the report upstream.

cu Andreas

-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

Message #17 received at 912180@bugs.debian.org (full text, mbox, reply):

From: Florian Zumbiehl <florz@florz.de>

To: 912180@bugs.debian.org

Subject: Also affects -inum

Date: Tue, 12 Mar 2019 12:17:33 +0100

Hi,

different symptom, but the same cause: find -inum (on stretch) doesn't find
files that are mounted because it uses d_ino from getdents(), which
contains the inode number of the moint point rather than of the directory
entry.

The specific use I encountered this bug with was finding a network name
space based on its inode number--but since network name spaces are mounted,
you can't use find for that anymore.

Florian

Send a report that this bug log contains spam.