Debian Bug report logs - #911757
zsh-antigen: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: zsh-antigen: please make the build reproducible

Date: Wed, 24 Oct 2018 08:38:36 -0400

[Message part 1 (text/plain, inline)]

Source: zsh-antigen
Version: 2.2.3-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that zsh-antigen could not be built reproducibly.

This is because it uses a timezone-varying date in ANTIGEN_REVISION_DATE.

Patch-to-a-patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[zsh-antigen.diff.txt (text/plain, attachment)]

Message #10 received at 911757@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: Chris Lamb <lamby@debian.org>

Cc: 911757@bugs.debian.org

Subject: Re: zsh-antigen: please make the build reproducible

Date: Wed, 24 Oct 2018 14:31:43 +0000

Chris Lamb wrote on Wed, Oct 24, 2018 at 08:38:36 -0400:
> @@ -17,7 +15,7 @@
> -+	@$(call ised,"s/{{ANTIGEN_REVISION_DATE}}/$$(date --date @$$(dpkg-parsechangelog -STimestamp) --rfc-3339=seconds)/",${TARGET})
> ++	@$(call ised,"s/{{ANTIGEN_REVISION_DATE}}/$$(date --date --utc @$$(dpkg-parsechangelog -STimestamp) --rfc-3339=seconds)/",${TARGET})

Chris, are you sure that's right?  According to date(1), the --date
option takes an argument, so that would seem to take "--utc" as the date
to parse:

% date --date --utc @1 
date: the argument ‘@1’ lacks a leading '+';
when using an option to specify date(s), any non-option
argument must be a format string beginning with '+'
Try 'date --help' for more information.
zsh: exit 1     date --date --utc @1
% date --utc --date @1
Thu Jan  1 00:00:01 UTC 1970
% 

>  -	@$(call ised,"s/{{ANTIGEN_REVISION}}/$$(git log -n1 --format=%h -- src)/",${TARGET})
>  -	@$(call ised,"s/{{ANTIGEN_REVISION_DATE}}/$$(git log -n1 --format='%ai' -- src)/",${TARGET})
>  +	@$(call ised,"s/{{ANTIGEN_REVISION}}/Debian/",${TARGET})

Tangentially, Michael, here you might consider changing the hardcoded
"Debian" to the package version, $$(dpkg-parsechangelog -SVersion).  The
zsh and zsh-syntax-highlighting packages do this, too.

Cheers,

Daniel
(not subscribed to the bug, please Cc)

Message #15 received at 911757@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Daniel Shahaf <danielsh@apache.org>

Cc: 911757@bugs.debian.org

Subject: Re: zsh-antigen: please make the build reproducible

Date: Wed, 24 Oct 2018 14:43:23 -0400

[Message part 1 (text/plain, inline)]

Hi Daniel,

> Chris, are you sure that's right?  According to date(1), the --date
> option takes an argument, so that would seem to take "--utc" as the date
> to parse

Mea culpa.

I think what happened was that as it was a patch-to-a-patch I
either a) made the change I attached quasi-manually and I made a
mistake or b) I just screwed up and the error message itself made
the package reproducible.

As in:

  date: the argument ‘@1’ lacks a leading '+';

… is, of course, the same in all timezones. *grin*

Updated patch attached. Thanks for your careful review, extremely
appreciated.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[zsh-antigen.diff.txt (text/plain, attachment)]

Message #20 received at 911757@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 911757@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#911757: zsh-antigen: please make the build reproducible

Date: Fri, 04 Sep 2020 22:58:03 -0000

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #25 received at 911757@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 911757@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#911757: zsh-antigen: please make the build reproducible

Date: Fri, 04 Dec 2020 17:51:03 -0000

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #30 received at 911757-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 911757-close@bugs.debian.org

Subject: Bug#911757: fixed in zsh-antigen 2.2.3-3

Date: Fri, 04 Dec 2020 21:31:28 +0000

Source: zsh-antigen
Source-Version: 2.2.3-3
Done: Michael Fladischer <fladi@debian.org>

We believe that the bug you reported is fixed in the latest version of
zsh-antigen, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 911757@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Fladischer <fladi@debian.org> (supplier of updated zsh-antigen package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 04 Dec 2020 21:21:35 +0100
Source: zsh-antigen
Architecture: source
Version: 2.2.3-3
Distribution: unstable
Urgency: medium
Maintainer: Michael Fladischer <fladi@debian.org>
Changed-By: Michael Fladischer <fladi@debian.org>
Closes: 911757
Changes:
 zsh-antigen (2.2.3-3) unstable; urgency=medium
 .
   * Update patch to use UTC timestamp and Debian revision to support
     reproducible builds (Closes: #911757).
   * Bump debhelper version to 13.
   * Bump Standards-Version to 4.5.1.
   * Use uscan version 4.
   * Switch to debhelper-compat.
   * Set Rules-Requires-Root: no.
   * Add d/upstream/metadata.
   * Remove renamed lintian override for missing GPG key.
Checksums-Sha1:
 e804b4dbad0c06cca934fb29edb0aa5d1a4e6a02 1517 zsh-antigen_2.2.3-3.dsc
 10e7374f40ce26c447f0bdf161e5faafd9f58462 3712 zsh-antigen_2.2.3-3.debian.tar.xz
 16d0c9e5752257ce828fe7774d8f76da97257dfa 6515 zsh-antigen_2.2.3-3_amd64.buildinfo
Checksums-Sha256:
 44dfa74a2af1a7180bb1c076708b4963c29916c2dcccaa34f7b43df006daf95c 1517 zsh-antigen_2.2.3-3.dsc
 2c99bf15521869d581b2eebc562f32be08652278ec2e47749badef2d8ae4e4d4 3712 zsh-antigen_2.2.3-3.debian.tar.xz
 c06a228aa3e5b195b2d5957b076c5082f0b7a3cc85fe6a8b7c1379385873a117 6515 zsh-antigen_2.2.3-3_amd64.buildinfo
Files:
 1148d8e8e2d7160ccfd9ba4d946ceed3 1517 shells optional zsh-antigen_2.2.3-3.dsc
 8387b211b98b4171d6f17d8985d1736f 3712 shells optional zsh-antigen_2.2.3-3.debian.tar.xz
 da27851414bbea15ef34f937d3085e24 6515 shells optional zsh-antigen_2.2.3-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEqVSlRXW87UkkCnJc/9PIi5l90WoFAl/KnUsACgkQ/9PIi5l9
0Wp7dggAlIzbkhph/HGn9ydWJr4y4S2Zw0Zn7QWRRMFq6fXEy+wsDY2M/1LQZ46c
WzUU1qcZ5fwUKHKOXopXLR6Dy/oEzG12PVAv3P1Konvx+hv2TfWJq8gfIw+9ASXY
d4PC8Y1+qg+xVKxQ8aWU2XrVZHmy2idCuJnDZZ4QbfBwtsUO9BCMdrqG+9RulSs2
yOv+6dV9z6V1cUdGBDPAZx2hpVhru4t6Fm1uC7m1grKsxLt6/I5glj3JZcQULZNh
MwBZiX8wb9i+LoTWn5xWxJIBuQx6KNKD7GrxCHGKlfJbC65X5hNDe0ydHwvHKwRI
EJHYySVip8op8cuW3HJqEDtrRn4ogg==
=YNoE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.