Debian Bug report logs - #911561
BreakBeforeBraces: Stroustrup does not break after struct/class

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Marius Mikucionis <mmikucionis@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Sun, 21 Oct 2018 22:09:53 +0200

Package: clang-format-8
Version: 1:8~svn343154-1
Severity: minor

Dear Maintainer,

Here is my sample file format.h:

class test {
	int one, two;
	test(int one, int two): one{one}, two{two} {}
};

The following command line produces the following output:

clang-format-8 -style="{BreakBeforeBraces: Stroustrup}" format.h
class test {
  int one, two;
  test(int one, int two) : one{one}, two{two} {}
};

Note that there is no line break after "class test" as described in documentation:
http://clang.llvm.org/docs/ClangFormatStyleOptions.html

As workaround, I can fallback to custom, which works, but it's more verbose:

clang-format-8 -style="{BreakBeforeBraces: Custom, BraceWrapping: {AfterClass: true, AfterStruct: true} }" format.h
class test
{
  int one, two;
  test(int one, int two) : one{one}, two{two} {}
};

I have tested with version 7 and 6, and they behave identically, which is strange.

Best regards,
Marius

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'stable'), (500, 'oldstable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages clang-format-8 depends on:
ii  libc6       2.27-6
ii  libgcc1     1:8.2.0-8
ii  libllvm8    1:8~svn343154-1
ii  libstdc++6  8.2.0-8
ii  python      2.7.15-3

clang-format-8 recommends no packages.

clang-format-8 suggests no packages.

-- no debconf information

Message #10 received at 911561@bugs.debian.org (full text, mbox, reply):

From: Sylvestre Ledru <s@mozilla.com>

To: Marius Mikucionis <mmikucionis@gmail.com>, 911561@bugs.debian.org

Subject: Re: Bug#911561: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Sun, 21 Oct 2018 22:20:35 +0200

Le 21/10/2018 à 22:09, Marius Mikucionis a écrit :
> Package: clang-format-8
> Version: 1:8~svn343154-1
> Severity: minor
[...]
> I have tested with version 7 and 6, and they behave identically, which is strange.

You mean that it is a regression with 8 or 6/7 have the same issue ?

S

Message #15 received at 911561@bugs.debian.org (full text, mbox, reply):

From: Marius Mikučionis <mmikucionis@gmail.com>

To: Sylvestre Ledru <s@mozilla.com>

Cc: 911561@bugs.debian.org

Subject: Re: Bug#911561: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Sun, 21 Oct 2018 22:23:29 +0200

[Message part 1 (text/plain, inline)]

On Sun, 21 Oct 2018, 22.20 Sylvestre Ledru <s@mozilla.com> wrote:

>
> Le 21/10/2018 à 22:09, Marius Mikucionis a écrit :
> > Package: clang-format-8
> > Version: 1:8~svn343154-1
> > Severity: minor
> [...]
> > I have tested with version 7 and 6, and they behave identically, which
> is strange.
>
> You mean that it is a regression with 8 or 6/7 have the same issue ?
>


They all have the same issue, so this is very old, seems broken and
untested upstream.

Marius

[Message part 2 (text/html, inline)]

Message #20 received at 911561@bugs.debian.org (full text, mbox, reply):

From: Sylvestre Ledru <s@mozilla.com>

To: Marius Mikučionis <mmikucionis@gmail.com>, 911561@bugs.debian.org

Subject: Re: Bug#911561: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Sun, 21 Oct 2018 22:30:16 +0200

[Message part 1 (text/plain, inline)]

Le 21/10/2018 à 22:23, Marius Mikučionis a écrit :
>
>
> On Sun, 21 Oct 2018, 22.20 Sylvestre Ledru <s@mozilla.com
> <mailto:s@mozilla.com>> wrote:
>
>
>     Le 21/10/2018 à 22:09, Marius Mikucionis a écrit :
>     > Package: clang-format-8
>     > Version: 1:8~svn343154-1
>     > Severity: minor
>     [...]
>     > I have tested with version 7 and 6, and they behave identically,
>     which is strange.
>
>     You mean that it is a regression with 8 or 6/7 have the same issue ?
>
>
>
> They all have the same issue, so this is very old, seems broken and
> untested upstream. 

Could you point to the Stroustrup coding style doc about this aspect?

About the issue itself, new reasons: when new options are added, default
for some CS
can be incorrect. I am not sure also how much Stroustrup is still used
(therefor tested)

Cheers

S

[Message part 2 (text/html, inline)]

Message #25 received at 911561@bugs.debian.org (full text, mbox, reply):

From: Marius Mikučionis <mmikucionis@gmail.com>

To: Sylvestre Ledru <s@mozilla.com>

Cc: 911561@bugs.debian.org

Subject: Re: Bug#911561: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Sun, 21 Oct 2018 22:35:22 +0200

[Message part 1 (text/plain, inline)]

On Sun, 21 Oct 2018, 22.30 Sylvestre Ledru <s@mozilla.com> wrote:

>
> Le 21/10/2018 à 22:23, Marius Mikučionis a écrit :
>
>
>
> On Sun, 21 Oct 2018, 22.20 Sylvestre Ledru <s@mozilla.com> wrote:
>
>>
>> Le 21/10/2018 à 22:09, Marius Mikucionis a écrit :
>> > Package: clang-format-8
>> > Version: 1:8~svn343154-1
>> > Severity: minor
>> [...]
>> > I have tested with version 7 and 6, and they behave identically, which
>> is strange.
>>
>> You mean that it is a regression with 8 or 6/7 have the same issue ?
>>
>
>
> They all have the same issue, so this is very old, seems broken and
> untested upstream.
>
> Could you point to the Stroustrup coding style doc about this aspect?
>

I followed this doc:
http://clang.llvm.org/docs/ClangFormatStyleOptions.html

(search for Stroustrup to scroll to the relevant section)

About the issue itself, new reasons: when new options are added, default
> for some CS
> can be incorrect. I am not sure also how much Stroustrup is still used
> (therefor tested)
>
> Cheers
>
> S
>
>

[Message part 2 (text/html, inline)]

Message #32 received at 911561@bugs.debian.org (full text, mbox, reply):

From: Sylvestre Ledru <sylvestre@debian.org>

To: Marius Mikučionis <mmikucionis@gmail.com>, 911561@bugs.debian.org

Subject: Re: Bug#911561: BreakBeforeBraces: Stroustrup does not break after struct/class

Date: Fri, 26 Oct 2018 09:30:13 +0200

Le 21/10/2018 à 22:35, Marius Mikučionis a écrit :
> 
> 
> On Sun, 21 Oct 2018, 22.30 Sylvestre Ledru <s@mozilla.com <mailto:s@mozilla.com>> wrote:
> 
> 
>     Le 21/10/2018 à 22:23, Marius Mikučionis a écrit :
>>
>>
>>     On Sun, 21 Oct 2018, 22.20 Sylvestre Ledru <s@mozilla.com <mailto:s@mozilla.com>> wrote:
>>
>>
>>         Le 21/10/2018 à 22:09, Marius Mikucionis a écrit :
>>         > Package: clang-format-8
>>         > Version: 1:8~svn343154-1
>>         > Severity: minor
>>         [...]
>>         > I have tested with version 7 and 6, and they behave identically, which is strange.
>>
>>         You mean that it is a regression with 8 or 6/7 have the same issue ?
>>
>>
>>
>>     They all have the same issue, so this is very old, seems broken and untested upstream. 
> 
>     Could you point to the Stroustrup coding style doc about this aspect?
> 
> 
> I followed this doc:
> http://clang.llvm.org/docs/ClangFormatStyleOptions.html
> 
> (search for Stroustrup to scroll to the relevant section) 

This was a documentation issue. The new doc matches the Stroustrup CS now.
I landed the fix upstream here:
https://reviews.llvm.org/rL345371

S

Message #37 received at 911561-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 714686-done@bugs.debian.org,758777-done@bugs.debian.org,831853-done@bugs.debian.org,910450-done@bugs.debian.org,911561-done@bugs.debian.org,912998-done@bugs.debian.org,

Cc: llvm-toolchain-snapshot@packages.debian.org

Subject: Bug#913464: Removed package(s) from unstable

Date: Sun, 18 Nov 2018 17:30:13 +0000

Version: 1:8~svn343154-1+rm

Dear submitter,

as the package llvm-toolchain-snapshot has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/913464

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

Send a report that this bug log contains spam.