Debian Bug report logs - #911036
partman-lvm: Volume group name "■" has invalid characters, and cannot removed

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: submit@bugs.debian.org

Subject: partman-lvm: Volume group name "■" has invalid characters, and cannot removed

Date: Mon, 15 Oct 2018 09:46:16 +0900

Package: partman-lvm
Version: 124
Severity: important
tags: d-i

Hi,

 While installing with d-i buster alpha3, I've tried to remove Logical Volume
 but couldn't. At VT4 shows below error

> partman-lvm:    Volume group name "■" has invalid characters
> partman-lvm:    Cannot process volume group ■

 However, LV names are "home", "root" and "swap_1", not "■".
 ("■" may be mojibake?)


># lvscan
>  ACTIVE        '/dev/elitebook830-vg/root' [<27.94 GiB] inherit
>  ACTIVE        '/dev/elitebook830-vg/swap_1' [<31.84 GiB] inherit
>  ACTIVE        '/dev/elitebook830-vg/home' [<893.34 GiB] inherit

 And "lvremove /dev/elitebook830-vg/{root,swap_1,home}" works well at VT2.


-- 
Regards,

 Hideki Yamane     henrich @ debian.org/iijmio-mail.jp

Message #10 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Tue, 16 Oct 2018 12:38:30 +0900

Hi,

 Here's a step to reproduce this bug
-----------------------------------------------------------------------
1. boot from d-i media and start installer
2. create encrypted LVM volume
3. select "go back" and "Change language" to "Japanese" 
   (or other multi-byte locale)
4. select "論理ボリュームマネージャーの設定 (Configure the Logical Volume Manager)"
    -> "論理ボリュームの削除 (Delete logical volue)" and any volume
5. Got error
6. select "戻る (go back) and "言語の選択/Change language" to "English"
7. select "Configure the Logical Volume Manager"
   -> "Delete logical volume" and any volume
8. you can delete it without error!


-- 
Hideki Yamane <henrich@iijmio-mail.jp>

Message #15 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Tue, 16 Oct 2018 23:27:19 +0900

control: tags -1 +patch

On Tue, 16 Oct 2018 12:38:30 +0900
Hideki Yamane <henrich@iijmio-mail.jp> wrote:
>  Here's a step to reproduce this bug

 And here's a proposed patch, please review it.
 https://salsa.debian.org/installer-team/partman-lvm/merge_requests/1


-- 
Hideki Yamane <henrich@iijmio-mail.jp>

Message #24 received at 911036-close@bugs.debian.org (full text, mbox, reply):

From: Holger Wansing <hwansing@mailbox.org>

To: 911036-close@bugs.debian.org

Subject: Bug#911036: fixed in partman-lvm 125

Date: Mon, 24 Dec 2018 13:35:05 +0000

Source: partman-lvm
Source-Version: 125

We believe that the bug you reported is fixed in the latest version of
partman-lvm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 911036@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Wansing <hwansing@mailbox.org> (supplier of updated partman-lvm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 24 Dec 2018 14:07:43 +0100
Source: partman-lvm
Binary: partman-lvm
Architecture: source
Version: 125
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Holger Wansing <hwansing@mailbox.org>
Description:
 partman-lvm - Adds support for LVM to partman (udeb)
Closes: 911036
Changes:
 partman-lvm (125) unstable; urgency=medium
 .
   * Team upload
 .
   [ Hideki Yamane ]
   * Fix invalid characters in volume group names (Closes: #911036).
 .
   [ Holger Wansing ]
   * Remove trailing whitespaces from changelog file, to fix lintian tag.
 .
   [ Updated translations ]
   * Arabic (ar.po) by ButterflyOfFire
   * Finnish (fi.po) by Juhani Numminen
   * Latvian (lv.po) by Tranzistors
Checksums-Sha1:
 df1c42902b433da5b84e5d4ee9c512188a21283f 1721 partman-lvm_125.dsc
 7d8c46354e64682e28d312950f6d73fbcc22919f 251640 partman-lvm_125.tar.xz
 9509ff73ec0d0776bf5941a0ff7981b0c96ec245 5285 partman-lvm_125_amd64.buildinfo
Checksums-Sha256:
 1dd8dd21c44e5a0c9d3ec07ddd70c6830130a53e87debbabe0bc94d99be244e8 1721 partman-lvm_125.dsc
 46e2285c81f37b510629199a8c26f128413795ac580d40349a20badc28f35fc2 251640 partman-lvm_125.tar.xz
 0b8a2e80b77393c14b759bbff41a11084f8e6911c64ce1aacc2f75ace3055772 5285 partman-lvm_125_amd64.buildinfo
Files:
 0612460617909e47b901d3bb3f0ba4cf 1721 debian-installer optional partman-lvm_125.dsc
 db4f9acfe24e538622f016bde60c1c49 251640 debian-installer optional partman-lvm_125.tar.xz
 77b48ca348e09af306f811db98903ce8 5285 debian-installer optional partman-lvm_125_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEESWrG6BRCSzSFCDUpWfGHyhVusHYFAlwg3QcVHGh3YW5zaW5n
QG1haWxib3gub3JnAAoJEFnxh8oVbrB2OksQALI7wd2TzYc7+f0LM7qhKMRWdaVd
KCPOR3JBsCiWFZnbde2io0v8wzyxKwif4JJMcxwnV0gL5W4CO8TqMggAs2/s2jCM
y3dRANECbhn5PWLGYMUmNMauCFfIP/NXkGc7JQHM2/AmSlyubF/XIDpZchMXQH6M
jDTe2NCIPm2tVbGRS0BWnSA4dA6jF9GZ/sOU2PjsoGkJiAr0M/mQSPbSqZv6xUIU
P8h7JNCbLAk7JACvmN6kPIGtrZZTb4BghGHYGu3jhTDYMqxllMyTTWfs4F5SNuLS
osYSNCEw4TgdeLeFWP7rXfK2cJJd2Sh69EBpdTwIu8FtKkYl6jnvJBnHSw7XysHr
0N3wBRQakz4RPHZweLuhaR6CtD+qcrF6fd6wCR3KY8X/L1esTniBOrGSmYdh02sS
rEmy+Y/5rHKMxLGTYtIwGW87XIjFyF5IWHdPbKlsZUiMWv6yFmHQPHnAOwQRPKsr
IoLD0b+2EhFlltZDI9i95dHAp4jpuH37h9pJqKV+35MppQrK6DEqUEkXzOHsrw0f
9gWQkMZuo+rOYBmpIJr9rwM9X4HNcoHg2GeKGt/4YoTpktS9NW0BOEvPXcYv25/0
+Gw0xtAKzkN8L3KGl9vySLY3abHi0TjEPGADM5bnLmJlMkKRRjZtYv9AzVIuPFUh
aREV0R+voDvkPiD/
=v6sv
-----END PGP SIGNATURE-----

Message #33 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <steve@einval.com>

To: Hideki Yamane <henrich@iijmio-mail.jp>, 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Tue, 12 Feb 2019 02:16:30 +0000

Control: reopen -1

Hi Hideki,

I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
causing problems for other people trying to use LVM in d-i. See
#922100, which I've just confirmed locally.

Code:

--- a/choose_partition/lvm/do_option
+++ b/choose_partition/lvm/do_option
@@ -471,7 +471,9 @@ do_lv_delete() {
                db_subst partman-lvm/text/lvdelete_invg VG "$vg"
                db_metaget partman-lvm/text/lvdelete_invg description
                lv_get_info "$vg" "$lv"
-               output=$(printf "%-30s (%sMB - %s)" "$lv" "$SIZE" "$RET")
+               # In non-latin locale environment, $RET contains extra characters
+               # clean it as valid ascii characters name
+               output=$(printf "%-30s (%sMB - %s)" "$lv" "$SIZE" "$(echo $RET | sed -e 's/^VG//' -e 's/[^-+_\.[:alnum:]]//g')")
                lvs="${lvs:+$lvs, }$output"
        done

In my test VM, I've added debug to see what $RET is before the sed
acts on it. I'm seeing that $RET is "in VG debian-vg", and after your
sed code it's "inVGdebian-vg". Maybe it should look something more
like:

  "$(echo $RET | sed -e 's/^.*VG//' -e 's/[^-+_\.[:alnum:]]//g')"

?? Please test this some more and see if you can fix it?

On Tue, Oct 16, 2018 at 12:38:30PM +0900, Hideki Yamane wrote:
>Hi,
>
> Here's a step to reproduce this bug
>-----------------------------------------------------------------------
>1. boot from d-i media and start installer
>2. create encrypted LVM volume
>3. select "go back" and "Change language" to "Japanese" 
>   (or other multi-byte locale)
>4. select "論理ボリュームマネージャーの設定 (Configure the Logical Volume Manager)"
>    -> "論理ボリュームの削除 (Delete logical volue)" and any volume
>5. Got error
>6. select "戻る (go back) and "言語の選択/Change language" to "English"
>7. select "Configure the Logical Volume Manager"
>   -> "Delete logical volume" and any volume
>8. you can delete it without error!
>
>
>-- 
>Hideki Yamane <henrich@iijmio-mail.jp>
>
>
-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
"Arguing that you don't care about the right to privacy because you have
 nothing to hide is no different than saying you don't care about free
 speech because you have nothing to say."
   -- Edward Snowden

Message #40 received at 911036-submitter@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <noreply@salsa.debian.org>

To: 911036-submitter@bugs.debian.org

Subject: Bug #911036 in partman-lvm marked as pending

Date: Wed, 13 Feb 2019 17:56:04 +0000

Control: tag -1 pending

Hello,

Bug #911036 in partman-lvm reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/installer-team/partman-lvm/commit/50fa12610ab7fe9e32f5540c374a3cf6fbfe3c64

------------------------------------------------------------------------
Revert "fix Invalid characters in Volume group name (Closes: #911036)"

This reverts commit 0ee8d363fd272f0e8879d137c1b48d43c59f02fa.

This change does not work, and is causing other bugs.
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/911036

Message #47 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <steve@einval.com>

To: Hideki Yamane <henrich@iijmio-mail.jp>, 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Wed, 13 Feb 2019 18:00:36 +0000

Hi Hideki,

On Tue, Feb 12, 2019 at 02:16:30AM +0000, Steve McIntyre wrote:
>Control: reopen -1
>
>Hi Hideki,
>
>I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
>causing problems for other people trying to use LVM in d-i. See
>#922100, which I've just confirmed locally.

I've reverted your change for now - we've already had 2 bug
reports. Please test and fix as/when you can.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
  Getting a SCSI chain working is perfectly simple if you remember that there
  must be exactly three terminations: one on one end of the cable, one on the
  far end, and the goat, terminated over the SCSI chain with a silver-handled
  knife whilst burning *black* candles. --- Anthony DeBoer

Message #52 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: Steve McIntyre <steve@einval.com>

Cc: 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Sat, 16 Feb 2019 20:30:00 +0900

Hi Steve,

On Wed, 13 Feb 2019 18:00:36 +0000
Steve McIntyre <steve@einval.com> wrote:
> >I'm afraid your fix in choose_partition/lvm/do_option is broken. It's
> >causing problems for other people trying to use LVM in d-i. See
> >#922100, which I've just confirmed locally.
> 
> I've reverted your change for now - we've already had 2 bug
> reports. Please test and fix as/when you can.

 Sorry for the delay, I've made and tested new patch for it as
 https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2

 Could you check it, please?


-- 
Hideki Yamane <henrich@iijmio-mail.jp>

Message #57 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Sun, 3 Mar 2019 21:19:59 +0900

On Sat, 16 Feb 2019 20:30:00 +0900
Hideki Yamane <henrich@iijmio-mail.jp> wrote:
>  Sorry for the delay, I've made and tested new patch for it as
>  https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2

 Can someone review it? > -boot


-- 
Regards,

 Hideki Yamane     henrich @ debian.org/iijmio-mail.jp

Message #62 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Hideki Yamane <henrich@iijmio-mail.jp>, 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Sun, 3 Mar 2019 17:20:30 +0100

[Message part 1 (text/plain, inline)]

Hi,

Hideki Yamane <henrich@iijmio-mail.jp> (2019-03-03):
> On Sat, 16 Feb 2019 20:30:00 +0900
> Hideki Yamane <henrich@iijmio-mail.jp> wrote:
> >  Sorry for the delay, I've made and tested new patch for it as
> >  https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2
> 
>  Can someone review it? > -boot

I'd rather avoid testing more things at this stage.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #67 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Hideki Yamane <henrich@iijmio-mail.jp>

To: Cyril Brulebois <kibi@debian.org>, 911036@bugs.debian.org

Cc: 911036@bugs.debian.org

Subject: Re: Bug#911036: Acknowledgement (partman-lvm: Volume group name "■" has invalid characters, and cannot removed)

Date: Thu, 7 Mar 2019 15:44:51 +0900

On Sun, 3 Mar 2019 17:20:30 +0100
Cyril Brulebois <kibi@debian.org> wrote:
> I'd rather avoid testing more things at this stage.

 ;-(

 Okay, when the window will be opened for it, then? I'm curious.


-- 
Hideki Yamane <henrich@iijmio-mail.jp>

Message #72 received at 911036@bugs.debian.org (full text, mbox, reply):

From: Andy Simpkins <rattusrattus@debian.org>

To: 911036@bugs.debian.org

Subject: reproducing bug / testing

Date: Sat, 9 Mar 2019 14:19:05 +0000

[Message part 1 (text/plain, inline)]

Confirmed in DI daily build debian-testing-amd64-netinst.iso dated
2019-03-09 11:14

About to test with your patch at
https://salsa.debian.org/installer-team/partman-lvm/merge_requests/2

(waiting for build)

/Andy

[signature.asc (application/pgp-signature, attachment)]

Message #75 received at 911036-submitter@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <noreply@salsa.debian.org>

To: 911036-submitter@bugs.debian.org

Subject: Bug #911036 in partman-lvm marked as pending

Date: Sat, 09 Mar 2019 18:03:03 +0000

Control: tag -1 pending

Hello,

Bug #911036 in partman-lvm reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/installer-team/partman-lvm/commit/ff30dc20307e982631b13b0870d6be322032f2d3

------------------------------------------------------------------------
Really fix invalid characters in volume group names

Second attempt, now Closes: #911036.

Thanks to Andy Simpkins for helping to test.
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/911036

Message #78 received at 911036-submitter@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <noreply@salsa.debian.org>

To: 911036-submitter@bugs.debian.org

Subject: Bug #911036 in partman-lvm marked as pending

Date: Sat, 09 Mar 2019 18:03:03 +0000

Control: tag -1 pending

Hello,

Bug #911036 in partman-lvm reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/installer-team/partman-lvm/commit/efcb8d53001a8491618d9d657b9fec638c87c0b3

------------------------------------------------------------------------
use $vg itself instead of it is from description (Closes: #911036)

It seems that $RET is expected to get $vg value, so using
description is unnecessary and cause problem with l10n-ed one,
just use $vg is enough, IMHO.

Tested on d-i alpha4 (reverted one) and works fine with English
and Japanese locale.
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/911036

Message #83 received at 911036-close@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <93sam@debian.org>

To: 911036-close@bugs.debian.org

Subject: Bug#911036: fixed in partman-lvm 129

Date: Sat, 09 Mar 2019 18:20:14 +0000

Source: partman-lvm
Source-Version: 129

We believe that the bug you reported is fixed in the latest version of
partman-lvm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 911036@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve McIntyre <93sam@debian.org> (supplier of updated partman-lvm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 09 Mar 2019 15:11:46 +0000
Source: partman-lvm
Architecture: source
Version: 129
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Steve McIntyre <93sam@debian.org>
Closes: 911036
Changes:
 partman-lvm (129) unstable; urgency=medium
 .
   [ Hideki Yamane ]
   * Really fix invalid characters in volume group names (Closes: #911036).
     Thanks to Andy Simpkins for helping to test.
Checksums-Sha1:
 80b1da46fb30a71ab5882fd028c3e182a4a48dbf 1717 partman-lvm_129.dsc
 a538ea92512f04d1b70fed4affc997b4144853f8 251604 partman-lvm_129.tar.xz
 5d2cabc32a8a6d3de79bc6d2852bb67c07ea91d0 4966 partman-lvm_129_source.buildinfo
Checksums-Sha256:
 677524e7fc115b4a0b8bdb9d434527ae67b3eaaa90ee584daf3a9e7a564aada0 1717 partman-lvm_129.dsc
 5f4e8f6b3d4d30552e5f813a1a578a852b2a1250b50c1867844426d75a2f7af5 251604 partman-lvm_129.tar.xz
 5dfa90c5f2f512b43b36806efd108b3117383a81b8dfa58ca9922b1cdd20291b 4966 partman-lvm_129_source.buildinfo
Files:
 7639e095acf1430a1c027dc4e0e45fe6 1717 debian-installer optional partman-lvm_129.dsc
 026e18262d2c41715b2037b30e93bb72 251604 debian-installer optional partman-lvm_129.tar.xz
 cf83e45c50efcbbf5c1456471396d562 4966 debian-installer optional partman-lvm_129_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEzrtSMB1hfpEDkP4WWHl5VzRCaE4FAlyEACARHDkzc2FtQGRl
Ymlhbi5vcmcACgkQWHl5VzRCaE7HcA//VlAavjeXLU0DHwh2lCcqWkHCGGOO+xeV
zX8k0j7G/g5pL5QPQofJ3iB/ijEBjzVVEvqTggJKMLB5jhxF2GdEsABC291/6T/p
deta3T/S4SWwzzNmrNnopAA3hWN45Q/qJzjAX2qqD2qIKFBaOzpRfuu/7Z3n2ONR
T3LlKrREu9xkWU75TFMztiOf/KmmGa/THe32kUOM+oCDkUHJwEDcns8Bo3wHA0oX
CrXcWX7Zsg8iRI+XK21QaauKzczH2XJpyb7dEOmNKbwpzwfyY7yYdUvj5RP4vxEm
woiWoxOX9jFHnph/TuSSaDeSqO/eGTMBs9yreVmRin+7Q2maFN9mW2A2W4b/t2mq
uSwP6t6FVYGSJBeTq9XkS1nITrylUOvcb98qNCYD2y3N4gWNywmfONPX72H8JFaX
tl9VnVqwNa3ndaAUfLLJYAe07GoQvMzY9jfdSEn0SjCUZnBpYpn88k+Z2giKlGpw
pzPTENbY+vp+8vo0f8o6MZ/I6xiIFUWv5Nf9c1IcWv5Tjz2wXatRN+FUoxefM+nd
Qdh42RCVmJEyg+RDaXYINc7b3ssBMBmd8YPmW15iXyrMe2f0QY8elVu77wKhmJgC
FGJMBT+TAtmn5lBmzQTWP8Q/D8HVUAcfN0xRxxTUpq4YhxgPgLWymA5M4Bc4Pafe
wWf6P71+x8M=
=yK/j
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.