Debian Bug report logs - #909782
libinput: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: libinput: please make the build reproducible

Date: Fri, 28 Sep 2018 09:21:37 +0100

[Message part 1 (text/plain, inline)]

Source: libinput
Version: 1.12.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that libinput could not be built reproducibly.

This is due to the LIBINPUT_QUIRKS_SRCDIR config.h variable including
the absolute build path to find the test-time input file.

Patch attached that uses a relative path instead. I'm not sure upstream
will like this patch, it is provided mostly as a demonstration
ofthe problem. However perhaps it could be modified to take an
environment variable instead? I will leave this with you.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[libinput.diff.txt (text/plain, attachment)]

Message #10 received at 909782@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 909782@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#909782: libinput: please make the build reproducible

Date: Mon, 31 Aug 2020 07:03:38 -0400 (EDT)

Dear Maintainer,

> Source: libinput
> Version: 1.12.6-2+deb10u1
> Tags: patch

There hasn't seem to be any update on this bug in 703 days, in which
time the Reproducible Builds effort has come on a long way.

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 909782@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Chris Lamb <lamby@debian.org>, 909782@bugs.debian.org

Subject: Re: Bug#909782: libinput: please make the build reproducible

Date: Wed, 9 Sep 2020 11:55:28 +0200

Control: tag -1 - patch
Control: tag -1 + upstream

On Mon, Aug 31, 2020 at 07:03:38AM -0400, Chris Lamb wrote:
> Dear Maintainer,
> 
> > Source: libinput
> > Version: 1.12.6-2+deb10u1
> > Tags: patch
> 
> There hasn't seem to be any update on this bug in 703 days, in which
> time the Reproducible Builds effort has come on a long way.
> 
> Would you consider applying this patch and uploading?
> 
The patch doesn't seem quite right, so I don't think we should apply it
as-is.  It seems to me LIBINPUT_QUIRKS_SRCDIR shouldn't be in the
shipped packages at all, so a patch that fixes that and can be sent
upstream would be better.

Cheers,
Julien

Message #24 received at 909782@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Julien Cristau" <jcristau@debian.org>, 909782@bugs.debian.org

Subject: Re: Bug#909782: libinput: please make the build reproducible

Date: Wed, 09 Sep 2020 12:02:03 -0000

Hi Julien,

> The patch doesn't seem quite right, so I don't think we should apply it
> as-is.  It seems to me LIBINPUT_QUIRKS_SRCDIR shouldn't be in the
> shipped packages at all, so a patch that fixes that and can be sent
> upstream would be better.

I would agree. I blame "2018 lamby" for his shortsightedness. Hopefully
someone can step up and write/submit this patch.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #29 received at 909782@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 909782@bugs.debian.org

Subject: Re: Bug#909782: libinput: please make the build reproducible

Date: Thu, 10 Sep 2020 11:39:13 +0200

Hi Chris,

On Wed, Sep 09, 2020 at 12:02:03PM -0000, Chris Lamb wrote:
> Hi Julien,
> 
> > The patch doesn't seem quite right, so I don't think we should apply it
> > as-is.  It seems to me LIBINPUT_QUIRKS_SRCDIR shouldn't be in the
> > shipped packages at all, so a patch that fixes that and can be sent
> > upstream would be better.
> 
> I would agree. I blame "2018 lamby" for his shortsightedness. Hopefully
> someone can step up and write/submit this patch.
> 
I thank "2018 lamby" for filing this and pointing out the issue :)
No blame necessary.

Cheers,
Julien

Message #34 received at 909782-done@bugs.debian.org (full text, mbox, reply):

From: Sven Joachim <svenjoac@gmx.de>

To: Julien Cristau <jcristau@debian.org>

Cc: Chris Lamb <lamby@debian.org>, 909782-done@bugs.debian.org

Subject: Re: Bug#909782: libinput: please make the build reproducible

Date: Fri, 11 Sep 2020 21:37:21 +0200

Package: libinput
Version: 1.16.1-1

On 2020-09-09 11:55 +0200, Julien Cristau wrote:

> Control: tag -1 - patch
> Control: tag -1 + upstream
>
> On Mon, Aug 31, 2020 at 07:03:38AM -0400, Chris Lamb wrote:
>> Dear Maintainer,
>>
>> > Source: libinput
>> > Version: 1.12.6-2+deb10u1
>> > Tags: patch
>>
>> There hasn't seem to be any update on this bug in 703 days, in which
>> time the Reproducible Builds effort has come on a long way.
>>
>> Would you consider applying this patch and uploading?
>>
> The patch doesn't seem quite right, so I don't think we should apply it
> as-is.  It seems to me LIBINPUT_QUIRKS_SRCDIR shouldn't be in the
> shipped packages at all, so a patch that fixes that and can be sent
> upstream would be better.

Apparently this is no longer necessary, for I could not find any
references to that directory in the binary packages.  Building libinput
in two different directories produced identical packages here and on
[1], so I have taken the liberty to close the bug. :-)

Cheers,
       Sven


1. https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libinput.html

Send a report that this bug log contains spam.