Debian Bug report logs - #908900
diffoscope: tests fail with colord 1.4.3

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: diffoscope: tests fail with colord 1.4.3

Date: Sat, 15 Sep 2018 18:03:27 +0100

Package: diffoscope
Version: 101
Severity: important

Since the upload of colord 1.4.3, the diffoscope testsuite fails with:


  =================================== FAILURES ===================================
  __________________________________ test_diff ___________________________________
  
  differences = [<Difference cd-iccdump {} -- cd-iccdump {} []>]
  
      @skip_unless_tools_exist('cd-iccdump')
      def test_diff(differences):
          if 'ne_SU' in differences[0].unified_diff:
              pytest.skip("Endian-specific differences detected; see "
                          "<https://bugs.debian.org/847595>")
      
          expected_diff = get_data('icc_expected_diff')
  >       assert differences[0].unified_diff == expected_diff
  E       AssertionError: assert '@@ -1,20 +1,...4 bytes]\n \n' == '@@ -1,20 +1,2... [24 bytes]\n'
  E           @@ -1,20 +1,20 @@
  E            icc:
  E            Header:
  E              Size		= 14684 bytes
  E              Version	= 4.3
  E              Profile Kind	= display-device
  E              Colorspace	= rgb
  E              Conn. Space	= xyz
  E           -  Date, Time	= 2016-02-15, 21:02:09
  E           +  Date, Time	= 2016-02-15, 21:03:22
  E              Flags		= Not embedded profile, Use anywhere
  E              Dev. Attrbts	= reflective, glossy
  E              Rndrng Intnt	= perceptual
  E              Creator	= lcms
  E         - -  Profile ID	= 0477fa4bb5ae5ae9a778f5cd72eb45a4
  E         - +  Profile ID	= 06017f17ec507191e9d859f2324fca53
  E         + -  Profile ID	= 0x0477fa4b
  E         + +  Profile ID	= 0x06017f17
  E         +  
  E            tag 00:
  E              sig	'desc' [0x64657363]
  E              size	38
  E              type	'mluc' [0x6d6c7563]
  E            Text:
  E              en_US:	sRGB [24 bytes]
  E         -
  

We would normally:

 1. Update the expected diff for this latest version.

 2. Add a minimum version check directive for pytest.

However, the `cd-iccdump` command has no --version command and, whilst
the `colord` binary does, it relies on the daemon running to return any
output.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #10 received at 908900@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 908900@bugs.debian.org

Subject: Re: diffoscope: tests fail with colord 1.4.3

Date: Mon, 17 Sep 2018 08:29:52 +0100

tags 908900 + pending
thanks

Fixed in Git, pending upload:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/b1addb0d00a6e1297e3ab1bf3dcb3af804f4b8b7

  tests/comparators/test_icc.py | 31 +++++++++++++++++++++++++++++--
  tests/data/icc_expected_diff  |  6 +++---
  2 files changed, 32 insertions(+), 5 deletions(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 908900-close@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 908900-close@bugs.debian.org

Subject: Bug#908900: fixed in diffoscope 102

Date: Sun, 23 Sep 2018 09:19:02 +0000

Source: diffoscope
Source-Version: 102

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 908900@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 23 Sep 2018 10:43:40 +0200
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 102
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 908900 909122
Changes:
 diffoscope (102) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Fix tests under colord >= 1.4.3.  Closes: #908900
 .
   [ Xavier Briand ]
   * Add an "Add a comparator" section in CONTRIBUTING.  MR: !9
 .
   [ Mattia Rizzolo ]
   * debian: Use the new debhelper-compat(=11) build dep and drop d/compat.
 .
   [ Marek Marczykowski-Górecki ]
   * comparators/json: Try fuzzy matching for non-text files too.
     This avoids loading very large file just to discover they aren't JSON.
     Closes: #909122
Checksums-Sha1:
 bb80029110f656ed86241bdcb4266bb77749a9c1 4072 diffoscope_102.dsc
 92246250370e173e5b97de98f336214b1e7eee5e 9252320 diffoscope_102.tar.xz
 0d51edabd976683027c534cd5bb604a827acec21 21640 diffoscope_102_amd64.buildinfo
Checksums-Sha256:
 882c29062247ec93d39e5c5180a5539d62bec9c8f5259fa215e225aa0b1ddda2 4072 diffoscope_102.dsc
 ce3f3ef52fc1fea17b31a890c9d9d3b49951e92501f515922f0f756ef64c59cb 9252320 diffoscope_102.tar.xz
 02ec4740f9992630affb1903e6b791a79c0146c57277e055897377d25c0d246e 21640 diffoscope_102_amd64.buildinfo
Files:
 5410095debfd02eddf4b77e4621c98ad 4072 devel optional diffoscope_102.dsc
 75b3c90e33dae8da49cc33c784a7c7aa 9252320 devel optional diffoscope_102.tar.xz
 ba4a04c653164ca0d13e1d36c2e9d00d 21640 devel optional diffoscope_102_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlunVkIACgkQCBa54Yx2
K63JbhAAgzCLLcAp9PomUHUsqnMlmw5JROdsSLb1iCAT6YklAxdWijl4DefGyNFH
zH8gvWgmSyO2kCIqnN6sAiDGJIwkb4CcaKhn6KaiNkucwBRa6kVe7/+2VPlBnGeF
vA76pKogLuvwgRUI1OicKC+5zaWegnlQcUDOKKXbM3srqu1+QvHEEO4Q3F5gXUOi
Vf+SKIYYwvUtY8hy/9ibAA+rHXyefVhJn88Xn335cele9X8soP/t0k1FFJ1NdgJd
Lpi4//w8P+M4eL6ItPVumQWENtekEXrohC5W+aUS6AQJF0/Gb119OGHbXIlYqJvj
sVUxiY4qTF4ETQOBeuBUJAT33Fa3vRH2L2XvVqJLJDlrDTCjBZy3QHkaEapmSDe6
BskX+YYNinK4t1CxRSU0I25JK7PuA67X4jK9NZt8rtMhUK1iNV3+LKxf5Dwf7qC6
o43vAoKfFHFAqwHdBFqHLyAmZmkQ0aBuMPAJ2LyBM3iq1K+Ymv4mDHHAJqfnRk7P
SdkyBg6UZgkOd54UX0vTxT2GSYdAJth6BS/h7ueuNR0L1FrH8qVpJYOTWDoK1H+m
CBX+MPxQmv2PjQzWcMV8YygiCIHEWiz2fvi5j6xaKDaeimgofZkms0IpFSGESMdO
hPZyQ/BlAf34dWcfvdKGOmWK0743ctisSTKRdR2Ba2UD4eqSELE=
=2mIQ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.