Debian Bug report logs - #908309
gdk-pixbuf: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: gdk-pixbuf: please make the build reproducible

Date: Sat, 08 Sep 2018 10:44:35 +0100

[Message part 1 (text/plain, inline)]

Source: gdk-pixbuf
Version: 2.36.12-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that gdk-pixbuf could not be built reproducibly.

This is because "@filename@" gets expanded to the full, absolute path
name. Patch attached that uses "@basename@" instead.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[gdk-pixbuf.diff.txt (text/plain, attachment)]

Message #10 received at 908309@bugs.debian.org (full text, mbox, reply):

From: Hugh McMaster <hugh.mcmaster@outlook.com>

To: "908309@bugs.debian.org" <908309@bugs.debian.org>

Cc: Chris Lamb <lamby@debian.org>

Subject: RE: Regression: gdk-pixbuf: please make the build reproducible

Date: Sun, 9 Sep 2018 06:10:10 +0000

Control: severity -1 important

On Sat, 08 Sep 2018 10:44:35 +0100, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0], we noticed
> that gdk-pixbuf could not be built reproducibly.
>
> This is because "@filename@" gets expanded to the full, absolute path
> name. Patch attached that uses "@basename@" instead.

This is a regression introduced in 2.38.0 and, unfortunately, it breaks
multi-arch support in this package.

In 2.36.12-2, we have the following in /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-enum-types.h:
    /* enumerations from "gdk-pixbuf-core.h" */
    [...]
    /* enumerations from "gdk-pixbuf-transform.h" */

But in 2.38.0, comparing an amd64 build with an i386 build, we see the following:
    -/* enumerations from "/build/gdk-pixbuf-DR2g5f/gdk-pixbuf-2.38.0+dfsg/obj-i686-linux-gnu/../gdk-pixbuf/gdk-pixbuf-core.h" */
    +/* enumerations from "/build/gdk-pixbuf-RzIOsU/gdk-pixbuf-2.38.0+dfsg/obj-x86_64-linux-gnu/../gdk-pixbuf/gdk-pixbuf-core.h" */
    [...]
    -/* enumerations from "/build/gdk-pixbuf-DR2g5f/gdk-pixbuf-2.38.0+dfsg/obj-i686-linux-gnu/../gdk-pixbuf/gdk-pixbuf-transform.h" */
    +/* enumerations from "/build/gdk-pixbuf-RzIOsU/gdk-pixbuf-2.38.0+dfsg/obj-x86_64-linux-gnu/../gdk-pixbuf/gdk-pixbuf-transform.h" */

Chris' patch looks like it should fix this bug.

--
Hugh McMaster

Message #17 received at 908309@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Hugh McMaster <hugh.mcmaster@outlook.com>, 908309@bugs.debian.org

Subject: Re: Regression: gdk-pixbuf: please make the build reproducible

Date: Sun, 09 Sep 2018 10:16:17 +0100

Hi Hugh,

> This is a regression introduced in 2.38.0 and, unfortunately, it breaks
> multi-arch support in this package.
> 
> In 2.36.12-2, we have the following in /usr/include/gdk-pixbuf-2.0/gdk-
> pixbuf/gdk-pixbuf-enum-types.h:
>     /* enumerations from "gdk-pixbuf-core.h" */
>     [...]
>     /* enumerations from "gdk-pixbuf-transform.h" */

Given that it is "just" a difference in a comment, how does this break
multi-arch support?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #22 received at 908309@bugs.debian.org (full text, mbox, reply):

From: Sven Joachim <svenjoac@gmx.de>

To: Chris Lamb <lamby@debian.org>

Cc: Hugh McMaster <hugh.mcmaster@outlook.com>, 908309@bugs.debian.org

Subject: Re: Bug#908309: Regression: gdk-pixbuf: please make the build reproducible

Date: Sun, 09 Sep 2018 11:32:33 +0200

On 2018-09-09 10:16 +0100, Chris Lamb wrote:

> Hi Hugh,
>
>> This is a regression introduced in 2.38.0 and, unfortunately, it breaks
>> multi-arch support in this package.
>> 
>> In 2.36.12-2, we have the following in /usr/include/gdk-pixbuf-2.0/gdk-
>> pixbuf/gdk-pixbuf-enum-types.h:
>>     /* enumerations from "gdk-pixbuf-core.h" */
>>     [...]
>>     /* enumerations from "gdk-pixbuf-transform.h" */
>
> Given that it is "just" a difference in a comment, how does this break
> multi-arch support?

Shared files need to be identical across architectures, or there is a
conflict (overridable with dpkg's --force-overwrite option), e.g. when
installing both libgdk-pixbuf2.0-dev:amd64 and libgdk-pixbuf2.0-dev:i386.

,----
| Selecting previously unselected package libgdk-pixbuf2.0-dev:i386.
| Preparing to unpack .../35-libgdk-pixbuf2.0-dev_2.38.0+dfsg-3_i386.deb ...
| Unpacking libgdk-pixbuf2.0-dev:i386 (2.38.0+dfsg-3) ...
| dpkg: error processing archive /tmp/apt-dpkg-install-F0zifA/35-libgdk-pixbuf2.0-dev_2.38.0+dfsg-3_i386.deb (--unpack):
|  trying to overwrite shared '/usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-enum-types.h', which is different from other instances of package libgdk-pixbuf2.0-dev:i386
| Errors were encountered while processing:
|  /tmp/apt-dpkg-install-F0zifA/35-libgdk-pixbuf2.0-dev_2.38.0+dfsg-3_i386.deb
| E: Sub-process /usr/bin/dpkg returned an error code (1)
`----

Cheers,
       Sven

Message #27 received at 908309@bugs.debian.org (full text, mbox, reply):

From: Hugh McMaster <hugh.mcmaster@outlook.com>

To: Chris Lamb <lamby@debian.org>, Sven Joachim <svenjoac@gmx.de>

Cc: "908309@bugs.debian.org" <908309@bugs.debian.org>

Subject: Re: Bug#908309: Regression: gdk-pixbuf: please make the build reproducible

Date: Sun, 9 Sep 2018 09:50:14 +0000

On Sunday, 9 September 2018 7:32 PM +1000, Sven Joachim wrote:
> Shared files need to be identical across architectures, or there is a
> conflict (overridable with dpkg's --force-overwrite option), e.g. when
> installing both libgdk-pixbuf2.0-dev:amd64 and libgdk-pixbuf2.0-dev:i386.

Yes, +1.

It would be good to get this fixed ASAP. Given that gdk-pixbuf
can't migrate to Buster until after glib2.0, we've got time.

Message #30 received at 908309-submitter@bugs.debian.org (full text, mbox, reply):

From: Jeremy Bicha <jbicha@debian.org>

To: 908309-submitter@bugs.debian.org

Subject: Bug #908309 in gdk-pixbuf marked as pending

Date: Sun, 09 Sep 2018 12:12:41 +0000

Control: tag -1 pending

Hello,

Bug #908309 in gdk-pixbuf reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below, and you can check the diff of the fix at:

https://salsa.debian.org/gnome-team/gdk-pixbuf/commit/b1386326e64a727c1a11dc1e55a1413739787098

------------------------------------------------------------------------
Add Use-basename-instead-of-filename.patch

Proposed patch for reproducible builds and multi-arch co-installability

Closes: #908309

Gbp-Dch: Full

------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/908309

Message #37 received at 908309-close@bugs.debian.org (full text, mbox, reply):

From: Jeremy Bicha <jbicha@debian.org>

To: 908309-close@bugs.debian.org

Subject: Bug#908309: fixed in gdk-pixbuf 2.38.0+dfsg-4

Date: Sun, 09 Sep 2018 12:33:59 +0000

Source: gdk-pixbuf
Source-Version: 2.38.0+dfsg-4

We believe that the bug you reported is fixed in the latest version of
gdk-pixbuf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 908309@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeremy Bicha <jbicha@debian.org> (supplier of updated gdk-pixbuf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 09 Sep 2018 08:12:01 -0400
Source: gdk-pixbuf
Binary: libgdk-pixbuf2.0-0 libgdk-pixbuf2.0-bin libgdk-pixbuf2.0-common libgdk-pixbuf2.0-dev libgdk-pixbuf2.0-doc libgdk-pixbuf2.0-0-udeb gir1.2-gdkpixbuf-2.0
Architecture: source
Version: 2.38.0+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Jeremy Bicha <jbicha@debian.org>
Description:
 gir1.2-gdkpixbuf-2.0 - GDK Pixbuf library - GObject-Introspection
 libgdk-pixbuf2.0-0 - GDK Pixbuf library
 libgdk-pixbuf2.0-0-udeb - GDK Pixbuf library - minimal runtime (udeb)
 libgdk-pixbuf2.0-bin - GDK Pixbuf library (thumbnailer)
 libgdk-pixbuf2.0-common - GDK Pixbuf library - data files
 libgdk-pixbuf2.0-dev - GDK Pixbuf library (development files)
 libgdk-pixbuf2.0-doc - GDK Pixbuf library (documentation)
Closes: 908309 908373
Changes:
 gdk-pixbuf (2.38.0+dfsg-4) unstable; urgency=medium
 .
   [ Jeremy Bicha ]
   * Update debian/gbp.conf
   * debian/libgdk-pixbuf2.0-0.install: Use ${DEB_HOST_MULTIARCH} less.
     Thanks lintian.
 .
   [ John Paul Adrian Glaubitz ]
   * debian/rules: Have dh_auto_test override honor nocheck (Closes: #908373)
 .
   [ Chris Lamb ]
   * Add Use-basename-instead-of-filename.patch:
     - Proposed patch for reproducible builds and multi-arch co-installability
       (Closes: #908309)
Checksums-Sha1:
 43305c0ea43f807f655c846ded4e27a8b9165a05 2903 gdk-pixbuf_2.38.0+dfsg-4.dsc
 bff4a84a15e853c5e1f780c633157e48dc7f72f0 17072 gdk-pixbuf_2.38.0+dfsg-4.debian.tar.xz
 cab1071bc76aaee4388fd84e01ecd5ac424bb71e 12058 gdk-pixbuf_2.38.0+dfsg-4_source.buildinfo
Checksums-Sha256:
 4a4cdb6b139400f660bcec4defaa677abd193e2237da6f936cc080346bee6392 2903 gdk-pixbuf_2.38.0+dfsg-4.dsc
 c3af5dfacaa34446ba96b69b1ae5f6e8dd1d37b97aeecba4d401925ef6bf0f6c 17072 gdk-pixbuf_2.38.0+dfsg-4.debian.tar.xz
 933b30fc66fb757e6bd6c88bedc4ea58cb53cdbabdd0cc21c9731cb4979e817b 12058 gdk-pixbuf_2.38.0+dfsg-4_source.buildinfo
Files:
 bae6b20e81b99d36e1217f7eb907d4d3 2903 libs optional gdk-pixbuf_2.38.0+dfsg-4.dsc
 a9a450ecc2caa3bb4ea7640d72ae0c02 17072 libs optional gdk-pixbuf_2.38.0+dfsg-4.debian.tar.xz
 d9915c4afb5df83d6ab6b78f7e21fa79 12058 libs optional gdk-pixbuf_2.38.0+dfsg-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEETQvhLw5HdtiqzpaW5mx3Wuv+bH0FAluVDtAACgkQ5mx3Wuv+
bH3/yA/8CO45VbHevtLKW1127AasfXFMbIwl9eaigBGWvaqL1dIEL0m0PSQLWX6T
kzQ25SyvLz3jjuyu0EwPr5qBQoY1QNgn31kW/uioFL/v5KRyG71DWluOh5iyt+3J
hvDcvwtTgJqw7bDZPBuh/q7zkEt7MZm/lcBOAX9FienqextH8vssK8F/EJdtMDgS
CQTMdEyHql0z+JgELUm/CBMP65q/yXZe/Mpcuka8wGNBRgYZnQDZR0Aq+xg5cWe5
/PVWzie/PaLtfOt96iqD2PE1NaiBqU4eomXrtAhL0nLVklPYUZ5V1UV77iz0YR/h
JcV0vXMPcvFTrHOgbFTlo3cRLwtw/hfNnqbwabrVxC4omWSpY7nRXwJHQuB5Y5Kq
amKIi/Cf8amTx7fF/HNkwjRly6J/G9tKdmRrUADyk9TXyXD7ysR/0G/mgfx+8Swv
dH85CjnLsPZS446uWINHAZfDXnPvDBb8PkjsdXVBtBduKogsUhiRL35BJcGAp8uT
PYGgv/LHqBbjRfejgNvzVJguRdDiTrbZqEqYVMu60h9sQQkY5LM1IzgFJc6ngLKB
TmSTzubx6DJnXyVqEeooRGDdiyLSSu5ETf7lmocHmC9/9C3monLEyuBQahtY65s/
g2Mp23FfXpGUZFhwPCLsCQ4GmA4QNBbdQaNy98zR9cp5x/lk3X8=
=b/Yt
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.