Debian Bug report logs - #907600
diffoscope: add option to ignore timestamp differences in containers

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: add option to ignore timestamp differences in containers

Date: Wed, 29 Aug 2018 22:36:11 -0300

Package: diffoscope
Version: 99
Severity: wishlist
Tags: upstream

Hi,

diffoscope has been a very useful tool for me, in comparing dumps of
various sorts spit out by several systems. It would be great to have an
option to ignore timestamps, in order to be able to check if two
tarballs/zipballs/whateverballs have the same contents, even if the
contents were generated on different dates.

Thanks for considering

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-rc5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages diffoscope depends on:
ii  libpython3.6-stdlib    3.6.6-3
ii  python3                3.6.6-1
ii  python3-distro         1.3.0-1
ii  python3-distutils      3.6.6-1
ii  python3-libarchive-c   2.1-3.1
ii  python3-magic          2:0.4.15-2
ii  python3-pkg-resources  39.2.0-1

Versions of packages diffoscope recommends:
pn  abootimg                         <none>
ii  acl                              2.2.52-3+b1
pn  apktool                          <none>
pn  binutils-multiarch               <none>
ii  bzip2                            1.0.6-9
pn  caca-utils                       <none>
ii  colord                           1.3.3-2
pn  db-util                          <none>
ii  default-jdk [java-sdk]           2:1.10-68
ii  default-jdk-headless             2:1.10-68
pn  device-tree-compiler             <none>
pn  docx2txt                         <none>
ii  e2fsprogs                        1.44.4-2
pn  enjarify                         <none>
pn  fontforge-extras                 <none>
pn  fp-utils                         <none>
ii  genisoimage                      9:1.1.11-3+b2
ii  gettext                          0.19.8.1-7
pn  ghc                              <none>
ii  ghostscript                      9.22~dfsg-3
pn  giflib-tools                     <none>
pn  gnumeric                         <none>
ii  gnupg                            2.2.9-2
ii  imagemagick                      8:6.9.10.8+dfsg-1
ii  imagemagick-6.q16 [imagemagick]  8:6.9.10.8+dfsg-1
pn  jsbeautifier                     <none>
pn  libarchive-tools                 <none>
pn  llvm                             <none>
ii  lz4                              1.8.2-1
ii  mono-utils                       4.6.2.7+dfsg-2
pn  odt2txt                          <none>
pn  oggvideotools                    <none>
ii  openjdk-10-jdk [java-sdk]        10.0.2+13-1
ii  openjdk-8-jdk [java-sdk]         8u181-b13-1
ii  openssh-client                   1:7.7p1-4
pn  pgpdump                          <none>
ii  poppler-utils                    0.63.0-2
pn  procyon-decompiler               <none>
pn  python3-argcomplete              <none>
pn  python3-binwalk                  <none>
ii  python3-debian                   0.1.33
pn  python3-defusedxml               <none>
pn  python3-guestfs                  <none>
pn  python3-jsondiff                 <none>
ii  python3-progressbar              2.3-4
ii  python3-pyxattr                  0.6.0-2+b2
pn  python3-tlsh                     <none>
pn  r-base-core                      <none>
ii  rpm2cpio                         4.14.1+dfsg1-4
pn  sng                              <none>
ii  sqlite3                          3.24.0-1
ii  squashfs-tools                   1:4.3-6
pn  tcpdump                          <none>
ii  unzip                            6.0-21
ii  vim-common                       2:8.1.0320-1
ii  xmlbeans                         2.6.0+dfsg-4
ii  xxd                              2:8.1.0320-1
ii  xz-utils                         5.2.2-1.3

Versions of packages diffoscope suggests:
ii  libjs-jquery  3.2.1-1

-- no debconf information

Message #10 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Felipe Sateler <fsateler@debian.org>, 907600@bugs.debian.org

Subject: Re: Bug#907600: diffoscope: add option to ignore timestamp differences in containers

Date: Thu, 30 Aug 2018 08:43:14 +0100

Dear Felipe,

> diffoscope has been a very useful tool for me, in comparing dumps of
> various sorts spit out by several systems. It would be great to have an
> option to ignore timestamps

Does the --exclude-directory-metadata option match your requirements?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 907600@bugs.debian.org

Subject: Re: Bug#907600: diffoscope: add option to ignore timestamp differences in containers

Date: Thu, 30 Aug 2018 11:18:59 -0300

[Message part 1 (text/plain, inline)]

Hi Chris,
On Thu, Aug 30, 2018 at 4:43 AM Chris Lamb <lamby@debian.org> wrote:

> Dear Felipe,
>
> > diffoscope has been a very useful tool for me, in comparing dumps of
> > various sorts spit out by several systems. It would be great to have an
> > option to ignore timestamps
>
> Does the --exclude-directory-metadata option match your requirements?


No, and according to the manpage it is intentional:

> Metadata of archive members remain un-excluded.

I could get the results I want by unpacking the tarballs on two dirs and
then using this option, though, so thanks for suggesting it!

It would still be nice if diffoscope provided this option natively.

-- 

Saludos,
Felipe Sateler

[Message part 2 (text/html, inline)]

Message #20 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Felipe Sateler <fsateler@debian.org>, 907600@bugs.debian.org

Subject: Re: Bug#907600: diffoscope: add option to ignore timestamp differences in containers

Date: Thu, 30 Aug 2018 16:31:31 +0100

Dear Felipe,

> > Does the --exclude-directory-metadata option match your requirements?
> 
> No, and according to the manpage it is intentional

Whoops, apologies for the premature suggestion. Indeed, it seems like I
was confused in the past:

  http://bugs.debian.org/893324

… leading me to add that exact line:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/0da118a131f95811c158c5d47e4d620d01a233ea

One option here would be to extend the --exclude-directory-metadata
option to ignore metadata inside archive formats too rather than create
a new, separate, option. Thoughts?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #25 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 907600@bugs.debian.org

Subject: Re: Bug#907600: diffoscope: add option to ignore timestamp differences in containers

Date: Thu, 30 Aug 2018 12:43:24 -0300

[Message part 1 (text/plain, inline)]

On Thu, Aug 30, 2018, 12:31 Chris Lamb <lamby@debian.org> wrote:

> Dear Felipe,
>
> > > Does the --exclude-directory-metadata option match your requirements?
> >
> > No, and according to the manpage it is intentional
>
> Whoops, apologies for the premature suggestion.


No worries, it was still useful :)


Indeed, it seems like I
> was confused in the past:
>
>   http://bugs.debian.org/893324
>
> … leading me to add that exact line:
>
>
> https://salsa.debian.org/reproducible-builds/diffoscope/commit/0da118a131f95811c158c5d47e4d620d01a233ea
>
> One option here would be to extend the --exclude-directory-metadata
> option to ignore metadata inside archive formats too rather than create
> a new, separate, option. Thoughts?
>

I would assume the current behavior is intentional, so it probably should
be an (optional) argument for this new behavior. But it would work for me.

Saludos

[Message part 2 (text/html, inline)]

Message #30 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 907600@bugs.debian.org

Cc: Felipe Sateler <fsateler@debian.org>

Subject: Re: diffoscope: add option to ignore timestamp differences in containers

Date: Sat, 15 Dec 2018 16:00:51 +0100

forwarded 907600 https://salsa.debian.org/reproducible-builds/diffoscope/issues/36
thanks

I've forwarded this upstream here:

  https://salsa.debian.org/reproducible-builds/diffoscope/issues/36


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #35 received at 907600-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 907600-submitter@bugs.debian.org

Subject: Bug #907600 in diffoscope marked as pending

Date: Tue, 19 Feb 2019 08:50:04 +0000

Control: tag -1 pending

Hello,

Bug #907600 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/commit/e47c4bf83661357e0a62cf8f15a93bbe37bff2e9

------------------------------------------------------------------------
Add a --exclude-directory-metadata=recursive option to support ignoring timestamp (etc.) differences in containers. (Closes: #907600, reproducible-builds/diffoscope#36)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/907600

Message #42 received at 907600@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 907600@bugs.debian.org

Cc: Felipe Sateler <fsateler@debian.org>

Subject: Re: diffoscope: add option to ignore timestamp differences in containers

Date: Tue, 19 Feb 2019 09:51:10 +0100

tags 907600 + pending fixed-upstream
thanks

Fixed in Git, pending upload:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/e47c4bf83661357e0a62cf8f15a93bbe37bff2e9

  diffoscope/comparators/directory.py        |  2 +-
  diffoscope/comparators/utils/compare.py    |  2 +-
  diffoscope/comparators/utils/libarchive.py | 13 ++++++++-----
  diffoscope/comparators/zip.py              | 11 ++++++++---
  diffoscope/config.py                       |  2 +-
  diffoscope/main.py                         | 21 +++++++++++++++------
  6 files changed, 34 insertions(+), 17 deletions(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #49 received at 907600-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 907600-close@bugs.debian.org

Subject: Bug#907600: fixed in diffoscope 112

Date: Tue, 19 Feb 2019 09:34:21 +0000

Source: diffoscope
Source-Version: 112

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 907600@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 19 Feb 2019 09:56:29 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source all
Version: 112
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 907600
Changes:
 diffoscope (112) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * New features:
     - Add a --exclude-directory-metadata=recursive option to support ignoring
       timestamp differences (etc.) in nested archives/containers.
       (Closes: #907600, reproducible-builds/diffoscope#36)
     - Add support for comparing metadata in MP3 files.
       (Closes: reproducible-builds/diffoscope#43)
     - Add support for comparing .crx Chrome browser extensions.
       (Closes: reproducible-builds/diffoscope#41)
 .
   * Bug fixes:
     - Catch tracebacks when mounting invalid filesystem images under guestfs.
     - Ensure both WASM test data files are actually unique.
       (Closes: reproducible-builds/diffoscope#42)
     - Replace literal xxd(1) output in tests/data/hello.wasm with its binary
       equivalent. (Closes: reproducible-builds/diffoscope#47)
 .
   * Misc improvements:
     - Rework and comment logic determining a default for
       exclude_directory_metadata.
     - Fix a number of Ghostscript-related test issues regarding the update of
       this package from 9.20 to 9.26 in Debian "stable".
 .
   [ Mattia Rizzolo ]
   * Make test_ps.test_text_diff pass with ghostscript 9.26.
 .
   [ Ed Maste ]
   * Include relocation information in objdump disassembly.
     (Closes: reproducible-builds/diffoscope#48)
 .
   [ Graham Christensen ]
   * Clarify notice if no file-specific diff caused fallback. (MR: !19)
Checksums-Sha1:
 f4f8b526689276ac6e8f8540c82a21543b77206c 4478 diffoscope_112.dsc
 5109d1bf3c13f33e3492ae3c8a6fd46c15c221e2 9280252 diffoscope_112.tar.xz
 ba825c778a4729c462190e11ae805ac9c09dd05e 127680 diffoscope_112_all.deb
 7017e9fb95fadfb69b8fa7eedae0e0ad21d20aea 24887 diffoscope_112_amd64.buildinfo
Checksums-Sha256:
 82a53d78cc5f21d60de4fc559993d9a0c5700d39148dad99b6ef8fbd31dfb2b9 4478 diffoscope_112.dsc
 7621437783056c67524ff38f9bc0018f8a5f21f825941f837ed03b7885161b3b 9280252 diffoscope_112.tar.xz
 988d1103b852a6525a42be0d4fab3bab1615bdede2d1df480a7f4e2f8cf376c0 127680 diffoscope_112_all.deb
 3ee1062700f45dfe2cf4cc9a0d6a61005fa3f809b05b81b0af2d823c0458fef3 24887 diffoscope_112_amd64.buildinfo
Files:
 4a5f5db4b8569718cf69e2a3080c494a 4478 devel optional diffoscope_112.dsc
 51d7eaabdba3c243df90a582f7e10fdd 9280252 devel optional diffoscope_112.tar.xz
 e78469f8645390c482475db28398185e 127680 devel optional diffoscope_112_all.deb
 60b147ec3fc0aa8b3d35919e2a91bfb0 24887 devel optional diffoscope_112_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlxryigACgkQHpU+J9Qx
HlgGKQ/9EiuGb4KVsXIvtuq42//tPa7MtPVlhtAGDgXrm4Uk5GUXH+vwPQnFlo3g
0y2fv3lWj292AC9D7ozWMSTVsgwAh70KzPtyYu2XQuYl0Kw7x97rC+ePdafKuP46
JDwXbCetHnD6oiRIbOU9q+wJX+Y3vrBlPOEDV6j9oDslIAQ8OP2iapTprpIRHzzu
bjjkLNC0NyjgIRaOIwM2TU2LaQgQpteZmebiMaxxahMShvcyowUzus7nyKzdUjHX
5e/ClozVBRKnpdGVCw9DDR0+JmSnQO9gWv7t0V35oEw3BdNDIhWh2Xlp4vD+IF5e
IBu65w3aouPEvD5FSRVh3U0hw05XAQ7l1Wo6lxJHRGeBG7j0BJsXPnO9OXAZYIcj
R74tAoa1Kj5AcClR5j7qmrs5YS52hppi4xt3K/ye2LJELWxwrYf/UdFvsrX0oEKc
ZzlkpSeQZjJxF//P5L5jsqtZ7OC4KXUVo9R1Jpdw89s02hMj2xbia3yBMiOyOlZf
o2qmm6Nvar5AMiNJwhlHZpeGrVdMvmbgMvjwv6IfzH5+kQ1wWtqem1MT+bR7qCJN
7w2zxgZ7OnSrpjBoBpmnQ1FWrFnTOf7VxIV0df3Rmy0VRGaSMKc+0Gk0YsTrkMnW
Sr/dFYuxzDjuAkq+HDlVsjsRbKQS14S31EHCQO1TjivqLnKr4Wo=
=S4nE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.