Debian Bug report logs - #901757
diffoscope: ZIP files: compare comments with zipnote or zipdetails output

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Paul Wise <pabs@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: ZIP files: compare comments with zipnote or zipdetails output

Date: Mon, 18 Jun 2018 09:59:21 +0800

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 95
Severity: wishlist

It would be nice if comparing ZIP files with diffoscope could compare
the comments embedded in the CDFH and EOCD structures:

https://en.wikipedia.org/wiki/Zip_(file_format)#Central_directory_file_header

This can be done using both zipnote or zipdetails but zipinfo (used by
diffoscope) does not print anything about zip file comments.

I'm not sure which tool to use but maybe use zipnote first and if that
produces no differences then use zipdetails, because the latter also
allows for comparing the compression level of individual files. Or
maybe just use zipdetails if the zipinfo output only differs by the
file size information, since scanning the whole zip may be expensive.

I've illustrated this with the command sequence below.

$ touch foo

$ zip foo.zip foo
  adding: foo (stored 0%)

$ cp foo.zip bar.zip

$ zipnote -w bar.zip <(zipnote foo.zip | sed -e '/@ foo/a hello' -e '$a goodbye')

$ diffoscope foo.zip bar.zip
 |#####################################################################################################################################|  100%                             Time: 0:00:00 
--- foo.zip
+++ bar.zip
├── zipinfo /dev/stdin
│ @@ -1,3 +1,3 @@
│ -Zip file size: 156 bytes, number of entries: 1
│ +Zip file size: 168 bytes, number of entries: 1
│  -rw-r-----  3.0 unx        0 bx stor 18-Jun-18 01:29 foo
│  1 file, 0 bytes uncompressed, 0 bytes compressed:  0.0%

$ diff -u <(zipnote foo.zip) <(zipnote bar.zip)
--- /dev/fd/63	2018-06-18 09:54:26.288808196 +0800
+++ /dev/fd/62	2018-06-18 09:54:26.288808196 +0800
@@ -1,3 +1,5 @@
 @ foo
+hello
 @ (comment above this line)
 @ (zip file comment below this line)
+goodbye

$ diff -u <(zipdetails foo.zip) <(zipdetails bar.zip)
--- /dev/fd/63	2018-06-18 09:54:42.860925054 +0800
+++ /dev/fd/62	2018-06-18 09:54:42.860925054 +0800
@@ -37,7 +37,7 @@
 0055 Uncompressed Length   00000000
 0059 Filename Length       0003
 005B Extra Length          0018
-005D Comment Length        0000
+005D Comment Length        0005
 005F Disk Start            0000
 0061 Int File Attributes   0000
      [Bit 0]               0 'Binary Data'
@@ -55,13 +55,15 @@
 007D   UID                 000003E8
 0081   GID Size            04
 0082   GID                 000003E8
+0086 Comment               'hello'
 
-0086 END CENTRAL HEADER    06054B50
-008A Number of this disk   0000
-008C Central Dir Disk no   0000
-008E Entries in this disk  0001
-0090 Total Entries         0001
-0092 Size of Central Dir   00000049
-0096 Offset to Central Dir 0000003D
-009A Comment Length        0000
+008B END CENTRAL HEADER    06054B50
+008F Number of this disk   0000
+0091 Central Dir Disk no   0000
+0093 Entries in this disk  0001
+0095 Total Entries         0001
+0097 Size of Central Dir   0000004E
+009B Offset to Central Dir 0000003D
+009F Comment Length        0007
+00A1 Comment               'goodbye'
 Done

-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages diffoscope depends on:
ii  libpython3.6-stdlib    3.6.6~rc1-1
ii  python3                3.6.5-3
ii  python3-distro         1.0.1-2
ii  python3-distutils      3.6.5-4
ii  python3-libarchive-c   2.1-3.1
ii  python3-magic          2:0.4.15-1
ii  python3-pkg-resources  39.1.0-1

Versions of packages diffoscope recommends:
ii  abootimg                         0.6-1+b2
ii  acl                              2.2.52-3+b1
ii  apktool                          2.3.3-1
ii  binutils-multiarch               2.30-21
ii  bzip2                            1.0.6-8.1
ii  caca-utils                       0.99.beta19-2+b3
ii  colord                           1.3.3-2
ii  db-util                          5.3.1
ii  default-jdk [java-sdk]           2:1.10-67
ii  default-jdk-headless             2:1.10-67
pn  device-tree-compiler             <none>
pn  docx2txt                         <none>
ii  e2fsprogs                        1.44.2-1
ii  enjarify                         1:1.0.3-4
ii  fontforge-extras                 0.3-4
pn  fp-utils                         <none>
ii  genisoimage                      9:1.1.11-3+b2
ii  gettext                          0.19.8.1-6+b1
ii  ghc                              8.0.2-11
ii  ghostscript                      9.22~dfsg-2.1
ii  giflib-tools                     5.1.4-3
ii  gnumeric                         1.12.39-1
ii  gnupg                            2.2.8-1
ii  imagemagick                      8:6.9.9.39+dfsg-1
ii  imagemagick-6.q16 [imagemagick]  8:6.9.9.39+dfsg-1
ii  jsbeautifier                     1.6.4-7
pn  libarchive-tools                 <none>
ii  llvm                             1:4.0-40
pn  mono-utils                       <none>
pn  odt2txt                          <none>
pn  oggvideotools                    <none>
ii  openjdk-10-jdk [java-sdk]        10.0.1+10-4
ii  openssh-client                   1:7.7p1-2
ii  pdftk                            2.02-4+b2
ii  pgpdump                          0.31-0.2
ii  poppler-utils                    0.63.0-2
pn  procyon-decompiler               <none>
ii  python3-argcomplete              1.8.1-1
ii  python3-binwalk                  2.1.1-16
ii  python3-debian                   0.1.32
pn  python3-defusedxml               <none>
pn  python3-guestfs                  <none>
ii  python3-jsondiff                 1.1.1-2
ii  python3-progressbar              2.3-4
ii  python3-pyxattr                  0.6.0-2+b1
ii  python3-tlsh                     3.4.4+20151206-1+b3
pn  r-base-core                      <none>
ii  rpm2cpio                         4.14.1+dfsg1-3
ii  sng                              1.1.0-1+b1
ii  sqlite3                          3.24.0-1
ii  squashfs-tools                   1:4.3-6
ii  tcpdump                          4.9.2-3
ii  unzip                            6.0-21
ii  vim-common                       2:8.0.1766-1
pn  xmlutils                         <none>
ii  xxd                              2:8.0.1766-1
ii  xz-utils                         5.2.2-1.3

Versions of packages diffoscope suggests:
ii  libjs-jquery  3.2.1-1

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 901757-submitter@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 901757-submitter@bugs.debian.org

Subject: Bug #901757 in diffoscope marked as pending

Date: Thu, 06 Dec 2018 21:29:04 +0000

Control: tag -1 pending

Hello,

Bug #901757 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/commit/28695191147fce66695e28503197d3656e43c1f1

------------------------------------------------------------------------
Compare .zip file comments with zipnote. (Closes: #901757)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/901757

Message #15 received at 901757-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 901757-close@bugs.debian.org

Subject: Bug#901757: fixed in diffoscope 107

Date: Thu, 06 Dec 2018 22:19:12 +0000

Source: diffoscope
Source-Version: 107

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 901757@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 06 Dec 2018 22:42:54 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source all
Version: 107
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 901757 902369
Changes:
 diffoscope (107) unstable; urgency=medium
 .
   * Compare .zip file comments with zipnote. (Closes: #901757)
   * Don't emit a large number of warnings if getfacl(1) is not available. This
     makes the behaviour consistent with if lsattr(1) is unavailable.
     (Closes: #902369)
Checksums-Sha1:
 21af4ed2ab50ff34ac7a66076e9eab2bf5e7b957 4419 diffoscope_107.dsc
 542ded30a54f8bfc70610a502dd9b5b290b9b77f 9277816 diffoscope_107.tar.xz
 e129417dcba8f7dd91651893aae558bc35e07d21 125472 diffoscope_107_all.deb
 8026b3a185326ce1e76288bb4d36bb66d29d508c 20664 diffoscope_107_amd64.buildinfo
Checksums-Sha256:
 0fc8c87d28f21418d69d4b7e3e0d827288cb161fdbb1c2d08e5f7f57fecc4db6 4419 diffoscope_107.dsc
 f7560469f3af6c81c9359fda605a8921c3124e56793cd2b094f360f84f1fa27d 9277816 diffoscope_107.tar.xz
 d7a602124f8b6572450f1f1e2195739680fb52f41d24dd037b49c34a1f1a45fc 125472 diffoscope_107_all.deb
 ecbedf3418d5f5bbffc169195537ceae273fa727d5d31c4bdb2bc73220a6962a 20664 diffoscope_107_amd64.buildinfo
Files:
 be893481bbd80d8ddd83e81a79843cdd 4419 devel optional diffoscope_107.dsc
 66baf936d20060edca415ddbe75e4028 9277816 devel optional diffoscope_107.tar.xz
 af88c75e462cd4f986c2860ce0e5bae0 125472 devel optional diffoscope_107_all.deb
 c17091a964ce545cde614ce339b4cfb8 20664 devel optional diffoscope_107_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlwJnJsACgkQHpU+J9Qx
HlgN5BAAoskV4FclnSugpiEUN68mrfsfprmMqePpZvkTKJSdwRu22oUvBDzIfHBC
b0mCL6Vtn//jlnNVzQlNYUc50LyKXm8ThH3jzUnnK7S8oVCcwFKYmfFxWJTT9F4j
DFPA2duufRRy1XgpZNs6dNTouvWtIW6Sj5ClL7fY1YR0ygqTD8O38FiixuzRD7ea
BSf6luHxYGzHpnF00Ocedj9ewUyloG6XIAyguLAbcn091/1DggOFLk/d94WviGuC
SYk4z7qrOf0pUqRl00/3FfUJ4KSdZRhaHjTwNRCOg8t/AZqlEqu+ZiWqD7bn47s3
RSP1QJFKJhXCqZFklInkt7udZIXQwp/koZX9cZeOC4hhiO0bo6Fask/ZSZcbpbLr
ADskBTdTw9qFbG2lr+4Vo5r5Dtof5ijl18Pzk7oriLBeOylsRMsUmC26VExNfpU9
Y95kxg1CyqYMCxnU/3ARB8IPs8pgdcKJd7gNJTbtYVDQC9d7q9zTCJ4YokEmohu7
3RGhPWAXEnsF5rL9D4FhbFa9s5tZZ6Hz7caWAdne5BvCOAPvvd5e5mzgumRW54c6
+1e6L3FyykxIgotJMUWZl+g5IiD6S1ayE1a8i5ok8gnsfbjSkqaa8eGmNUimmNof
HYtxJG0ir45zhbgv2by6xYZl0MuYaTO8UttYBbxkg96TKncsCUc=
=buxf
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.