Debian Bug report logs - #900410
mtools: please make the output reproducible (directory timestamps)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: mtools: please make the output reproducible (directory timestamps)

Date: Wed, 30 May 2018 11:50:07 +0100

[Message part 1 (text/plain, inline)]

Source: mtools
Version: 4.0.18-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that mtools generates non-reproducible output.

This is because it uses the current time of day as a default
timestamp, such as when adding files to an existing file.

Patch attached that uses SOURCE_DATE_EPOCH [1].

 [0] https://reproducible-builds.org/
 [1] https://https://reproducible-builds.org/specs/source-date-epoch/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[mtools.diff.txt (text/plain, attachment)]

Message #10 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 900410@bugs.debian.org

Subject: Re: mtools: please make the output reproducible (directory timestamps)

Date: Wed, 30 May 2018 12:15:26 +0100

[Message part 1 (text/plain, inline)]

Chris Lamb wrote:

> […]

Updated patch attached - I left a debug "printf" call in there by
accident.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[mtools.diff.txt (text/plain, attachment)]

Message #17 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: Chris Lamb <lamby@debian.org>, 900410@bugs.debian.org

Subject: Re: mtools: please make the output reproducible (directory timestamps)

Date: Sun, 10 Jun 2018 12:26:51 -0700

[Message part 1 (text/plain, inline)]

On 2018-05-30, Chris Lamb wrote:
> Chris Lamb wrote:
> Updated patch attached - I left a debug "printf" call in there by
> accident.
...
> +			else if (*endptr != '\0')
> +				fprintf(stderr, "SOURCE_DATE_EPOCHh has trailing garbage\n");


Minor typo in error message? Or is the error message trying to indicate
the problem by example? :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Vagrant Cascadian <vagrant@debian.org>, 900410@bugs.debian.org

Subject: Re: mtools: please make the output reproducible (directory timestamps)

Date: Sun, 10 Jun 2018 20:30:13 +0100

[Message part 1 (text/plain, inline)]

Dear Vagrant,

> > +			else if (*endptr != '\0')
> > +				fprintf(stderr, "SOURCE_DATE_EPOCHh has trailing garbage\n");
> 
> 
> Minor typo in error message? Or is the error message trying to indicate
> the problem by example? :)

Very well spotted. I'll leave the hermeneutics of my original
intentions ambiguous for comedic effect ;-)

Updated patch attached..


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[mtools.diff.txt (text/plain, attachment)]

Message #27 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 900409@bugs.debian.org, 900410@bugs.debian.org, Anibal Monsalve Salazar <anibal@debian.org>

Cc: 900918@bugs.debian.org

Subject: Re: debian-installer: Please make the generated images reproducible

Date: Mon, 11 Jun 2018 22:15:13 +0100

Dear Anibal,

> mtools: please make the output reproducible (uninitialised memory)
> mtools: please make the output reproducible (directory timestamps)

I'd dearly love to ensure there are no blockers to making the Debian
Installer images to be reproducible well in advance of the «buster»
release. :)

May I gently prod you to review and hopefully apply these patches?


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #32 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 900409@bugs.debian.org, 900410@bugs.debian.org, Anibal Monsalve Salazar <anibal@debian.org>

Cc: 900918@bugs.debian.org, reproducible-builds@alioth-lists.debian.net

Subject: Re: debian-installer: Please make the generated images reproducible

Date: Thu, 12 Jul 2018 10:52:09 +0100

On 11th June 2018, Chris Lamb wrote:

> > mtools: please make the output reproducible (uninitialised memory)
> > mtools: please make the output reproducible (directory timestamps)
> 
> I'd dearly love to ensure there are no blockers to making the Debian
> Installer images to be reproducible well in advance of the «buster»
> release. :)
> 
> May I gently prod you to review and hopefully apply these patches?

Another gentle ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #37 received at 900410@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 837044@bugs.debian.org, 900409@bugs.debian.org, 900410@bugs.debian.org

Cc: reproducible-builds@alioth-lists.debian.net

Subject: Re: mtools: Corrupted FAT entries when mcopy copies a directory

Date: Wed, 25 Jul 2018 13:44:40 +0100

[Message part 1 (text/plain, inline)]

tags 837044 + pending patch
tags 900409 + pending patch
tags 900410 + pending patch
thanks

Hi,

After a few pings I've uploaded mtools 4.0.18-2.1 to DELAYED/10:
  
  mtools (4.0.18-2.1) unstable; urgency=medium
  
    * Non-maintainer upload.
    * Prevent an issue where mtools creates corrupted FAT entries for
      directories when copied to a filesystem. This issue was reported upstream
      at <https://lists.gnu.org/archive/html/info-mtools/2014-08/msg00000.html>
      and as the underlying issue is based on uninitialised memory also affects
      the reproducibility of the output of mtools which s required for
      reproducible Debian Installer images. (Closes: #837044, #900409)
    * Use the SOURCE_DATE_EPOCH environment variable if set instead of the
      current time of day as the default timestamp (such as when adding files to
      an existing file) to make its output reproducible. (Closes: #900410)
    * Use "Priority: extra" over "Priority: optional" for Debian Policy  2.0.5.

The full debdiff is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[mtools_4.0.18-2.1_amd64.debdiff.txt (text/plain, attachment)]

Message #44 received at 900410-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 900410-close@bugs.debian.org

Subject: Bug#900410: fixed in mtools 4.0.18-2.1

Date: Sat, 04 Aug 2018 13:19:02 +0000

Source: mtools
Source-Version: 4.0.18-2.1

We believe that the bug you reported is fixed in the latest version of
mtools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 900410@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated mtools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 25 Jul 2018 20:23:59 +0800
Source: mtools
Binary: floppyd mtools
Architecture: source amd64
Version: 4.0.18-2.1
Distribution: unstable
Urgency: medium
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 floppyd    - Daemon for remote access to floppy drives
 mtools     - Tools for manipulating MSDOS files
Closes: 837044 900409 900410
Changes:
 mtools (4.0.18-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Prevent an issue where mtools creates corrupted FAT entries for
     directories when copied to a filesystem. This issue was reported upstream
     at <https://lists.gnu.org/archive/html/info-mtools/2014-08/msg00000.html>
     and as the underlying issue is based on uninitialised memory also affects
     the reproducibility of the output of mtools which s required for
     reproducible Debian Installer images. (Closes: #837044, #900409)
   * Use the SOURCE_DATE_EPOCH environment variable if set instead of the
     current time of day as the default timestamp (such as when adding files to
     an existing file) to make its output reproducible. (Closes: #900410)
   * Use "Priority: extra" over "Priority: optional" for Debian Policy § 2.0.5.
Checksums-Sha1:
 2b24765dac042d81989526b27ce1d4bb00bdee83 1841 mtools_4.0.18-2.1.dsc
 cd45031441ac944eacebdc8d4b82b20cd9cc8461 420190 mtools_4.0.18.orig.tar.bz2
 44e44140de4e2d8abd0af8cbef38b5fc1f25bb7a 11240 mtools_4.0.18-2.1.debian.tar.xz
 16a82bcac1802cec8fcf96aa8e6f730f6ca41e63 51844 floppyd-dbgsym_4.0.18-2.1_amd64.deb
 f5d6a1bab6ac8cb9da9cd0d10b6a2fb385b09290 25356 floppyd_4.0.18-2.1_amd64.deb
 4c785fd242802e0b5d5db29e6addcd6c859534b9 372328 mtools-dbgsym_4.0.18-2.1_amd64.deb
 70f3f59cfa0c1abff010d4df34736003a74020b7 7224 mtools_4.0.18-2.1_amd64.buildinfo
 4baeb693134bb2162ef908ecfb0ba26d1fdd2c8d 181368 mtools_4.0.18-2.1_amd64.deb
Checksums-Sha256:
 7c7065a17d35ef0b00a015aa5b8bf515a3321335b17bd1e26e53d50a2e4eb9a9 1841 mtools_4.0.18-2.1.dsc
 59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85 420190 mtools_4.0.18.orig.tar.bz2
 7d7e78a31052c6c5009819378d3b11dc0c00fb27682a698e6c7635f5540aca71 11240 mtools_4.0.18-2.1.debian.tar.xz
 f603e9b64c93764fb4a13ac6d95b7e87d6ad59234764a12aa5eb549d87167899 51844 floppyd-dbgsym_4.0.18-2.1_amd64.deb
 63b8b8dcb2e4787dc80af2d384ff0335fc258d6e2e4756d8cc71beb85ebae86a 25356 floppyd_4.0.18-2.1_amd64.deb
 cba6c40e15360e5b229471499b7039a53c728f909034757020d2f7c9692c73f8 372328 mtools-dbgsym_4.0.18-2.1_amd64.deb
 ea175c126e0c29768d071501ff2d5031ca18487c968756782c4084008e1877f2 7224 mtools_4.0.18-2.1_amd64.buildinfo
 8136bcff153ce8cc819111fa024d6c28ba2b80eb14a50cd83e06340d6b110e02 181368 mtools_4.0.18-2.1_amd64.deb
Files:
 3def44f0749c86728fb557e72d473596 1841 otherosfs extra mtools_4.0.18-2.1.dsc
 a23646617546bf6ad56f061d8b283c85 420190 otherosfs extra mtools_4.0.18.orig.tar.bz2
 399faea805d1bc219e5b5a50362101b0 11240 otherosfs extra mtools_4.0.18-2.1.debian.tar.xz
 fe5d86283e42c6789c3ae191fd999c86 51844 debug optional floppyd-dbgsym_4.0.18-2.1_amd64.deb
 b977ae14cb53eeb1ea88a71cecadf234 25356 otherosfs extra floppyd_4.0.18-2.1_amd64.deb
 4e353edfdc03ca4886d76020379d610b 372328 debug optional mtools-dbgsym_4.0.18-2.1_amd64.deb
 5c26751aca04ff0f24b602a5f72947c4 7224 otherosfs extra mtools_4.0.18-2.1_amd64.buildinfo
 e10dbf322c4e45aa9e77dc597b9418ce 181368 otherosfs extra mtools_4.0.18-2.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAltYcAMACgkQHpU+J9Qx
HliBrg/9GnEu9Qncd4P5hNJwB1p0M1EeBBKixZkmDfQs1nmlPQdK/5lbR47VIuh/
YiskLanpkCBkFwpR0egwK5tiwPGuzsHUBx2sqco35Z7Jb+0gBtNpg6WpdR7ndg1q
37LH9A4k2Ab32bxcEltBabDQZ6lpciDG1p/o2UBsgRSapCmEjM3O3ZCCWGv89Pmo
TKEOJOfxEdfVF1Okkxhljick9jyvTxXLPxZHGl5Z6aTraU5bHh1sPGy7vjhrs2IV
JMeulzC0y2+HBR4hsIbldeVSbRtxjY4H+jaE4p2JFEzR3c61OoRGMTZYSwh6dDH1
+nGCHNd7b+hd+SE+iTRiM9yel7aKp+cQPCng003vL2Hkq/6jj7er0AI+wDI5gzcE
zvIMExqRt8yQMgN/YQu4kz2TGI5qj4hB62a7DE8WNHFneRjqLwsvRAb8ez6A4YDd
CDuuy0ejjWjPa37uUwYsKsJ26E689rXOR/Afg92DsEqvfT3VkLDu1F3SLetnvPw+
x26bVaSn3VYkmfRDCY9I7LfyzRmPB+VnG7azpSF3YLVTjJc/bYTtNw4Wk7Hi6YxI
8vgEemsXMX0fs+pOmS4jjCqD5aFRn6xqmhScS7y9QK+vlinpYrTrS7WSCc5grsMw
Vct+NlGsfqbGLv0qKLb/JKOOk0Xsb+JJIsyxlgrNd64z4MvZGqs=
=LK2w
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.