Debian Bug report logs - #897099
diffoscope FTBFS with file 5.33

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope FTBFS with file 5.33

Date: Sat, 28 Apr 2018 16:33:08 +0300

Source: diffoscope
Version: 93
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope.html

...
=================================== FAILURES ===================================
_________________________ test_text_proper_indentation _________________________

capsys = <_pytest.capture.CaptureFixture object at 0x7f3475f7c828>

    def test_text_proper_indentation(capsys):
        out = run(capsys, pair=('archive1.tar', 'archive2.tar'))
    
>       assert out == get_data('archive12.diff.txt')
E       assert '--- archive1... -a\\n\u2502 \u2502 +b\\n' == '--- archive1.... -a\\n\u2502 \u2502 +b\\n'
E           --- archive1.tar
E           +++ archive2.tar
E           \u251c\u2500\u2500 file list
E           \u2502 @@ -1 +1 @@
E           \u2502 --rw-r--r--   0 lamby     (1000) lamby     (1000)       22 2017-03-19 22:26:58.000000 compressed.gz
E           \u2502 +-rw-r--r--   0 lamby     (1000) lamby     (1000)       33 2017-03-19 22:27:42.000000 compressed.gz
E           \u251c\u2500\u2500 compressed.gz
E           \u2502 \u251c\u2500\u2500 filetype from file(1)
E           \u2502 \u2502 @@ -1 +1 @@
E         - \u2502 \u2502 -gzip compressed data, max compression, from Unix, original size 2
E         ?                                                      -----------------
E         + \u2502 \u2502 -gzip compressed data, max compression, from Unix
E         - \u2502 \u2502 +gzip compressed data, was "compressed", last modified: Sun Mar 19 22:27:42 2017, max compression, from Unix, original size 2
E         ?                                                                                                                 -----------------
E         + \u2502 \u2502 +gzip compressed data, was "compressed", last modified: Sun Mar 19 22:27:42 2017, max compression, from Unix
E           \u2502 \u251c\u2500\u2500 compressed
E           \u2502 \u2502 @@ -1 +1 @@
E           \u2502 \u2502 -a
E           \u2502 \u2502 +b
...
============= 9 failed, 362 passed, 18 skipped in 1001.16 seconds ==============
E: pybuild pybuild:336: test: plugin distutils failed with: exit code=1: cd /build/1st/diffoscope-93/.pybuild/cpython3_3.6/build; python3.6 -m pytest -vv -r sxX -l --cov=diffoscope --cov-report=term-missing --cov-report=html
dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.6 returned exit code 13
make: *** [debian/rules:35: binary] Error 25

Message #12 received at 897099@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Adrian Bunk <bunk@debian.org>, 897099@bugs.debian.org

Subject: Re: Bug#897099: diffoscope FTBFS with file 5.33

Date: Sun, 29 Apr 2018 06:15:51 +0100

clone 897099 -1
reassign -1 file
retitle -1 returns empty string for Berkeley DB databases
severity -1 important
found -1 5.33-1
affects -1 + diffoscope
thanks

Hi Adrian,

> FTBFS with file 5.33

So, the causes of these are different. The following tests:

  tests/comparators/test_gzip.py::test_metadata
  tests/comparators/test_ipk.py::test_metadata
  tests/test_presenters.py::test_text_proper_indentation
  tests/test_quines.py::test_difference
  tests/comparators/test_gzip.py::test_metadata
  tests/comparators/test_ipk.py::test_metadata

.. are failing because file 5.33 is now appending a ", original size
XXX" to some output:

  $ buster file -v | head -n1
  file-5.32
  
  $ buster file tests/data/quine.gz
  tests/data/quine.gz: gzip compressed data, was "recursive", from
          FAT filesystem (MS-DOS, OS/2, NT)

  $ sid file -v | head -n1
  file-5.33
  
  $ sid tests/data/quine.gz
  tests/data/quine.gz: gzip compressed data, was "recursive", from
           FAT filesystem (MS-DOS, OS/2, NT), original size 250

However, the following failing tests:

  tests/comparators/test_berkeley_db.py::test_identification
  tests/comparators/test_berkeley_db.py::test_diff
  tests/comparators/test_berkeley_db.py::test_compare_non_existing

... are caused by file returning an empty string for berkeley DB databases:

  $ file ./tests/data/test1.db
  ./tests/data/test1.db: , created: Thu Jan  1 00:38:24 1970
                        ^

Cloning and re-assigning this second issue.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 897099@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 897099@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: diffoscope FTBFS with file 5.33

Date: Sun, 29 Apr 2018 06:53:19 +0100

tags 897099 + pending
thanks

I've updated the diffoscope testsuite to support file 5.33:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=f800b207a3bde7450705f205ac37993d0666be5c

  tests/comparators/test_containers.py   | 8 +++++---
  tests/comparators/test_gzip.py         | 2 ++
  tests/comparators/test_ipk.py          | 2 ++
  tests/data/archive12.diff.txt          | 4 ++--
  tests/data/containers/magic_gzip       | 2 +-
  tests/data/gzip_metadata_expected_diff | 4 ++--
  tests/data/ipk_metadata_expected_diff  | 4 ++--
  tests/data/quine_expected_diff         | 2 +-
  tests/test_presenters.py               | 3 ++-
  tests/test_quines.py                   | 2 ++
  tests/utils/tools.py                   | 9 +++++++++
  11 files changed, 30 insertions(+), 12 deletions(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #24 received at 897099@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Adrian Bunk <bunk@debian.org>, 897099@bugs.debian.org

Subject: Re: Bug#897099: diffoscope FTBFS with file 5.33

Date: Sun, 29 Apr 2018 18:35:04 +0100

Chris Lamb wrote:

> Cloning and re-assigning this second issue.

This was #897153, which was fixed in src:file 1:5.33-1. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #29 received at 897099-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 897099-close@bugs.debian.org

Subject: Bug#897099: fixed in diffoscope 94

Date: Sun, 06 May 2018 06:04:30 +0000

Source: diffoscope
Source-Version: 94

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 897099@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 05 May 2018 22:44:44 -0700
Source: diffoscope
Binary: diffoscope
Architecture: source all
Version: 94
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 897099
Changes:
 diffoscope (94) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Update tests to prevent FTBFS under file 5.33. (Closes: #897099)
   * Remove all __pycache__ directories to avoid source-contains-empty-directory
     Lintian warning.
   * Remove unused test1.txt test data file.
   * Bump Standards-Version to 4.1.4.
 .
   [ anthraxx ]
   * Add gnumeric to the list of ArchLinux tools.
 .
   [ Paul Wise ]
   * Sort the Debian dependencies.
Checksums-Sha1:
 3dec3ad23c8546d05412274be2e9e8b9ceec8083 3450 diffoscope_94.dsc
 575fac5fa88864a2666b0d8f074cf3418b1308fc 8941372 diffoscope_94.tar.xz
 1d7702ab6ea43e8b8403aeb5468ba98360e0623f 119604 diffoscope_94_all.deb
 9910798300808d34de640cd220dbb1be00f3834f 21637 diffoscope_94_amd64.buildinfo
Checksums-Sha256:
 8b63af936de8952d09b3829c60fa4154015104dc4bb3b6c2a253db0701c3b71c 3450 diffoscope_94.dsc
 94b91868e792d0cb27f2a8a23e34768686b40135ee891a0877c3246edda3757f 8941372 diffoscope_94.tar.xz
 f037bb91be7f79245cf34265a0e82034f7e80f86568dd62ec30522e1f75caee6 119604 diffoscope_94_all.deb
 849b8f10862486653c9b84ad59d6bfb4b9a051df9067cc09452404c93c50e8ca 21637 diffoscope_94_amd64.buildinfo
Files:
 31fc101799de76f66c2f8c13999d231a 3450 devel optional diffoscope_94.dsc
 6b6970b8d1fdf08dc63390c6528c5bfb 8941372 devel optional diffoscope_94.tar.xz
 bdb11f0d5a7574308e8a1c147ba28416 119604 devel optional diffoscope_94_all.deb
 837053d5c4ef7b77716a91d85a88b6a1 21637 devel optional diffoscope_94_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlrumaQACgkQHpU+J9Qx
HliwmA//UJ/OTQNvywA8AI4kF+8kstYc71V4YzZ5U9knUsOfc2a/4Xuz23OzRBx2
z/qqA22UGo+ODNScACM6Jz5B6/PIvEjfgU5obMXXnwtzGZuVJouB1PgYKOZy4dyM
iAcdEgrCDu0CqQvZ8NexaC46e19vlnrTo1A/53Gzlb5SjpjAbvTF7Sg8iOKTeAq/
d/6Cku0/P6m6N2rmDurqbLk8IQARimFp81L589tDo2kjaQfYlH+8yf6RYgdLinZF
P7xiy3azBgRp768MeAgugHwSY1YovBkjMWaMmQZn5PcZYT4yemHUuD1aahEbZuyz
DFqh+bSHsFbMdHiTe0Hi58tF8PmsDI13pTN/9KtKUTsC+4hfzJteBGOs+Bb3vvwJ
53L6Yq/rzbQSIKH6spUqNKQCyom81mumQOJgz4JtKhG/Dw3EDFaDXRDYRUj/n8B1
/jlcB4sPBIWuywFiURLUS/ZsJ+wIIpnpeCGTwldp6OZzaPVQ7V6zeDHdM0Dp+wcy
MzLcKMirF0tG1cPJHrPoen7y5KReFDy7LD8fPTfkvrQwrhK1sov6PUcY7OK1Nj4P
Q3rXI+aIRd6nuxUSzsDzcAKjQSKJsEgabe7Wi7i8NeSp+u0CyCW96JfaFriSV4cu
9VfRSIBAOIccxVrO/Bzdq+n94GTQ/txY3riz0I4B+6kvfhFEdUk=
=BoGR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.