Debian Bug report logs - #892425
node-package-preamble: please make the output reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: node-package-preamble: please make the output reproducible

Date: Fri, 09 Mar 2018 02:19:26 +0000

[Message part 1 (text/plain, inline)]

Source: node-package-preamble
Version: 0.1.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that node-package-preamble generates output that is not
reproducible which is affecting the reproducibility of (at least)
5 packages.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[node-package-preamble.diff.txt (text/plain, attachment)]

Message #10 received at 892425@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 892425@bugs.debian.org

Subject: Re: node-package-preamble: please make the output reproducible

Date: Fri, 09 Mar 2018 02:25:17 +0000

forwarded 892425 https://github.com/mbostock/preamble/pull/4
thanks

I've forwarded this upstream here:

  https://github.com/mbostock/preamble/pull/4


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Ben Finney <bignose@debian.org>

Cc: submit@bugs.debian.org, 892425@bugs.debian.org

Subject: Re: Bug#892425: node-package-preamble: please make the output reproducible

Date: Fri, 09 Mar 2018 02:41:05 +0000

Hi Ben,

> Is this change generally useful to recipients of the upstream code base?
> Or is it specific to OS distributions?

It is generally useful, not specific to any OS.

> Does this constitute an improvement to the upstream code base? Or should
> remain a persistent patch in the Debian package?

Upstream. I've filed it here:

  https://github.com/mbostock/preamble/pull/4
 
> Does this change apply more generally to many JavaScript packages?

Not that I am aware of. It would only apply to a limit subset of
packages where:

  a) We use the output during a package build
  b) That output ends up in the resulting binaries
  c) The output actually is not reproducible (ie. dates).

(The only other example I can recall right now is in uglifyjs which
has non- determinstic dictionary ordering IIRC.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #22 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ben Finney <bignose@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: submit@bugs.debian.org, 892425@bugs.debian.org

Subject: Re: Bug#892425: node-package-preamble: please make the output reproducible

Date: Fri, 09 Mar 2018 13:34:28 +1100

Chris Lamb <lamby@debian.org> writes:

> diff --git a/bin/preamble b/bin/preamble
> index a563140..be96d96 100755
> --- a/bin/preamble
> +++ b/bin/preamble
> @@ -3,12 +3,17 @@
>  var os = require("os"),
>      fs = require("fs");
>  
> +var now = new Date();
> +if (process.env.SOURCE_DATE_EPOCH) {
> +  now = new Date((process.env.SOURCE_DATE_EPOCH * 1000) + (now.getTimezoneOffset() * 60000));
> +}
> +
>  fs.readFile("package.json", "utf8", function(error, text) {
>    if (error) throw error;
>    var json = JSON.parse(text);
>    process.stdout.write("// " + (json.homepage || json.name)
>        + " Version " + json.version + "."
> -      + " Copyright " + (new Date).getFullYear()
> +      + " Copyright " + now.getFullYear()
>        + " " + json.author.name + (/\.$/.test(json.author.name) ? "" : ".")
>        + os.EOL);
>  });

Is this change generally useful to recipients of the upstream code base?
Or is it specific to OS distributions?

Does this constitute an improvement to the upstream code base? Or should
remain a persistent patch in the Debian package?

Does this change apply more generally to many JavaScript packages?

-- 
 \           “I prayed for twenty years but received no answer until I |
  `\          prayed with my legs.” —Frederick Douglass, escaped slave |
_o__)                                                                  |
Ben Finney <bignose@debian.org>

Message #37 received at 892425@bugs.debian.org (full text, mbox, reply):

From: Ben Finney <bignose@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 892425@bugs.debian.org

Subject: Re: Bug#892425: node-package-preamble: please make the output reproducible

Date: Fri, 9 Mar 2018 13:46:13 +1100

[Message part 1 (text/plain, inline)]

On 09-Mar-2018, Chris Lamb wrote:

> Upstream. I've filed it here:
>   https://github.com/mbostock/preamble/pull/4

I see that now, thank you.

> > Does this change apply more generally to many JavaScript packages?
> Not that I am aware of. It would only apply to a limit subset of
> packages where […]

Great, thank you for indulging my curiosity.

-- 
 \       “During the Middle Ages, probably one of the biggest mistakes |
  `\   was not putting on your armor because you were ‘just going down |
_o__)                                    to the corner.’” —Jack Handey |
Ben Finney <bignose@debian.org>

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 892425@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 892425@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#892425: node-package-preamble: please make the output reproducible

Date: Thu, 03 Sep 2020 22:58:03 -0000

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #47 received at 892425@bugs.debian.org (full text, mbox, reply):

From: Xavier <yadd@debian.org>

To: Chris Lamb <lamby@debian.org>, 892425@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: [Pkg-javascript-devel] Bug#892425: node-package-preamble: please make the output reproducible

Date: Fri, 4 Sep 2020 06:05:03 +0200

Le 04/09/2020 à 00:58, Chris Lamb a écrit :
> Chris Lamb wrote:
> 
>> [..]
> 
> Friendly ping on this?
> 
> 
> Regards,

Hi,

I think we already fix that with https://bugs.debian.org/935790

Duplication ?

Cheers,
Xavier

Message #52 received at 892425-done@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Xavier Guimard" <yadd@debian.org>, 892425-done@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: [Pkg-javascript-devel] Bug#892425: node-package-preamble: please make the output reproducible

Date: Fri, 04 Sep 2020 10:28:59 +0100

Hi Xavier,
 
> I think we already fix that with https://bugs.debian.org/935790

Ah yes, well-spotted. Closing this bug accordingly.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.