Debian Bug report logs - #892420
nova: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: nova: please make the build reproducible

Date: Fri, 09 Mar 2018 00:07:51 +0000

[Message part 1 (text/plain, inline)]

Source: nova
Version: 2:17.0.0~rc1-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that nova could not be built reproducibly as the docs etc contain
the absolute build path.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[nova.diff.txt (text/plain, attachment)]

Message #10 received at 892420@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 892420@bugs.debian.org

Subject: Re: nova: please make the build reproducible

Date: Fri, 09 Mar 2018 00:29:39 +0000

forwarded 892420 https://github.com/openstack/nova/pull/80
thanks

I've forwarded this upstream here:

  https://github.com/openstack/nova/pull/80


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 892420@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: 892420@bugs.debian.org, Chris Lamb <lamby@debian.org>

Subject: nova: please make the build reproducible

Date: Fri, 9 Mar 2018 13:19:57 +0100

Hi Chris,

It is very nice of you to attempt to upstream the reproducible build
patches for OpenStack. While it did work for Gnocchi (which is now away
from the "normal" OpenStack infrastructure), it didn't for Nova, as it's
not really using Github.

Code from git.openstack.org is only pushed to github as a copy of the
original code, and to send a patch, you have to use "git review" and
Gerrit. You also need to sign the CLA (unfortunately). If you have never
contributed to OpenStack before make sure you have read the getting
started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started

The way to do it once you've created a new Gerrit username (as per
above) is to install git-review on your machine, simply make a Git
commit as usual, and then just type "git review". This will open a patch
review process in upstream OpenStack.

I have therefore forwarded your patch here:

https://review.openstack.org/551269

Cheers,

Thomas Goirand (zigo)

Message #22 received at 892420@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Thomas Goirand <zigo@debian.org>, 892420@bugs.debian.org

Subject: Re: nova: please make the build reproducible

Date: Fri, 09 Mar 2018 16:49:15 +0000

Hi Thomas,

> https://review.openstack.org/551269

Thanks for doing this. :)  But wouldn't it make more sense — as the
package maintainer in Debian — for you to handle these? :)

Sure, if the patch was huge, added features or was otherwise invasive
I would perfectly understand going to upstream, but for these smaller
changes I can't help but feel this is the responsibility of the
maintainer in Debian.

This is especially so as there seems to be a number of things one needs
to do to get a single line upstream, such as the CLA (meh..) as well as
knowing how to use navigate Gerrit and even to know *where* to send
the patch.

Thoughts?


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #27 received at 892420@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Chris Lamb <lamby@debian.org>, 892420@bugs.debian.org

Subject: Re: [PKG-Openstack-devel] Bug#892420: nova: please make the build reproducible

Date: Sat, 10 Mar 2018 00:13:38 +0100

On 03/09/2018 05:49 PM, Chris Lamb wrote:
> Hi Thomas,
> 
>> https://review.openstack.org/551269
> 
> Thanks for doing this. :)  But wouldn't it make more sense — as the
> package maintainer in Debian — for you to handle these? :)

Of course it does make sense. Though I told you because you attempted to
upstream the patch using github, and I thought it was best to let you
know that you shouldn't do that, because it's a waste of time: the pull
request will automatically be closed telling you to use gerrit.

I also feel like cheating you if I upload the change, and then take over
the ownership of the patch. If you're ok with that, then I'm very happy
to have a few patch here and there in OpenStack, so I can participate in
the elections of the leaders of each project ! It's always nice to have
the opportunity to vote for friends.

> Sure, if the patch was huge, added features or was otherwise invasive
> I would perfectly understand going to upstream, but for these smaller
> changes I can't help but feel this is the responsibility of the
> maintainer in Debian.

Sure.

> This is especially so as there seems to be a number of things one needs
> to do to get a single line upstream, such as the CLA (meh..) as well as
> knowing how to use navigate Gerrit and even to know *where* to send
> the patch.

FYI, there's just the CLA once (I don't like it either... though it's
the nicer type of CLA, where you just confirm you're using the upstream
Apache-2.0 license for all of your contrib, nothing more), and then
nothing else to know about. Just "git review" and it will send the patch
to the correct place automatically (thanks to the .gitreview file in
each project). The only other thing there is to know is from were to
clone the upstream source. If it's a package from Debian OpenStack team,
then either there's an UPSTREAM_GIT= in debian/rules, or it's
systematically from https://git.openstack.org/<FOO> (or from Github
which holds a copy).

Again, all I'm telling here, you don't need to know, I'm very happy to
upstream these patches myself, I just didn't want you to waste your time
sending patches as Github pull requests which goes nowhere.

Thanks for your patch, and working on reproducible-build,
Cheers,

Thomas Goirand (zigo)

Message #32 received at 892420@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Thomas Goirand <zigo@debian.org>, 892420@bugs.debian.org

Subject: Re: [PKG-Openstack-devel] Bug#892420: nova: please make the build reproducible

Date: Sat, 10 Mar 2018 00:05:06 +0000

Hi Thomas,

> Of course it does make sense. Though I told you because you attempted to
> upstream the patch using github, and I thought it was best to let you
> know that you shouldn't do that, because it's a waste of time

That was considerate of you, thanks :)  But don't worry too much; 
have some shell aliases that semi-automate it so I only expended
about five minutes on it.

Oh, you might wish to update:

  Source: https://github.com/openstack/nova.git

.. in debian/copyright (and possibly other reference).

> I also feel like cheating you if I upload the change, and then take over
> the ownership of the patch.

Not at all! And you should get a vote; indeed, I would have thought
you would have one anyway as someone who takes care of that in Debian.
It would definitely make sense for you to have a vote.

(Feel free to take over the patch entirely; it is so trivial anyway
it's probably not even copyrightable...)

> Thanks for your patch, and working on reproducible-build,

A pleasure as always :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #39 received at 892420-close@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: 892420-close@bugs.debian.org

Subject: Bug#892420: fixed in nova 2:17.0.3-12

Date: Tue, 05 Jun 2018 07:50:07 +0000

Source: nova
Source-Version: 2:17.0.3-12

We believe that the bug you reported is fixed in the latest version of
nova, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 892420@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated nova package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 05 Jun 2018 09:33:02 +0200
Source: nova
Binary: nova-api nova-cells nova-common nova-compute nova-compute-ironic nova-compute-kvm nova-compute-lxc nova-compute-qemu nova-conductor nova-console nova-consoleauth nova-consoleproxy nova-doc nova-placement-api nova-scheduler nova-volume python3-nova
Architecture: source all
Version: 2:17.0.3-12
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <openstack-devel@lists.alioth.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Description:
 nova-api   - OpenStack Compute - compute API frontend
 nova-cells - Openstack Compute - cells
 nova-common - OpenStack Compute - common files
 nova-compute - OpenStack Compute - compute node
 nova-compute-ironic - OpenStack Compute - compute node (Ironic)
 nova-compute-kvm - OpenStack Compute - compute node (KVM)
 nova-compute-lxc - OpenStack Compute - compute node (LXC)
 nova-compute-qemu - OpenStack Compute - compute node (QEmu)
 nova-conductor - OpenStack Compute - conductor service
 nova-console - OpenStack Compute - console
 nova-consoleauth - OpenStack Compute - Console Authenticator
 nova-consoleproxy - OpenStack Compute - NoVNC proxy
 nova-doc   - OpenStack Compute - documentation
 nova-placement-api - OpenStack compute - placement API
 nova-scheduler - OpenStack Compute - virtual machine scheduler
 nova-volume - OpenStack Compute - storage metapackage
 python3-nova - OpenStack Compute - libraries
Closes: 892420
Changes:
 nova (2:17.0.3-12) unstable; urgency=medium
 .
   * Refreshed patches.
   * Add make-nova-reproducible.patch (Closes: #892420).
Checksums-Sha1:
 858d085c01e51736b67e842aa3300bb3fbdc9703 5675 nova_17.0.3-12.dsc
 ab1df1412c5d4df23ca73942f444aa31702d608d 53392 nova_17.0.3-12.debian.tar.xz
 c651a24d38ddf8b64e74bcc235c455f998f2b1bd 38160 nova-api_17.0.3-12_all.deb
 5cbaec2a2c70043afea068ae48f0af9a459d51d9 23740 nova-cells_17.0.3-12_all.deb
 fadf78a831cd94e33e1862af72fba989a2c41b0e 129224 nova-common_17.0.3-12_all.deb
 9572f63fd44fd9adc95a92e5ce3bc28e359fd4ce 20948 nova-compute-ironic_17.0.3-12_all.deb
 3959f458c9b06a5161e1af9e117bf60e769ba28b 21052 nova-compute-kvm_17.0.3-12_all.deb
 617847e017ce98c89e448a99c8079e7ab59870f8 20912 nova-compute-lxc_17.0.3-12_all.deb
 f06107dc5ee90d16a71e71e80e78214a4dcde5e1 20936 nova-compute-qemu_17.0.3-12_all.deb
 50305356fba7d7f91266aba7aad05e7bd92c951f 26752 nova-compute_17.0.3-12_all.deb
 6cfb9682bfe3b4972797498c1786b44daf16f686 24620 nova-conductor_17.0.3-12_all.deb
 3a706a0140360ce02e080321dea50f14e23095dc 24732 nova-console_17.0.3-12_all.deb
 4e6a1a88078d376b0b13b5adb0f4c945451bb552 24708 nova-consoleauth_17.0.3-12_all.deb
 0d8960f2a4bc5909ac73595ac9f20edb5e7710a6 29552 nova-consoleproxy_17.0.3-12_all.deb
 107a475367f9a68a2bbe7854cc20b6d6ad20c649 3090476 nova-doc_17.0.3-12_all.deb
 31fc1f2ed99d96e40fc32830212860224580b41b 35704 nova-placement-api_17.0.3-12_all.deb
 31b74e82b68ff7fa2ee2c44b0dc537a675162848 24644 nova-scheduler_17.0.3-12_all.deb
 be4b6a315e1d181ef65a77b726902eebd91f08a0 20600 nova-volume_17.0.3-12_all.deb
 4928d33eb7e8fa3ae39e9c3ab12da002f3177572 24276 nova_17.0.3-12_amd64.buildinfo
 67cab5e4e013096f7abb63ddbb3fc5a38f47e49f 2840416 python3-nova_17.0.3-12_all.deb
Checksums-Sha256:
 73a1a4b3427029ea972ec646a76222c17167b853e906274a4bbe05801a656858 5675 nova_17.0.3-12.dsc
 130f2c1027276e928041ae4cbc00bbe138fd459b8ef62f37606ae888b0305aa4 53392 nova_17.0.3-12.debian.tar.xz
 e289910b5d2d16388cc46bfb335fc1fbbe4c6028ecaa6c8f00ec312106d23393 38160 nova-api_17.0.3-12_all.deb
 1407f70119a3d15fd8df18353ede5892ab9ba942beb979bd17bf0085eced4024 23740 nova-cells_17.0.3-12_all.deb
 31653cce005c0754b55dcbc8ca09716e6facee4b1836f095dd2cc85202417751 129224 nova-common_17.0.3-12_all.deb
 431e56a38b94ee9f6c0407fed24f26c38f699db9d9d4e934ea6bb49752a95538 20948 nova-compute-ironic_17.0.3-12_all.deb
 48a477e300db49a79b6a94964c56623c639c73d8aa5fa0b01b842a0c65c516cd 21052 nova-compute-kvm_17.0.3-12_all.deb
 76b3c0cde3cef4e774c60c36b92dac49e4ecad12e8e5ae0fe271dc9ba99883f5 20912 nova-compute-lxc_17.0.3-12_all.deb
 63feaef7e1ff7006bcc1b8f8a726a2ae015d32ee31228a30632c1ddd0c22165a 20936 nova-compute-qemu_17.0.3-12_all.deb
 969d805a10bf28332963753675fed312e733f81ee6c1330b2fedf24b167daae3 26752 nova-compute_17.0.3-12_all.deb
 deb40a3563189ad52440a05f86c5088797b1448751404c4d0b9f5b85c4f7047d 24620 nova-conductor_17.0.3-12_all.deb
 6f2ad7bf1741a56ba075264d1be4703fe34ec2df1d6573bf67f38945343aac1b 24732 nova-console_17.0.3-12_all.deb
 ad199338c73c3c687fd973097160eb829fd250a699340ebd66c317d8995a5fcc 24708 nova-consoleauth_17.0.3-12_all.deb
 3b12002d8190efcc3fc41d66c3db4bf4934914a0dc7fb48a8dba7fa97b17fa70 29552 nova-consoleproxy_17.0.3-12_all.deb
 230b4dc45fe47b8a6dfcad8f5e82bc6f843f4c0d9e251d4da5dc63d31f2aa270 3090476 nova-doc_17.0.3-12_all.deb
 d76a1f199695f5ce52571031ec60fac5591e26ce74fb642a010d4b93da1f846b 35704 nova-placement-api_17.0.3-12_all.deb
 1e6f89969304b465f76e1537ecbd2a88439c0cb37b6bca4888efccc02988d695 24644 nova-scheduler_17.0.3-12_all.deb
 c76b9d61c975725e66793f3cf56ed10846e4cd7b550b3e458ea8b96147f898aa 20600 nova-volume_17.0.3-12_all.deb
 d800e065a4477444c2b26a2047e95d2354d379cc8a84e15c0f2cddb78a70f10e 24276 nova_17.0.3-12_amd64.buildinfo
 f004d6c99feef832f08b1b09f3ed73f1d840cc7c7af493d0beb79020bacb1f4e 2840416 python3-nova_17.0.3-12_all.deb
Files:
 5f428b9653388a4d41470039aea476ac 5675 net optional nova_17.0.3-12.dsc
 c14286fe393e4a458f01dc4c264b1950 53392 net optional nova_17.0.3-12.debian.tar.xz
 598b4630c5bffa1e09d2302425804201 38160 net optional nova-api_17.0.3-12_all.deb
 d91650342bfe80e7864d9ae6f1bf5f1b 23740 net optional nova-cells_17.0.3-12_all.deb
 62738ea169d224f6f5f5f685565cc17b 129224 net optional nova-common_17.0.3-12_all.deb
 33642351198efcb204bf8f0f9eafc1ec 20948 net optional nova-compute-ironic_17.0.3-12_all.deb
 f362f6409fb0aeb49bf3f89b37b34b4e 21052 net optional nova-compute-kvm_17.0.3-12_all.deb
 334dce34782f1a5821ce73e868ed26d3 20912 net optional nova-compute-lxc_17.0.3-12_all.deb
 39b7e09ca5ea7b5c8b33144663e6c187 20936 net optional nova-compute-qemu_17.0.3-12_all.deb
 ba3b78c26a86bcf306217bbe4c81fbef 26752 net optional nova-compute_17.0.3-12_all.deb
 7521475e671d25d25c8ce05f95521b84 24620 net optional nova-conductor_17.0.3-12_all.deb
 1073eb45e22fc317915040458101ef57 24732 net optional nova-console_17.0.3-12_all.deb
 438ac881dd2c56a5f2bd984ecb2f4a62 24708 net optional nova-consoleauth_17.0.3-12_all.deb
 3e890e5ed6061243be955b6980b2d71b 29552 net optional nova-consoleproxy_17.0.3-12_all.deb
 aac1a6ba77017166aeaf0ffe1bc1443a 3090476 doc optional nova-doc_17.0.3-12_all.deb
 22d7affa6eb311344abcde5d98ff6745 35704 net optional nova-placement-api_17.0.3-12_all.deb
 cbad492a10d34a5f51c9330ef3fb5fc8 24644 net optional nova-scheduler_17.0.3-12_all.deb
 ec1122caaf0a7257abb547c03fe2f816 20600 oldlibs optional nova-volume_17.0.3-12_all.deb
 2caef0435d31c938225b9bf91b499a78 24276 net optional nova_17.0.3-12_amd64.buildinfo
 03b366af0d1bb5e6c4ac3c9b30d1b174 2840416 python optional python3-nova_17.0.3-12_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEtKCq/KhshgVdBnYUq1PlA1hod6YFAlsWPhwACgkQq1PlA1ho
d6Yrkg/+NUwlzQu1gBhrQg/wtn36nBMYC/GzPCiOjR39HXd2ktIuHtwrgswFFWR6
yow9MiYrYasvHngMdX9h+ADMIlQ+ExZgTFWDaFosW3t/0yGnTk+54lmjp8gtZ1LS
QY8otX40NwNciR0YTi2vbl/W7AQKtSCDzbKaw3frEg4zbKMfRD2+4DU5XTLTMKTN
FTRPtigelJNNGEX33xsnBZdlUyuOoEnQk0K6gHBA4MRk0EyFzHDfD8nRvU7/QT3o
znjjJRkJ/HC5WAmPZoadAVfC7+7futfm9BhgcgPJzekvVAgw9yLNBf8Jk8xjGNcX
eb2e+EPk8xYGKZoQZ7tzeeHebbAJZqDWJL9byjAaO3G3whCop0l75TFKJBSMG8KA
raeeh6Qey5Qdx4bEvui/F72BVwB5f8NQ+tPiU9HRsAc44WV3lYKYUteyY6/USeHe
wErNk1/NCf0heBR45e31/WxW9VdNDwkZr3X/aE5kKR2XdFaZEQjq7DxVzbB3avzN
5lZaaaq480infx5eO3jKuRhKc+AInqR4skE4LdqJqw/NHFeFbcG/MSQL5h3sw9u4
pBVvvesgusiyC0ENk8RE0fHHCuA48OD45FVqR3INniCb75C1ZEeTX8fdUOrGFa/O
a5L4wNGlazWIVQIp7kXptCU6fACdfH2v2pG4yOx8BvLo/1fIWgs=
=6Wuh
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.