Debian Bug report logs - #890577
tkgate: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: tkgate: please make the build reproducible

Date: Fri, 16 Feb 2018 08:27:51 +0000

[Message part 1 (text/plain, inline)]

Source: tkgate
Version: 2.0~b10-5
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that tkgate could not be built reproducibly.

This is because it includes the output of `pwd` in the resulting
binary (which is useless/broken for an end-user, as well as being
a privacy leak of the builder).

Patch attached that sets TKGATE_SECONDARYHOME from TKGATE_HOMEDIR.
This is cleaner than removing the TKGATE_SECONDARYHOME mechanism
as the patch for _that_ would be:

  --- a/src/tkgate/tkgate.c	2018-02-16 07:56:06.421183383 +0000
  --- b/src/tkgate/tkgate.c	2018-02-16 08:27:09.286827217 +0000
  @@ -122,32 +122,29 @@
    * 1) Directory specified by TKGATE_HOME environment variable
    * 2) Current directory
    * 3) Directory specified by TKGATE_HOMEDIR in config.h
  - * 4) Directory specified by TKGATE_SECONDARYHOME in config.h
    *
    * The #define value TKGATE_HOMEDIR is normally generated automatically by the
    * configure script using TKGATE_HOMEDIRBASE as a prefix and tkgate-x.y (where
  - * x.y is the version number) the subdirectory.  The #define value TKGATE_SECONDARYHOME
  - * is normally set to the directory in which tkgate was configured/compiled.
  + * x.y is the version number) the subdirectory.
    *
    *****************************************************************************/
   void findTkGateHome(char *homeDir)
   {
     char buf[STRMAX];
  -  char *trydirs[4];
  +  char *trydirs[3];
     int i;
   
     trydirs[0] = getenv("TKGATE_HOME");
     trydirs[1] = getcwd(buf,STRMAX);
     trydirs[2] = TKGATE_HOMEDIR;
  -  trydirs[3] = TKGATE_SECONDARYHOME;
   
  -  for (i = 0;i < 4;i++) {
  +  for (i = 0;i < 3;i++) {
       if (!trydirs[i]) continue;
       strcpy(homeDir,trydirs[i]);
       if (testHome(homeDir)) break;
     }
   
  -  if (i == 4) {
  +  if (i == 3) {
       printf("\n");
       printf("I could not locate the tkgate home directory.  I tried looking in:\n");
       if (trydirs[0]) printf("  %s  (environment variable)\n", trydirs[0]);


.. which is a little bizarre, not helped by the "magic numbers" used by
upstream :)


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[tkgate.diff.txt (text/plain, attachment)]

Message #10 received at 890577-close@bugs.debian.org (full text, mbox, reply):

From: Georges Khaznadar <georgesk@debian.org>

To: 890577-close@bugs.debian.org

Subject: Bug#890577: fixed in tkgate 2.0~b10-6

Date: Sat, 17 Feb 2018 21:49:36 +0000

Source: tkgate
Source-Version: 2.0~b10-6

We believe that the bug you reported is fixed in the latest version of
tkgate, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 890577@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Georges Khaznadar <georgesk@debian.org> (supplier of updated tkgate package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 17 Feb 2018 18:25:41 +0100
Source: tkgate
Binary: tkgate tkgate-data tkgate-doc
Architecture: source all amd64
Version: 2.0~b10-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Georges Khaznadar <georgesk@debian.org>
Description:
 tkgate     - Tcl/Tk based digital circuit editor and simulator
 tkgate-data - Tcl/Tk based digital circuit editor and simulator - data files
 tkgate-doc - Tcl/Tk based digital circuit editor and simulator - documentation
Closes: 860493 887918 890577
Changes:
 tkgate (2.0~b10-6) unstable; urgency=medium
 .
   * updated Vcs-Browser and Vcs-Git fields in d/control to take in
     account the new repository salsa.d.o
   * made the dependency tkgate -> tkgate-data more precise regarding the
     version number
   * checked that dhelp is no longer a dependency. Closes: #860493
   * recompiled against the latest versions of Tcl/Tk. Closes: #887918
   * applied Chris Lamb's patch. Closes: #890577
   * updated debian/copyright
   * removed the obsoleted field DM-Upload-Allowed from d/control
   * removed debian/menu since there is a desktop file
Checksums-Sha1:
 de9e5a7c73b2e8f0b415ac5081aee95fd1b94860 2181 tkgate_2.0~b10-6.dsc
 c7c30f619de8138c8f1af87302e4eb4c298a758f 8436 tkgate_2.0~b10-6.debian.tar.xz
 500d2fd4b24884dc574d11ce7711c03d86973b4d 1087272 tkgate-data_2.0~b10-6_all.deb
 7351e791a1975815989ee0efa001a7a81b22e58c 4019032 tkgate-dbgsym_2.0~b10-6_amd64.deb
 8c3e0d125126f566e1958dfc716c1c7f43ecdd61 3250892 tkgate-doc_2.0~b10-6_all.deb
 ece1d0b5bf6583982796dd832bfa19dc8c81ceb1 7804 tkgate_2.0~b10-6_amd64.buildinfo
 4e053d8b3f9b1894a688d81d3b02709bf3156923 400912 tkgate_2.0~b10-6_amd64.deb
Checksums-Sha256:
 967bb48c78688f00da604cd688385e9ccffbf226aec4ab79cc0c592ae658b2d9 2181 tkgate_2.0~b10-6.dsc
 c43cdbc2fce590c00e71b2e6db2fc0cbc6799d4e752a33d65d9a2c2123a37d50 8436 tkgate_2.0~b10-6.debian.tar.xz
 72f3866b5d8aa3157a7e4d9c0a0c83a4d945dbcfda2718ae21007a8851dfa2c9 1087272 tkgate-data_2.0~b10-6_all.deb
 8395d5164a339a93cd855b53c086ca6b3aeea70a575549e89a19b1aa5a806c55 4019032 tkgate-dbgsym_2.0~b10-6_amd64.deb
 92b1e6eaa5e5c7a26d4fb21e2552c9eecdc9a5d4b550a0ca9c4edc71dbfd88e2 3250892 tkgate-doc_2.0~b10-6_all.deb
 d60b07cd4fd9fea191778c1617436bb3d63b39f8bef861f7953dad98f65725ae 7804 tkgate_2.0~b10-6_amd64.buildinfo
 027af161fffc003eaa01bc34f1a6ed7dcc902188428fbd15c1de8eeb3ac5612a 400912 tkgate_2.0~b10-6_amd64.deb
Files:
 9f6e1192c09ad36857ca4cb8deb8eb59 2181 electronics optional tkgate_2.0~b10-6.dsc
 a48074314ba2123fe036d64e650191c4 8436 electronics optional tkgate_2.0~b10-6.debian.tar.xz
 f1dac2c349b1c3fe4c00e5c5af106fe6 1087272 electronics optional tkgate-data_2.0~b10-6_all.deb
 fc44859da43a23ea249770b778fe0498 4019032 debug optional tkgate-dbgsym_2.0~b10-6_amd64.deb
 73a1a0ba22c9d4efdd3033814ba5a090 3250892 doc optional tkgate-doc_2.0~b10-6_all.deb
 a92bf483f791e45a0949fb469980ae96 7804 electronics optional tkgate_2.0~b10-6_amd64.buildinfo
 b953ee5642f575850c2c2e5ef8d06c35 400912 electronics optional tkgate_2.0~b10-6_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEM0CzZP9nFT+3zK6FHCgWkHE2rjkFAlqIm7oACgkQHCgWkHE2
rjkPvhAAshuMHX3RYBGvoI4jmHgnvDaZUvsgNxQCFiekgwWmZBnK0bU7t3iaF/5Q
FMpIwBg2PiGaeyVdhdRjsqJdxpi+e8mvFU/w2d7DS7qwsiWSmYznhyBXWvZHfP8y
HRy2WcvfJ0kulN/CBmZ6PQfbbwajlGVMrl2YZgFawuhSY/SeYRsIJtB/pjg0xxAv
8yW2+QNNn3QdSZaOi2F7TYp4KfyloktZEJCO+Hu0ZevukVNl9Hyz44dg1UBKJrDY
acUgvFbRMfSOLqLSdHSFHflKfeej37u9IArkgV9Lx2IDIPtqWlLdZMRztpvMn8F/
8KQ17kZTI6V+V3EIxIr9Wl/16qKZdS/A6UB+h3gP5K8oxYmd8w9epnYksGKOIbz4
L+jgHOr4UxlwQTmwSAH9KJv74bgS4P31y7T7Zn9EX5Ry0y+w40RAvvA+WjaQroVl
lKcUTwO2Wv71rT34JgMr8d/f1gtENQPuYBvUXW8jzuWyqBGDIJLoqjXRV1pgsFUU
Y/nXEP1pzkpuiM49qjc/H5ZqCfp4kp4tpulOtYGNi7NBR52v0V1JxI7gjTrqbUef
LT81d9D77wjPOrMgLbT1Kse2Nact33U6Pw//AL6Ct3L1Z7FYN9DH99lX32MIF3by
u5krAwWkgUrvaZnABVSHbElmfB8f2au/6Tz0ZO6e3eAEu4caMo4=
=I9B/
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.