Debian Bug report logs - #890568
libdashel-dev: dashelConfig.cmake(.in) broken

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Aaron M. Ucko" <ucko@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libdashel-dev: dashelConfig.cmake(.in) broken

Date: Thu, 15 Feb 2018 21:08:02 -0500

Package: libdashel-dev
Version: 1.3.3-4
Severity: serious
Justification: makes other packages FTBFS

Greetings.

In the course of making dashelConfig.cmake reproducible, you
inadvertently broke it altogether.  Builds of aseba against
libdashel-dev 1.3.3-4 [1][2] have been failing with the errors

  CMake Error at /usr/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
    Could NOT find dashel (missing: dashel_LIBRARIES dashel_INCLUDE_DIRS)
  Call Stack (most recent call first):
    /usr/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
    /usr/share/dashel/CMake/dashelConfig.cmake:47 (find_package_handle_standard_args)
    CMakeLists.txt:66 (find_package)

Could you please rework this patch?

Thanks!

[1] https://buildd.debian.org/status/fetch.php?pkg=aseba&arch=mips64el&ver=1.6.0-2&stamp=1518688831&raw=0
[2] https://buildd.debian.org/status/fetch.php?pkg=aseba&arch=mipsel&ver=1.6.0-2&stamp=1518686286&raw=0

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu

Message #12 received at 890568@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: "Aaron M. Ucko" <ucko@debian.org>, 890568@bugs.debian.org

Subject: Re: Bug#890568: libdashel-dev: dashelConfig.cmake(.in) broken

Date: Fri, 16 Feb 2018 08:12:43 +0000

[Message part 1 (text/plain, inline)]

tags 890568 + patch
thanks

Hi Aaron,

> In the course of making dashelConfig.cmake reproducible, you
> inadvertently broke it altogether.  Builds of aseba against
> libdashel-dev 1.3.3-4 [1][2] have been failing

Really sorry about that. Updated patch (also attached):
 
  --- dashel-1.3.3.orig/dashelConfig.cmake.in
  +++ dashel-1.3.3/dashelConfig.cmake.in
  @@ -42,8 +42,8 @@ else (WIN32)
   endif (WIN32)
   
   # Standard search
  -find_path(dashel_INCLUDE_DIRS dashel/dashel.h @PROJECT_SOURCE_DIR@ CMAKE_FIND_ROOT_PATH_BOTH)
  -find_library(dashel_LIBRARY dashel @PROJECT_BINARY_DIR@ CMAKE_FIND_ROOT_PATH_BOTH)
  +find_path(dashel_INCLUDE_DIRS dashel/dashel.h CMAKE_FIND_ROOT_PATH_BOTH)
  +find_library(dashel_LIBRARY dashel CMAKE_FIND_ROOT_PATH_BOTH)
   set(dashel_LIBRARIES ${dashel_LIBRARY} ${EXTRA_LIBS})
   include(FindPackageHandleStandardArgs)
   find_package_handle_standard_args(dashel DEFAULT_MSG dashel_LIBRARIES dashel_INCLUDE_DIRS)

I can confirm this then builds with aseba.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[reproducible-build.patch (text/x-patch, attachment)]

Message #19 received at 890568-close@bugs.debian.org (full text, mbox, reply):

From: Georges Khaznadar <georgesk@debian.org>

To: 890568-close@bugs.debian.org

Subject: Bug#890568: fixed in dashel 1.3.3-5

Date: Fri, 16 Feb 2018 15:21:16 +0000

Source: dashel
Source-Version: 1.3.3-5

We believe that the bug you reported is fixed in the latest version of
dashel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 890568@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Georges Khaznadar <georgesk@debian.org> (supplier of updated dashel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 16 Feb 2018 14:16:55 +0100
Source: dashel
Binary: libdashel1 libdashel-dev
Architecture: source amd64
Version: 1.3.3-5
Distribution: unstable
Urgency: medium
Maintainer: Georges Khaznadar <georgesk@debian.org>
Changed-By: Georges Khaznadar <georgesk@debian.org>
Description:
 libdashel-dev - Dashel Library development files
 libdashel1 - Cross-platform DAta Stream Helper Encapsulation Library
Closes: 890568
Changes:
 dashel (1.3.3-5) unstable; urgency=medium
 .
   * applied the new patch from Chris Lamb. Closes: #890568
Checksums-Sha1:
 5b572725fa0f000c6057af917a614e1d1c20aca8 1927 dashel_1.3.3-5.dsc
 7dfd7b4aaf885c404c4de9b0af76efa77de27107 13296 dashel_1.3.3-5.debian.tar.xz
 ae619c7688120bc983d63ea00c30009caa298927 6810 dashel_1.3.3-5_amd64.buildinfo
 b451884b97e44e57404f293e90ed453e6e7eacd3 49548 libdashel-dev_1.3.3-5_amd64.deb
 c9ebf4f116089aef7c91ad4b242ba9b60081f2b4 341820 libdashel1-dbgsym_1.3.3-5_amd64.deb
 31f96a9aa2a8a51fa31bf630729d4c0a733d7615 45884 libdashel1_1.3.3-5_amd64.deb
Checksums-Sha256:
 f2356624be24e78924400751ecd893e5323a93e7196b7b087afa8b1b63a60739 1927 dashel_1.3.3-5.dsc
 ea253a5d83709a467b513a77f9e58a23773b826c67baeee3b905a621963f2fd8 13296 dashel_1.3.3-5.debian.tar.xz
 2988df241867527989404629876529f2fc3ab4ff7c0ccf3209e26df67bf7fee1 6810 dashel_1.3.3-5_amd64.buildinfo
 861334cd4830d803402b44a6842fd9030b07ee35d202e4c357227a5d4ebfbcce 49548 libdashel-dev_1.3.3-5_amd64.deb
 209c7487e4996614b26799cc94abcd32a73617017e2f28364722feb658e8b6d1 341820 libdashel1-dbgsym_1.3.3-5_amd64.deb
 51d85d2bc004b2aeb0e541be6d715d5de25a331a50402486d791f13f123e5095 45884 libdashel1_1.3.3-5_amd64.deb
Files:
 5927938774bf8637398717f46aeed38f 1927 devel optional dashel_1.3.3-5.dsc
 ee71fc42ea9429e2c36907483863b82e 13296 devel optional dashel_1.3.3-5.debian.tar.xz
 307367da21c1645574642d15af2569c6 6810 devel optional dashel_1.3.3-5_amd64.buildinfo
 8ad5faa59a0359c461bb2a217e882711 49548 libdevel optional libdashel-dev_1.3.3-5_amd64.deb
 30ac5e632e92b7675272bcda5107e43a 341820 debug optional libdashel1-dbgsym_1.3.3-5_amd64.deb
 18b0a38a2b5d06e66ec7dadc1ad2d434 45884 libs optional libdashel1_1.3.3-5_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEM0CzZP9nFT+3zK6FHCgWkHE2rjkFAlqG2yoACgkQHCgWkHE2
rjlUVg/9FbzOZbbW9eRrq5R3sRGGuf2SGl7X4R/u70nMx2hRfMCdjdzRn78qGcGE
d1bN4lz54cp6QaP7tKesSssx6yjA0rcqitB+xePEyV5KG9CBtjGWZLPVaUgcoadq
EY5wRW1rjjvTtPgiBclTZGKfzV6cw5UIcktDPwRYaGqp3t3G6JNQW57a9ITBDswZ
1MFtXY03iIxGYNXf5Cti8+4yQxC8UZU68Lk57WQ37SzotoBwO3KSw/rAIbTVsH4R
evdhrFPU9v2U8+/UQKvQiN2gdeNVj/1oVrbblOC+5Bk7FWY9u5bx5cdVkd9rTc/P
Cq+bXION7Y4oXFM8Ix0T+RrFnl+ZkckKrKgCxxSlhXI/tbC/iGaIjON96Cu3mpM3
PRsj0Uf2oZtwUUTMoRnanmzeG35+M1dQaXwr5lcgNkXcMf4WzlaPUMUMdoineOPM
CUfJ0NwSFha+kNUhbbtlQ0VVitF2Wml4TwjfAx6d3Ot3AoqWP7zjYofUSY+lw/si
c4qCQ53WpqrOESSDlNzLYPK99kueva6aUH2XBKBpm04yEQClNHO6xbnGZtBXVJJv
ygsvafu/eiXoS8LRlJMh2hDkW/O44h+M8+7zhjjZe06NBnjD18FD9H4cKj8EAvyZ
6iL5oTHWO2zsrLcnszvzkL/nxm1O581G/SMCq2krZ+wSfsMauGE=
=d6Wh
-----END PGP SIGNATURE-----

Message #28 received at 890568@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 890568@bugs.debian.org, 890311@bugs.debian.org

Cc: "Aaron M. Ucko" <ucko@debian.org>

Subject: Re: libdashel-dev: dashelConfig.cmake(.in) broken

Date: Sun, 01 Apr 2018 18:39:23 +0100

forwarded 890311 https://github.com/aseba-community/dashel/pull/42
forwarded 890568 https://github.com/aseba-community/dashel/pull/42
thanks

FYI I've forwarded this upstream here:

  https://github.com/aseba-community/dashel/pull/42


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.