Debian Bug report logs - #886416
libnih: FTBFS with expat 2.2.5: "FAIL test_parse (unexpected line numbering)" and is now uninstallable due now failing BinNMU

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Fri, 5 Jan 2018 15:20:50 +0000

Source: libnih
Version: 1.0.3-9
Severity: serious
Justification: fails to build from source (but built successfully in the past)
Affects: systemd-shim

libnih was made uninstallable by the glibc 2.26 transition, because it
uses internal glibc symbols. Normally this would be handled by a simple
rebuild. However, the recent binNMU of libnih against glibc 2.26 failed:

> Testing parse_xml()
> ...
> BAD: wrong content in file 0x13be5e730 (output), expected 'test:foo:2:0: Invalid object path in <node> name attribute
> ' got 'test:foo:1:36: Invalid object path in <node> name attribute
> '
>	 at tests/test_parse.c:7954 (test_parse_xml).
> FAIL test_parse (exit status: 134)

I don't know whether the test failure is triggered by glibc 2.26, or by
something else that changed since November.

This is particularly nasty because the missing binNMU makes libnih
(and hence systemd-shim) uninstallable; and until #883569 and #883573
are resolved, that's going to cause problems on the buildds whenever
a chain of (build-)dependencies pulls in libpam-systemd, because apt
apparently commits to installing systemd-shim and is not able to roll
back far enough to consider installing systemd-sysv instead.

    smcv

Message #14 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Simon McVittie <smcv@debian.org>, 886416@bugs.debian.org

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 02:31:04 +0100

Control: retitle -1 libnih: FTBFS with expat 2.2.5: "FAIL test_parse (unexpected line numbering)" and is now uninstallable due now failing BinNMU

Hi,

Simon McVittie wrote:
> > Testing parse_xml()
> > ...
> > BAD: wrong content in file 0x13be5e730 (output), expected 'test:foo:2:0: Invalid object path in <node> name attribute
> > ' got 'test:foo:1:36: Invalid object path in <node> name attribute
> > '
> >	 at tests/test_parse.c:7954 (test_parse_xml).
> > FAIL test_parse (exit status: 134)
> 
> I don't know whether the test failure is triggered by glibc 2.26, or by
> something else that changed since November.

It doesn't seem to be caused glibc 2.26, because if I try to compile
libnih on Sid without having glibc updated from 2.25 to 2.26 yet (due
to libnih), it still FTBFS in the same way:

BAD: wrong content in file 0x5653145373a0 (output), expected 'test:foo:2:0: Invalid object path in <node> name attribute
' got 'test:foo:1:36: Invalid object path in <node> name attribute
'
        at tests/test_parse.c:7954 (test_parse_xml).
FAIL test_parse (exit status: 134)

The reproducible build saw its first FTBFS on 2017-12-23 (sid) and
2017-12-30 (buster), and the last successful build on 2017-12-14 (sid)
2017-12-25 (buster):

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libnih.html

Looking at libnih's build dependencies, the expat upstream version
bump on 2017-12-16 in Sid and on 2017-12-25 in buster fits quite well.

Another hint towards expat is the fact that the failing test involves
XML parsing.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #21 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Simon McVittie <smcv@debian.org>, 886416@bugs.debian.org

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 02:42:44 +0100

Hi again,

Axel Beckert wrote:
> BAD: wrong content in file 0x5653145373a0 (output), expected 'test:foo:2:0: Invalid object path in <node> name attribute
> ' got 'test:foo:1:36: Invalid object path in <node> name attribute
> '
>         at tests/test_parse.c:7954 (test_parse_xml).
> FAIL test_parse (exit status: 134)

I don't know if that test suite failure shows that expat broke libnih
or if the test suite just needs to be adapted to the new expat
version.

Iff the later is the case, the following patch fixes the FTBFS:

--- a/nih-dbus-tool/tests/test_parse.c
+++ b/nih-dbus-tool/tests/test_parse.c
@@ -7950,7 +7950,7 @@
 
                TEST_EQ_P (node, NULL);
 
-               TEST_FILE_EQ (output, ("test:foo:2:0: "
+               TEST_FILE_EQ (output, ("test:foo:1:36: "
                                       "Invalid object path in <node> name attribute\n"));
                TEST_FILE_END (output);
                TEST_FILE_RESET (output);

Haven't yet tried if the resulting packages still work, but will try
that now.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #26 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Simon McVittie <smcv@debian.org>, 886416@bugs.debian.org

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 03:01:35 +0100

Control: tag -1 + patch

Hi again,

Axel Beckert wrote:
> I don't know if that test suite failure shows that expat broke libnih
> or if the test suite just needs to be adapted to the new expat
> version.
> 
> Iff the later is the case, the following patch fixes the FTBFS:
> 
> --- a/nih-dbus-tool/tests/test_parse.c
> +++ b/nih-dbus-tool/tests/test_parse.c
> @@ -7950,7 +7950,7 @@
>  
>                 TEST_EQ_P (node, NULL);
>  
> -               TEST_FILE_EQ (output, ("test:foo:2:0: "
> +               TEST_FILE_EQ (output, ("test:foo:1:36: "
>                                        "Invalid object path in <node> name attribute\n"));
>                 TEST_FILE_END (output);
>                 TEST_FILE_RESET (output);
> 
> Haven't yet tried if the resulting packages still work, but will try
> that now.

So far no issues and nih-dbus-tool still generates a lot of C code.

The patch fixes the FTBFS with both, glibc 2.25 as well as glibc 2.26.

I've now pushed the above patch with some proper metadata to the newly
created git branch "adapt-testsuite-to-expat-2.2.5":

https://anonscm.debian.org/cgit/collab-maint/libnih.git/log/?h=adapt-testsuite-to-expat-2.2.5

I'd appreciate some more eyes on that change as I have not much of an
idea of libnih's guts.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #33 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Axel Beckert <abe@debian.org>

Cc: 886416@bugs.debian.org

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 12:03:04 +0000

On Sat, 06 Jan 2018 at 03:01:35 +0100, Axel Beckert wrote:
> Axel Beckert wrote:
> > I don't know if that test suite failure shows that expat broke libnih
> > or if the test suite just needs to be adapted to the new expat
> > version.
> >  
> > -               TEST_FILE_EQ (output, ("test:foo:2:0: "
> > +               TEST_FILE_EQ (output, ("test:foo:1:36: "
> >                                        "Invalid object path in <node> name attribute\n"));
> >                 TEST_FILE_END (output);
> >                 TEST_FILE_RESET (output);

It certainly seems more true to say that the error in
"<node name=\"com/netsplit/Nih/Test\"/>\n" is at line 1 column 36 (the
closing double quote around the invalid object path) than at line 2
column 0 (after the newline).

> I'd appreciate some more eyes on that change as I have not much of an
> idea of libnih's guts.

I have no idea about how libnih works, but the change looks harmless at
worst - it's not as if it changes the behaviour of non-test code, and the
new output looks more correct than the old. (My only interest in libnih
is in keeping libpam-systemd installable on buildds.)

    smcv

Message #38 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Simon McVittie <smcv@debian.org>, 886416@bugs.debian.org

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 14:03:21 +0100

Control: tag -1 + pending

Hi Simon,

Simon McVittie wrote:
> > > -               TEST_FILE_EQ (output, ("test:foo:2:0: "
> > > +               TEST_FILE_EQ (output, ("test:foo:1:36: "
> > >                                        "Invalid object path in <node> name attribute\n"));
[…]
> It certainly seems more true to say that the error in
> "<node name=\"com/netsplit/Nih/Test\"/>\n" is at line 1 column 36 (the
> closing double quote around the invalid object path) than at line 2
> column 0 (after the newline).

Argh! Thanks for enlightening me what these numbers mean!

Yes, indeed, that looks much more sane now. Might be related to this
bug fix in expat 2.2.5:

       #137 #138  Fix a case of mistakenly reported parsing success where
                    XML_StopParser was called from an element handler

> > I'd appreciate some more eyes on that change as I have not much of an
> > idea of libnih's guts.
> 
> I have no idea about how libnih works, but the change looks harmless at
> worst - it's not as if it changes the behaviour of non-test code, and the
> new output looks more correct than the old.

Thanks for the review! Will prepare an upload.

> (My only interest in libnih is in keeping libpam-systemd installable
> on buildds.)

(My only interest in libnih is in being able to continue to not have to
use systemd as init system on my systems without having to uninstall
about 500 packages. :-P)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #45 received at 886416-close@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 886416-close@bugs.debian.org

Subject: Bug#886416: fixed in libnih 1.0.3-10

Date: Sat, 06 Jan 2018 13:49:28 +0000

Source: libnih
Source-Version: 1.0.3-10

We believe that the bug you reported is fixed in the latest version of
libnih, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 886416@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Axel Beckert <abe@debian.org> (supplier of updated libnih package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 06 Jan 2018 14:28:28 +0100
Source: libnih
Binary: libnih1 libnih-dev libnih-dbus1 libnih-dbus-dev nih-dbus-tool
Architecture: source amd64
Version: 1.0.3-10
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Axel Beckert <abe@debian.org>
Description:
 libnih-dbus-dev - NIH D-Bus Bindings Library (development files)
 libnih-dbus1 - NIH D-Bus Bindings Library
 libnih-dev - NIH Utility Library (development files)
 libnih1    - NIH Utility Library
 nih-dbus-tool - NIH D-Bus Binding Tool
Closes: 886416
Changes:
 libnih (1.0.3-10) unstable; urgency=medium
 .
   * QA upload.
   * Adapt test suite to expat 2.2.5. (Closes: #886416)
   * Declare compliance with Debian Policy 4.1.3.
   * Bump debhelper compatibility level to 11.
     + Update versioned debhelper build-dependency accordingly.
   * Update Vcs-* headers for switch to salsa.debian.org.
Checksums-Sha1:
 2991dbeda2765e2bebd37f71f1831a0844e3781e 2169 libnih_1.0.3-10.dsc
 db2485fe5596c9127c45eb96827bf7b7fd5080a7 9428 libnih_1.0.3-10.debian.tar.xz
 3634ce516fb7c714d6dd4850ac2437709f67139b 106280 libnih-dbus-dev_1.0.3-10_amd64.deb
 45efc1993e501c5354281a2c0d1d0d7fdfdc315c 29968 libnih-dbus1-dbgsym_1.0.3-10_amd64.deb
 7c1f22893eb7d07c2dccec8fbf55d4156bc13f37 97744 libnih-dbus1_1.0.3-10_amd64.deb
 ab3958b3956ac5c5b051302a4a8967e9e9492393 153336 libnih-dev_1.0.3-10_amd64.deb
 460cabffa40360d164c29cd45a29d4db20255acf 91348 libnih1-dbgsym_1.0.3-10_amd64.deb
 2e4c27c69567fcefa3f72512e23da952b36eceb7 126448 libnih1_1.0.3-10_amd64.deb
 f263f9bac9851890238966418fa0673fb32459a3 7563 libnih_1.0.3-10_amd64.buildinfo
 c4fc0e874ffe199b239e3c9da255a0194157480a 114512 nih-dbus-tool-dbgsym_1.0.3-10_amd64.deb
 2a515cdfa0078da1cf3258fa92968afc371a8688 135708 nih-dbus-tool_1.0.3-10_amd64.deb
Checksums-Sha256:
 ebb817a2d068ad2cc77510bd774a5c7aa2da7ddb8a0ad95d1c99cb68187d56e2 2169 libnih_1.0.3-10.dsc
 e8fa98507f820127c74269aecc23cd2a1276e01f3967cebecdfb0be59db227d4 9428 libnih_1.0.3-10.debian.tar.xz
 00325fd521508696d5ab473a6a2416544d8b9f468738621fa5f8c59cabd2e927 106280 libnih-dbus-dev_1.0.3-10_amd64.deb
 1ed6290d01618ed87678acbf0c2b5b791a0c852dd8301a841103df3083f82d4f 29968 libnih-dbus1-dbgsym_1.0.3-10_amd64.deb
 d74b31a550dfc23a2e2170bdbab7065ffa816ae5793f18c48028aed2212c2341 97744 libnih-dbus1_1.0.3-10_amd64.deb
 b83f8222c99b63b06d399fb252dfd5e3615984de43d6d8ade110fc03b201e0bc 153336 libnih-dev_1.0.3-10_amd64.deb
 121696708bedf8ac67efdf07966ae56dc193e7970a366c6a7d598852494f9e21 91348 libnih1-dbgsym_1.0.3-10_amd64.deb
 e09d4e7e3f77672128126ece68e7bbe26584cff8b47eba4c3fe28aeaaea42789 126448 libnih1_1.0.3-10_amd64.deb
 f414aff3f6361681582593c173d269822ab885b8aff5fc78f9fab351515097aa 7563 libnih_1.0.3-10_amd64.buildinfo
 61d88e34cfa4801e864da67d75e2ddbc5f25d8e975b69ed0bce233dd462e2a9d 114512 nih-dbus-tool-dbgsym_1.0.3-10_amd64.deb
 6dfae370b41674b0d214b631630d0328a614415579154fb69ba51e22b59a15ed 135708 nih-dbus-tool_1.0.3-10_amd64.deb
Files:
 51abd7ad0a4718cb8cd9fea06ac07049 2169 libs optional libnih_1.0.3-10.dsc
 5f9d9d60600586ed5a962b5d0270d259 9428 libs optional libnih_1.0.3-10.debian.tar.xz
 5e0789637e2a703d601d9516e5713dfe 106280 libdevel optional libnih-dbus-dev_1.0.3-10_amd64.deb
 1eb61e1992c7afcd723ce0dec5096c96 29968 debug optional libnih-dbus1-dbgsym_1.0.3-10_amd64.deb
 28a7ecaedcd243ea2a7620f5cabd7955 97744 libs optional libnih-dbus1_1.0.3-10_amd64.deb
 84d5fd010a0c3dfccdfd04d220ab47ba 153336 libdevel optional libnih-dev_1.0.3-10_amd64.deb
 75c5a77e34c3cce5bcd84c1db92feaab 91348 debug optional libnih1-dbgsym_1.0.3-10_amd64.deb
 97cbe032aa49970a357a71e37aa389db 126448 libs optional libnih1_1.0.3-10_amd64.deb
 eac09cd7c95dff9b5a40b55be0b84580 7563 libs optional libnih_1.0.3-10_amd64.buildinfo
 a88a55680c59c3db7c08f69cec7bdc21 114512 debug optional nih-dbus-tool-dbgsym_1.0.3-10_amd64.deb
 ac0c32234eac132af1cf5de499ebb641 135708 devel optional nih-dbus-tool_1.0.3-10_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAlpQ0IIACgkQa+Zjx1o1
yXWydA//R7Op1Z7Rn5uYvP8U9Gtj9UmnVjrrjFDeuFpSsWR/HHU4Ey+oPmjmZvXW
J2FrPB3H6lqk/IfdSFMKLHlu/nxgL4m3qJ+FU9KtTVHrbG899OT5ataBsWI/bZxH
cb1TeEE/gheF5kYd8UX+2TJQZLWZ6sXBJ9S/G0EpL/rb7Tz5wKvkj/VZhxTQrsPz
+ll7/SqMQLx9n4kNLdCBXz6B9kDjx/pvNuXaKhhlVmiVP/0WN+SCVdyFg0LzflvI
pP+EXU/vvMkH1fQ+G8ABhm7EpnMdxWndvrpsjP8eqJzSmqTOLE2AElFUluNUASec
sPYCKuGulVLcIs1uotGpSmNn5dmuWJcpvzewi7XJ84OPzd4ASvavuuu0wD+FQeec
QjmB09O4ipbAu8HmvAxU6MJJY9oJdJelXG3Dr0f15ifkiDp22Og8NRp+RSaUXO6U
XQIdVdGWfyzdAjGGx1u5Wd98KxwUkSyM/CSSEdlYQkZP3RauSdeQpeI2Cs3fgse0
ukvpTof9E/vVENt4IJm4ajKgsZLmCt2TcRTrYvRGnbKy1iVx1P0dgy8yNhmwXfEt
ASu3QTHlGo9o1JquHmpuMr1ULbfrmhRvHTzWDO9km3TOJ4c5ZTJPPLvCSFYHSgaS
HbXRl+NmDAK8YaMYutS2DfKHbYkLS8e4LyrPGmJWPIn6xjvt0Zs=
=9ZSP
-----END PGP SIGNATURE-----

Message #50 received at 886416@bugs.debian.org (full text, mbox, reply):

From: Niko Tyni <ntyni@debian.org>

To: Axel Beckert <abe@debian.org>, 886416@bugs.debian.org

Cc: Simon McVittie <smcv@debian.org>

Subject: Re: Bug#886416: libnih: uninstallable, and FTBFS when rebuilt: FAIL test_parse (unexpected line numbering)

Date: Sat, 6 Jan 2018 16:21:54 +0200

On Sat, Jan 06, 2018 at 02:03:21PM +0100, Axel Beckert wrote:

> Yes, indeed, that looks much more sane now. Might be related to this
> bug fix in expat 2.2.5:
> 
>        #137 #138  Fix a case of mistakenly reported parsing success where
>                     XML_StopParser was called from an element handler

Yes. The relevant change seems to be

 https://github.com/libexpat/libexpat/commit/718d51a66b0d69f3b8c5ff63d044c36dd5314232

as reverting that made the error go away for me.

Changing the libnih test suite to accomodate the expat fix seems correct
to me too fwiw. Thanks for your work on this!
-- 
Niko Tyni   ntyni@debian.org

Send a report that this bug log contains spam.