Debian Bug report logs - #883100
ksudoku FTBFS on armel/armhf: error: conflicting declaration 'typedef ptrdiff_t GLsizeiptr'

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ksudoku FTBFS on armel/armhf: error: conflicting declaration 'typedef ptrdiff_t GLsizeiptr'

Date: Wed, 29 Nov 2017 19:15:35 +0200

[Message part 1 (text/plain, inline)]

Source: ksudoku
Version: 4:17.08.3-1
Severity: serious
Tags: patch

https://buildd.debian.org/status/package.php?p=ksudoku

...
In file included from /usr/include/GL/gl.h:2055:0,
                 from /<<PKGBUILDDIR>>/src/gui/views/ArcBall.h:43,
                 from /<<PKGBUILDDIR>>/src/gui/views/roxdokuview.h:34,
                 from /<<PKGBUILDDIR>>/src/gui/views/ksview.cpp:35:
/usr/include/GL/glext.h:466:19: error: conflicting declaration 'typedef ptrdiff_t GLsizeiptr'
 typedef ptrdiff_t GLsizeiptr;
                   ^~~~~~~~~~
In file included from /usr/include/arm-linux-gnueabi/qt5/QtGui/qopengl.h:107:0,
                 from /usr/include/arm-linux-gnueabi/qt5/QtOpenGL/qgl.h:45,
                 from /usr/include/arm-linux-gnueabi/qt5/QtOpenGL/QGL:1,
                 from /<<PKGBUILDDIR>>/src/gui/views/roxdokuview.h:26,
                 from /<<PKGBUILDDIR>>/src/gui/views/ksview.cpp:35:
/usr/include/GLES3/gl3.h:75:25: note: previous declaration as 'typedef khronos_ssize_t GLsizeiptr'
 typedef khronos_ssize_t GLsizeiptr;
                         ^~~~~~~~~~
In file included from /usr/include/GL/gl.h:2055:0,
                 from /<<PKGBUILDDIR>>/src/gui/views/ArcBall.h:43,
                 from /<<PKGBUILDDIR>>/src/gui/views/roxdokuview.h:34,
                 from /<<PKGBUILDDIR>>/src/gui/views/ksview.cpp:35:
/usr/include/GL/glext.h:467:19: error: conflicting declaration 'typedef ptrdiff_t GLintptr'
 typedef ptrdiff_t GLintptr;
                   ^~~~~~~~
In file included from /usr/include/arm-linux-gnueabi/qt5/QtGui/qopengl.h:107:0,
                 from /usr/include/arm-linux-gnueabi/qt5/QtOpenGL/qgl.h:45,
                 from /usr/include/arm-linux-gnueabi/qt5/QtOpenGL/QGL:1,
                 from /<<PKGBUILDDIR>>/src/gui/views/roxdokuview.h:26,
                 from /<<PKGBUILDDIR>>/src/gui/views/ksview.cpp:35:
/usr/include/GLES3/gl3.h:76:26: note: previous declaration as 'typedef khronos_intptr_t GLintptr'
 typedef khronos_intptr_t GLintptr;
                          ^~~~~~~~
src/gui/CMakeFiles/ksudoku_gui.dir/build.make:321: recipe for target 'src/gui/CMakeFiles/ksudoku_gui.dir/views/ksview.cpp.o' failed
make[4]: *** [src/gui/CMakeFiles/ksudoku_gui.dir/views/ksview.cpp.o] Error 1


Fix is attached.

[opengl-es.patch (text/plain, attachment)]

Message #10 received at 883100@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Pino Toscano <pino@debian.org>

Cc: 886245@bugs.debian.org, 883100@bugs.debian.org

Subject: Re: Bug#886245: RM: ksudoku [armel armhf] -- ROM; does not support Desktop OpenGL

Date: Wed, 3 Jan 2018 20:48:25 +0200

On Wed, Jan 03, 2018 at 07:32:46PM +0100, Pino Toscano wrote:
> On mercoledì 3 gennaio 2018 20:26:53 CET Adrian Bunk wrote:
> > On Wed, Jan 03, 2018 at 07:14:58PM +0100, Pino Toscano wrote:
> > > On mercoledì 3 gennaio 2018 20:12:05 CET Adrian Bunk wrote:
> > >...
> > > > Regarding ksudoku, is there any reason why you didn't apply
> > > > either my patch from #883100 or the similar change from Ubuntu?
> > > > Either one would fix the build on armel and armhf.
> > > 
> > > It is a bad hack, and I do not want to carry and support it.
> > 
> > Ubuntu backported the upstream fix.
> 
> Ah I see, a different hack than yours [1],
>...
> [1] that btw will not work, since even if you skip the
> find_package(OpenGL) call, then set_package_properties(OpenGL ...) sets
> TYPE REQUIRED, and thus make cmake error out (see feature_summary)
> because a required dependency was not found

Why are you implying that I did not test that my patch fixed the FTBFS
before submitting it?

When you are claiming that it "will not work", all I can say is
that it did work for me in an armel build on November 29th 2017.

> Pino Toscano

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Message #15 received at 883100@bugs.debian.org (full text, mbox, reply):

From: Pino Toscano <pino@debian.org>

To: Adrian Bunk <bunk@debian.org>, 883100@bugs.debian.org, 886245@bugs.debian.org

Subject: Re: Bug#883100: Bug#886245: RM: ksudoku [armel armhf] -- ROM; does not support Desktop OpenGL

Date: Wed, 03 Jan 2018 20:20:52 +0100

[Message part 1 (text/plain, inline)]

On mercoledì 3 gennaio 2018 20:48:25 CET Adrian Bunk wrote:
> On Wed, Jan 03, 2018 at 07:32:46PM +0100, Pino Toscano wrote:
> > On mercoledì 3 gennaio 2018 20:26:53 CET Adrian Bunk wrote:
> > > On Wed, Jan 03, 2018 at 07:14:58PM +0100, Pino Toscano wrote:
> > > > On mercoledì 3 gennaio 2018 20:12:05 CET Adrian Bunk wrote:
> > > >...
> > > > > Regarding ksudoku, is there any reason why you didn't apply
> > > > > either my patch from #883100 or the similar change from Ubuntu?
> > > > > Either one would fix the build on armel and armhf.
> > > > 
> > > > It is a bad hack, and I do not want to carry and support it.
> > > 
> > > Ubuntu backported the upstream fix.
> > 
> > Ah I see, a different hack than yours [1],
> >...
> > [1] that btw will not work, since even if you skip the
> > find_package(OpenGL) call, then set_package_properties(OpenGL ...) sets
> > TYPE REQUIRED, and thus make cmake error out (see feature_summary)
> > because a required dependency was not found
> 
> Why are you implying that I did not test that my patch fixed the FTBFS
> before submitting it?
> 
> When you are claiming that it "will not work", all I can say is
> that it did work for me in an armel build on November 29th 2017.

I stand corrected: your patch "builds" (although IMHO it should not).

Still, both yours and "upstream" patches are hacks, and no, I am *not*
going to support them.  If you could stop pushing for them, it would
be less time I am wasting on this.

Thanks,
-- 
Pino Toscano

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 883100@bugs.debian.org (full text, mbox, reply):

From: Pino Toscano <pino@debian.org>

To: 883100@bugs.debian.org

Subject: Re: Bug#883100: ksudoku FTBFS on armel/armhf: error: conflicting declaration 'typedef ptrdiff_t GLsizeiptr'

Date: Thu, 04 Jan 2018 15:45:04 +0100

[Message part 1 (text/plain, inline)]

severity 883100 important
tag 883100 - patch
thanks

Since ksudoku was removed from unstable (and soon testing), this is no
more a blocking issue.

-- 
Pino Toscano

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 883100@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: 883100@bugs.debian.org

Subject: FTBFS fix for ksudoku on armel

Date: Sun, 24 Jun 2018 21:27:32 +0300

Control: tags -1 patch

The following fixes the armel build similar to the armhf build:

--- debian/control.old	2018-06-24 16:15:54.987390079 +0000
+++ debian/control	2018-06-24 16:17:45.541199061 +0000
@@ -12,8 +12,8 @@
 Build-Depends: cmake (>= 2.8.12~),
                debhelper (>= 11),
                extra-cmake-modules (>= 5.31.0~),
-               libgl1-mesa-dev [!armhf] | libgl-dev [!armhf],
-               libglu1-mesa-dev [!armhf],
+               libgl1-mesa-dev [!armhf !armel] | libgl-dev [!armhf !armel],
+               libglu1-mesa-dev [!armhf !armel],
                libkf5archive-dev (>= 5.31.0~),
                libkf5config-dev (>= 5.31.0~),
                libkf5configwidgets-dev (>= 5.31.0~),


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Message #40 received at 883100-done@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: 883100-done@bugs.debian.org

Subject: With #894076 fixed this now builds

Date: Thu, 29 Nov 2018 18:51:17 +0200

With #894076 fixed this now builds.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Send a report that this bug log contains spam.