Debian Bug report logs -
#881627
ruby-http-parser.rb: FTBFS with newer http-parser version
Reported by: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
Date: Mon, 13 Nov 2017 17:33:01 UTC
Severity: serious
Tags: buster, patch, sid, upstream
Found in versions ruby-http-parser.rb/0.6.0-3+b3, ruby-http-parser.rb/0.6.0-3
Fixed in version ruby-http-parser.rb/0.6.0-4
Done: Cédric Boutillier <boutil@debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Mon, 13 Nov 2017 17:33:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Christoph Biedl <debian.axhn@manchmal.in-ulm.de>:
New Bug report received and forwarded. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Mon, 13 Nov 2017 17:33:04 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Source: ruby-http-parser.rb
Version: 0.6.0-3+b3
Severity: serious
Tags: upstream
Dear Maintainer,
your package build-depends on http-parser, and a new version of that
one has been around for a while. Even before eventually uploading last
night I already saw a problem in the test suite of your package.
However, due to a fault on my side, the new http-parser went to
unstable instead of experimental. So this increases the pressure for
your package, sorry about that.
With http-parser 2.7.1, one test fails:
1) HTTP::Parser should parse request: line folding in header value
Failure/Error: expect(@headers).to eq(test['headers'])
expected: {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"}
got: {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"}
(compared using ==)
Diff:
@@ -1,3 +1,3 @@
-"Line1" => "abcdefghijklmno qrs",
+"Line1" => "abc\tdef ghi\t\tjkl mno \t \tqrs",
"Line2" => "line2\t",
# ./spec/parser_spec.rb:347:in `block (4 levels) in <top (required)>'
If I understand correctly, this is taken from spec/support/requests.json
line 445 and 457f.
While doubtlessly http-parser changed the behaviour, I'm not sure yet
whether this wasn't rather about fixing bugs - bugs the test in
ruby-http-parser.rb relied upon.
However, HTTP header line folding is complicated and actually also
deprecated in RFC 7230. Reading that one and also the older description
in RFC 2616 I guess there a too many freedoms to expect a certain
result. Also it seems http-parser 2.7.1 does unfolding in a ...
surprising manner.
Now, quite frankly, my main interest is a sound solution. Otherwise,
I'm not keen on legal discussions, especially when it's about a
deprecated feature like this one. It's my job to sort these things out
with http-parser upstream but since I'm not sure how long this will
take: Would you mind disabling or relaxing the test on your side for
the time being? You might as well upgrade the test to the one in
http-parser/test.c¹ which is where obviously it was taken from in the
first place - but I'd expect this to change again soon.
Sorry for the mess, and kind regards,
Christoph
¹ https://github.com/nodejs/http-parser/blob/master/test.c (line 614)
[signature.asc (application/pgp-signature, inline)]
Marked as found in versions ruby-http-parser.rb/0.6.0-3.
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Mon, 13 Nov 2017 20:30:25 GMT) (full text, mbox, link).
Added tag(s) sid and buster.
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Mon, 13 Nov 2017 20:30:26 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 17:51:06 GMT) (full text, mbox, link).
Acknowledgement sent
to Christoph Biedl <debian.axhn@manchmal.in-ulm.de>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 17:51:06 GMT) (full text, mbox, link).
Message #14 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
tags 881627 patch
thanks
Christoph Biedl wrote...
> Would you mind disabling or relaxing the test on your side for
> the time being?
Patch attached, tested successfully.
As I noticed some packaging work has been done since the last release,
so I'm somewhat reluctant to do a NMU. But since this is the remaining
blocker for the http-parser transition, I'd like to do the finishing
step soon. I'll wait until the week-end but would of course appreciate a
faster resolution.
Regards,
Christoph
[0006-disable-folding-header-test.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]
Added tag(s) patch.
Request was from Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
to control@bugs.debian.org.
(Tue, 14 Nov 2017 17:51:08 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 19:24:03 GMT) (full text, mbox, link).
Acknowledgement sent
to mario serna <semario1013@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 19:24:03 GMT) (full text, mbox, link).
Message #21 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Stop emailing me
On Nov 14, 2017 12:08 PM, "AmazonReward Alert" <
debian.axhn@manchmal.in-ulm.de> wrote:
> Message for mario
>
>
> <http://lavishjob.com/cl/r-S5LNS7MEGC4S143KDS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/ua-S5LNS7MEGC4S143KDS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/op-S5LNS7MEGC4S143KDS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags:
> upstream Dear Maintainer, your package build-depends on http-parser, and a
> new version of that one has been around for a while. Even before eventually
> uploading last night I already saw a problem in the test suite of your
> package. However, due to a fault on my side, the new http-parser went to
> unstable instead of experimental. So this increases the pressure for your
> package, sorry about that. With http-parser 2.7.1, one test fails: 1)
> HTTP::Parser should parse request: line folding in header value
> Failure/Error: expect(@headers).to eq(test) expected:
> {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"} got:
> {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"} (compared
> using ==) Diff: @@ -1,3 +1,3 @@ -"Line1" => "abcdefghijklmno qrs", +"Line1"
> => "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" => "line2\t", #
> ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand
> correctly, this is taken from spec/support/requests.json line 445 and 457f.
> While doubtlessly http-parser changed the behaviour, I'm not sure yet
> whether this wasn't rather about fixing bugs - bugs the test in
> ruby-http-parser.rb relied upon. However, HTTP header line folding is
> complicated and actually also deprecated in RFC 7230. Reading that one and
> also the older description in RFC 2616 I guess there a too many freedoms to
> expect a certain result. Also it seems http-parser 2.7.1 does unfolding in
> a ... surprising manner. Now, quite frankly, my main interest is a sound
> solution. Otherwise, I'm not keen on legal discussions, especially when
> it's about a deprecated feature like this one. It's my job to sort these
> things out with http-parser upstream but since I'm not sure how long this
> will take: Would you mind disabling or relaxing the test on your side for
> the time being? You might as well upgrade the test to the one in
> http-parser/test.c¹ which is where obviously it was taken from in the first
> place - but I'd expect this to change again soon. Sorry for the mess, and
> kind regards, Christoph ¹ https://github.com/nodejs/http-parser/blob/master/test.c
> (line 614)
[Message part 2 (text/html, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 19:24:05 GMT) (full text, mbox, link).
Acknowledgement sent
to Michael Johnson <johnson74072@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 19:24:05 GMT) (full text, mbox, link).
Message #26 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Stop
On Nov 14, 2017 2:08 PM, "AmazonReward Alert" <
debian.axhn@manchmal.in-ulm.de> wrote:
> Message for michael
>
>
> <http://lavishjob.com/cl/r-S5ODSDA6H8NS15J3LS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/ua-S5ODSDA6H8NS15J3LS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/op-S5ODSDA6H8NS15J3LS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags:
> upstream Dear Maintainer, your package build-depends on http-parser, and a
> new version of that one has been around for a while. Even before eventually
> uploading last night I already saw a problem in the test suite of your
> package. However, due to a fault on my side, the new http-parser went to
> unstable instead of experimental. So this increases the pressure for your
> package, sorry about that. With http-parser 2.7.1, one test fails: 1)
> HTTP::Parser should parse request: line folding in header value
> Failure/Error: expect(@headers).to eq(test) expected:
> {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"} got:
> {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"} (compared
> using ==) Diff: @@ -1,3 +1,3 @@ -"Line1" => "abcdefghijklmno qrs", +"Line1"
> => "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" => "line2\t", #
> ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand
> correctly, this is taken from spec/support/requests.json line 445 and 457f.
> While doubtlessly http-parser changed the behaviour, I'm not sure yet
> whether this wasn't rather about fixing bugs - bugs the test in
> ruby-http-parser.rb relied upon. However, HTTP header line folding is
> complicated and actually also deprecated in RFC 7230. Reading that one and
> also the older description in RFC 2616 I guess there a too many freedoms to
> expect a certain result. Also it seems http-parser 2.7.1 does unfolding in
> a ... surprising manner. Now, quite frankly, my main interest is a sound
> solution. Otherwise, I'm not keen on legal discussions, especially when
> it's about a deprecated feature like this one. It's my job to sort these
> things out with http-parser upstream but since I'm not sure how long this
> will take: Would you mind disabling or relaxing the test on your side for
> the time being? You might as well upgrade the test to the one in
> http-parser/test.c¹ which is where obviously it was taken from in the first
> place - but I'd expect this to change again soon. Sorry for the mess, and
> kind regards, Christoph ¹ https://github.com/nodejs/http-parser/blob/master/test.c
> (line 614)
[Message part 2 (text/html, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 21:21:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Edwin Carter <edwinmcarter@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 21:21:03 GMT) (full text, mbox, link).
Message #31 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
nice con attempt, I will be reporting you to officials
On Mon, Nov 13, 2017 at 11:30 AM, AmazonReward Alert <
debian.axhn@manchmal.in-ulm.de> wrote:
> Message for Ed
>
>
> <http://lavishjob.com/cl/r-S4IOSP9LDO0S145O7S1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/ua-S4IOSP9LDO0S145O7S1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/op-S4IOSP9LDO0S145O7S1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags:
> upstream Dear Maintainer, your package build-depends on http-parser, and a
> new version of that one has been around for a while. Even before eventually
> uploading last night I already saw a problem in the test suite of your
> package. However, due to a fault on my side, the new http-parser went to
> unstable instead of experimental. So this increases the pressure for your
> package, sorry about that. With http-parser 2.7.1, one test fails: 1)
> HTTP::Parser should parse request: line folding in header value
> Failure/Error: expect(@headers).to eq(test) expected:
> {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"} got:
> {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"} (compared
> using ==) Diff: @@ -1,3 +1,3 @@ -"Line1" => "abcdefghijklmno qrs", +"Line1"
> => "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" => "line2\t", #
> ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand
> correctly, this is taken from spec/support/requests.json line 445 and 457f.
> While doubtlessly http-parser changed the behaviour, I'm not sure yet
> whether this wasn't rather about fixing bugs - bugs the test in
> ruby-http-parser.rb relied upon. However, HTTP header line folding is
> complicated and actually also deprecated in RFC 7230. Reading that one and
> also the older description in RFC 2616 I guess there a too many freedoms to
> expect a certain result. Also it seems http-parser 2.7.1 does unfolding in
> a ... surprising manner. Now, quite frankly, my main interest is a sound
> solution. Otherwise, I'm not keen on legal discussions, especially when
> it's about a deprecated feature like this one. It's my job to sort these
> things out with http-parser upstream but since I'm not sure how long this
> will take: Would you mind disabling or relaxing the test on your side for
> the time being? You might as well upgrade the test to the one in
> http-parser/test.c¹ which is where obviously it was taken from in the first
> place - but I'd expect this to change again soon. Sorry for the mess, and
> kind regards, Christoph ¹ https://github.com/nodejs/http-parser/blob/master/test.c
> (line 614)
[Message part 2 (text/html, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 21:39:11 GMT) (full text, mbox, link).
Acknowledgement sent
to Sundra Johnson <sunshine45.sj@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 21:39:11 GMT) (full text, mbox, link).
Message #36 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Sunshine45.sj@gmail.com
On Nov 14, 2017 2:08 PM, "AmazonReward Alert" <
debian.axhn@manchmal.in-ulm.de> wrote:
> Message for sundra
>
>
> <http://lavishjob.com/cl/r-S26SIIIL16S15J4AS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/ua-S26SIIIL16S15J4AS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/op-S26SIIIL16S15J4AS1CK7ISE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags:
> upstream Dear Maintainer, your package build-depends on http-parser, and a
> new version of that one has been around for a while. Even before eventually
> uploading last night I already saw a problem in the test suite of your
> package. However, due to a fault on my side, the new http-parser went to
> unstable instead of experimental. So this increases the pressure for your
> package, sorry about that. With http-parser 2.7.1, one test fails: 1)
> HTTP::Parser should parse request: line folding in header value
> Failure/Error: expect(@headers).to eq(test) expected:
> {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"} got:
> {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"} (compared
> using ==) Diff: @@ -1,3 +1,3 @@ -"Line1" => "abcdefghijklmno qrs", +"Line1"
> => "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" => "line2\t", #
> ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand
> correctly, this is taken from spec/support/requests.json line 445 and 457f.
> While doubtlessly http-parser changed the behaviour, I'm not sure yet
> whether this wasn't rather about fixing bugs - bugs the test in
> ruby-http-parser.rb relied upon. However, HTTP header line folding is
> complicated and actually also deprecated in RFC 7230. Reading that one and
> also the older description in RFC 2616 I guess there a too many freedoms to
> expect a certain result. Also it seems http-parser 2.7.1 does unfolding in
> a ... surprising manner. Now, quite frankly, my main interest is a sound
> solution. Otherwise, I'm not keen on legal discussions, especially when
> it's about a deprecated feature like this one. It's my job to sort these
> things out with http-parser upstream but since I'm not sure how long this
> will take: Would you mind disabling or relaxing the test on your side for
> the time being? You might as well upgrade the test to the one in
> http-parser/test.c¹ which is where obviously it was taken from in the first
> place - but I'd expect this to change again soon. Sorry for the mess, and
> kind regards, Christoph ¹ https://github.com/nodejs/http-parser/blob/master/test.c
> (line 614)
[Message part 2 (text/html, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Tue, 14 Nov 2017 22:24:05 GMT) (full text, mbox, link).
Acknowledgement sent
to mannywellz2005@gmail.com:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Tue, 14 Nov 2017 22:24:05 GMT) (full text, mbox, link).
Message #41 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Bye
> On Nov 13, 2017, at 12:30 PM, AmazonReward Alert <debian.axhn@manchmal.in-ulm.de> wrote:
>
> Message for emanuel
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags: upstream Dear Maintainer, your package build-depends on http-parser, and a new version of that one has been around for a while. Even before eventually uploading last night I already saw a problem in the test suite of your package. However, due to a fault on my side, the new http-parser went to unstable instead of experimental. So this increases the pressure for your package, sorry about that. With http-parser 2.7.1, one test fails: 1) HTTP::Parser should parse request: line folding in header value Failure/Error: expect(@headers).to eq(test) expected: {"Line1"=3D>"abcdefghijklmno qrs", "Line2"=3D>"line2\t"} got: {"Line1"=3D>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"= =3D>"line2\t"} (compared using =3D=3D) Diff: @@ -1,3 +1,3 @@ -"Line1" =3D> "abcdefghijklmno qrs", +"Line1" =3D> "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" =3D> "line2\t", # ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand correctly, this is taken from spec/support/requests.json line 445 and 457f. While doubtlessly http-parser changed the behaviour, I'm not sure yet whether this wasn't rather about fixing bugs - bugs the test in ruby-http-parser.rb relied upon. However, HTTP header line folding is complicated and actually also deprecated in RFC 7230. Reading that one and also the older description in RFC 2616 I guess there a too many freedoms to expect a certain result. Also it seems http-parser 2.7.1 does unfolding in a ... surprising manner. Now, quite frankly, my main interest is a sound solution. Otherwise, I'm not keen on legal discussions, especially when it's about a deprecated feature like this one. It's my job to sort these things out with http-parser upstream but since I'm not sure how long this will take: Would you mind disabling or relaxing the test on your side for the time being? You might as well upgrade the test to the one in http-parser/test.c=C2=B9 which is where obviously it was taken from in the first place - but I'd expect this to change again soon. Sorry for the mess, and kind regards, Christoph =C2=B9 https://github.com/nodejs/http-parser/blob/master/test.c (line 614)
[Message part 2 (text/html, inline)]
Added tag(s) pending.
Request was from Cédric Boutillier <boutil@debian.org>
to control@bugs.debian.org.
(Wed, 15 Nov 2017 23:54:03 GMT) (full text, mbox, link).
Message sent on
to Christoph Biedl <debian.axhn@manchmal.in-ulm.de>:
Bug#881627.
(Wed, 15 Nov 2017 23:54:05 GMT) (full text, mbox, link).
Message #46 received at 881627-submitter@bugs.debian.org (full text, mbox, reply):
tag 881627 pending
thanks
Hello,
Bug #881627 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:
https://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-http-parser.rb.git/commit/?id=fa0a473
---
commit fa0a473327b3281570887a81a304c6ed8ac52dc0
Author: Cédric Boutillier <boutil@debian.org>
Date: Wed Nov 15 23:16:15 2017 +0100
prepare changelog
diff --git a/debian/changelog b/debian/changelog
index 281ca03..a51e283 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,17 @@
+ruby-http-parser.rb (0.6.0-4) unstable; urgency=medium
+
+ * Team upload
+ * Remove version in the gem2deb build-dependency
+ * Use https:// in Vcs-* fields
+ * Run wrap-and-sort on packaging files
+ * Bump Standards-Version to 4.1.1 (no changes needed)
+ * Bump debhelper compatibility level to 10
+ * Add Testsuite field for autopkgtest
+ * Add 0006-disable-folding-header-test.patch to support newer http-parser
+ (Closes: #881627). Thanks Christoph Biedl for the patch!
+
+ -- Cédric Boutillier <boutil@debian.org> Wed, 15 Nov 2017 23:15:54 +0100
+
ruby-http-parser.rb (0.6.0-3) unstable; urgency=medium
[Sebastien Badia]
Reply sent
to Cédric Boutillier <boutil@debian.org>:
You have taken responsibility.
(Thu, 16 Nov 2017 00:57:04 GMT) (full text, mbox, link).
Notification sent
to Christoph Biedl <debian.axhn@manchmal.in-ulm.de>:
Bug acknowledged by developer.
(Thu, 16 Nov 2017 00:57:04 GMT) (full text, mbox, link).
Message #51 received at 881627-close@bugs.debian.org (full text, mbox, reply):
Source: ruby-http-parser.rb
Source-Version: 0.6.0-4
We believe that the bug you reported is fixed in the latest version of
ruby-http-parser.rb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 881627@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Cédric Boutillier <boutil@debian.org> (supplier of updated ruby-http-parser.rb package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 15 Nov 2017 23:15:54 +0100
Source: ruby-http-parser.rb
Binary: ruby-http-parser.rb ruby-http-parser.rb-doc
Architecture: source
Version: 0.6.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
Changed-By: Cédric Boutillier <boutil@debian.org>
Description:
ruby-http-parser.rb - Simple callback-based HTTP request/response parser
ruby-http-parser.rb-doc - Simple callback-based HTTP request/response parser (documentation
Closes: 881627
Changes:
ruby-http-parser.rb (0.6.0-4) unstable; urgency=medium
.
* Team upload
* Remove version in the gem2deb build-dependency
* Use https:// in Vcs-* fields
* Run wrap-and-sort on packaging files
* Bump Standards-Version to 4.1.1 (no changes needed)
* Bump debhelper compatibility level to 10
* Add Testsuite field for autopkgtest
* Add 0006-disable-folding-header-test.patch to support newer http-parser
(Closes: #881627). Thanks Christoph Biedl for the patch!
Checksums-Sha1:
56958edb0a313101feb149baad6b217032936011 1969 ruby-http-parser.rb_0.6.0-4.dsc
73af345a0e4b977eaf78509d11a5672c01c16af2 7888 ruby-http-parser.rb_0.6.0-4.debian.tar.xz
253e028fdd4a8ae796c072ec8a96f7db9aedb0f2 6535 ruby-http-parser.rb_0.6.0-4_source.buildinfo
Checksums-Sha256:
ca4d6fb73e43afb5c5c2c70a5bdf7e431e906fbea24284a86bf58629977f9762 1969 ruby-http-parser.rb_0.6.0-4.dsc
fb07837143977108e1c8fecac2fd036ff31f1cd462c73da3033513f1d6ec4a62 7888 ruby-http-parser.rb_0.6.0-4.debian.tar.xz
0a5828b880e15dc2927333d9b1cb7d0c9d8078f120aa933a12a985833cb10f16 6535 ruby-http-parser.rb_0.6.0-4_source.buildinfo
Files:
0e46a5ca2c06493d09415ec0ee97afcc 1969 ruby optional ruby-http-parser.rb_0.6.0-4.dsc
72c0e05d20e0d8bbd1506af8ffd90284 7888 ruby optional ruby-http-parser.rb_0.6.0-4.debian.tar.xz
53a1c6f189881c9e85eac66cbd90899d 6535 ruby optional ruby-http-parser.rb_0.6.0-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEnM1rMZ2/jkCrGr0aia+CtznNIXoFAloM0sIACgkQia+CtznN
IXpV5Af+Nmm3nl6JS/ZjCdIEzxEB1Z6ftH4m3qr/jqSg6YXdrOY8qmUyWhzybMWw
xmR3hPcV6k2XL9INh0STn58UtMJyrSwjTXbu2jmN5d2LmoEuYRLwBBBi8E3ySTHp
mdJsuzPByrK6Z1yKApGKB8uina0CN36AXYo4rvcHWB1DPeo2MPYDt1BFPHf3C2NI
v3X+lkQ/Ef71HIJ6HZcnUUjB20kyf7BCh7BUnC6ccFQxImbqiWZf7QyOY2/3l6p1
LoiJCTG+Zv/aJ3956VRsA11teWo+boGfB8Ts8VeZ/ZVj1m88jk7EMwHSZb6bdNu9
FJ8FShR7xdlwKcjjefeOhj63I8NByQ==
=gNMT
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>:
Bug#881627; Package src:ruby-http-parser.rb.
(Thu, 16 Nov 2017 10:06:03 GMT) (full text, mbox, link).
Acknowledgement sent
to kamya jamyes <jameskjammox57@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>.
(Thu, 16 Nov 2017 10:06:03 GMT) (full text, mbox, link).
Message #56 received at 881627@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
thnks alot but how can i use lcfhc to register or login
On Mon, Nov 13, 2017 at 9:30 AM, AmazonReward Alert <
debian.axhn@manchmal.in-ulm.de> wrote:
> Message for james.kjammox57
>
>
> <http://lavishjob.com/cl/r-S38KS1D2P4G4S13C46S1CK7NSE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/ua-S38KS1D2P4G4S13C46S1CK7NSE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
> <http://lavishjob.com/cl/op-S38KS1D2P4G4S13C46S1CK7NSE3NS0S0S0S15S2SBSCCS21FS1GMSA>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Source: ruby-http-parser.rb Version: 0.6.0-3+b3 Severity: serious Tags:
> upstream Dear Maintainer, your package build-depends on http-parser, and a
> new version of that one has been around for a while. Even before eventually
> uploading last night I already saw a problem in the test suite of your
> package. However, due to a fault on my side, the new http-parser went to
> unstable instead of experimental. So this increases the pressure for your
> package, sorry about that. With http-parser 2.7.1, one test fails: 1)
> HTTP::Parser should parse request: line folding in header value
> Failure/Error: expect(@headers).to eq(test) expected:
> {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"} got:
> {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2"=>"line2\t"} (compared
> using ==) Diff: @@ -1,3 +1,3 @@ -"Line1" => "abcdefghijklmno qrs", +"Line1"
> => "abc\tdef ghi\t\tjkl mno \t \tqrs", "Line2" => "line2\t", #
> ./spec/parser_spec.rb:347:in `block (4 levels) in ' If I understand
> correctly, this is taken from spec/support/requests.json line 445 and 457f.
> While doubtlessly http-parser changed the behaviour, I'm not sure yet
> whether this wasn't rather about fixing bugs - bugs the test in
> ruby-http-parser.rb relied upon. However, HTTP header line folding is
> complicated and actually also deprecated in RFC 7230. Reading that one and
> also the older description in RFC 2616 I guess there a too many freedoms to
> expect a certain result. Also it seems http-parser 2.7.1 does unfolding in
> a ... surprising manner. Now, quite frankly, my main interest is a sound
> solution. Otherwise, I'm not keen on legal discussions, especially when
> it's about a deprecated feature like this one. It's my job to sort these
> things out with http-parser upstream but since I'm not sure how long this
> will take: Would you mind disabling or relaxing the test on your side for
> the time being? You might as well upgrade the test to the one in
> http-parser/test.c¹ which is where obviously it was taken from in the first
> place - but I'd expect this to change again soon. Sorry for the mess, and
> kind regards, Christoph ¹ https://github.com/nodejs/http-parser/blob/master/test.c
> (line 614)
[Message part 2 (text/html, inline)]
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Tue, 19 Dec 2017 07:27:51 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Wed May 17 14:04:43 2023;
Machine Name:
buxtehude
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.