Debian Bug report logs - #881536
ffmpeg: Breaks sound in kodi

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Robert Luberda <robert@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ffmpeg: Breaks sound in kodi

Date: Sun, 12 Nov 2017 21:32:31 +0100

Package: ffmpeg
Version: 7:3.4-2
Severity: important

The latest ffmpeg makes sound in kodi to be scratchy, i.e. containing some 
additional noise that makes watching videos in kodi uncomfortable/annoying.

Downgrading ffmpeg and dependent libraries to version 3.3.4-2+b3 fixes the
issue (makes sound in kodi clear).

Regards,
robert


-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (990, 'unstable-debug'), (990, 'stable-updates'), (990, 'unstable'), (990, 'testing'), (990, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8), LANGUAGE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ffmpeg depends on:
ii  libavcodec57    7:3.4-2
ii  libavdevice57   7:3.4-2
ii  libavfilter6    7:3.4-2
ii  libavformat57   7:3.4-2
ii  libavresample3  7:3.4-2
ii  libavutil55     7:3.4-2
ii  libc6           2.24-17
ii  libpostproc54   7:3.4-2
ii  libsdl2-2.0-0   2.0.7+dfsg1-3
ii  libswresample2  7:3.4-2
ii  libswscale4     7:3.4-2

ffmpeg recommends no packages.

Versions of packages ffmpeg suggests:
pn  ffmpeg-doc  <none>

-- no debconf information

Message #10 received at 881536@bugs.debian.org (full text, mbox, reply):

From: James Cowgill <jcowgill@debian.org>

To: Robert Luberda <robert@debian.org>

Cc: 881536@bugs.debian.org

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Sun, 12 Nov 2017 21:55:42 +0000

[Message part 1 (text/plain, inline)]

Hi,

On 12/11/17 20:32, Robert Luberda wrote:
> Package: ffmpeg
> Version: 7:3.4-2
> Severity: important
> 
> The latest ffmpeg makes sound in kodi to be scratchy, i.e. containing some 
> additional noise that makes watching videos in kodi uncomfortable/annoying.
> 
> Downgrading ffmpeg and dependent libraries to version 3.3.4-2+b3 fixes the
> issue (makes sound in kodi clear).

This is likely to be related to #879673 / #881286 which has a workaround
which I hoped would work, but doesn't seem to in every case. I can
reproduce the bug, but only for videos containing aac audio and only in
kodi.

I have attached a LD_PRELOAD shim which will cause any drain packets
sent to avcodec_decode_audio4 to be dropped (see the above bugs and
links for why this may be relevant). Could you compile it and run kodi
like this:

 gcc -shared shim.c -olibshim.so
 LD_PRELOAD=$(pwd)/libshim.so kodi-standalone

If that fixes your audio problems, then this is almost certainly #881286
in kodi (where kodi flagrantly violates the ffmpeg API).

Thanks,
James

[shim.c (text/x-csrc, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 881536@bugs.debian.org (full text, mbox, reply):

From: Viktor Malyarchuk <malyar@gmail.com>

To: James Cowgill <jcowgill@debian.org>, Robert Luberda <robert@debian.org>

Cc: 881536@bugs.debian.org

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Mon, 13 Nov 2017 00:23:10 -0600

[Message part 1 (text/plain, inline)]

Hi James,

just want to confirm that

gcc -shared shim.c -olibshim.so
LD_PRELOAD=$(pwd)/libshim.so kodi-standalone

indeed fixed the audio problem with kodi.

Best regards,
Viktor Malyarchuk

[Message part 2 (text/html, inline)]

Message #20 received at 881536@bugs.debian.org (full text, mbox, reply):

From: Robert Luberda <robert@debian.org>

To: Viktor Malyarchuk <malyar@gmail.com>, James Cowgill <jcowgill@debian.org>

Cc: 881536@bugs.debian.org

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Mon, 13 Nov 2017 18:53:03 +0100

Viktor Malyarchuk pisze:

Hi

> just want to confirm that
> 
> gcc -shared shim.c -olibshim.so
> LD_PRELOAD=$(pwd)/libshim.so kodi-standalone
> 
> indeed fixed the audio problem with kodi.

I can confirm that too.

Thanks a lot,
robert

Message #25 received at 881536@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@debian.org>

To: Robert Luberda <robert@debian.org>, 881536@bugs.debian.org, Viktor Malyarchuk <malyar@gmail.com>, James Cowgill <jcowgill@debian.org>

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Tue, 14 Nov 2017 15:03:01 +0100

[Message part 1 (text/plain, inline)]

Am Montag, den 13.11.2017, 18:53 +0100 schrieb Robert Luberda:
> I can confirm that too.

Impressive! Good work, James.

 - Fabian

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 881536@bugs.debian.org (full text, mbox, reply):

From: maze <maze@quantentunnel.de>

To: 881536@bugs.debian.org

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Thu, 16 Nov 2017 08:19:53 +0100

> I can
> reproduce the bug, but only for videos containing aac audio and only
> in
> kodi.

Affects .mp2 audio used in live tv streams (.ts) as well.
The workaround fixes that as well, though. 

Message #35 received at 881536@bugs.debian.org (full text, mbox, reply):

From: James Cowgill <jcowgill@debian.org>

To: Robert Luberda <robert@debian.org>, 881536@bugs.debian.org, Viktor Malyarchuk <malyar@gmail.com>

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Sat, 18 Nov 2017 16:18:10 +0000

[Message part 1 (text/plain, inline)]

Control: reassign -1 kodi 2:17.3+dfsg1-5

Hi,

On 13/11/17 17:53, Robert Luberda wrote:
> Viktor Malyarchuk pisze:
> 
> Hi
> 
>> just want to confirm that
>>
>> gcc -shared shim.c -olibshim.so
>> LD_PRELOAD=$(pwd)/libshim.so kodi-standalone
>>
>> indeed fixed the audio problem with kodi.
> 
> I can confirm that too.

Thanks. Reassigning the bug to kodi.

I think fixing the audio is easier than fixing the video (which only
works due to a workaround patch in ffmpeg). Maybe removing this decode
call is all that is needed?
https://anonscm.debian.org/git/pkg-multimedia/kodi.git/tree/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp#n489

James

[signature.asc (application/pgp-signature, attachment)]

Message #46 received at 881536@bugs.debian.org (full text, mbox, reply):

From: Stefan Hachmann <stefan@hachmann-it.de>

To: 881536@bugs.debian.org

Subject: Re: Bug#881536: ffmpeg: Breaks sound in kodi

Date: Sun, 17 Dec 2017 01:21:39 +0100

On Sat, 18 Nov 2017 16:18:10 +0000 James Cowgill <jcowgill@debian.org> wrote:

> Thanks. Reassigning the bug to kodi.
> 
> I think fixing the audio is easier than fixing the video (which only
> works due to a workaround patch in ffmpeg). Maybe removing this decode
> call is all that is needed?
> https://anonscm.debian.org/git/pkg-multimedia/kodi.git/tree/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp#n489

Yes, works fine after removal of decode call (with 17.6 from debian git[1]).
Thanks. :-)

[1] To compile it, directory 'kodi-17.6+dfsg1/addons/' have to be
    completed with missing library.* directories ...

Best regards,
Stefan


Patch:
--- a/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp
+++ b/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp
@@ -486,7 +486,7 @@
         // guess next pts
         m_audioClock += audioframe.duration;

-        int ret = m_pAudioCodec->Decode(nullptr, 0, DVD_NOPTS_VALUE, DVD_NOPTS_VALUE);
+        int ret = 0;
         if (ret < 0)
         {
           CLog::Log(LOGERROR, "CVideoPlayerAudio::DecodeFrame - Decode Error. Skipping audio packet (%d)", ret);

Message #51 received at 881536-submitter@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: 881536-submitter@bugs.debian.org

Subject: Bug#881536 marked as pending

Date: Tue, 26 Dec 2017 01:12:57 +0000

tag 881536 pending
thanks

Hello,

Bug #881536 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://anonscm.debian.org/git/pkg-multimedia/kodi.git/commit/?id=d0244c1

---
commit d0244c11d721bbdecc350a0780c9251fcf07e97a
Author: Balint Reczey <balint.reczey@canonical.com>
Date:   Tue Dec 26 01:11:04 2017 +0100

    Update changelog

diff --git a/debian/changelog b/debian/changelog
index 57b9283..255ce08 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,20 @@
-kodi (2:17.6+dfsg1-1) UNRELEASED; urgency=medium
+kodi (2:17.6+dfsg1-1) unstable; urgency=medium
 
-  * New upstream version 17.6+dfsg1
+  * New upstream version 17.6 (with accumulated changes from 17.4 and 17.5):
+    - https://kodi.tv/article/kodi-v174-final-just-bunch-fixes
+    - https://kodi.tv/article/kodi-v175-final-another-bunch-fixes
+    - https://kodi.tv/article/kodi-v176-final-very-last
   * Refresh patches
-
- -- Balint Reczey <rbalint@ubuntu.com>  Mon, 27 Nov 2017 01:35:37 +0100
+  * Depend and build-depend on python-pil instead of python-imaging
+    (Closes: #866437)
+  * Apply workaround for scratchy sound with FFmpeg 3.4.
+    Thanks to James Cowgill for triaging and Stefan Hachmann for the patch
+    (Closes: #881536)
+  * Fix starting kodi on arm64 (Closes: #876876)
+  * Change URLs to use HTTPS in README.Debian and drop feed URL from
+    description (Closes: #860484)
+
+ -- Balint Reczey <rbalint@ubuntu.com>  Tue, 26 Dec 2017 01:06:49 +0100
 
 kodi (2:17.3+dfsg1-5) unstable; urgency=medium
 

Message #56 received at 881536-close@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <rbalint@ubuntu.com>

To: 881536-close@bugs.debian.org

Subject: Bug#881536: fixed in kodi 2:17.6+dfsg1-1

Date: Tue, 26 Dec 2017 06:34:00 +0000

Source: kodi
Source-Version: 2:17.6+dfsg1-1

We believe that the bug you reported is fixed in the latest version of
kodi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 881536@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Balint Reczey <rbalint@ubuntu.com> (supplier of updated kodi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 26 Dec 2017 01:06:49 +0100
Source: kodi
Binary: kodi kodi-data kodi-bin kodi-eventclients-common kodi-eventclients-dev kodi-eventclients-wiiremote kodi-eventclients-ps3 kodi-eventclients-kodi-send kodi-addons-dev kodi-repository-kodi xbmc xbmc-bin xbmc-eventclients-common xbmc-eventclients-dev xbmc-eventclients-wiiremote xbmc-eventclients-ps3 xbmc-eventclients-xbmc-send xbmc-addons-dev
Architecture: source
Version: 2:17.6+dfsg1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Balint Reczey <rbalint@ubuntu.com>
Description:
 kodi       - Open Source Home Theatre (executable binaries)
 kodi-addons-dev - Open Source Home Theatre (Addons Dev package)
 kodi-bin   - Open Source Home Theatre (architecture-dependent files)
 kodi-data  - Open Source Home Theatre (arch-independent data package)
 kodi-eventclients-common - Open Source Home Theatre (Event Client Common package)
 kodi-eventclients-dev - Open Source Home Theatre (Event Client Dev package)
 kodi-eventclients-kodi-send - Open Source Home Theatre (Event Client Kodi-SEND package)
 kodi-eventclients-ps3 - Open Source Home Theatre (Event Client PS3 package)
 kodi-eventclients-wiiremote - Open Source Home Theatre (Event Client WII Remote support package
 kodi-repository-kodi - Open Source Home Theatre (official addons repository feed)
 xbmc       - transitional dummy package
 xbmc-addons-dev - transitional dummy package
 xbmc-bin   - transitional dummy package
 xbmc-eventclients-common - transitional dummy package
 xbmc-eventclients-dev - transitional dummy package
 xbmc-eventclients-ps3 - transitional dummy package
 xbmc-eventclients-wiiremote - transitional dummy package
 xbmc-eventclients-xbmc-send - transitional dummy package
Closes: 860484 866437 876876 881536
Changes:
 kodi (2:17.6+dfsg1-1) unstable; urgency=medium
 .
   * New upstream version 17.6 (with accumulated changes from 17.4 and 17.5):
     - https://kodi.tv/article/kodi-v174-final-just-bunch-fixes
     - https://kodi.tv/article/kodi-v175-final-another-bunch-fixes
     - https://kodi.tv/article/kodi-v176-final-very-last
   * Refresh patches
   * Depend and build-depend on python-pil instead of python-imaging
     (Closes: #866437)
   * Apply workaround for scratchy sound with FFmpeg 3.4.
     Thanks to James Cowgill for triaging and Stefan Hachmann for the patch
     (Closes: #881536)
   * Fix starting kodi on arm64 (Closes: #876876)
   * Change URLs to use HTTPS in README.Debian and drop feed URL from
     description (Closes: #860484)
Checksums-Sha1:
 7bda25a52435ac170afce7db9d803ad93cb90607 5751 kodi_17.6+dfsg1-1.dsc
 6843449c4d26cc97950b3dd93161b66be63d9945 369621 kodi_17.6+dfsg1.orig-libdvdnav-5-0-3.tar.bz2
 3cda64c06ca9b617d976c490651db4391a162e1f 394885 kodi_17.6+dfsg1.orig-libdvdread-5-0-3.tar.bz2
 08f0d3cbe066a515d13c7445475f23be233bf21c 246480 kodi_17.6+dfsg1.orig-webinterface-default.tar.xz
 7acfc7646b2202a8fc8310d1bad14139332b97b0 20277044 kodi_17.6+dfsg1.orig.tar.xz
 b6da10fedf4bf687493712a987c642489c2722d7 105080 kodi_17.6+dfsg1-1.debian.tar.xz
Checksums-Sha256:
 f07976c0621d76358e88ea467694fcf3535dccb1361328cacc910dfcbea52db7 5751 kodi_17.6+dfsg1-1.dsc
 3ff45551e81378e994c5a2381962d35282570e303fa16357ecb98f6fb616fd3c 369621 kodi_17.6+dfsg1.orig-libdvdnav-5-0-3.tar.bz2
 321cdf2dbdc83c96572bc583cd27d8c660ddb540ff16672ecb28607d018ed82b 394885 kodi_17.6+dfsg1.orig-libdvdread-5-0-3.tar.bz2
 693fa280d5f5622b1d197332d37124fbc8dbde80204d25b6a7a3bf8d85fcfb0f 246480 kodi_17.6+dfsg1.orig-webinterface-default.tar.xz
 961be0e9ba1ea715c2b887fbf37d5b6a31f3b4ab1e0eb15fd201ae3410254cea 20277044 kodi_17.6+dfsg1.orig.tar.xz
 9955414dc58fbd64678452cf7b1755df245725b1b1c04519b71e0d16ac728d26 105080 kodi_17.6+dfsg1-1.debian.tar.xz
Files:
 8db56aedd7c80688e84325f0425cba31 5751 video optional kodi_17.6+dfsg1-1.dsc
 0b8eb73603514a9c39444c2235cdb45c 369621 video optional kodi_17.6+dfsg1.orig-libdvdnav-5-0-3.tar.bz2
 b7b7d2a782087ed2a913263087083715 394885 video optional kodi_17.6+dfsg1.orig-libdvdread-5-0-3.tar.bz2
 7cfcb00a22c55c023966ce7d9abc1f4a 246480 video optional kodi_17.6+dfsg1.orig-webinterface-default.tar.xz
 1f1ffaec902a36386759d3ed6ab020fe 20277044 video optional kodi_17.6+dfsg1.orig.tar.xz
 e8e0abf4222beeb888017b7e71f8095a 105080 video optional kodi_17.6+dfsg1-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIwBAEBCAAaBQJaQZO7ExxyYmFsaW50QHVidW50dS5jb20ACgkQ9mTSVrRpGn0d
ZxAAjykMCSga4s/KRpVSPNgmkPpRYunTKblr79R3nsmYyqtWkIJcsDpxy8NeNopC
/1nIle3SvBl5UrA1MJtX7t3GwrFGwn74aStD6fj0ysfseaNjzuCtpLFkpJhATqqo
gL8eXmMs80fncUYmO5FSxw628cZQDSHdHyJbyPW4ZB6+qb9lcou8t4PBjiAWPdNC
XYA8A6W6+kGCO1uMh5oes/MzjFvaOOP7gf14+rvLd9SxcZU3I/Zf4Q5Gt9TKW2Dx
bm+FGpXkLuVnf97thr7i1pi6cd/Od3tR3X60RGC/UV05tvJBbb6j1BIiUlCv8cBJ
rb8xwIXVlumC2/pBoZFHCwLqYvQfaQCikLT1N+z1G0s69PunN+G85+3bBD25QnSU
1/hYxQU+lv81hNau3nFp7SHLiQEPiRIH3obm1p4C2rd2OUPY4MXNqaKOZKxPoie7
mPp8lBWU5oaKu0ujF6ymb0hQ+U/BsX44xvTpzgbuZDVGLDn/PIxSJH+EIg01sroW
hQ67wsdxszQOUfBoExsdLFABN/nvhNA8Z2h7D2MRFf0r7wZaCiXnhZ1U2O2fJ45X
/mnyE68ahb8MpTrgIZCvAufQR2tyoG4GTjZi4cyEITyXPnMH1+OYs39r/rJu+Ek/
5BSNozwYAJrpCUFDs3TzETfrlvbG7FfMnu7UXzZfXwvNHrI=
=f2ee
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.