Debian Bug report logs - #880902
zfs-test: fails to upgrade from 'testing' - trying to overwrite /usr/share/zfs/common.sh

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: zfs-test: fails to upgrade from 'testing' - trying to overwrite /usr/share/zfs/common.sh

Date: Sun, 05 Nov 2017 15:18:57 +0100

[Message part 1 (text/plain, inline)]

Package: zfs-test
Version: 0.7.3-1
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package fails to upgrade from
'testing'.
It installed fine in 'testing', then the upgrade to 'sid' fails
because it tries to overwrite other packages files without declaring a
Breaks+Replaces relation.

See policy 7.6 at
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces

From the attached log (scroll to the bottom...):

  Selecting previously unselected package zfs-test.
  Preparing to unpack .../38-zfs-test_0.7.3-1_amd64.deb ...
  Unpacking zfs-test (0.7.3-1) ...
  dpkg: error processing archive /tmp/apt-dpkg-install-RL6UMz/38-zfs-test_0.7.3-1_amd64.deb (--unpack):
   trying to overwrite '/usr/share/zfs/common.sh', which is also in package zfsutils-linux 0.6.5.11-1
  dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
  Errors were encountered while processing:
   /tmp/apt-dpkg-install-RL6UMz/38-zfs-test_0.7.3-1_amd64.deb


cheers,

Andreas

[zfsutils-linux=0.6.5.11-1_zfs-test=0.7.3-1.log.gz (application/gzip, attachment)]

Message #10 received at 880902@bugs.debian.org (full text, mbox, reply):

From: Raphael Hertzog <hertzog@debian.org>

To: 880902@bugs.debian.org

Subject: RC bug on zfs-linux that has to be fixed

Date: Thu, 16 Nov 2017 12:10:38 +0100

Hello,

This bug should be quickly fixed because ZFS is broken in Debian
Testing right now, spl-linux migrated already and zfs-linux did not
migrate due to this bug.

Someone reported this problematic mismatch in Kali (which is based on
Debian testing):
https://bugs.kali.org/view.php?id=4351

Adding the required header is rather easy so I hope that a maintainer
can take care of preparing the required update.

Given that both packages are tightly coupled, you should consider
adding more tight dependencies as well so that this does not happen
again in the future.

Thank you!
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Message #15 received at 880902@bugs.debian.org (full text, mbox, reply):

From: Craig Sanders <cas@taz.net.au>

To: 880902@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#880902: RC bug on zfs-linux that has to be fixed

Date: Fri, 17 Nov 2017 00:00:59 +1100

On Thu, Nov 16, 2017 at 12:10:38PM +0100, Raphael Hertzog wrote:
> This bug should be quickly fixed because ZFS is broken in Debian Testing
> right now, spl-linux migrated already and zfs-linux did not migrate due to
> this bug.

This bug definitely needs to be fixed but it shouldn't be a big panic-inducing
deal for anyone following sane practice with the zfs packages anyway.

By "sane practice", I mean that the zfs packages should **always** be held
until you manually unhold them immediately prior to upgrading them, and then
immediately hold them again.

Ditto for linux-image-$arch and linux-header-$arch packages on any system that
needs dkms modules.

Why?

Because zfs-dkms and spl-dkms almost always need to be updated for new kernel
versions.  Just letting them upgrade automatically via apt-get upgrade or
dist-upgrade is a recipe for a broken system.  So far, while new kernels
almost always break older zfs packages, newer zfs packages tend to compile OK
on older kernels....but that's not at all guaranteed to be the case.  It's a
pretty safe bet, but not one I'd be willing to take when it could mean being
unable to access my data or even boot my zfs-root systems.

Actually, that's true for most, if not all, -dkms packages.  So the safe thing to
do is to hold kernel and dkms packages.


BTW, I use the following script to list (default), verbose list (-v), hold
(-h), and unhold (-u) zfs related packages:


    #!/bin/bash
    #
    # script: list-zfs.sh
    # author: Craig Sanders <cas@taz.net.au>
    # license: Public Domain (this script is too trivial to be anything else)

    # options:
    # default/none    list the installed ZoL packages, one per line
    # -v              verbose (dpkg -l) list the packages
    # -h              hold the packages with apt-mark
    # -u              unhold the packages with apt-mark

    # build an array of currently-installed zfs packages.
    # this would be better with grep-status from dctrl-tools, but dpkg is
    # guaranteed to be on every debian system while dctrl-tools isn't.
    PKGS=( $(dpkg -l '*libnvpair*linux' '*libuutil*linux*' '*zfs*' '*zpool*' 'spl' 'spl-dkms' 2>/dev/null | awk '/^.i/ {print $2}') )

    if [ "$1" == "-v" ] ; then
      dpkg -l "${PKGS[@]}"
    elif [ "$1" == "-h" ] ; then
      apt-mark hold "${PKGS[@]}"
    elif [ "$1" == "-u" ] ; then
      apt-mark unhold "${PKGS[@]}"
    else
      printf "%s\n" "${PKGS[@]}"
    fi

I've got a similar script for nvidia related packages.  It's exactly the same except
for the PKGS array.


For kernels, I keep them on hold until I want to (manually) upgrade them:

    apt-get -u install linux-headers-amd64 linux-image-amd64 ; \
      apt-mark hold linux-headers-amd64 linux-image-amd64



packages make systems administration easier. they're not a substitute for it.

craig

ps: this bug is an example of why testing is actually worse than sid for
real-world (non-testing) usage.  This bug report, while necessary, actually
delayed the migration of the updated zfs packages that would have resolved
it.  That's an unavoidable side-effect of bug reports against packages in sid.
IIRC, packages only get migrated from sid to testing if there hasn't been a
bug reported against them for 14 (? not sure exactly) days.


--
craig sanders <cas@taz.net.au>

BOFH excuse #112:

The monitor is plugged into the serial port

Message #20 received at 880902@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: Andreas Beckmann <anbe@debian.org>, 880902@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#880902: zfs-test: fails to upgrade from 'testing' - trying to overwrite /usr/share/zfs/common.sh

Date: Thu, 16 Nov 2017 14:45:04 +0100

[Message part 1 (text/plain, inline)]

On Sun, Nov 05, 2017 at 03:18:57PM +0100, Andreas Beckmann wrote:
> Package: zfs-test
> Version: 0.7.3-1
> Severity: serious
> User: debian-qa@lists.debian.org
> Usertags: piuparts
> 
> Hi,
> 
> during a test with piuparts I noticed your package fails to upgrade from
> 'testing'.
> It installed fine in 'testing', then the upgrade to 'sid' fails
> because it tries to overwrite other packages files without declaring a
> Breaks+Replaces relation.
> 
> See policy 7.6 at
> https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
> 
> From the attached log (scroll to the bottom...):
> 
>   Selecting previously unselected package zfs-test.
>   Preparing to unpack .../38-zfs-test_0.7.3-1_amd64.deb ...
>   Unpacking zfs-test (0.7.3-1) ...
>   dpkg: error processing archive /tmp/apt-dpkg-install-RL6UMz/38-zfs-test_0.7.3-1_amd64.deb (--unpack):
>    trying to overwrite '/usr/share/zfs/common.sh', which is also in package zfsutils-linux 0.6.5.11-1
>   dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
>   Errors were encountered while processing:
>    /tmp/apt-dpkg-install-RL6UMz/38-zfs-test_0.7.3-1_amd64.deb
> 
> 
> cheers,
> 
> Andreas

attached patch should fix the issue in this bug, proposal for related
bug #880907 will follow.

[0001-zfs-test-add-proper-Breaks-Replaces.patch (text/x-diff, attachment)]

Message #27 received at 880902-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: 880902-close@bugs.debian.org

Subject: Bug#880902: fixed in zfs-linux 0.7.3-2

Date: Tue, 28 Nov 2017 09:11:28 +0000

Source: zfs-linux
Source-Version: 0.7.3-2

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 880902@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aron Xu <aron@debian.org> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 28 Nov 2017 16:16:34 +0800
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-test zfs-dbg
Architecture: source amd64 all
Version: 0.7.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
Changed-By: Aron Xu <aron@debian.org>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-test   - OpenZFS test infrastructure an support scripts
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 880709 880902 882209
Changes:
 zfs-linux (0.7.3-2) unstable; urgency=medium
 .
   [ Fabian Grünbichler ]
   * d/rules: remove obsolete calls to dpkg-architecture (Closes: #882209)
   * zfs-test: add proper Breaks+Replaces (Closes: #880902)
   * build: add implicit version to dh_makeshlibs (Closes: #880709)
 .
   [ Aron Xu ]
   * Depend on matching version of spl-dkms (Closes: ##881013)
Checksums-Sha1:
 54225dbb393856a6a8a471196baf7ec93ea3b201 2663 zfs-linux_0.7.3-2.dsc
 3470ce564ee978304174f6763efc565f9e816a6f 41540 zfs-linux_0.7.3-2.debian.tar.xz
 a6f5ee09508de84dcbbd5c9da959563ea0a408d6 45680 libnvpair1linux_0.7.3-2_amd64.deb
 68c6511fb1a922c3287f1f9c11ef166388600a4a 48116 libuutil1linux_0.7.3-2_amd64.deb
 5b00361b08d45f30565cd446c3a906ba09a9271a 138076 libzfs2linux_0.7.3-2_amd64.deb
 9eb27c5a2f1df342036d35380191d6a322c6af63 1024008 libzfslinux-dev_0.7.3-2_amd64.deb
 c636c71ba8215a162d7844b13ccb1208934bbd94 562920 libzpool2linux_0.7.3-2_amd64.deb
 b4d969233c9a9336050cede7b1347c8a0018c7a9 3719392 zfs-dbg_0.7.3-2_amd64.deb
 330df1340fed6e35775b8fc1b1159ab16aa0f454 1381936 zfs-dkms_0.7.3-2_all.deb
 7c472c2be4e0de5d69f0f46cf9651f00a9f84396 20868 zfs-dracut_0.7.3-2_all.deb
 5a7bf9990a4d8735e7173172903b19289527780f 24412 zfs-initramfs_0.7.3-2_all.deb
 e6bcd65340b5ea987860fab6191b98b8aa0c9b24 8736 zfs-linux_0.7.3-2_amd64.buildinfo
 258e73e322d1e7a4bfe93f3a124a2b81fb99587b 2463732 zfs-test_0.7.3-2_amd64.deb
 a95dfb8a4eb27611ee6ebbb97ec9c4ab61d7ab79 60232 zfs-zed_0.7.3-2_amd64.deb
 ad4a07dd3ce3fd034eb718841722ad73d4a65297 349556 zfsutils-linux_0.7.3-2_amd64.deb
Checksums-Sha256:
 53407931f098eb27ef8bcd528e363b1c6a5ace3f8d4054f459b35e8dedf8854e 2663 zfs-linux_0.7.3-2.dsc
 d8d74841faeca3747d52e9365f3a25e32390744c8abf8e4af2543e005d1064e0 41540 zfs-linux_0.7.3-2.debian.tar.xz
 155edd92365ffab23153a8b9e96c1156d0245bcd321c446703cc9934ce04b5da 45680 libnvpair1linux_0.7.3-2_amd64.deb
 b12f449af004a9aa8b85194ca56287aaba5231f8396fcf6f34a5e401af772349 48116 libuutil1linux_0.7.3-2_amd64.deb
 4e4a881bfbb1e41bf993fe26b71c0bacec98c19a1b39eb73d76edadc6c24ecd5 138076 libzfs2linux_0.7.3-2_amd64.deb
 cdb623c01318235bb949cddcc4e31bedea66062c2bef4a13a71de81fe7c53202 1024008 libzfslinux-dev_0.7.3-2_amd64.deb
 16e45b1b979415fd3839d4c31cf1e2783edab582bb2207ac0e0084df07de6846 562920 libzpool2linux_0.7.3-2_amd64.deb
 ad150a6914e426f45e3d8e0c2fd33cf036c0803ac7f21bf9a4f4ba189afdae64 3719392 zfs-dbg_0.7.3-2_amd64.deb
 377a0b3b09330787560724287d7bea31763f4e4783363e0b38806f31a2e3524f 1381936 zfs-dkms_0.7.3-2_all.deb
 66bced87d9ab6c2ca75dfba5f4e4cc4fbba9fe8ec7bfb5c0aa0387242c2576f9 20868 zfs-dracut_0.7.3-2_all.deb
 dcadc59dc22e9ac38a9b6b9f33891b4ef04e1af100c48e619b90a9c308a1b7a8 24412 zfs-initramfs_0.7.3-2_all.deb
 a73ce75dbbb6b429c02153c463f9f19c8798eac09b8d36728f1784a59aee2f5f 8736 zfs-linux_0.7.3-2_amd64.buildinfo
 dce291ff8d2a2a255ae29e999c29da0dafd382a2106e152aaf69e8e44450f32c 2463732 zfs-test_0.7.3-2_amd64.deb
 3c8e8849dea235b9a86e7da47ba4b599a507484c82865e23bc01db46ca105f84 60232 zfs-zed_0.7.3-2_amd64.deb
 85decf2f2011fb8ed14521294a03cea7290b60c8fdb8a20678aada5d3a25d9f2 349556 zfsutils-linux_0.7.3-2_amd64.deb
Files:
 0d0e8c4f7722c5f6b0c4a6e9c67f0751 2663 contrib/kernel optional zfs-linux_0.7.3-2.dsc
 a700e29685b227dad062d05052b2b0e9 41540 contrib/kernel optional zfs-linux_0.7.3-2.debian.tar.xz
 111ff44d1868341b94640988ee499f9c 45680 contrib/libs optional libnvpair1linux_0.7.3-2_amd64.deb
 b3d17cf66ff953ff0361d8c50ac946a5 48116 contrib/libs optional libuutil1linux_0.7.3-2_amd64.deb
 7c55ff8a02c0f3139b0f7ab0567ec018 138076 contrib/libs optional libzfs2linux_0.7.3-2_amd64.deb
 2b54b0e5707e03717a91a707a438c10f 1024008 contrib/libdevel optional libzfslinux-dev_0.7.3-2_amd64.deb
 82d02296c7f629728d869e58d5dee510 562920 contrib/libs optional libzpool2linux_0.7.3-2_amd64.deb
 c6cf2aab4b6e844ccc51e6c031f915ec 3719392 contrib/debug extra zfs-dbg_0.7.3-2_amd64.deb
 99f2e221461667530d2bd453a843d3ad 1381936 contrib/kernel optional zfs-dkms_0.7.3-2_all.deb
 b1019d9aaf38a95cf504a5e827f3df81 20868 contrib/kernel optional zfs-dracut_0.7.3-2_all.deb
 486d1669fb22114c7c55b61b8c791504 24412 contrib/kernel optional zfs-initramfs_0.7.3-2_all.deb
 88d2af4c8c83efa71c155196747857f2 8736 contrib/kernel optional zfs-linux_0.7.3-2_amd64.buildinfo
 d742b19d636c1aae14a42034043126de 2463732 contrib/admin optional zfs-test_0.7.3-2_amd64.deb
 9933aaaf0b12f19f8590fd5d5e8d33bd 60232 contrib/admin optional zfs-zed_0.7.3-2_amd64.deb
 6a34fc9f739c14d36d79be2af512007e 349556 contrib/admin optional zfsutils-linux_0.7.3-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEsW3g9zWrjdJ64EeNev3ArdrqwV4FAlodHSsACgkQev3Ardrq
wV6phQgAtIghYCz1mJi6S+tcPJrSvFLjqd0e8LIyTSBOZtbiE92j34XgpTR4qyzI
OHb/5pYanGzqQMvAncNYv026r6JkzthyXMLSE7HMZkYQ6HnVBRbp5Z7AZxnN0Lz9
6qFMXl0asA78iJIev3SjS+IOw9s7T3cpXQrL2CuWGDu5JR6IV02T2iHFBIAxw1Bf
+XXlplwCRajxyEDSRu/MjjsPQt5/8VUBfeKmACpiaAnkBrHB350d5qkgi/GyOGt5
wuNt6V18aLEFZryzxfKXUoZgYB6v9acoAyaTm5iCaB0oReLmev966ZsCS5GJElVh
VOAfEn3DqkdHhVYiCNpN7RC65w7DwA==
=csPW
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.