Debian Bug report logs - #878911
avahi FTBFS with debhelper 10.9.2

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: avahi FTBFS with debhelper 10.9.2

Date: Tue, 17 Oct 2017 19:45:11 +0300

Source: avahi
Version: 0.7-3
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/avahi.html

...
   dh_systemd_start
dh_systemd_start: Could not find "avahi-daemon.socket" in the /lib/systemd/system directory of avahi-dnsconfd. This could be a typo, or using Also= with a service file from another package. Please check carefully that this message is harmless.
dh_systemd_start: Cannot open(avahi-daemon.socket) for extracting the Also= line(s)
debian/rules:4: recipe for target 'binary' failed
make: *** [binary] Error 2


19:35 < nthykier> bunk: Ideally, avahi would fix this on their end.  Without the fail-on-error, debhelper will silently "not do things" 
                  when the file is unreadable (even if only temporarily).  I.e. a "fail-to-fail"-case

Message #10 received at 878911@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 878911@bugs.debian.org, niels@thykier.net

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: avahi FTBFS with debhelper 10.9.2

Date: Sat, 21 Oct 2017 03:34:22 +0200

[Message part 1 (text/plain, inline)]

On Tue, 17 Oct 2017 19:45:11 +0300 Adrian Bunk <bunk@debian.org> wrote:
> Source: avahi
> Version: 0.7-3
> Severity: serious
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/avahi.html
> 
> ...
>    dh_systemd_start
> dh_systemd_start: Could not find "avahi-daemon.socket" in the /lib/systemd/system directory of avahi-dnsconfd. This could be a typo, or using Also= with a service file from another package. Please check carefully that this message is harmless.
> dh_systemd_start: Cannot open(avahi-daemon.socket) for extracting the Also= line(s)
> debian/rules:4: recipe for target 'binary' failed
> make: *** [binary] Error 2
> 
> 
> 19:35 < nthykier> bunk: Ideally, avahi would fix this on their end.  Without the fail-on-error, debhelper will silently "not do things" 
>                   when the file is unreadable (even if only temporarily).  I.e. a "fail-to-fail"-case
> 

avahi-daemon.socket is provided by avahi-daemon, a binary package which
is built from the same source package and avahi-dnsconfd depends on
avahi-daemon.
Niels, can you be a bit more specific why this fails now and what you
think is the proper fix?
A service file having an Also= line referencing a service which pulled
in via Depends seems fine to me.

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 878911@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Michael Biebl <biebl@debian.org>, 878911@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>, Felipe Sateler <fsateler@debian.org>

Subject: Re: avahi FTBFS with debhelper 10.9.2

Date: Sat, 21 Oct 2017 06:44:00 +0000

Control: reassign -1 debhelper 10.9.2

Michael Biebl:
> On Tue, 17 Oct 2017 19:45:11 +0300 Adrian Bunk <bunk@debian.org> wrote:
>> Source: avahi
>> Version: 0.7-3
>> Severity: serious
>>
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/avahi.html
>>
>> ...
>>    dh_systemd_start
>> dh_systemd_start: Could not find "avahi-daemon.socket" in the /lib/systemd/system directory of avahi-dnsconfd. This could be a typo, or using Also= with a service file from another package. Please check carefully that this message is harmless.
>> dh_systemd_start: Cannot open(avahi-daemon.socket) for extracting the Also= line(s)
>> debian/rules:4: recipe for target 'binary' failed
>> make: *** [binary] Error 2
>>
>>
>> 19:35 < nthykier> bunk: Ideally, avahi would fix this on their end.  Without the fail-on-error, debhelper will silently "not do things" 
>>                   when the file is unreadable (even if only temporarily).  I.e. a "fail-to-fail"-case
>>
> 

Hi,

> avahi-daemon.socket is provided by avahi-daemon, a binary package which
> is built from the same source package and avahi-dnsconfd depends on
> avahi-daemon.

Ok, when I spoke with Adrian about this, I had a different understanding
of what happened and why it broke.

> Niels, can you be a bit more specific why this fails now and what you
> think is the proper fix?

I can explain why it fails; dh_systemd_start basically reads the Also=
line and pretends it was a part of the services listed on the cmdline/in
the package.  As it is now mandatory for us to be able to read the
service files, this will fail as the service is not where we expect to
find it.

The comment related to that part of the code reads:

"""
	# Handle all unit files specified via Also= explicitly.
	# This is not necessary for enabling, but for disabling, as we
	# cannot read the unit file when disabling (it was already
	# deleted).
"""

@biebl/@fsateler: when a unit has an Also= that points to a unit in a
different package can we then just ignore the relation?  I assume that
we should not disable/stop services from another package on removal.

Thanks,
~Niels

Message #34 received at 878911-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 878911-close@bugs.debian.org

Subject: Bug#878911: fixed in debhelper 10.10

Date: Sat, 21 Oct 2017 18:18:49 +0000

Source: debhelper
Source-Version: 10.10

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 878911@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 21 Oct 2017 17:59:46 +0000
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 10.10
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 debhelper  - helper programs for debian/rules
 dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 876453 878911
Changes:
 debhelper (10.10) unstable; urgency=medium
 .
   * dh_installsystemd: Improve error messages to include the actual
     error caused by attempted to open the file.
   * dh_systemd_enable: Ditto.
   * dh_systemd_start: Ditto.
   * dh_installinit: In compat 12, error out if an upstart init file
     is provided with a reminder message about how to remove the
     obsolete conffile.  (Closes: #876453)
   * dh_systemd_enable: Permit missing explicitly requested file in
     package as long as another on being acted on ships it.
     (Closes: #878911)
   * dh_systemd_start: Ditto.
   * Dh_Lib.pm: Add support for R³ (Rules-Requires-Root field) to
     enable package builds without requiring root (or only
     selectively require root).
   * dh_fixperms: Skip "chown" calls when R³ is set to anything but
     "binary-targets".
   * dh_installchangelogs: Ditto.
   * dh_installdocs: Ditto.
   * dh_testroot: Update check for root to support R³.
   * makefile.pm: Call "make install" with DPKG_GAIN_ROOT_CMD when
     R³ contains the "debhelper/upstream-make-install" keyword.
   * dh_builddeb: Pass --root-owner-group to dpkg-deb in packages
     with R³ (except for "binary-targets").
   * dh_usrlocal: When R³ is enabled (and not "binary-targets"),
     ignore the ownership/mode information on the directories.
     Instead, the ownership "root:staff" and the mode 02775 is used.
   * d/control: Bump (Build-)Dependency on dpkg-dev to support to
     support R³.
   * d/control: Set R³ to "no".
Checksums-Sha1:
 b0eb65b81ea22e1e034ad7fbb9673925d2ebb2e6 1766 debhelper_10.10.dsc
 97755a50cbdfd8ab6042c381d2a4eb8e6aa206cb 427004 debhelper_10.10.tar.xz
 d06fa91ccbc1c5ead2d9d252bc88fe0646454b83 4519 debhelper_10.10_source.buildinfo
Checksums-Sha256:
 56c3c637d8dcb43a5605092b23005866f671671c717ae339ad8ebede9dcdc0ab 1766 debhelper_10.10.dsc
 61be3a7ce7000088320af83139d0a1c1f765e4e5cd2a053edc5e65433e012f19 427004 debhelper_10.10.tar.xz
 173c92c1a912f81bb650aa7cbe2d148750f1269509f288592482a5c0bec00d64 4519 debhelper_10.10_source.buildinfo
Files:
 6622752d41beab466a2374781d2a6876 1766 devel optional debhelper_10.10.dsc
 fda6cbcfa5d15b2d35bdabeb7331528c 427004 devel optional debhelper_10.10.tar.xz
 6083b2217ecf9583ef902aa85a4d66d4 4519 devel optional debhelper_10.10_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAlnrjFcACgkQBUu7n32A
ZELcfQ//XYNuPoUZwCJpKCmNz7HdlzqvzmUrxZQxW9+klrnTJIMZX58KQbTt8rxg
FikNuKQENrgFEIMJQfepcrVgJ5+4NG+VJ3UriQUCMl+yQJuI7tdmNzXKLCbCZWx6
4YDkqt/3rAtuIW/TIha5rhj7obQ3ARikGM6JUdPyH5Gys3KE2H7s1D0/5DrwjELG
yrCAB+JjIZFMUBLmrXRPPdHTvhGL9pdM5GUnPWektfLdQ7/vcN06sO3GgBfJN75F
wdZik8Q2wL/uowQ6/KHyyrZ6E14PZYtIFcR83aHUdKAHMWKaVJHegGfL3RrDmfvN
lBckKJkZvCJg1Jq8rSh0ohpKU4lJyXvr1XeVRSlrX2e1uzNOBtRkr8atYqSPf20M
LZLbNOk5tNwVrcP3YV+ML9Dp+gTchAW2OhUovF1ytfpRmbyu45dnYSGGbbQQIORq
lWJlQqraMuJwlMWyvYu6gjYjkmBmBdr+FqI5kC5G+wG1hmqov8FGfRWL2IQtK8Ll
oCpBDfKVjhxvPrD5k6y6rDTxVFg0p/s90VfEGoHaVrfNiyyMLDRUzxymQ56I9T02
zJd26LKn++RM5lkZGe8S0iNmbeTh6u70H18pN6NNv7umP88s34O3czCt9tTr/7VG
jPZH7R3U7p+oOXOBgQ0a4IQFdCxfSHod3iQMgW8MldiiMVnN1IY=
=3j15
-----END PGP SIGNATURE-----

Message #43 received at 878911@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Niels Thykier <niels@thykier.net>

Cc: Michael Biebl <biebl@debian.org>, 878911@bugs.debian.org, Adrian Bunk <bunk@debian.org>

Subject: Re: avahi FTBFS with debhelper 10.9.2

Date: Mon, 23 Oct 2017 18:13:44 -0300

On Sat, Oct 21, 2017 at 3:44 AM, Niels Thykier <niels@thykier.net> wrote:
> Control: reassign -1 debhelper 10.9.2
>
> Michael Biebl:
>> On Tue, 17 Oct 2017 19:45:11 +0300 Adrian Bunk <bunk@debian.org> wrote:
>>> Source: avahi
>>> Version: 0.7-3
>>> Severity: serious
>>>
>>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/avahi.html
>>>
>>> ...
>>>    dh_systemd_start
>>> dh_systemd_start: Could not find "avahi-daemon.socket" in the /lib/systemd/system directory of avahi-dnsconfd. This could be a typo, or using Also= with a service file from another package. Please check carefully that this message is harmless.
>>> dh_systemd_start: Cannot open(avahi-daemon.socket) for extracting the Also= line(s)
>>> debian/rules:4: recipe for target 'binary' failed
>>> make: *** [binary] Error 2
>>>
>>>
>>> 19:35 < nthykier> bunk: Ideally, avahi would fix this on their end.  Without the fail-on-error, debhelper will silently "not do things"
>>>                   when the file is unreadable (even if only temporarily).  I.e. a "fail-to-fail"-case
>>>
>>
>
> Hi,
>
>> avahi-daemon.socket is provided by avahi-daemon, a binary package which
>> is built from the same source package and avahi-dnsconfd depends on
>> avahi-daemon.
>
> Ok, when I spoke with Adrian about this, I had a different understanding
> of what happened and why it broke.
>
>> Niels, can you be a bit more specific why this fails now and what you
>> think is the proper fix?
>
> I can explain why it fails; dh_systemd_start basically reads the Also=
> line and pretends it was a part of the services listed on the cmdline/in
> the package.  As it is now mandatory for us to be able to read the
> service files, this will fail as the service is not where we expect to
> find it.
>
> The comment related to that part of the code reads:
>
> """
>         # Handle all unit files specified via Also= explicitly.
>         # This is not necessary for enabling, but for disabling, as we
>         # cannot read the unit file when disabling (it was already
>         # deleted).
> """
>
> @biebl/@fsateler: when a unit has an Also= that points to a unit in a
> different package can we then just ignore the relation?  I assume that
> we should not disable/stop services from another package on removal.

I think that in this case, the correct fix is to drop the Also= line.

1. We don't want to stop avahi-daemon socket if dnsconfd is removed
2. It appears the Also line is being treated as some form of
dependency manager (ie, to ensure that the avahi-daemon is started
when dnsconfd is started), but it is not necessary, because
avahi-daemon.socket is already Required.

So, I think we have not yet found a compelling case for dropping the
debhelper error. The Also line is not needed, and can be safely
dropped from the avahi-dnsconfd unit.

-- 

Saludos,
Felipe Sateler

Send a report that this bug log contains spam.