Debian Bug report logs - #878899
dpkg-buildpackage no longer calls build, only binary

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dpkg-buildpackage no longer calls build, only binary

Date: Tue, 17 Oct 2017 18:03:20 +0300

Package: dpkg-dev
Version: 1.19.0.1
Severity: serious

14:39 < _rene_> hmm. dpkg-dev 1.19.0.1 broken for anyone else? looks like it doesn't call build(-arch,indep) anymore at 
                dpkg-buildpackage -b, but just binary?

I seen the same debugging a FTBFS.

Message #10 received at 878899@bugs.debian.org (full text, mbox, reply):

From: James Clarke <jrtc27@debian.org>

To: Adrian Bunk <bunk@debian.org>, 878899@bugs.debian.org

Subject: Re: Bug#878899: dpkg-buildpackage no longer calls build, only binary

Date: Tue, 17 Oct 2017 16:31:05 +0100

On Tue, Oct 17, 2017 at 06:03:20PM +0300, Adrian Bunk wrote:
> Package: dpkg-dev
> Version: 1.19.0.1
> Severity: serious
>
> 14:39 < _rene_> hmm. dpkg-dev 1.19.0.1 broken for anyone else? looks like it doesn't call build(-arch,indep) anymore at
>                 dpkg-buildpackage -b, but just binary?
>
> I seen the same debugging a FTBFS.

I believe this is caused by [0]:

[16:26:57]  <jrtc27>	my understanding is that rules_requires_root is going to be returning 0 for the build-* targets
[16:27:06]  <helmut>	jrtc27: clearly the default tries to be binary-targets which would preserve the original behaviour
[16:27:19]  <jrtc27>	since $rules_requires_root{'binary-targets'} will be set, but $target_legacy_root{'build'} will be false
[16:27:33]  <helmut>	aha
[16:28:17]  <jrtc27>	so I think the two instances of rules_requires_root($buildtarget) should be rules_requires_root($binarytarget)
[16:28:33]  <helmut>	jrtc27: thank you. so it should say "return if not any_target_requires_root;" in build_target_fallback
[16:28:43]  <helmut>	or that
[16:28:53]  <jrtc27>	rules_requires_root('build') is correct to return 0
[16:28:58]  <jrtc27>	build doesn't need root :P
[16:29:08]  <helmut>	no package building today I guess

Regards,
James

[0] https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/?id=fca1bfe8406898105d1d724fb808f0cbcf985ae4

Message #15 received at 878899@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: James Clarke <jrtc27@debian.org>, 878899@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#878899: dpkg-buildpackage no longer calls build, only binary

Date: Tue, 17 Oct 2017 22:06:22 +0200

Hi!

On Tue, 2017-10-17 at 16:31:05 +0100, James Clarke wrote:
> On Tue, Oct 17, 2017 at 06:03:20PM +0300, Adrian Bunk wrote:
> > Package: dpkg-dev
> > Version: 1.19.0.1
> > Severity: serious
> >
> > 14:39 < _rene_> hmm. dpkg-dev 1.19.0.1 broken for anyone else? looks like it doesn't call build(-arch,indep) anymore at
> >                 dpkg-buildpackage -b, but just binary?
> >
> > I seen the same debugging a FTBFS.
> 
> I believe this is caused by [0]:
> 
> [16:26:57]  <jrtc27>	my understanding is that rules_requires_root is going to be returning 0 for the build-* targets
> [16:27:06]  <helmut>	jrtc27: clearly the default tries to be binary-targets which would preserve the original behaviour
> [16:27:19]  <jrtc27>	since $rules_requires_root{'binary-targets'} will be set, but $target_legacy_root{'build'} will be false
> [16:27:33]  <helmut>	aha
> [16:28:17]  <jrtc27>	so I think the two instances of rules_requires_root($buildtarget) should be rules_requires_root($binarytarget)
> [16:28:33]  <helmut>	jrtc27: thank you. so it should say "return if not any_target_requires_root;" in build_target_fallback
> [16:28:43]  <helmut>	or that
> [16:28:53]  <jrtc27>	rules_requires_root('build') is correct to return 0
> [16:28:58]  <jrtc27>	build doesn't need root :P
> [16:29:08]  <helmut>	no package building today I guess

Right, thanks for the analisys! I've fixed this locally now, and will
be included in 1.19.0.2.

Although, I've to say, the Severity looks a bit unfair (while practically
correct), because any package that gets broken due to build rules not
being called is violating several Debian policy MUSTS anyway.

I'll open a discussion on d-d later today.

Thanks,
Guillem

Message #18 received at 878899-submitter@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 878899-submitter@bugs.debian.org

Subject: Bug#878899 in package dpkg marked as pending

Date: Wed, 18 Oct 2017 00:03:49 +0000

Control: tag 878899 pending

Hi!

Bug #878899 in package dpkg reported by you has been fixed in
the dpkg/dpkg.git Git repository. You can see the changelog below, and
you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/dpkg/dpkg.git/diff/?id=a3a9527

---
commit a3a9527efb1345ac71014dd59da911db05e99ea0
Author: Guillem Jover <guillem@debian.org>
Date:   Tue Oct 17 21:20:53 2017 +0200

    dpkg-buildpackage: Fix logic to decide whether to call the build targets
    
    The build targets never require root, so checking them will always return
    false. We need to key on the binary target instead.
    
    This broke tons of packages that are violating Debian policy MUSTs.
    
    Thanks-to: James Clarke <jrtc27@debian.org>
    Closes: #878899

diff --git a/debian/changelog b/debian/changelog
index b0d8ca6..fd9c8a8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,8 @@
 dpkg (1.19.1) UNRELEASED; urgency=medium
 
+  * Fix logic in dpkg-buildpackage to decide whether to run build targets,
+    which broke tons of packages that are violating Debian policy MUSTs.
+    Thanks to James Clarke <jrtc27@debian.org>. Closes: #878899
   * Packaging:
     - Install update-alternatives policykit-1 file.
     - Add Breaks to libdpkg-perl against pkg-kde-tools (<< 0.15.28~), as

Message #23 received at 878899-submitter@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 878899-submitter@bugs.debian.org

Subject: Bug#878899 in package dpkg marked as pending

Date: Wed, 18 Oct 2017 00:05:22 +0000

Control: tag 878899 pending

Hi!

Bug #878899 in package dpkg reported by you has been fixed in
the dpkg/dpkg.git Git repository. You can see the changelog below, and
you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/dpkg/dpkg.git/diff/?id=029aa41

---
commit 029aa41244e44c6d4675ac7af69df4ce29bbe2b0
Author: Guillem Jover <guillem@debian.org>
Date:   Tue Oct 17 21:20:53 2017 +0200

    dpkg-buildpackage: Fix logic to decide whether to call the build targets
    
    The build targets never require root, so checking them will always return
    false. We need to key on the binary target instead.
    
    This broke tons of packages that are violating Debian policy MUSTs.
    
    Thanks-to: James Clarke <jrtc27@debian.org>
    Closes: #878899
    (cherry picked from commit a3a9527efb1345ac71014dd59da911db05e99ea0)

diff --git a/debian/changelog b/debian/changelog
index 9724658..2d81348 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,8 @@
 dpkg (1.19.0.2) UNRELEASED; urgency=medium
 
+  * Fix logic in dpkg-buildpackage to decide whether to run build targets,
+    which broke tons of packages that are violating Debian policy MUSTs.
+    Thanks to James Clarke <jrtc27@debian.org>. Closes: #878899
   * Packaging:
     - Add Breaks to libdpkg-perl against pkg-kde-tools (<< 0.15.28~), as
       that package is using private modules with no API guarantees, that

Message #28 received at 878899-close@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 878899-close@bugs.debian.org

Subject: Bug#878899: fixed in dpkg 1.19.0.2

Date: Wed, 18 Oct 2017 00:19:01 +0000

Source: dpkg
Source-Version: 1.19.0.2

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 878899@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <guillem@debian.org> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 18 Oct 2017 01:28:20 +0200
Source: dpkg
Binary: dpkg libdpkg-dev dpkg-dev libdpkg-perl dselect
Architecture: source
Version: 1.19.0.2
Distribution: unstable
Urgency: medium
Maintainer: Dpkg Developers <debian-dpkg@lists.debian.org>
Changed-By: Guillem Jover <guillem@debian.org>
Description:
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
 libdpkg-dev - Debian package management static library
 libdpkg-perl - Dpkg perl modules
Closes: 878899 878919
Changes:
 dpkg (1.19.0.2) unstable; urgency=medium
 .
   * Fix logic in dpkg-buildpackage to decide whether to run build targets,
     which broke tons of packages that are violating Debian policy MUSTs.
     Thanks to James Clarke <jrtc27@debian.org>. Closes: #878899
   * Do not try to recompute hashes for the .dsc file when signing binary-only
     builds in dpkg-buildpackage. Reported by Ximin Luo <infinity0@debian.org>.
   * Packaging:
     - Add Breaks to libdpkg-perl against pkg-kde-tools (<< 0.15.28~), as
       that package is using private modules with no API guarantees, that
       obviously broke due to recent changes in 1.19.0. Closes: #878919
Checksums-Sha1:
 b2f6d9173af40a17b02d94b16b0145ec9429e160 1977 dpkg_1.19.0.2.dsc
 45119dfd8048a3e1a69de62f160f10b4ba746586 4558044 dpkg_1.19.0.2.tar.xz
 8aac5d479df5a8d537c9c40ab9c373024d52e6fb 7288 dpkg_1.19.0.2_amd64.buildinfo
Checksums-Sha256:
 d84249ca302d687e90f62b396e45b3ae6d24f6a6113353be5022aa985e475b78 1977 dpkg_1.19.0.2.dsc
 1436cd75d3910e32d1366fff9b1ec7cfb154bc0d63c035e22dba76fdd06ad6a2 4558044 dpkg_1.19.0.2.tar.xz
 170a5d55e11e097a3f907809b0560a026351c342de0632b87eb39d028e07df0d 7288 dpkg_1.19.0.2_amd64.buildinfo
Files:
 114f6254ea009b78ebe11b295241a6b8 1977 admin required dpkg_1.19.0.2.dsc
 49dc1fb11d434784ca002fe93af8eaa6 4558044 admin required dpkg_1.19.0.2.tar.xz
 82865dbd20a886364495439fcb754bfc 7288 admin required dpkg_1.19.0.2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEETz509DYFDBD1aWV0uXK/PqSuV6MFAlnmmaAACgkQuXK/PqSu
V6N8UQ/9Hxb1afXmr5vfb9BENvZgWhd6oedtp+pjeRRn9T3OOMF1OQuG+HG1EOjJ
HYzbNWziupHtoU8Iqly1ClD0qPwpGCR14+K9MIYltQ4b5Fo1qeaDB5ATHFV8/FZk
i6UsZxz5IQ+s7R0eUMs8pGkrIpAMv3qXrKKuRYyUihTQFRCIv9MQyoHCuDzuHNtT
8j+HSf8e+svWiYnllC6i8UTVZHBHK7OsoyPgyhiuS/OHLJUJhV/AYBBiyHJap13b
FYfdyWIRPfQa73L+QHWZUkWMdcdVS6fEckNfJ8tULeV7A3l7aP6rBGuAcpkxo94p
boj0Hpq+GrA3FORtCfcgQ/7lr23yx56BUDIXjlYXyyi11bBiOTo9BzE0oMCyCyzg
awKjiXS4LOdMOKlF3y/pymFW9mgr2asiKLgCXDcKa+apf18gZzA8QHv1w2hx/yCk
EYR86v88TVBhToBuRg0HEvDdXP+/Od0pHPULcPhlr3n50uDOhZpnHpRs9bOYHgVc
4sZ6veoMpmCP6FZDmQ31Q8dyBsYyrX4H45z6RVIA+UPsZ2z2MWXqY6ePRgAPe4Dc
ClS0Id8L2exK4x/ppQTT9NcsasHfnNuBIh64M19w0AQKOJVSvEoNR2P9luGS1p3H
HEjg0tD4LH5FFklKFrvZzVPgTNUYSWQxitJuLD75gY5Cc5leLBI=
=zEg+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.