Debian Bug report logs - #877761
glib2.0: Desktop actions are not translated when querying localized version

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Didier Roche <didrocks@ubuntu.com>

To: submit@bugs.debian.org

Subject: glib2.0: Desktop actions are not translated when querying localized version

Date: Thu, 5 Oct 2017 09:41:33 +0200

Source: glib2.0
Version: 2.54.1-1
Severity: normal

Dear Maintainer,

Calling g_desktop_app_info_get_action_name doesn't return the localized 
string
for action name, but the untranslated one, if the translation is in the .mo
file.

The issue is in the way gkeyfile debian's patch is handling gettext support:
it will return translated strings for any Name/GenericName/Icon and 
other keys
but only in the "Desktop Entry" group. Each action though, have a Name
(and Exec) in its own "Desktop Action …" entry.

One of the result is that desktop quicklist actions in GNOME Shell aren't
translated.


-- System Information:
Debian Release: stretch/sid
  APT prefers artful
  APT policy: (500, 'artful')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-12-generic (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR:fr_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 877761@bugs.debian.org (full text, mbox, reply):

From: Didier Roche <didier.roche@canonical.com>

To: 877761@bugs.debian.org

Subject: Debdiff

Date: Thu, 5 Oct 2017 09:50:03 +0200

[Message part 1 (text/plain, inline)]

Please find a patch enclosed for that issue. Already applied and tested 
in the ubuntu package.

[fix_get_action_name_translated.debdiff (text/plain, attachment)]

Message #17 received at 877761@bugs.debian.org (full text, mbox, reply):

From: Iain Lane <laney@debian.org>

To: Didier Roche <didier.roche@canonical.com>, 877761@bugs.debian.org

Subject: Re: Bug#877761: Debdiff

Date: Thu, 5 Oct 2017 15:49:05 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + pending confirmed

On Thu, Oct 05, 2017 at 09:50:03AM +0200, Didier Roche wrote:
> Please find a patch enclosed for that issue. Already applied and tested in
> the ubuntu package.

Thanks, I think it looks good. I've committed so it'll be in the next
upload.

It would have been nice to attach a reproducer, so for the record here's
mine. It gives:

  laney@raleigh> LC_MESSAGES=zh_CN.UTF-8 ./a.out
  Name: 终端
  action new-window: 新终端

Cheers,

-- 
Iain Lane                                  [ iain@orangesquash.org.uk ]
Debian Developer                                   [ laney@debian.org ]
Ubuntu Developer                                   [ laney@ubuntu.com ]

[test.c (text/x-csrc, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 877761-close@bugs.debian.org (full text, mbox, reply):

From: Jeremy Bicha <jbicha@debian.org>

To: 877761-close@bugs.debian.org

Subject: Bug#877761: fixed in glib2.0 2.54.2-1

Date: Sat, 28 Oct 2017 01:33:56 +0000

Source: glib2.0
Source-Version: 2.54.2-1

We believe that the bug you reported is fixed in the latest version of
glib2.0, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 877761@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeremy Bicha <jbicha@debian.org> (supplier of updated glib2.0 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 27 Oct 2017 21:16:41 -0400
Source: glib2.0
Binary: libglib2.0-0 libglib2.0-tests libglib2.0-udeb libglib2.0-bin libglib2.0-dev libglib2.0-dev-bin libglib2.0-data libglib2.0-doc libgio-fam
Architecture: source
Version: 2.54.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Jeremy Bicha <jbicha@debian.org>
Description:
 libgio-fam - GLib Input, Output and Streaming Library (fam module)
 libglib2.0-0 - GLib library of C routines
 libglib2.0-bin - Programs for the GLib library
 libglib2.0-data - Common files for GLib library
 libglib2.0-dev - Development files for the GLib library
 libglib2.0-dev-bin - Development utilities for the GLib library
 libglib2.0-doc - Documentation files for the GLib library
 libglib2.0-tests - GLib library of C routines - installed tests
 libglib2.0-udeb - GLib library of C routines - minimal runtime (udeb)
Closes: 870346 877761
Changes:
 glib2.0 (2.54.2-1) unstable; urgency=medium
 .
   [ Jeremy Bicha ]
   * New upstream release
 .
   [ Didier Roche ]
   * debian/patches/01_gettext-desktopfiles.patch:
     - fix untranslated desktop action names when using gettext
       (Closes: #877761)
 .
   [ Simon McVittie ]
   * Skip gtk-doc documentation unless we are building libglib2.0-doc,
     fixing cross-builds (Closes: #870346)
     - Note that gtk-doc-tools is still in Build-Depends, not
       Build-Depends-Indep, because we need it for autoreconf
   * Explicitly disable documentation for the udeb build
   * Skip build-time tests for Arch:all builds - testing once per
     architecture is sufficient
   * Remove unused lintian override for an example file that is no
     longer installed
Checksums-Sha1:
 b1ea2fee8e53457bed31567bc203041cd83c4a88 3267 glib2.0_2.54.2-1.dsc
 85b5d649fc3d18f8d8197bd971dfbebd94b5f96d 7830724 glib2.0_2.54.2.orig.tar.xz
 07da31d7517af1dc3197ec32472489f6c86abaeb 72072 glib2.0_2.54.2-1.debian.tar.xz
 3c3874e742882691b17acf1cb8dfa9db3d93fa95 8792 glib2.0_2.54.2-1_source.buildinfo
Checksums-Sha256:
 03c60628757b711fcd00adb611e9e9a7146a9383bb886b614d066f66379a7adf 3267 glib2.0_2.54.2-1.dsc
 bb89e5c5aad33169a8c7f28b45671c7899c12f74caf707737f784d7102758e6c 7830724 glib2.0_2.54.2.orig.tar.xz
 4bcc3dc3615060cd14c2ddbfda99d648af1a141e874dad149ba82d45f2a8ab02 72072 glib2.0_2.54.2-1.debian.tar.xz
 ea5754f53967a5d4b37cdbae544d1c2452458b8cedc34b3784dba35470fea949 8792 glib2.0_2.54.2-1_source.buildinfo
Files:
 f94414e58d4d643122c581106799d158 3267 libs optional glib2.0_2.54.2-1.dsc
 50f83e08f080f99b1e2f0ad2b760fb81 7830724 libs optional glib2.0_2.54.2.orig.tar.xz
 cfccf087a2f62301a1a500a14f38f7a0 72072 libs optional glib2.0_2.54.2-1.debian.tar.xz
 5b48ad14e7397e5f0e31d07772e4e4be 8792 libs optional glib2.0_2.54.2-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJZ89rfAAoJEOZsd1rr/mx9eIgP/3UA4v4M795MXUxOnw/hjBfr
oVh4tZmy6EjYLcuHmds71kG9GZfoTIa0nXdEdUbJ/sXZLEsqCaBRLYYGqkEdgRXs
aLeFsc0LW3rkiBRry77APNI7Xay/Qj+DUVjs+s/aOIpLOX7YD7fWGhLGNvTFZkMr
J1irPJ04UFlDuvqJg4RKasbdiQGUpRdRxBeNlPS2L1TNKdcgjp9fhj5Gaowc/yL6
xQ33l+jhgRpuOBdoJ7NuV4nxRCuMLpF0hxulcDuIqAXsA1/7sEx+6gCEHdAd+jUN
yOjB/3n6U7VOiNwn+0XTbLVyC832gSbWsGujkxPPVDkqaMgQjzDVhczR35ZAcJ2g
fQ0Mn3prqXf1xtsPm+jqTKsm1qUhUTIHNx+Vx+9LFWy7hLWczweteJJIOL1uk/vS
ZIjS96Cxh7rCe2fRCKiRf1v4leZnW+vhTMg0WpKZc+PyQjLZ5Y72Y5fhf4ZYfoPc
m3YmWo8w+HYyBEP7Qu0qshGdS7qrlLPna2wU4IJMZx3Ng3SgU4lGEmZMq8X7fccU
52TsjlSRPAs9JHtO7EZzPYjKPu0GYJxSv6d6gdvqYjKs7cwFzJkVIqvMlpVg1+Rm
ek4/duCdRCx7dojyytbJ5ttYkoQ1jBcKLA+rPJqD1kbULAopSEcZrRtn9GSg8b0/
9y1rrFvC9dTjtBsX2LDi
=8Bxi
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.