Debian Bug report logs - #876685
mssh FTBFS with libvte-2.91-dev 0.50.0-1

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Sun, 24 Sep 2017 23:24:34 +0300

Source: mssh
Version: 2.2-2
Severity: serious
Tags: buster sid

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mssh.html

...
mssh-terminal.c: In function 'mssh_terminal_start_session':
mssh-terminal.c:70:5: error: 'vte_terminal_spawn_sync' is deprecated [-Werror=deprecated-declarations]
     vte_terminal_spawn_sync(VTE_TERMINAL(terminal),
     ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
cc1: all warnings being treated as errors
Makefile:378: recipe for target 'mssh-terminal.o' failed
make[3]: *** [mssh-terminal.o] Error 1

Message #10 received at 876685@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 876685@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#876685: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Mon, 2 Oct 2017 15:07:56 +0200

Hi,

Adrian Bunk wrote:
> mssh-terminal.c: In function 'mssh_terminal_start_session':
> mssh-terminal.c:70:5: error: 'vte_terminal_spawn_sync' is deprecated [-Werror=deprecated-declarations]
>      vte_terminal_spawn_sync(VTE_TERMINAL(terminal),
>      ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated due to -Wfatal-errors.
> cc1: all warnings being treated as errors
> Makefile:378: recipe for target 'mssh-terminal.o' failed
> make[3]: *** [mssh-terminal.o] Error 1

According to
https://developer.gnome.org/vte/0.50/VteTerminal.html#vte-terminal-spawn-sync
vte_terminal_spawn_sync() has been replaced by
vte_terminal_spawn_async() which seems to work differently, i.e. it
need more than just a simple replacement.

One way to postpone this issue for a while would be this patch:

--- mssh-2.2/debian/patches/disable-pedantic-errors.patch       2016-09-01 00:02:49.000000000 +0200
+++ mssh-2.2/debian/patches/disable-pedantic-errors.patch       2017-10-02 14:33:52.000000000 +0200
@@ -1,12 +1,14 @@
-Description: Disable pedantic errors to fix FTBFS with GCC 6
+Description: Disable pedantic errors and don't make deprecation warnings fatal to fix FTBFS with GCC 6 or vte 0.50
 Author: Axel Beckert <abe@debian.org>
 Bug-Debian: https://bugs.debian.org/811684
+Bug-Debian: https://bugs.debian.org/876685
+Last-Update: 2017-10-02
 
 --- a/src/Makefile.am
 +++ b/src/Makefile.am
 @@ -1,4 +1,4 @@
 -AM_CFLAGS = -pedantic-errors -Werror -Wall -Wfatal-errors -Wwrite-strings
-+AM_CFLAGS = -Werror -Wall -Wfatal-errors -Wwrite-strings
++AM_CFLAGS = -Wall -Wfatal-errors -Wwrite-strings
  
  AM_CPPFLAGS = $(MSSH_CFLAGS)
  

(JFTR: Removing just -Wfatal-errors did not suffice.)

But if that patch is applied on a short term base, I'd not close this
bug report but just downgrade it to "important", until
vte_terminal_spawn_sync() is not only deprecated but also removed.
Then, the severity needs to be bumped to RC again.

Deliberately not setting the patch tag on this bug report as this
patch is just to buy some more time to develop a real fix.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #15 received at 876685@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 876685@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: [PATCH/NMU] Re: Bug#876685: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Mon, 2 Oct 2017 15:29:22 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 + patch

Hi again,

Axel Beckert wrote:
> Adrian Bunk wrote:
> > mssh-terminal.c: In function 'mssh_terminal_start_session':
> > mssh-terminal.c:70:5: error: 'vte_terminal_spawn_sync' is deprecated [-Werror=deprecated-declarations]
> >      vte_terminal_spawn_sync(VTE_TERMINAL(terminal),
> >      ^~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated due to -Wfatal-errors.
> > cc1: all warnings being treated as errors
> > Makefile:378: recipe for target 'mssh-terminal.o' failed
> > make[3]: *** [mssh-terminal.o] Error 1
> 
> According to
> https://developer.gnome.org/vte/0.50/VteTerminal.html#vte-terminal-spawn-sync
> vte_terminal_spawn_sync() has been replaced by
> vte_terminal_spawn_async() which seems to work differently, i.e. it
> need more than just a simple replacement.

This is not completely true. All changed parameters either accept a
default integer value or NULL.

So forget my previous patch, this is the one to use:

diff -Nru mssh-2.2/debian/changelog mssh-2.2/debian/changelog
--- mssh-2.2/debian/changelog	2017-03-31 09:39:59.000000000 +0200
+++ mssh-2.2/debian/changelog	2017-10-02 14:53:23.000000000 +0200
@@ -1,3 +1,12 @@
+mssh (2.2-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTBFS due to deprecated functions by replacing the call to
+    vte_terminal_spawn_sync() with a call to
+    vte_terminal_spawn_async(). (Closes: #876685)
+
+ -- Axel Beckert <abe@debian.org>  Mon, 02 Oct 2017 14:53:23 +0200
+
 mssh (2.2-2) unstable; urgency=medium
 
   * Add patch from Adrian Bunk to fix installation error. 
diff -Nru mssh-2.2/debian/patches/fix-ftbfs-with-libvte-0.50.patch mssh-2.2/debian/patches/fix-ftbfs-with-libvte-0.50.patch
--- mssh-2.2/debian/patches/fix-ftbfs-with-libvte-0.50.patch	1970-01-01 01:00:00.000000000 +0100
+++ mssh-2.2/debian/patches/fix-ftbfs-with-libvte-0.50.patch	2017-10-02 14:53:23.000000000 +0200
@@ -0,0 +1,27 @@
+Description: Fix FTBFS with libvte 0.50 due to deprecated functions
+Bug-Debian: https://bugs.debian.org/876685
+Author: Axel Beckert <abe@debian.org>
+
+--- a/src/mssh-terminal.c
++++ b/src/mssh-terminal.c
+@@ -67,7 +67,7 @@
+          args[4] = NULL;
+     }
+ 
+-    vte_terminal_spawn_sync(VTE_TERMINAL(terminal),
++    vte_terminal_spawn_async(VTE_TERMINAL(terminal),
+                             VTE_PTY_NO_LASTLOG|VTE_PTY_NO_UTMP|VTE_PTY_NO_WTMP,
+                             NULL,  /* working dir */
+                             args,
+@@ -76,8 +76,10 @@
+                             NULL,  /* child_setup */
+                             NULL,  /* child_setup_data */
+                             NULL,  /* *child_pid */
++                            -1,  /* timeout */
+                             NULL,  /* *cancellable */
+-                            NULL); /* Error handling */
++                            NULL,  /* callback */
++                            NULL); /* user_data */
+ 
+     free(args[0]);
+ }
diff -Nru mssh-2.2/debian/patches/series mssh-2.2/debian/patches/series
--- mssh-2.2/debian/patches/series	2017-03-31 09:31:11.000000000 +0200
+++ mssh-2.2/debian/patches/series	2017-10-02 14:53:23.000000000 +0200
@@ -1,2 +1,3 @@
 disable-pedantic-errors.patch
 intltools_update
+fix-ftbfs-with-libvte-0.50.patch

A first test also revealed that this patch has no impact on at least
basic functionality.

I'll upload this as NMU to DELAYED/5. Feel free to tell me if I should
fast-forward it or delay it a little bit longer.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 876685@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 876685@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#876685: [PATCH/NMU] Re: Bug#876685: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Mon, 2 Oct 2017 17:19:46 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 + pending

Hi again,

Axel Beckert wrote:
> I'll upload this as NMU to DELAYED/5. Feel free to tell me if I should
> fast-forward it or delay it a little bit longer.

I just did an NMU with the patch as posted in my previous mail and
uploaded it to the DELAYED/5-day queue.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 876685@bugs.debian.org (full text, mbox, reply):

From: Hector Garcia <hector@debian.org>

To: Axel Beckert <abe@debian.org>, 876685@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#876685: [PATCH/NMU] Re: Bug#876685: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Tue, 03 Oct 2017 10:36:21 +0200

[Message part 1 (text/plain, inline)]

Hi Axel,
I'm really not so sure that a direct function replacement can be done
directly. I'll test further, but in case I don't find enough time to do
so before your NMU delayed makes it in, I'll let it go, because surely
it is better than nothing.
Regards and thanks for the patch,
Héctor
El lun, 02-10-2017 a las 17:19 +0200, Axel Beckert escribió:
> Control: tag -1 + pending
> 
> Hi again,
> 
> Axel Beckert wrote:
> > I'll upload this as NMU to DELAYED/5. Feel free to tell me if I
> > should
> > fast-forward it or delay it a little bit longer.
> 
> I just did an NMU with the patch as posted in my previous mail and
> uploaded it to the DELAYED/5-day queue.
> 
> 		Regards, Axel

[Message part 2 (text/html, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 876685@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Hector Garcia <hector@debian.org>

Cc: 876685@bugs.debian.org, Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#876685: [PATCH/NMU] Re: Bug#876685: mssh FTBFS with libvte-2.91-dev 0.50.0-1

Date: Tue, 3 Oct 2017 13:20:23 +0200

Hi Héctor,

Hector Garcia wrote:
> I'm really not so sure that a direct function replacement can be done
> directly.

Yeah, initially I was sceptical, too (see my first mail), but when I
noticed that there are NULLs already mentioned as default value in the
API documentation, I gave it a try and got it building again quite
quickly.

And at least in my setup it worked as before: I tested it before I
even published that patch and tested it even more throrough before I
uploaded it to DELAYED/5.

> I'll test further,

Please do so. Much appreciated. The more eyes, the better. :-)

> but in case I don't find enough time to do so before your NMU
> delayed makes it in, I'll let it go, because surely it is better
> than nothing.

*nod*

> thanks for the patch, Héctor

You're welcome.

mssh is an important tool for me in my daily work as well as for
managing my own and our LUG's machines. So I'm really keen on mssh
staying in good shape.

Accordingly I'm really glad that you didn't only take over the Debian
package back then, but also upstream developement. Thanks again for
that!

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #39 received at 876685-close@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 876685-close@bugs.debian.org

Subject: Bug#876685: fixed in mssh 2.2-2.1

Date: Sat, 07 Oct 2017 15:49:32 +0000

Source: mssh
Source-Version: 2.2-2.1

We believe that the bug you reported is fixed in the latest version of
mssh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 876685@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Axel Beckert <abe@debian.org> (supplier of updated mssh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 02 Oct 2017 14:53:23 +0200
Source: mssh
Binary: mssh
Architecture: source amd64
Version: 2.2-2.1
Distribution: unstable
Urgency: medium
Maintainer: Hector Garcia <hector@debian.org>
Changed-By: Axel Beckert <abe@debian.org>
Description:
 mssh       - tool to administrate multiple servers at once
Closes: 876685
Changes:
 mssh (2.2-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Fix FTBFS due to deprecated functions by replacing the call to
     vte_terminal_spawn_sync() with a call to
     vte_terminal_spawn_async(). (Closes: #876685)
Checksums-Sha1:
 a3dc6ad7c07e2f2988c5ccdd1faa054725dbb6c4 1871 mssh_2.2-2.1.dsc
 116ade2c9a71726cbd0510ff69e827dc241227e7 5256 mssh_2.2-2.1.debian.tar.xz
 31cceefcec36c68c0fe1b1291c35f84a9d2c8c2f 77520 mssh-dbgsym_2.2-2.1_amd64.deb
 d268e5e273ec11370a76053f4c6b87c2b1fa034a 15429 mssh_2.2-2.1_amd64.buildinfo
 7ddf188b950ca17c07cf59c11fea7790c0ac4f76 24600 mssh_2.2-2.1_amd64.deb
Checksums-Sha256:
 73aa2c3cfcdf33dd93f5f4ef3661bf985a9a9893ec2306ea2da2637bfe15240d 1871 mssh_2.2-2.1.dsc
 929784ccb11ade024a4336fe3d4a42da844e6de4995adb6e3e427bfa56edf56b 5256 mssh_2.2-2.1.debian.tar.xz
 9ac3e9ca02fbd37cc305540cc796b2d3e70807dc061dec3d4aa103d24931af76 77520 mssh-dbgsym_2.2-2.1_amd64.deb
 1cb92d4ae98d57f059b29bd3698026c8b1c910c5d6d0054580147becb2992d53 15429 mssh_2.2-2.1_amd64.buildinfo
 9ab2cc376acceaf0eb256e282e38ca58cdc142da4af0feaf23f19610f9c81005 24600 mssh_2.2-2.1_amd64.deb
Files:
 c63dbbe5e11efa5a5a628cf7892ee310 1871 admin optional mssh_2.2-2.1.dsc
 428d9869daca3a960ee81a74511feaad 5256 admin optional mssh_2.2-2.1.debian.tar.xz
 5ab5e908f548be33d49b263aecb073f5 77520 debug optional mssh-dbgsym_2.2-2.1_amd64.deb
 e7b4057d2a489db761a75e5d356c5c70 15429 admin optional mssh_2.2-2.1_amd64.buildinfo
 d7334013f0b23a28c36572816322080d 24600 admin optional mssh_2.2-2.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAlnSVywACgkQa+Zjx1o1
yXX+Dw//WKnuGhuPWexD2bj8mBAk30AlaOWloJXY6xghgr7tInCsBWkIMhK3HMNB
JqkK1qCKsc+XbddRO0bQFdmrr0xj5fl4H8yp0uywLIvILKDEUR+SdBtOJfHrW6wh
oe526ehx8IOFP8AKwIMCdJl2S9aw5TH6BWn/CQMowZA9fOtEYEbZQ0XjpweXHeb+
a/AeWBwbps3Ig+StT2Gpiq/3xSIpIj86s38iJuhBx1YfWROO0XgOXO+8PBky44wb
3MlWAv+f/xfH7/1R3mIGk9tP1EizK7TtwUpNcG6aSsJdlzI5a/pxwsqQizeGxqL+
nnHQZOKRZyOVg7k+UHh3L5G/3qK+lgPmUcZUh11yIp3TOq1eCRL9AweJ9FJPChPu
UUEGc2m4r5mNPk3upkRyJ6+HGGOblIZgc9MrhWplASUUXguFURYGlqVNyaZY8moV
TBp/1TzHS7GYyWOfSx9GU3Yqozsb578Rckc2HTMdaiH1Fp8DdvTtGbgKuG1JpVOd
ggarLWD+WS/S/WnFRUc35Uguyb/qP5Jmer3K8lZnPaRk9NIWuJW9eDbfDY5/guI8
SgHkXElaOxJKT09WUUTkMJ9opGXepefuvTClaeiwvh9YBrqUDIrttLFMpDI1AJqE
5W5lqdIne+aXHMSQcx4D2ZpxgTbMC/+yocspoOYyAczLBEBVy94=
=PFtM
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.