Debian Bug report logs - #875603
ITP: python-hvac -- Python 2/3 client for HashiCorp Vault

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Gregor Riepl <gregor.riepl@swisstxt.ch>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: RFP: python-hvac -- Python 2/3 client for HashiCorp Vault

Date: Tue, 12 Sep 2017 16:46:06 +0200

Package: wnpp
Severity: wishlist

* Package name    : python-hvac
  Version         : 0.2.17
  Upstream Author : Ian Unruh
* URL             : https://github.com/ianunruh/hvac
* License         : Apache-2.0
  Programming Lang: Python
  Description     : Python 2/3 client for HashiCorp Vault

HashiCorp Vault API client for Python 2/3

This package should be a 'Recommended' dependency of Ansible 2.3, as it allows
lookups from Vaults without external Python modules. Please consider adding it
to Debian.

Message #10 received at 875603@bugs.debian.org (full text, mbox, reply):

From: Gregor Riepl <onitake@gmail.com>

To: 875603@bugs.debian.org

Cc: debian-python@lists.debian.org

Subject: ITP: python-hvac -- Python 2/3 client for HashiCorp Vault

Date: Fri, 20 Jul 2018 08:36:27 +0200

Package: wnpp
Severity: wishlist
Owner: Gregor Riepl <onitake@gmail.com>

* Package name    : python-hvac
  Version         : 0.6.2
  Upstream Author : Ian Unruh
* URL             : https://github.com/ianunruh/hvac
* License         : Apache-2.0
  Programming Lang: Python
  Description     : Python 2/3 client for HashiCorp Vault

HashiCorp Vault API client for Python 2/3.

This package is useful for Ansible, as it allows accessing Vault credentials
directly from Playbooks.

I intend to maintain this package together with the DPMT.
The Debian repository is here:
https://salsa.debian.org/python-team/modules/hvac

Please review and upload to Debian if the package fits the necessary criteria.

Thank you!

Message #19 received at 875603@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: Gregor Riepl <onitake@gmail.com>

Cc: 875603@bugs.debian.org

Subject: Re: Bug#875603: ITP: python-hvac -- Python 2/3 client for HashiCorp Vault

Date: Mon, 15 Oct 2018 12:49:34 -0400

On 2018-07-20 08:36:27, Gregor Riepl wrote:
> Package: wnpp
> Severity: wishlist
> Owner: Gregor Riepl <onitake@gmail.com>
>
> * Package name    : python-hvac
>   Version         : 0.6.2
>   Upstream Author : Ian Unruh
> * URL             : https://github.com/ianunruh/hvac
> * License         : Apache-2.0
>   Programming Lang: Python
>   Description     : Python 2/3 client for HashiCorp Vault
>
> HashiCorp Vault API client for Python 2/3.
>
> This package is useful for Ansible, as it allows accessing Vault credentials
> directly from Playbooks.
>
> I intend to maintain this package together with the DPMT.
> The Debian repository is here:
> https://salsa.debian.org/python-team/modules/hvac
>
> Please review and upload to Debian if the package fits the necessary criteria.

Hi,

Here's a review.

 * the debian/changelog has a typo in your email address, introduced in
   your latest commit. be more dilligent and review diffs before
   pushing! :) i have fixed it and pushed.

 * it is customary (but not mandatory) to use the same license as
   upstream for the debian/* files. You use a BSD-3 license while
   upstream uses Apache-2... that seems like a gratitious change. not a
   blocker.

 * nice note about vault in the README.Debian. care to link against
   other WNPP bug reports there (opening them as needed)?

 * I haven't audited the upstream source, I assume you have taken at
   least a cursory look to make sure it's not total junk.

 * lintian warns us about this:

W: python-hvac: new-package-should-not-package-python2-module python-hvac
W: python-hvac: multi-arch-same-package-calls-pycompile postinst:6
W: python3-hvac: multi-arch-same-package-calls-pycompile postinst:6

The latter should probably be fixed.

Otherwise things look good! I can sponsor this when you're ready - just
change the changelog to update the release and we're good to go.

Cheers,

A.

-- 
Secrecy is the keystone to all tyranny. Not force, but secrecy and
censorship.
                       -  Robert A. Heinlein

Message #24 received at 875603@bugs.debian.org (full text, mbox, reply):

From: Gregor Riepl <onitake@gmail.com>

To: Antoine Beaupré <anarcat@debian.org>

Cc: 875603@bugs.debian.org

Subject: Re: Bug#875603: ITP: python-hvac -- Python 2/3 client for HashiCorp Vault

Date: Tue, 16 Oct 2018 09:41:21 +0200

Hi Antoine,

> Here's a review.

Thanks for reviewing.

>  * the debian/changelog has a typo in your email address, introduced in
>    your latest commit. be more dilligent and review diffs before
>    pushing! :) i have fixed it and pushed.

So _that's_ what it was... I got NMU warnings and just couldn't see why.
I assumed the changelog diff was simply the date being updated.
Looks like my DEBEMAIL got mangled somewhere.
Thanks for pointing that out.

>  * it is customary (but not mandatory) to use the same license as
>    upstream for the debian/* files. You use a BSD-3 license while
>    upstream uses Apache-2... that seems like a gratitious change. not a
>    blocker.

Personal preference.
I generally prefer permissive licenses and have used BSD 3-clause for all
Debian packages I made so far. I didn't know about the custom to use the same
license as upstream.

>  * nice note about vault in the README.Debian. care to link against
>    other WNPP bug reports there (opening them as needed)?

Good idea. I believe there is one for vault, but not pyhcl.
Unfortunately, I noticed the upstream source packages no longer include the
tox test suite (or they never did). Only the upstream master branch has them.

Adding the tests back or running the unit tests that are still included may be
more work. I'll see what I can do.

>  * I haven't audited the upstream source, I assume you have taken at
>    least a cursory look to make sure it's not total junk.

A very cursory one - a full audit would probably waste a lot of time.
At least there are no hidden "gems" like files with a different license or
somesuch.

>  * lintian warns us about this:
> 
> W: python-hvac: new-package-should-not-package-python2-module python-hvac
> W: python-hvac: multi-arch-same-package-calls-pycompile postinst:6
> W: python3-hvac: multi-arch-same-package-calls-pycompile postinst:6
> 
> The latter should probably be fixed.

Yes, you are right. I noticed these yesterday, but simply couldn't make any
sense out of the documentation
(https://lintian.debian.org/tags/multi-arch-same-package-calls-pycompile.html)
on short notice. Multi-Arch is still giving me a headache...

I have fixed this by setting Architecture: all and removing Multi-Arch: same -
the package is completely architecture independent anyway.

> Otherwise things look good! I can sponsor this when you're ready - just
> change the changelog to update the release and we're good to go.

Thanks, I'll get back to you shortly.

Regards,
Gregor

Message #29 received at 875603-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 875603-close@bugs.debian.org

Subject: Bug#875603: fixed in python-hvac 0.10.12-1

Date: Thu, 19 Aug 2021 07:00:13 +0000

Source: python-hvac
Source-Version: 0.10.12-1
Done: Thomas Goirand <zigo@debian.org>

We believe that the bug you reported is fixed in the latest version of
python-hvac, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 875603@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated python-hvac package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 20 May 2021 10:07:27 +0200
Source: python-hvac
Binary: python3-hvac
Architecture: source all
Version: 0.10.12-1
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openstack@tracker.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Description:
 python3-hvac - HashiCorp Vault API client - Python 3.x
Closes: 875603
Changes:
 python-hvac (0.10.12-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #875603) I'm taking it over, since there's no
     activity in the ITP since 2018.
Checksums-Sha1:
 fe274a4f2a82845c7db5448e2ade611272704269 2699 python-hvac_0.10.12-1.dsc
 ac8d51a5d82b3e926f66eeec57cefaf0af43f660 242324 python-hvac_0.10.12.orig.tar.xz
 056fc78176560af84f1472161b5645f5c290472b 5260 python-hvac_0.10.12-1.debian.tar.xz
 ff46b4222abfb890af5166895ef5bc0cc9bc6c0e 8363 python-hvac_0.10.12-1_amd64.buildinfo
 7c6460a173d4199fe80d4c4ca66eb8ebf6422616 90532 python3-hvac_0.10.12-1_all.deb
Checksums-Sha256:
 e5c4aa14c190c4d40d8849224e66c25d87487da09cbda15ede61c05ea8073dba 2699 python-hvac_0.10.12-1.dsc
 50eb7560b9b072b6ada1b754faa72692512536dabd4318bee79f908aac31532a 242324 python-hvac_0.10.12.orig.tar.xz
 d6add2ace09610ea4f2a47a928078488a63f791eeb7dcb5951707f3109d1628c 5260 python-hvac_0.10.12-1.debian.tar.xz
 d9262ea387c3a36ed571d3ab6ca7adaf54f81eff93075608a7fbb5d81bcde87c 8363 python-hvac_0.10.12-1_amd64.buildinfo
 fc50b096da1db98e16acd42ce3b42242ce229cf3776922da52f7f1545485fc60 90532 python3-hvac_0.10.12-1_all.deb
Files:
 7501cfbd8afb6be6e35921dfcb010361 2699 python optional python-hvac_0.10.12-1.dsc
 5d3c3dd7e0c8d7486df871b27ab6c21c 242324 python optional python-hvac_0.10.12.orig.tar.xz
 7898cb329d294e2ef4c7b86b1621a8bf 5260 python optional python-hvac_0.10.12-1.debian.tar.xz
 c7526b3c0bffb543027553ee5570ce3b 8363 python optional python-hvac_0.10.12-1_amd64.buildinfo
 2acdaf04ebcf06adc96e78ae34c3db2f 90532 python optional python3-hvac_0.10.12-1_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmCmKtkACgkQ1BatFaxr
Q/6B5hAAilyBTc3R4FjGl1NKs66QfO2kmk9H1wYwCnTQkuhxOLitZHVWH/tONdY6
C+pyUBRvDMoKggsXq8QPCOLgOxCXw4YkK06uIb5AW/gbGA4/WWLAtYHn3eV623Rl
a8/JyqtA66aK9BIwYAwk6R6gIa7nohOf7q5AJhDF9BMLk+Kp7nmiGM/7gTKNXiCh
vbX+VJW8b9N+XqotbT2F4SXHYnh+gClxugb302jiWFoQytsGLcn1se4P4xu0UT/3
qDwLL2/jvJoB+vHGEhW5xeYk4qGyvIbs9oNo03WqR81ixRMQ/5VImaMEyKgFlw8r
IMJhCZDxDiz9enCaVSL1+v/qoP12bMHTqc47lk6koAlTgJ/VnGXA3QpQ1yrv53SE
NmfPTX6XAnj2z271SYEnqKqlxpvr9MynPqY5hgj5ltzVbrKFLV15pOzAFPVCad4r
MrGBqP1WAOSMGwz/VR97Va4MJdSmlcQa7NAVYzmq3gEFSpSNUoP9XXODB5ErA+Kh
07PMrgHJlFenIRxnApcYG+AHPPezBWXIyvrQRgzGZXqQPH1FyV6YVesMz9sxdtU1
mYduv4/PcBScqK0579C49x1uVysI6d3VPJihkApIMofhz+Laooiq6Wx9xfOK576K
aZRD3j127VWXcRV0s2r7Ufu0BG++SLxNoAGSnmcBQuz3wBbwpo8=
=OQLS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.