Debian Bug report logs - #871782
python-fife: leak memory when looking for icons (affects unknown-horizons)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: submit@bugs.debian.org

Subject: unknown-horizons: run slower and slower and uses more and more memory

Date: Sun, 06 Aug 2017 20:59:45 +0200

Package: unknown-horizons
Version: 2017.1+ds-2

Hi.  When I played though the tutorial today, for the first time in a
long time, the experience at the start was quite nice, but after a while
the game became slower and slower.  A look at 'top' showed that the
program was using a lot of memory (31% of my total), and all swap was
spent.  At the end it was running so slow it was hard to use the game.

After I ended the game I did a test run in valgrind just starting and
stopping the game (ie just visiting the main meny), and according to
valgrind 200 MiB was lost and 400 MiB was indirectly lost.  In addition
there were heaps of problems reported by valgrind about use after free.

I asked about excessive memory usage on #unknown-horizons
(irc.freenode.net), and was told by user LinuxDonald that several fixes
regarding memory usage should be fixed in version 2017.2.  Perhaps some
of these fixes should be backported to Stretch?
-- 
Happy hacking
Petter Reinholdtsen

Message #10 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: Petter Reinholdtsen <pere@hungry.com>

Cc: 871037@bugs.debian.org

Subject: Re: Bug#871037: unknown-horizons: run slower and slower and uses more and more memory

Date: Sun, 6 Aug 2017 15:40:08 -0400

On 06/08/17 14:59, Petter Reinholdtsen wrote:
> 
> Package: unknown-horizons
> Version: 2017.1+ds-2
> 
> Hi.  When I played though the tutorial today, for the first time in a
> long time, the experience at the start was quite nice, but after a while
> the game became slower and slower.  A look at 'top' showed that the
> program was using a lot of memory (31% of my total), and all swap was
> spent.  At the end it was running so slow it was hard to use the game.
> 
> After I ended the game I did a test run in valgrind just starting and
> stopping the game (ie just visiting the main meny), and according to
> valgrind 200 MiB was lost and 400 MiB was indirectly lost.  In addition
> there were heaps of problems reported by valgrind about use after free.
> 
> I asked about excessive memory usage on #unknown-horizons
> (irc.freenode.net), and was told by user LinuxDonald that several fixes
> regarding memory usage should be fixed in version 2017.2.  Perhaps some
> of these fixes should be backported to Stretch?

The problem is what shall be backported? Are those bug fixes documented 
somewhere? Can you confirm that 2017.2 resolves all memory issues and 
the "sluggishness"?

Markus

Message #15 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 871037@bugs.debian.org

Subject: Re: Bug#871037: unknown-horizons: run slower and slower and uses more and more memory

Date: Sun, 06 Aug 2017 22:42:23 +0200

[Markus Koschany]
> The problem is what shall be backported? Are those bug fixes documented 
> somewhere?

I am sorry to tell that I have no idea.  I tried to ask on the IRC
channel for more details, but got no reply, so I do not know.  The
changelog for 2017.2 do not mention anything memory related, and I do
not know how to figure out which commit made a difference.

I have not given up on the IRC channel, and hope someone there can
provide more input.

> Can you confirm that 2017.2 resolves all memory issues and the
> "sluggishness"?

Nope, I have not tested 2017.2 yet.  Does this mean you do not see the
problem when you test?

-- 
Happy hacking
Petter Reinholdtsen

Message #20 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Thomas Kowaliczek <linuxdonald@posteo.de>

To: 871037@bugs.debian.org

Subject: UH leaks

Date: Mon, 7 Aug 2017 08:36:21 +0200

Hello I'm the project leader of Unknown-horizons.
The version 2017.1 have some memory leaks and the engine too. They are all fixed in the last stable versions.
I would recommend to use 2017.2 from testing/unstable repo.

Greetings 

Thomas Kowaliczek 

Message #25 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: Petter Reinholdtsen <pere@hungry.com>

Cc: 871037@bugs.debian.org

Subject: Re: Bug#871037: unknown-horizons: run slower and slower and uses more and more memory

Date: Mon, 7 Aug 2017 08:13:15 -0400

On 06/08/17 16:42, Petter Reinholdtsen wrote:
> [Markus Koschany]
>> The problem is what shall be backported? Are those bug fixes documented
>> somewhere?
> 
> I am sorry to tell that I have no idea.  I tried to ask on the IRC
> channel for more details, but got no reply, so I do not know.  The
> changelog for 2017.2 do not mention anything memory related, and I do
> not know how to figure out which commit made a difference.

Thanks for investigating the issue anyway.

> I have not given up on the IRC channel, and hope someone there can
> provide more input.
> 
>> Can you confirm that 2017.2 resolves all memory issues and the
>> "sluggishness"?
> 
> Nope, I have not tested 2017.2 yet.  Does this mean you do not see the
> problem when you test?

I can't really test it at the moment because I'm at DebConf in Canada 
but maybe upstream can clarify the situation.

Markus

Message #30 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: Thomas Kowaliczek <linuxdonald@posteo.de>

Cc: 871037@bugs.debian.org, Petter Reinholdtsen <pere@hungry.com>

Subject: Re: Bug#871037: UH leaks

Date: Mon, 7 Aug 2017 08:19:33 -0400

On 07/08/17 02:36, Thomas Kowaliczek wrote:
> Hello I'm the project leader of Unknown-horizons.
> The version 2017.1 have some memory leaks and the engine too. They are all fixed in the last stable versions.
> I would recommend to use 2017.2 from testing/unstable repo.

Hello,

thank you for following up on this bug report.

We have already packaged the latest version of UH in unstable. The 
current problem is that we ship 2017.1 in Debian Stretch, the stable 
distribution of Debian, and updates should be minimal to comply with 
Debian's rules for stable updates. I'm not sure if we were allowed to 
backport 2017.2 to Stretch because there are other changes which makes 
it hard for our release team to review.

Can you point me to the relevant commits or patches that fix those 
memory leaks? Then I might be able to backport them. If I understand you 
correctly, fife and maybe even fifechan are affected as well? Then we 
need to clone this bug report and address those issues in all packages.

Regards,

Markus

Message #35 received at 871037@bugs.debian.org (full text, mbox, reply):

From: LinuxDonald <linuxdonald@posteo.de>

To: 871037@bugs.debian.org

Subject: Re: Bug#871037: UH leaks

Date: Mon, 07 Aug 2017 17:22:58 +0200

ON UH side it should be this commit: 
https://github.com/unknown-horizons/unknown-horizons/commit/25e933202e2db6083d0f163d978559c4ac24fb94
and on fife engine side this one: 
https://github.com/fifengine/fifengine/commit/2efebb3a0940e2570d2e7abeb54957dcb6f110ea

Am 07.08.2017 14:19 schrieb Markus Koschany:
> On 07/08/17 02:36, Thomas Kowaliczek wrote:
>> Hello I'm the project leader of Unknown-horizons.
>> The version 2017.1 have some memory leaks and the engine too. They are 
>> all fixed in the last stable versions.
>> I would recommend to use 2017.2 from testing/unstable repo.
> 
> Hello,
> 
> thank you for following up on this bug report.
> 
> We have already packaged the latest version of UH in unstable. The
> current problem is that we ship 2017.1 in Debian Stretch, the stable
> distribution of Debian, and updates should be minimal to comply with
> Debian's rules for stable updates. I'm not sure if we were allowed to
> backport 2017.2 to Stretch because there are other changes which makes
> it hard for our release team to review.
> 
> Can you point me to the relevant commits or patches that fix those
> memory leaks? Then I might be able to backport them. If I understand
> you correctly, fife and maybe even fifechan are affected as well? Then
> we need to clone this bug report and address those issues in all
> packages.
> 
> Regards,
> 
> Markus

Message #40 received at 871037@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: LinuxDonald <linuxdonald@posteo.de>, 871037@bugs.debian.org

Subject: Re: Bug#871037: UH leaks

Date: Fri, 11 Aug 2017 15:13:35 +0200

Control: clone -1 -2
Control: reassign -2 python-fife
Control: retitle -2 python-fife: leak memory when looking for icons (affects unknown-horizons)

[LinuxDonald]
> ON UH side it should be this commit: https://github.com/unknown-horizons/unknown-horizons/commit/25e933202e2db6083d0f163d978559c4ac24fb94
> and on fife engine side this one: https://github.com/fifengine/fifengine/commit/2efebb3a0940e2570d2e7abeb54957dcb6f110ea

Thank you.  Those are small and to the point, and should be possible to get
into Debian Stable.

As the fix is in two packages, I clone this bug to the python-fife package.
-- 
Happy hacking
Petter Reinholdtsen

Message #53 received at 871782@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 871782@bugs.debian.org

Subject: Patch for fife to plug memory leak

Date: Fri, 11 Aug 2017 22:25:04 +0200

[Message part 1 (text/plain, inline)]

Here is a tested quilt patch to be stored in
debian/patches/1000-icon-mem-leak.patch.

I could not verify that all leaks are plugged, as the program is
still increasing in size while playing, and I do not know if this
is normal or not.  But the code in question make sense and is from
upstream, so it should at least reduce the amount of memory used. :)

I tested with the patch in place, and the game is working as it should.
I was not able to trigger the slowdown, but do not know if I played
long enough. :)
-- 
Happy hacking
Petter Reinholdtsen

[1000-icon-mem-leak.patch (text/x-diff, attachment)]

Message #58 received at 871782@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: 871782@bugs.debian.org, pere@hungry.com

Subject: Re: Patch for fife to plug memory leak

Date: Mon, 21 Aug 2017 09:42:06 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 pending
Control: block -1 by 872774

I have prepared a stretch-pu. The fix is pending.

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #69 received at 871782-close@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: 871782-close@bugs.debian.org

Subject: Bug#871782: fixed in fife 0.4.0-3+deb9u1

Date: Wed, 23 Aug 2017 20:47:15 +0000

Source: fife
Source-Version: 0.4.0-3+deb9u1

We believe that the bug you reported is fixed in the latest version of
fife, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 871782@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@debian.org> (supplier of updated fife package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 21 Aug 2017 07:59:18 +0200
Source: fife
Binary: python-fife
Architecture: source
Version: 0.4.0-3+deb9u1
Distribution: stretch
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@debian.org>
Description:
 python-fife - FIFE is a multi-platform isometric game engine
Closes: 871782
Changes:
 fife (0.4.0-3+deb9u1) stretch; urgency=medium
 .
   * Team upload.
   * Add 1000-icon-mem-leak.patch and fix a memory leak.
     Thanks to Petter Reinholdtsen for the report and testing and LinuxDonald
     for the patch. (Closes: #871782)
Checksums-Sha1:
 aa3defb608d19c3dd547ceb4072d0f6374a44c02 2410 fife_0.4.0-3+deb9u1.dsc
 1bb5089041ca2062f8728cab0a1728187da86b2d 5720 fife_0.4.0-3+deb9u1.debian.tar.xz
 e1cc3499d9ccba8c66c539939fef12e6f533ea28 13560 fife_0.4.0-3+deb9u1_source.buildinfo
Checksums-Sha256:
 d39fd9c5743a91b2b9f351e2c0018330f71106cd93a36022c5cb4631baa5fec0 2410 fife_0.4.0-3+deb9u1.dsc
 5fa2bf45ad62d9e70e9781d88db373a3fea4719cc419e746bdcc8c56cd1e3933 5720 fife_0.4.0-3+deb9u1.debian.tar.xz
 ab81b5fe340612b040ee85ef740891f229eddd89c39b513232120f8f5e8cb8d0 13560 fife_0.4.0-3+deb9u1_source.buildinfo
Files:
 224b58c2ffb132f59bb698694ada9f21 2410 libdevel optional fife_0.4.0-3+deb9u1.dsc
 0ae8ed2286896829aa2012620f2fd809 5720 libdevel optional fife_0.4.0-3+deb9u1.debian.tar.xz
 336c808bdb0f1c294830a39213fabbee 13560 libdevel optional fife_0.4.0-3+deb9u1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAlmcql1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkhbUQAICOXGL2ApBZwPHmYdDZh0WZd6FWKWdIKmnE
2jQO18LL5MMq023O6N/q7aymiRo7rbb7mtpWKU1oT0QiBpRlDcu9YJKSyuEyVG2H
uFBHbU4FEUDUouFcEAB3y7M4W3Oss/Rq8YiMgpkTa4F99ghwF2jkLAimRknHsta8
45s0xNly6LNlR7idkqYC95H4HYl52/TH/x0iPv1HIcQ4md5zxtYTWKvPQAe7nYKi
6vusI54s9jBaGk9jgx77ayt9HCvERK8xtqOPxnsl4bZrWCEQz+DxD/V1FI4OV/oK
5tTZZpOhY+HejEYs+33ojiD55WfJiYNwI1AFwaMk9SbqwYaejC0RaL0Jm8GM89nF
tnLXU6woIHjf6fgaYHWyM+CvgpBBBHrX7/ALiz+GYTIn6tcP7nIGFayTk+D+nKs5
ViuGcEuIBUWIZOZJZQV4Rier2VaggYlGZ57tiT/PPTYNi+YmGUDliCcnxVkXcWuZ
cg3QWWa4RoAp7j9LNtFkJTsMz0VQoj4nTtdQqLE1HkrIoDB1C7mw+ZleegdKt3tZ
zEmWgTfdk7yqDWw3D9sCRl+kSBdzdJmQlNPy9elM92h3XyTiCiDInc1yDZO7Gw5h
V030P2dMqU5pYuJJQoA+KLF8wVP3BdE1xsK5l5FfLdgoo8IF4M/Xvj6bGGOwtsWE
6LbOIZQY
=zEhp
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.